coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: vc/mediatek/mt8195: Fix rank1 CKE setting for single-rank DRAM
by Rex-BC Chen (Code Review) 29 Nov '21

29 Nov '21

Attention is currently required from: Ryan Chuang. Hello Ryan Chuang, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/59715 to review the following change. Change subject: vc/mediatek/mt8195: Fix rank1 CKE setting for single-rank DRAM ...................................................................... vc/mediatek/mt8195: Fix rank1 CKE setting for single-rank DRAM Fix rank1 CKE setting for single-rank DRAM power consumption issue. BUG=b:196867407 TEST=DUT can boot to OS. Signed-off-by: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Change-Id: If336197aea4770dda1332b6e83da8ec9a4f9d77b --- M src/vendorcode/mediatek/mt8195/dramc/dramc_pi_main.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/59715/1 diff --git a/src/vendorcode/mediatek/mt8195/dramc/dramc_pi_main.c b/src/vendorcode/mediatek/mt8195/dramc/dramc_pi_main.c index e7e8f89..e3baf7b 100644 --- a/src/vendorcode/mediatek/mt8195/dramc/dramc_pi_main.c +++ b/src/vendorcode/mediatek/mt8195/dramc/dramc_pi_main.c @@ -1946,6 +1946,11 @@ #endif } + if (p->support_rank_num == RANK_SINGLE){ + CKEFixOnOff(p, RANK_1, CKE_DYNAMIC, TO_ALL_CHANNEL); + mcSHOW_DBG_MSG(("Set RANK1 CKE to DYNAMIC\n")); + } + #if (FOR_DV_SIMULATION_USED == 0 && SW_CHANGE_FOR_SIMULATION == 0) U32 backup_broadcast; backup_broadcast = GetDramcBroadcast(); -- To view, visit https://review.coreboot.org/c/coreboot/+/59715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If336197aea4770dda1332b6e83da8ec9a4f9d77b Gerrit-Change-Number: 59715 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/brya/var/baseboard/brask: Add power limits functions
by Hou-hsun Lee (Code Review) 29 Nov '21

29 Nov '21

Attention is currently required from: Paul Menzel, Nick Vaccaro, Zhuohao Lee, Alan Huang. Hou-hsun Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58241 ) Change subject: mb/google/brya/var/baseboard/brask: Add power limits functions ...................................................................... Patch Set 15: (1 comment) File src/mainboard/google/brya/variants/baseboard/brask/ramstage.c: https://review.coreboot.org/c/coreboot/+/58241/comment/3c3509b6_4dbc4e00 PS14, Line 108: soc_config->tdp_pl4 = 0; > Yes, it's correct. Added comments in variants.h. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/58241 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I183017068e9c78acb9fa7073c53593d304ba9248 Gerrit-Change-Number: 58241 Gerrit-PatchSet: 15 Gerrit-Owner: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Hou-hsun Lee <hou-hsun.lee(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 29 Nov 2021 02:06:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hou-hsun Lee <hou-hsun.lee(a)intel.com> Comment-In-Reply-To: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/brask: Set PL and PsysPL
by Hou-hsun Lee (Code Review) 29 Nov '21

29 Nov '21

Attention is currently required from: David Wu, Zhuohao Lee, Alan Huang. Hou-hsun Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59576 ) Change subject: mb/google/brya/var/brask: Set PL and PsysPL ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brya/variants/brask/ramstage.c: https://review.coreboot.org/c/coreboot/+/59576/comment/0bc4edec_26317fa1 PS1, Line 18: { PCI_DEVICE_ID_INTEL_ADL_P_ID_1, 45, 5000, 45000, 80000, 80000, 159000 }, > Yes, you're correct. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59576 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9261902b8c892d0b866f326b24988039c1d30b56 Gerrit-Change-Number: 59576 Gerrit-PatchSet: 2 Gerrit-Owner: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Hou-hsun Lee <hou-hsun.lee(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 29 Nov 2021 02:05:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hou-hsun Lee <hou-hsun.lee(a)intel.com> Comment-In-Reply-To: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/brask: Set PL and PsysPL
by Hou-hsun Lee (Code Review) 29 Nov '21

29 Nov '21

Attention is currently required from: David Wu, Zhuohao Lee, Alan Huang. Hou-hsun Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59576 ) Change subject: mb/google/brya/var/brask: Set PL and PsysPL ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brya/variants/brask/ramstage.c: https://review.coreboot.org/c/coreboot/+/59576/comment/5fc13410_7589020e PS1, Line 18: { PCI_DEVICE_ID_INTEL_ADL_P_ID_1, 45, 5000, 45000, 80000, 80000, 159000 }, > According to the HW design, we will use performance config. […] Yes, you're correct. -- To view, visit https://review.coreboot.org/c/coreboot/+/59576 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9261902b8c892d0b866f326b24988039c1d30b56 Gerrit-Change-Number: 59576 Gerrit-PatchSet: 2 Gerrit-Owner: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Hou-hsun Lee <hou-hsun.lee(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 29 Nov 2021 02:01:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hou-hsun Lee <hou-hsun.lee(a)intel.com> Comment-In-Reply-To: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS
by Kane Chen (Code Review) 29 Nov '21

29 Nov '21

Attention is currently required from: Kangheui Won, Isaac Lee, chris wang. Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59558 ) Change subject: mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS ...................................................................... Patch Set 5: (1 comment) File src/mainboard/google/zork/variants/shuboz/overridetree.cb: https://review.coreboot.org/c/coreboot/+/59558/comment/fdd0acb7_09b3185b PS5, Line 2: fw_config > So IIUC it SSFC is not set devicetree doesn't match `option AUDIO_CODEC_ALC5682 0` and emit nothing […] Hi Kangheui, We tested the single setting codec in "overridetree.cb" SSFC can work, but we set two setting of codec, the first settings will be invalid. Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/59558 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c78aa166010ffa4d0cacc8a11d418d5a6906749 Gerrit-Change-Number: 59558 Gerrit-PatchSet: 5 Gerrit-Owner: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com> Gerrit-Reviewer: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: chris wang <Chris.Wang(a)amd.com> Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Randy Wang <ifanw(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Isaac Lee <isaaclee(a)google.com> Gerrit-Attention: chris wang <Chris.Wang(a)amd.com> Gerrit-Comment-Date: Mon, 29 Nov 2021 01:27:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kangheui Won <khwon(a)chromium.org> Comment-In-Reply-To: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mainboard/google/brya/variants/brask: Enable audio driver option in b...
by Adam Liu (Code Review) 29 Nov '21

29 Nov '21

Attention is currently required from: Tim Wawrzynczak. Adam Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59610 ) Change subject: mainboard/google/brya/variants/brask: Enable audio driver option in bios-stage for brask ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/59610 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05c5d734ab9cd9a894084398decb5e3bac45ddf2 Gerrit-Change-Number: 59610 Gerrit-PatchSet: 2 Gerrit-Owner: Adam Liu <adam.liu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Mon, 29 Nov 2021 00:56:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbfstool: Port elogtool to libflashrom
by build bot (Jenkins) (Code Review) 29 Nov '21

29 Nov '21

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59714 ) Change subject: util/cbfstool: Port elogtool to libflashrom ...................................................................... Patch Set 1: (186 comments) File util/cbfstool/uflashrom.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/dd9fe3e3_ba2c2895 PS1, Line 9: const char *programmer; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/ba1b37f9_f32b6a6f PS1, Line 9: const char *programmer; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/cceee54b_c5bfcbf5 PS1, Line 10: uint32_t size; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/ac00a756_39912af3 PS1, Line 10: uint32_t size; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/b2df3632_9ec40e5c PS1, Line 11: uint8_t *data; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/008ee169_a51ee173 PS1, Line 11: uint8_t *data; please, no spaces at the start of a line File util/cbfstool/uflashrom.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/296a1174_7f003409 PS1, Line 15: va_list ap) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/89ec0db4_079ef873 PS1, Line 15: va_list ap) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/fb5a02d6_22d08509 PS1, Line 17: int ret = 0; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/69d62ee0_b44bf669 PS1, Line 17: int ret = 0; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/664c5aba_7e4f9996 PS1, Line 18: FILE *output_type = (level < FLASHROM_MSG_INFO) ? stderr : stdout; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/16a28b65_848228a9 PS1, Line 18: FILE *output_type = (level < FLASHROM_MSG_INFO) ? stderr : stdout; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/e151eea1_c228b36b PS1, Line 20: if (level > g_verbose_screen) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/f1ac4f40_dbde8a02 PS1, Line 20: if (level > g_verbose_screen) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/c29d202e_dfa8314e PS1, Line 21: return ret; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/9868be78_b2d5efba PS1, Line 21: return ret; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/0b0dd4ef_d3934346 PS1, Line 23: ret = vfprintf(output_type, fmt, ap); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/ca44e660_6d7a840a PS1, Line 23: ret = vfprintf(output_type, fmt, ap); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/b43825b9_bd4b9c1c PS1, Line 24: /* msg_*spew often happens inside chip accessors code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/deccffd1_6562df5b PS1, Line 25: * in possibly time-critical operations. code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/d452c83c_5412a507 PS1, Line 26: * Don't slow them down by flushing. code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/cc13b7f7_1d7b9cbe PS1, Line 27: */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/296e7fd9_a8024161 PS1, Line 28: if (level != FLASHROM_MSG_SPEW) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/a03b5b6a_153d0cc8 PS1, Line 28: if (level != FLASHROM_MSG_SPEW) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/aa2eb497_a847e35c PS1, Line 29: fflush(output_type); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/8d0aa20e_eead1d2a PS1, Line 29: fflush(output_type); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/cedd6fd7_426d1bf0 PS1, Line 31: return ret; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/de4ca997_ec42127f PS1, Line 31: return ret; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/fc97b102_7cccaa1e PS1, Line 36: int r = 0; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/e9b3bbea_3d1359e9 PS1, Line 36: int r = 0; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/00a11c6d_d04f71c0 PS1, Line 37: size_t len = 0; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5988e85e_f8701c06 PS1, Line 37: size_t len = 0; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/6e579764_79758a25 PS1, Line 39: struct flashrom_programmer *prog = NULL; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5273b50e_26fe405d PS1, Line 39: struct flashrom_programmer *prog = NULL; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5c1a7f89_18f9ab77 PS1, Line 40: struct flashrom_flashctx *flashctx = NULL; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/4f49cfae_a52f61cb PS1, Line 40: struct flashrom_flashctx *flashctx = NULL; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/ed4ccf31_11473d03 PS1, Line 41: struct flashrom_layout *layout = NULL; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/def0e3c3_ee6e2adc PS1, Line 41: struct flashrom_layout *layout = NULL; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/4ef777ba_360d87e8 PS1, Line 43: flashrom_set_log_callback((flashrom_log_callback *)&flashrom_print_cb); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/f2681fa7_667002d2 PS1, Line 43: flashrom_set_log_callback((flashrom_log_callback *)&flashrom_print_cb); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/7fa4ceff_9e8d80f5 PS1, Line 45: r |= flashrom_init(1); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/7de24780_c6394ae3 PS1, Line 45: r |= flashrom_init(1); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/8f65a252_35134322 PS1, Line 46: r |= flashrom_programmer_init(&prog, image->programmer, NULL); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/f8d5c367_cbbeba5c PS1, Line 46: r |= flashrom_programmer_init(&prog, image->programmer, NULL); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/4c12085a_7bfd1dcd PS1, Line 47: r |= flashrom_flash_probe(&flashctx, prog, NULL); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/cb5a7269_8dbb3dc5 PS1, Line 47: r |= flashrom_flash_probe(&flashctx, prog, NULL); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/bd6a3163_37fe9765 PS1, Line 49: len = flashrom_flash_getsize(flashctx); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/09f3134e_958f197e PS1, Line 49: len = flashrom_flash_getsize(flashctx); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/ebeee55e_c0dc3cf2 PS1, Line 50: if (region) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/d2ec5868_ccd6f56e PS1, Line 50: if (region) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/4d409118_db99ec21 PS1, Line 51: r = flashrom_layout_read_fmap_from_rom( code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/588c94ee_392a31cf PS1, Line 51: r = flashrom_layout_read_fmap_from_rom( please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/6311e8f2_e1c0d2cc PS1, Line 52: &layout, flashctx, 0, len); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/b5ef17f2_2442b0b8 PS1, Line 52: &layout, flashctx, 0, len); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/f7071302_6e413c16 PS1, Line 53: if (r > 0) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/9d598ed7_9388bbd1 PS1, Line 53: if (r > 0) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/6380f0b8_b2e3da1d PS1, Line 54: ERROR("could not read fmap from rom, r=%d\n", r); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/85f0bfa5_e4e6a082 PS1, Line 54: ERROR("could not read fmap from rom, r=%d\n", r); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5416df1c_dd9f6860 PS1, Line 55: r = -1; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/8d324b87_b35dfec3 PS1, Line 55: r = -1; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/974b9256_ff91a75c PS1, Line 56: goto err_cleanup; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/c7276eda_2ec04601 PS1, Line 56: goto err_cleanup; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/371443dd_99ecac4c PS1, Line 57: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/d1cb0e03_518d714e PS1, Line 57: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/9811ac86_aa368178 PS1, Line 58: // empty region causes seg fault in API. code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/9c9c82de_28240500 PS1, Line 59: r |= flashrom_layout_include_region(layout, region); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/d079cf8b_d46a0073 PS1, Line 59: r |= flashrom_layout_include_region(layout, region); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/1eef204a_266d42c5 PS1, Line 60: if (r > 0) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/3b08175c_308e2126 PS1, Line 60: if (r > 0) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/bae6709a_e11ed4d5 PS1, Line 61: ERROR("could not include region = '%s'\n", region); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/4b2966f1_bf040712 PS1, Line 61: ERROR("could not include region = '%s'\n", region); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/2ffd6866_68d0f036 PS1, Line 62: r = -1; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/b5e1a919_4bcc1815 PS1, Line 62: r = -1; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/6785dff4_d2b5cd6f PS1, Line 63: goto err_cleanup; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/4eec44ba_d0a2e0eb PS1, Line 63: goto err_cleanup; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/9ae3b2e3_51cd04af PS1, Line 64: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/1efda331_997239ed PS1, Line 64: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/1e3383ba_7611dc0f PS1, Line 65: flashrom_layout_set(flashctx, layout); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/ccf8b867_ce7b9c4d PS1, Line 65: flashrom_layout_set(flashctx, layout); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/afcf791e_f0776ebd PS1, Line 66: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/6772b9e3_e96203d5 PS1, Line 66: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/cb547b6c_0c49c277 PS1, Line 67: image->data = calloc(1, len); // XXX code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5da573bd_39041653 PS1, Line 67: image->data = calloc(1, len); // XXX please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/ce007300_7f433d92 PS1, Line 68: image->size = len; // XXX code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/c4d8aedb_a0ffc0ab PS1, Line 68: image->size = len; // XXX please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/9c1a65a8_329f9a99 PS1, Line 70: r |= flashrom_image_read(flashctx, image->data, len); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/68e19770_8dc21fad PS1, Line 70: r |= flashrom_image_read(flashctx, image->data, len); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5a7bb0ef_14effb88 PS1, Line 72: r |= flashrom_programmer_shutdown(prog); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/cca2d45d_289044ca PS1, Line 72: r |= flashrom_programmer_shutdown(prog); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/16e7a53a_03ec0784 PS1, Line 73: flashrom_flash_release(flashctx); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/0eae38f6_c5bd4608 PS1, Line 73: flashrom_flash_release(flashctx); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/dc0c9dda_a0ea40dc PS1, Line 75: return r; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/1b9a1415_75aff560 PS1, Line 75: return r; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/9a396b04_54534fd4 PS1, Line 80: int r = 0; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/7cddbbed_d5cb13eb PS1, Line 80: int r = 0; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/7ea60416_fd94c074 PS1, Line 81: size_t len = 0; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/bb1d0ee3_30874a0b PS1, Line 81: size_t len = 0; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/8f93b39b_46688007 PS1, Line 83: struct flashrom_programmer *prog = NULL; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/8cd6f549_f0c11162 PS1, Line 83: struct flashrom_programmer *prog = NULL; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/caec51eb_3fdbec3e PS1, Line 84: struct flashrom_flashctx *flashctx = NULL; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/b5e74816_055ee6e1 PS1, Line 84: struct flashrom_flashctx *flashctx = NULL; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/a0b43e5b_7f32a16b PS1, Line 85: struct flashrom_layout *layout = NULL; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/e057af3b_7e14ade8 PS1, Line 85: struct flashrom_layout *layout = NULL; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/0f6d87f8_f957f47d PS1, Line 87: flashrom_set_log_callback((flashrom_log_callback *)&flashrom_print_cb); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/fd2dda60_2ddd5d7b PS1, Line 87: flashrom_set_log_callback((flashrom_log_callback *)&flashrom_print_cb); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/7173596b_7142c107 PS1, Line 89: r |= flashrom_init(1); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/236e37f2_4b76d4d6 PS1, Line 89: r |= flashrom_init(1); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/6ee5c131_b5ea4ccd PS1, Line 90: r |= flashrom_programmer_init(&prog, image->programmer, NULL); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/cbd56773_0e8bb4d5 PS1, Line 90: r |= flashrom_programmer_init(&prog, image->programmer, NULL); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/bfac3d39_0ce8652d PS1, Line 91: r |= flashrom_flash_probe(&flashctx, prog, NULL); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/dd502acb_91754b0a PS1, Line 91: r |= flashrom_flash_probe(&flashctx, prog, NULL); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/d8526262_77ee1ab5 PS1, Line 93: len = flashrom_flash_getsize(flashctx); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/f5bc452e_81afb76c PS1, Line 93: len = flashrom_flash_getsize(flashctx); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/bf0b681b_cf887369 PS1, Line 94: if (len == 0) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/370eaaf4_eea84128 PS1, Line 94: if (len == 0) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/a4da47e0_a5c571d1 PS1, Line 95: ERROR("zero sized flash detected\n"); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/b5eff057_a1ead019 PS1, Line 95: ERROR("zero sized flash detected\n"); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/083d9c0d_43d78ed9 PS1, Line 96: r = -1; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/2d503159_03a49cbb PS1, Line 96: r = -1; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/3ba654c3_8f69387e PS1, Line 97: goto err_cleanup; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/e28d8ca3_385725f3 PS1, Line 97: goto err_cleanup; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/025e0ab0_c4325c96 PS1, Line 98: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/96450b8f_dcf22bba PS1, Line 98: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/488653a8_168f2b80 PS1, Line 99: if (region) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/39c4ac41_3eafd5ef PS1, Line 99: if (region) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/b4ba4c22_034d3700 PS1, Line 100: r = flashrom_layout_read_fmap_from_buffer( code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/c38a915a_3ae7643b PS1, Line 100: r = flashrom_layout_read_fmap_from_buffer( please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/2753f1d4_80c349fb PS1, Line 101: &layout, flashctx, (const uint8_t *)image->data, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/4e4bdc3e_21d46c4c PS1, Line 101: &layout, flashctx, (const uint8_t *)image->data, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/00c6533d_1a13af1b PS1, Line 102: image->size); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/7cd27bfc_dfd0082b PS1, Line 102: image->size); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/29e64efd_b042308e PS1, Line 103: if (r > 0) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/d99b875e_892c9397 PS1, Line 103: if (r > 0) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/1d0186f2_57c8df91 PS1, Line 104: WARN("could not read fmap from image, r=%d, " code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/2037e926_9ae18100 PS1, Line 104: WARN("could not read fmap from image, r=%d, " please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/583cab56_b0bec08d PS1, Line 105: "falling back to read from rom\n", r); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5db8e13c_0251f106 PS1, Line 105: "falling back to read from rom\n", r); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/a7a1b9c1_60264236 PS1, Line 106: r = flashrom_layout_read_fmap_from_rom( code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/6dda1149_cd089f92 PS1, Line 106: r = flashrom_layout_read_fmap_from_rom( please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/4d4b5fcc_29b5e550 PS1, Line 107: &layout, flashctx, 0, len); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/23ac7770_898d6487 PS1, Line 107: &layout, flashctx, 0, len); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/6eb32f83_9fe6ead3 PS1, Line 108: if (r > 0) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/de9890e3_abf87328 PS1, Line 108: if (r > 0) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/8dc014e2_e0f314e0 PS1, Line 109: ERROR("could not read fmap from rom, r=%d\n", r); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/c91ecaf5_50cbb985 PS1, Line 109: ERROR("could not read fmap from rom, r=%d\n", r); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/9230c1d4_f5e0c025 PS1, Line 110: r = -1; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/b69f6935_7ee6a700 PS1, Line 110: r = -1; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5c53ae49_ad141bd1 PS1, Line 111: goto err_cleanup; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/0c477c0c_53e0fe11 PS1, Line 111: goto err_cleanup; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/8c22762d_18d59bfe PS1, Line 112: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/23a15643_756ea457 PS1, Line 112: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/0ed73642_7f72d273 PS1, Line 113: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/ae550823_721118ad PS1, Line 113: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/101ab177_78cbd2cb PS1, Line 114: // empty region causes seg fault in API. code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5adaf4ce_032b1a3c PS1, Line 115: r |= flashrom_layout_include_region(layout, region); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/3c594243_1354bd81 PS1, Line 115: r |= flashrom_layout_include_region(layout, region); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/8aa6cf02_a31c713b PS1, Line 116: if (r > 0) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5b07633e_8ef410ab PS1, Line 116: if (r > 0) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/0c8adc50_4b6d88e1 PS1, Line 117: ERROR("could not include region = '%s'\n", region); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/3f3d1fc4_d182ae09 PS1, Line 117: ERROR("could not include region = '%s'\n", region); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/f019c11e_8834814b PS1, Line 118: r = -1; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/a35de7ef_54ac5e1c PS1, Line 118: r = -1; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/23c30fbc_bdd402a2 PS1, Line 119: goto err_cleanup; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/2f4478da_f58d74e2 PS1, Line 119: goto err_cleanup; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/0af04e7d_c54e9028 PS1, Line 120: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/8ef9c5de_40cec81b PS1, Line 120: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5db4d881_50f9fa77 PS1, Line 121: flashrom_layout_set(flashctx, layout); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/6bc730ac_10a3bf2e PS1, Line 121: flashrom_layout_set(flashctx, layout); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/f34e5786_4e843d9e PS1, Line 122: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/78105d3c_67090000 PS1, Line 122: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/672c7e84_2b7a3eba PS1, Line 124: flashrom_flag_set(flashctx, FLASHROM_FLAG_VERIFY_WHOLE_CHIP, true); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/087e7b27_aec9ed34 PS1, Line 124: flashrom_flag_set(flashctx, FLASHROM_FLAG_VERIFY_WHOLE_CHIP, true); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/4cf300ed_ef259da8 PS1, Line 125: flashrom_flag_set(flashctx, FLASHROM_FLAG_VERIFY_AFTER_WRITE, true); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/b1168290_4d389aa3 PS1, Line 125: flashrom_flag_set(flashctx, FLASHROM_FLAG_VERIFY_AFTER_WRITE, true); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/83c39ef2_d1d9f0fb PS1, Line 127: r |= flashrom_image_write(flashctx, image->data, image->size, NULL); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/fc779c82_c8ef4159 PS1, Line 127: r |= flashrom_image_write(flashctx, image->data, image->size, NULL); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/40b9261d_4e33ebd8 PS1, Line 130: r |= flashrom_programmer_shutdown(prog); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/b68a0286_e2e4f7c7 PS1, Line 130: r |= flashrom_programmer_shutdown(prog); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/6ef3ab6b_e91d029a PS1, Line 131: flashrom_layout_release(layout); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/d7465944_ce6256ee PS1, Line 131: flashrom_layout_release(layout); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/45b3b71c_44396e52 PS1, Line 132: flashrom_flash_release(flashctx); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/c77c98b1_f7e5e266 PS1, Line 132: flashrom_flash_release(flashctx); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/db62ffc9_5cfbaddf PS1, Line 133: free(tmp); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/0907f033_10e0b446 PS1, Line 133: free(tmp); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/704630ad_5f3c8506 PS1, Line 135: return r; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/8ce72fa6_41f1faf5 PS1, Line 135: return r; please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/59714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79df2934b9b0492a554a4fecdd533a0abe1df231 Gerrit-Change-Number: 59714 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 29 Nov 2021 00:23:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbfstool: Port elogtool to libflashrom
by Edward O'Callaghan (Code Review) 29 Nov '21

29 Nov '21

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59714 ) Change subject: util/cbfstool: Port elogtool to libflashrom ...................................................................... util/cbfstool: Port elogtool to libflashrom This also uncouples cbfstool from being overly Chromium specific. However the main objective is to not subprocess flashrom any more and instead use the programmatic API. BUG=b:207808292 TEST=none Change-Id: I79df2934b9b0492a554a4fecdd533a0abe1df231 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M util/cbfstool/Makefile.inc M util/cbfstool/elogtool.c A util/cbfstool/uflashrom.c A util/cbfstool/uflashrom.h 4 files changed, 168 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/59714/1 diff --git a/util/cbfstool/Makefile.inc b/util/cbfstool/Makefile.inc index 4651f51..3282c91 100644 --- a/util/cbfstool/Makefile.inc +++ b/util/cbfstool/Makefile.inc @@ -92,6 +92,7 @@ elogobj := elogobj := elogtool.o elogobj += eventlog.o +elogobj += uflashrom.o elogobj += valstr.o elogobj += elog.o elogobj += common.o diff --git a/util/cbfstool/elogtool.c b/util/cbfstool/elogtool.c index 253e2ee..68aa207 100644 --- a/util/cbfstool/elogtool.c +++ b/util/cbfstool/elogtool.c @@ -11,9 +11,9 @@ #include <common.h> #include <commonlib/bsd/elog.h> -#include <flashrom.h> #include "eventlog.h" +#include "uflashrom.h" /* Only refers to the data max size. The "-1" is the checksum byte */ #define ELOG_MAX_EVENT_DATA_SIZE (ELOG_MAX_EVENT_SIZE - sizeof(struct event_header) - 1) @@ -78,16 +78,17 @@ */ static int elog_read(struct buffer *buffer, const char *filename) { + struct firmware_programmer image = { + .programmer = FLASHROM_PROGRAMMER_INTERNAL_AP, + .data = NULL, + .size = 0, + }; if (filename == NULL) { - uint8_t *buf; - uint32_t buf_size; - - if (flashrom_read(FLASHROM_PROGRAMMER_INTERNAL_AP, ELOG_RW_REGION_NAME, - &buf, &buf_size) != VB2_SUCCESS) { + if (flashrom_read(&image, ELOG_RW_REGION_NAME) != 0) { fprintf(stderr, "Could not read RW_ELOG region using flashrom\n"); return ELOGTOOL_EXIT_READ_ERROR; } - buffer_init(buffer, NULL, buf, buf_size); + buffer_init(buffer, NULL, image.data, image.size); } else if (buffer_from_file(buffer, filename) != 0) { fprintf(stderr, "Could not read input file: %s\n", filename); return ELOGTOOL_EXIT_READ_ERROR; @@ -108,9 +109,13 @@ */ static int elog_write(struct buffer *buf, const char *filename) { + struct firmware_programmer image = { + .programmer = FLASHROM_PROGRAMMER_INTERNAL_AP, + .data = buffer_get(buf), + .size = buffer_size(buf), + }; if (filename == NULL) { - if (flashrom_write(FLASHROM_PROGRAMMER_INTERNAL_AP, ELOG_RW_REGION_NAME, - buffer_get(buf), buffer_size(buf)) != VB2_SUCCESS) { + if (flashrom_write(&image, ELOG_RW_REGION_NAME) != 0) { fprintf(stderr, "Failed to write to RW_ELOG region using flashrom\n"); return ELOGTOOL_EXIT_WRITE_ERROR; diff --git a/util/cbfstool/uflashrom.c b/util/cbfstool/uflashrom.c new file mode 100644 index 0000000..f53bfbe --- /dev/null +++ b/util/cbfstool/uflashrom.c @@ -0,0 +1,136 @@ +/* SPDX-License-Identifier: BSD-3-Clause */ + +#include <stdio.h> +#include <stdlib.h> +#include <stdint.h> + +#include <libflashrom.h> + +#include "uflashrom.h" + +// global to allow verbosity level to be injected into callback. +static enum flashrom_log_level g_verbose_screen = FLASHROM_MSG_INFO; + +static int flashrom_print_cb(enum flashrom_log_level level, const char *fmt, + va_list ap) +{ + int ret = 0; + FILE *output_type = (level < FLASHROM_MSG_INFO) ? stderr : stdout; + + if (level > g_verbose_screen) + return ret; + + ret = vfprintf(output_type, fmt, ap); + /* msg_*spew often happens inside chip accessors + * in possibly time-critical operations. + * Don't slow them down by flushing. + */ + if (level != FLASHROM_MSG_SPEW) + fflush(output_type); + + return ret; +} + +int flashrom_read(struct firmware_programmer *image, const char *region) +{ + int r = 0; + size_t len = 0; + + struct flashrom_programmer *prog = NULL; + struct flashrom_flashctx *flashctx = NULL; + struct flashrom_layout *layout = NULL; + + flashrom_set_log_callback((flashrom_log_callback *)&flashrom_print_cb); + + r |= flashrom_init(1); + r |= flashrom_programmer_init(&prog, image->programmer, NULL); + r |= flashrom_flash_probe(&flashctx, prog, NULL); + + len = flashrom_flash_getsize(flashctx); + if (region) { + r = flashrom_layout_read_fmap_from_rom( + &layout, flashctx, 0, len); + if (r > 0) { + ERROR("could not read fmap from rom, r=%d\n", r); + r = -1; + goto err_cleanup; + } + // empty region causes seg fault in API. + r |= flashrom_layout_include_region(layout, region); + if (r > 0) { + ERROR("could not include region = '%s'\n", region); + r = -1; + goto err_cleanup; + } + flashrom_layout_set(flashctx, layout); + } + image->data = calloc(1, len); // XXX + image->size = len; // XXX + + r |= flashrom_image_read(flashctx, image->data, len); + + r |= flashrom_programmer_shutdown(prog); + flashrom_flash_release(flashctx); + + return r; +} + +int flashrom_write(struct firmware_programmer *image, const char *region) +{ + int r = 0; + size_t len = 0; + + struct flashrom_programmer *prog = NULL; + struct flashrom_flashctx *flashctx = NULL; + struct flashrom_layout *layout = NULL; + + flashrom_set_log_callback((flashrom_log_callback *)&flashrom_print_cb); + + r |= flashrom_init(1); + r |= flashrom_programmer_init(&prog, image->programmer, NULL); + r |= flashrom_flash_probe(&flashctx, prog, NULL); + + len = flashrom_flash_getsize(flashctx); + if (len == 0) { + ERROR("zero sized flash detected\n"); + r = -1; + goto err_cleanup; + } + if (region) { + r = flashrom_layout_read_fmap_from_buffer( + &layout, flashctx, (const uint8_t *)image->data, + image->size); + if (r > 0) { + WARN("could not read fmap from image, r=%d, " + "falling back to read from rom\n", r); + r = flashrom_layout_read_fmap_from_rom( + &layout, flashctx, 0, len); + if (r > 0) { + ERROR("could not read fmap from rom, r=%d\n", r); + r = -1; + goto err_cleanup; + } + } + // empty region causes seg fault in API. + r |= flashrom_layout_include_region(layout, region); + if (r > 0) { + ERROR("could not include region = '%s'\n", region); + r = -1; + goto err_cleanup; + } + flashrom_layout_set(flashctx, layout); + } + + flashrom_flag_set(flashctx, FLASHROM_FLAG_VERIFY_WHOLE_CHIP, true); + flashrom_flag_set(flashctx, FLASHROM_FLAG_VERIFY_AFTER_WRITE, true); + + r |= flashrom_image_write(flashctx, image->data, image->size, NULL); + +err_cleanup: + r |= flashrom_programmer_shutdown(prog); + flashrom_layout_release(layout); + flashrom_flash_release(flashctx); + free(tmp); + + return r; +} diff --git a/util/cbfstool/uflashrom.h b/util/cbfstool/uflashrom.h new file mode 100644 index 0000000..82f79d6 --- /dev/null +++ b/util/cbfstool/uflashrom.h @@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: BSD-3-Clause */ + +#ifndef UFLASHROM_H +#define UFLASHROM_H + +#define FLASHROM_PROGRAMMER_INTERNAL_AP "internal" + +struct firmware_programmer { + const char *programmer; + uint32_t size; + uint8_t *data; +}; + +int flashrom_read(struct firmware_programmer *image, const char *region); +int flashrom_write(struct firmware_programmer *image, const char *region); + +#endif /* UFASHROM_H */ -- To view, visit https://review.coreboot.org/c/coreboot/+/59714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79df2934b9b0492a554a4fecdd533a0abe1df231 Gerrit-Change-Number: 59714 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mainboard/starlabs/labtop: Enable/disable Thunderbolt based on CMOS
by build bot (Jenkins) (Code Review) 28 Nov '21

28 Nov '21

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59705 ) Change subject: mainboard/starlabs/labtop: Enable/disable Thunderbolt based on CMOS ...................................................................... Patch Set 2: (2 comments) File src/mainboard/starlabs/labtop/variants/tgl/devtree.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134564): https://review.coreboot.org/c/coreboot/+/59705/comment/30b82344_e7e3bfbd PS2, Line 59: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134564): https://review.coreboot.org/c/coreboot/+/59705/comment/d6d7721e_e111d11f PS2, Line 59: } please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/59705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibadc7464831242ae51982610b410ccf0a6811edd Gerrit-Change-Number: 59705 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 28 Nov 2021 21:41:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mainboard/starlabs/labtop: Change logic for CMOS handling
by Sean Rhodes (Code Review) 28 Nov '21

28 Nov '21

Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/59706 ) Change subject: mainboard/starlabs/labtop: Change logic for CMOS handling ...................................................................... Abandoned Not needed -- To view, visit https://review.coreboot.org/c/coreboot/+/59706 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie4c479bad027598751209929514f2a2643090178 Gerrit-Change-Number: 59706 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021