Attention is currently required from: David Wu, Furquan Shaikh, Paul Menzel, Zhuohao Lee, Alan Huang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56539 )
Change subject: mb/google/brya: Enable DDR4 SODIMM for brask
......................................................................
Patch Set 16: Code-Review+2
(3 comments)
Patchset:
PS16:
Thanks David and Alan!
File src/mainboard/google/brya/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/56539/comment/5c8769bb_0ab94af3
PS15, Line 24: RW_SPD_CACHE(PRESERVE) 4K
> Ack
Done
File src/mainboard/google/brya/variants/baseboard/brask/memory.c:
https://review.coreboot.org/c/coreboot/+/56539/comment/d9cb1fd1_0bd4232f
PS15, Line 38: variant_get_spd_info
> We do have called this function in romstage.c.
Sorry, I think I looked at the wrong patchset.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56539
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41c57a3df127356b8c7e619c4d6144dc73aeac72
Gerrit-Change-Number: 56539
Gerrit-PatchSet: 16
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 01 Oct 2021 14:35:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Sugnan Prabhu S, Andy Yeh, Jim Lai, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58048 )
Change subject: mb/google/brya/variants/kano: Correct MIPI camera info
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/kano/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/58048/comment/a4a2a9b5_88c42d89
PS1, Line 323: 0x15752A00
> Done. Should be 360 * MHz, and it does the job.
Thanks I missed a zero 😊
--
To view, visit https://review.coreboot.org/c/coreboot/+/58048
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4612c9d42cd59cba0991b763224f77b7af33770b
Gerrit-Change-Number: 58048
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Lai <jim.lai(a)intel.com>
Gerrit-Reviewer: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Attention: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-Attention: Jim Lai <jim.lai(a)intel.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Fri, 01 Oct 2021 14:31:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Jim Lai <jim.lai(a)intel.com>
Gerrit-MessageType: comment
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58030 )
Change subject: mb/google/brya/var/kano: Add Synaptics touchpad
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58030/comment/4a03363a_578e2c14
PS1, Line 9: Add new Synaptics touchpad for kano.
> Thank you. This information would be great in the commit message (in the future). […]
It will still work with a standard GNU/Linux distribution. What the patch allows us to do is not spend time on each suspend/resume performing the _ON and _OFF methods on power resources for peripherals that are not actually connected to the device.
Basically, the I2C devices spend a few ms getting probed for their existence or not when the kernel inits the drivers, and then we don't have to waste time on non-existent devices for suspend/resume. On other distributions, suspend/resume might just take a little longer
--
To view, visit https://review.coreboot.org/c/coreboot/+/58030
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec43aaa9525309d2a0e3c9822038869786f5fe66
Gerrit-Change-Number: 58030
Gerrit-PatchSet: 3
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 01 Oct 2021 14:28:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Wu <david_wu(a)quanta.corp-partner.google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Marshall Dawson.
Felix Held has uploaded a new patch set (#3) to the change originally created by Raul Rangel. ( https://review.coreboot.org/c/coreboot/+/57051 )
Change subject: mb/google/guybrush: Use register and bit defines for eSPI setup
......................................................................
mb/google/guybrush: Use register and bit defines for eSPI setup
It's hard to understand what this code is doing because it uses hard
coded values, so use the register and bit defines instead.
BUG=none
TEST=Timeless build for guybrush results in identical binary.
Signed-off-by: Raul E Rangel <rrangel(a)chromium.org>
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I2d74ed3b9b4984ab1e2a22c50375baf9c9589df0
---
M src/mainboard/google/guybrush/bootblock.c
M src/mainboard/google/guybrush/verstage.c
2 files changed, 23 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/57051/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/57051
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d74ed3b9b4984ab1e2a22c50375baf9c9589df0
Gerrit-Change-Number: 57051
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-MessageType: newpatchset
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58052 )
Change subject: mb/siemens/mc_ehl: Move UART_FOR_CONSOLE switch to variant level
......................................................................
mb/siemens/mc_ehl: Move UART_FOR_CONSOLE switch to variant level
There are currently two variants for mc_ehl where different UARTs are
used for the console. Move the Kconfig switch UART_FOR_CONSOLE to the
Kconfig of the variant and select the matching value there.
Change-Id: I7152013a0e32ff151b92932a47953705e591dc0d
Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58052
Reviewed-by: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/mainboard/siemens/mc_ehl/Kconfig
M src/mainboard/siemens/mc_ehl/variants/mc_ehl1/Kconfig
M src/mainboard/siemens/mc_ehl/variants/mc_ehl2/Kconfig
3 files changed, 8 insertions(+), 5 deletions(-)
Approvals:
build bot (Jenkins): Verified
Mario Scheithauer: Looks good to me, approved
diff --git a/src/mainboard/siemens/mc_ehl/Kconfig b/src/mainboard/siemens/mc_ehl/Kconfig
index 8e5d95f..90881aa 100644
--- a/src/mainboard/siemens/mc_ehl/Kconfig
+++ b/src/mainboard/siemens/mc_ehl/Kconfig
@@ -34,9 +34,4 @@
config DIMM_SPD_SIZE
default 512
-config UART_FOR_CONSOLE
- int
- default 2 if INTEL_LPSS_UART_FOR_CONSOLE
- default 0
-
endif # BOARD_SIEMENS_BASEBOARD_MC_EHL
diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl1/Kconfig b/src/mainboard/siemens/mc_ehl/variants/mc_ehl1/Kconfig
index bc799dd..fbee7b0 100644
--- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl1/Kconfig
+++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl1/Kconfig
@@ -8,4 +8,8 @@
config FMDFILE
default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/mc_ehl.fmd"
+config UART_FOR_CONSOLE
+ int
+ default 2
+
endif # BOARD_SIEMENS_MC_EHL1
diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/Kconfig b/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/Kconfig
index 645379f..f577b24 100644
--- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/Kconfig
+++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/Kconfig
@@ -8,4 +8,8 @@
config FMDFILE
default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/mc_ehl.fmd"
+config UART_FOR_CONSOLE
+ int
+ default 0
+
endif # BOARD_SIEMENS_MC_EHL2
--
To view, visit https://review.coreboot.org/c/coreboot/+/58052
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7152013a0e32ff151b92932a47953705e591dc0d
Gerrit-Change-Number: 58052
Gerrit-PatchSet: 3
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged