coreboot-gerrit October 2021

coreboot-gerrit@coreboot.org

1 participants
5514 discussions

Change in coreboot[master]: src/ec/google/chromeec: Add APIs for USB-C DP ALT mode
by Derek Huang (Code Review) 01 Oct '21

01 Oct '21

Attention is currently required from: Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Brandon Breitenstein, Curtis Chen. Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57138 ) Change subject: src/ec/google/chromeec: Add APIs for USB-C DP ALT mode ...................................................................... Patch Set 14: (10 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/57138/comment/903303eb_03d779ad PS12, Line 9: Add API to allow AP to send the command to EC to enter DP ALT mode, : API to wait for DP HPD event and API to get USB-C mux related : information. Rename google_chromeec_usb_pd_control() to : google_chromeec_usb_pd_get_info() for better understanding. Change : the return value of google_chromeec_wait_for_displayport() : and google_chromeec_pd_get_amode(). > Thanks for reviewing. I will update patch set to address the comments. Done Commit Message: https://review.coreboot.org/c/coreboot/+/57138/comment/9e59fea5_78b48700 PS13, Line 10: and API to wait for DP HPD event > Please add a dot/period at the end. Done https://review.coreboot.org/c/coreboot/+/57138/comment/e083ba9f_bebc9fe7 PS13, Line 11: > Please elaborate, why 100 ms delay steps are used. […] Done File src/ec/google/chromeec/ec.h: https://review.coreboot.org/c/coreboot/+/57138/comment/39c62212_f33cde59 PS12, Line 12: usbc_mux.h > This file doesn't exist. Done https://review.coreboot.org/c/coreboot/+/57138/comment/7bfcf982_65dfa74c PS12, Line 41: int > Why was this type changed? I think we should keep it as long. Done File src/ec/google/chromeec/ec.c: https://review.coreboot.org/c/coreboot/+/57138/comment/240d03d1_6a7abab7 PS12, Line 1481: cable > `active_cable` to make the param intent clear. Done https://review.coreboot.org/c/coreboot/+/57138/comment/de7815c3_73a58164 PS12, Line 1513: if (google_chromeec_check_feature(EC_FEATURE_TYPEC_REQUIRE_AP_MODE_ENTRY)) { > If you invert the check, you can eliminate the additional tab required for rest of the function. […] Done https://review.coreboot.org/c/coreboot/+/57138/comment/a880b02d_4b14aa25 PS12, Line 1653: if (ret) : return ret; : else : return 0; > `return ret;` would do the right thing. Done https://review.coreboot.org/c/coreboot/+/57138/comment/ba00a2d8_f9e9441e PS12, Line 1679: : return ret; > printk BIOS_ERR in this case? Done File src/ec/google/chromeec/ec.c: https://review.coreboot.org/c/coreboot/+/57138/comment/04789aa4_7879a345 PS13, Line 1674: mdelay(100); > 100 ms sounds excessive for coreboot’s normal execution time. This function should be used only when there is no internal display (like Chromebox) so we must poll HPD event of external display. Also we need display in bios only when the system is in dev mode or recovery mode, we don't care about boot time so much, so we poll every 100ms up to `timeout_ms` -- To view, visit https://review.coreboot.org/c/coreboot/+/57138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id11510c1ff58579ae2cddfe5a4d69646fd84f5c3 Gerrit-Change-Number: 57138 Gerrit-PatchSet: 14 Gerrit-Owner: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Curtis Chen <curtis.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Attention: Curtis Chen <curtis.chen(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Fri, 01 Oct 2021 10:02:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/ec/google/chromeec: Add new API for USB-C mux handling
by Derek Huang (Code Review) 01 Oct '21

01 Oct '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak. Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58059 ) Change subject: src/ec/google/chromeec: Add new API for USB-C mux handling ...................................................................... Patch Set 2: (1 comment) File src/ec/google/chromeec/ec.c: https://review.coreboot.org/c/coreboot/+/58059/comment/f86bd5db_ee4df5ae PS1, Line 1585: if (google_chromeec_usb_pd_get_info(port, &ufp, &dbg_acc, &active_cable, &dp_mode) < 0) { > > line over 96 characters […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/58059 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc27f23214c2d5b91334ae3efe248100329964ba Gerrit-Change-Number: 58059 Gerrit-PatchSet: 2 Gerrit-Owner: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Fri, 01 Oct 2021 10:00:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/ec/google/chromeec: Update google_chromeec_usb_pd_get_info()
by Derek Huang (Code Review) 01 Oct '21

01 Oct '21

Attention is currently required from: Paul Menzel, Tim Wawrzynczak. Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58060 ) Change subject: src/ec/google/chromeec: Update google_chromeec_usb_pd_get_info() ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/58060/comment/c87a61ff_74fbd4fd PS1, Line 10: static and drop from ec.h > Please add a dot/period to the end of sentences. (Also other change-sets. […] Done File src/ec/google/chromeec/ec.h: https://review.coreboot.org/c/coreboot/+/58060/comment/14960f83_6dd278fb PS1, Line 36: /* Returns data role and type of device connected */ > Please add the comment to the now static function. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/58060 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4b3df4223d5c26ea1c1a52b26f7d49fa4c947de8 Gerrit-Change-Number: 58060 Gerrit-PatchSet: 2 Gerrit-Owner: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Fri, 01 Oct 2021 09:59:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tests: Add lib/lzma-test test case
by Jakub Czapiga (Code Review) 01 Oct '21

01 Oct '21

Attention is currently required from: Paul Menzel, Paul Fagerburg, Jan Dabros. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57555 ) Change subject: tests: Add lib/lzma-test test case ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/57555/comment/2b7aeb79_86fc3159 PS1, Line 8: > Maybe you could add the test output to the commit message for reference? The test output is the same as for other tests in tests/ tree. I added steps, which lead to creation of input files for test. I hope it helps :) -- To view, visit https://review.coreboot.org/c/coreboot/+/57555 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id75e0b41991382d4c391b031862106de58eacdf7 Gerrit-Change-Number: 57555 Gerrit-PatchSet: 3 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-Comment-Date: Fri, 01 Oct 2021 09:59:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/ec/google/chromeec: Register USB-C mux operations
by Derek Huang (Code Review) 01 Oct '21

01 Oct '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak. Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58061 ) Change subject: src/ec/google/chromeec: Register USB-C mux operations ...................................................................... Patch Set 2: (1 comment) File src/ec/google/chromeec/usbc_mux.c: https://review.coreboot.org/c/coreboot/+/58061/comment/ffa77526_f1dd9002 PS1, Line 5: struct > static const struct Done -- To view, visit https://review.coreboot.org/c/coreboot/+/58061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I576c9e4c6c82d6b4055b0a0a9a75c677d4b05220 Gerrit-Change-Number: 58061 Gerrit-PatchSet: 2 Gerrit-Owner: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Fri, 01 Oct 2021 09:59:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/tcss: Optimize USB-C DP flow and code structure
by Derek Huang (Code Review) 01 Oct '21

01 Oct '21

Attention is currently required from: Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Curtis Chen, Brandon Breitenstein. Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57139 ) Change subject: soc/intel/common/tcss: Optimize USB-C DP flow and code structure ...................................................................... Patch Set 21: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/57139/comment/8491af68_363cd10e PS20, Line 8: > Please describe the problem first. Done https://review.coreboot.org/c/coreboot/+/57139/comment/b88b6be2_e769b3d3 PS20, Line 11: > Please paste the new log messages, which should be shown now, and say, what exact device you tested […] Done File src/soc/intel/common/block/tcss/tcss.c: https://review.coreboot.org/c/coreboot/+/57139/comment/f4837c34_02530779 PS19, Line 313: get_mux_info > If `wait_for_hpd()` is successful, does it not guarantee that the MUX is configured in DP mode? Is t […] Agree that if `wait_for_hpd()` is successful, it guarantee that the mux is configured in DP. Removed the additional check. -- To view, visit https://review.coreboot.org/c/coreboot/+/57139 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7e6dd952d3183ecb76de6d4887ee573ef89bb50 Gerrit-Change-Number: 57139 Gerrit-PatchSet: 21 Gerrit-Owner: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Curtis Chen <curtis.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Curtis Chen <curtis.chen(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Curtis Chen <curtis.chen(a)intel.com> Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Attention: Curtis Chen <curtis.chen(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Fri, 01 Oct 2021 09:58:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/tcss: Optimize USB-C DP flow and code structure
by Derek Huang (Code Review) 01 Oct '21

01 Oct '21

Attention is currently required from: Tim Wawrzynczak, Curtis Chen, Brandon Breitenstein. Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Zhuohao Lee, Brandon Breitenstein, Patrick Rudolph, Curtis Chen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57139 to look at the new patch set (#21). Change subject: soc/intel/common/tcss: Optimize USB-C DP flow and code structure ...................................................................... soc/intel/common/tcss: Optimize USB-C DP flow and code structure HPD event may not be ready when configuring TCSS mux for DP, check if any DP device is connected and wait for HPD ready before TCSS configuration. Remove unnecessary dependency on mainboard functions, use generic interface which provides USB-C mux operations. BUG=b:192947843 TEST=select ENABLE_TCSS_DISPLAY_DETECTION in Kconfig.name for Brya. Build coreboot and update your Brya. Boot Brya with USB-C display connected, you should find `HPD ready after %lu ms` and `Port C%zd is configured to DP mode!` in coreboot log. Display should show screen in developer mode or recovery mode. Signed-off-by: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Change-Id: Ia7e6dd952d3183ecb76de6d4887ee573ef89bb50 --- M src/soc/intel/common/block/include/intelblocks/tcss.h M src/soc/intel/common/block/tcss/tcss.c 2 files changed, 40 insertions(+), 39 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/57139/21 -- To view, visit https://review.coreboot.org/c/coreboot/+/57139 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7e6dd952d3183ecb76de6d4887ee573ef89bb50 Gerrit-Change-Number: 57139 Gerrit-PatchSet: 21 Gerrit-Owner: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Curtis Chen <curtis.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Curtis Chen <curtis.chen(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Curtis Chen <curtis.chen(a)intel.com> Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Attention: Curtis Chen <curtis.chen(a)intel.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: src/ec/google/chromeec: Register USB-C mux operations
by Derek Huang (Code Review) 01 Oct '21

01 Oct '21

Attention is currently required from: Tim Wawrzynczak. Hello build bot (Jenkins), Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58061 to look at the new patch set (#2). Change subject: src/ec/google/chromeec: Register USB-C mux operations ...................................................................... src/ec/google/chromeec: Register USB-C mux operations Register USB-C mux operations to the generic interface. BUG=b:192947843 Signed-off-by: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Change-Id: I576c9e4c6c82d6b4055b0a0a9a75c677d4b05220 --- M src/ec/google/chromeec/Makefile.inc A src/ec/google/chromeec/usbc_mux.c 2 files changed, 20 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/58061/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I576c9e4c6c82d6b4055b0a0a9a75c677d4b05220 Gerrit-Change-Number: 58061 Gerrit-PatchSet: 2 Gerrit-Owner: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: src/ec/google/chromeec: Update google_chromeec_usb_pd_get_info()
by Derek Huang (Code Review) 01 Oct '21

01 Oct '21

Attention is currently required from: Tim Wawrzynczak. Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58060 to look at the new patch set (#2). Change subject: src/ec/google/chromeec: Update google_chromeec_usb_pd_get_info() ...................................................................... src/ec/google/chromeec: Update google_chromeec_usb_pd_get_info() google_chromeec_usb_pd_get_info() is used in ec.c only. Make it static and drop from ec.h. BUG=b:192947843 Signed-off-by: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Change-Id: I4b3df4223d5c26ea1c1a52b26f7d49fa4c947de8 --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h 2 files changed, 2 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/58060/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58060 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4b3df4223d5c26ea1c1a52b26f7d49fa4c947de8 Gerrit-Change-Number: 58060 Gerrit-PatchSet: 2 Gerrit-Owner: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: src/ec/google/chromeec: Add new API for USB-C mux handling
by Derek Huang (Code Review) 01 Oct '21

01 Oct '21

Attention is currently required from: Tim Wawrzynczak. Hello build bot (Jenkins), Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58059 to look at the new patch set (#2). Change subject: src/ec/google/chromeec: Add new API for USB-C mux handling ...................................................................... src/ec/google/chromeec: Add new API for USB-C mux handling Add google_chromeec_get_usbc_mux_info() to obtain USB-C mux related information. BUG=b:192947843 Signed-off-by: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Change-Id: Idc27f23214c2d5b91334ae3efe248100329964ba --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h 2 files changed, 44 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/58059/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58059 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc27f23214c2d5b91334ae3efe248100329964ba Gerrit-Change-Number: 58059 Gerrit-PatchSet: 2 Gerrit-Owner: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2021