Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58030 )
Change subject: mb/google/brya/var/kano: Add Synaptics touchpad
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58030/comment/ea70f7b6_312f2d49
PS1, Line 9: Add new Synaptics touchpad for kano.
> ChromeOS carries 1 patch that was not upstreamable that allows us to probe in the kernel for which t […]
Thank you. This information would be great in the commit message (in the future).
Does that mean, this won’t currently work with a standard GNU/Linux distribution? What touchpad is going to get chosen?
--
To view, visit https://review.coreboot.org/c/coreboot/+/58030
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec43aaa9525309d2a0e3c9822038869786f5fe66
Gerrit-Change-Number: 58030
Gerrit-PatchSet: 3
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 01 Oct 2021 07:22:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Wu <david_wu(a)quanta.corp-partner.google.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Xi Chen, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58074 )
Change subject: soc/mediatek: add debug dump for ltiming and clock_div
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> (I was wondering if we can create common/i2c_v1 and i2c_v2. […]
GPIOs and speed_init setting are different.
If we want to do that, maybe there are some big effort to separate them.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58074
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3228c6953be5fac18a76029702b878a34c7563f7
Gerrit-Change-Number: 58074
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Fri, 01 Oct 2021 07:11:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Xi Chen, Rex-BC Chen, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58074 )
Change subject: soc/mediatek: add debug dump for ltiming and clock_div
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
(I was wondering if we can create common/i2c_v1 and i2c_v2.c and do the timing cal / structure specific stuff there)
--
To view, visit https://review.coreboot.org/c/coreboot/+/58074
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3228c6953be5fac18a76029702b878a34c7563f7
Gerrit-Change-Number: 58074
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Fri, 01 Oct 2021 07:05:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Xi Chen, Rex-BC Chen, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58074 )
Change subject: soc/mediatek: add debug dump for ltiming and clock_div
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
so even for all v2 SoCs (83, 92, 95), we still can't make a unified implementation for mtk_i2c_speed_init?
--
To view, visit https://review.coreboot.org/c/coreboot/+/58074
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3228c6953be5fac18a76029702b878a34c7563f7
Gerrit-Change-Number: 58074
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Fri, 01 Oct 2021 07:04:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/17137 )
Change subject: skylake: Fix wake source reporting with Deep S3
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> > Well, pm1_en and gpe0_std registers are not restored/overridden by this patch but only the masks u […]
Great, thank you very much! 😊
--
To view, visit https://review.coreboot.org/c/coreboot/+/17137
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5113d6890f6cbecc32f92af67a29952266fe0ac
Gerrit-Change-Number: 17137
Gerrit-PatchSet: 3
Gerrit-Owner: Duncan Laurie
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Duncan Laurie
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Comment-Date: Fri, 01 Oct 2021 07:04:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Xi Chen.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58074 )
Change subject: soc/mediatek: add debug dump for ltiming and clock_div
......................................................................
Patch Set 3:
(3 comments)
File src/soc/mediatek/mt8183/i2c.c:
https://review.coreboot.org/c/coreboot/+/58074/comment/8456bae6_a5a10221
PS2, Line 139: void mtk_i2c_dump_more_info(struct mt_i2c_regs *regs) {
> open brace '{' following function definitions go on the next line
Please fix.
File src/soc/mediatek/mt8192/i2c.c:
https://review.coreboot.org/c/coreboot/+/58074/comment/69e05b53_d24480ce
PS2, Line 185: void mtk_i2c_dump_more_info(struct mt_i2c_regs *regs) {
> open brace '{' following function definitions go on the next line
Please fix.
File src/soc/mediatek/mt8195/i2c.c:
https://review.coreboot.org/c/coreboot/+/58074/comment/71d07f47_0791b397
PS2, Line 359: void mtk_i2c_dump_more_info(struct mt_i2c_regs *regs) {
> open brace '{' following function definitions go on the next line
Please fix.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58074
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3228c6953be5fac18a76029702b878a34c7563f7
Gerrit-Change-Number: 58074
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Comment-Date: Fri, 01 Oct 2021 06:52:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Xi Chen.
Hello Xi Chen, Hung-Te Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58074
to look at the new patch set (#3).
Change subject: soc/mediatek: add debug dump for ltiming and clock_div
......................................................................
soc/mediatek: add debug dump for ltiming and clock_div
ltiming and clock_div are not support for MT8173, so we separate them
to weak function: mtk_i2c_dump_more_info()
Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Change-Id: I3228c6953be5fac18a76029702b878a34c7563f7
---
M src/soc/mediatek/mt8183/i2c.c
M src/soc/mediatek/mt8192/i2c.c
M src/soc/mediatek/mt8195/i2c.c
3 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/58074/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/58074
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3228c6953be5fac18a76029702b878a34c7563f7
Gerrit-Change-Number: 58074
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Xi Chen.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58074 )
Change subject: soc/mediatek: add debug dump for ltiming and clock_div
......................................................................
Patch Set 2:
(3 comments)
File src/soc/mediatek/mt8183/i2c.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129585):
https://review.coreboot.org/c/coreboot/+/58074/comment/c4c9407e_706c4000
PS2, Line 139: void mtk_i2c_dump_more_info(struct mt_i2c_regs *regs) {
open brace '{' following function definitions go on the next line
File src/soc/mediatek/mt8192/i2c.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129585):
https://review.coreboot.org/c/coreboot/+/58074/comment/da1ebce2_cd69daa5
PS2, Line 185: void mtk_i2c_dump_more_info(struct mt_i2c_regs *regs) {
open brace '{' following function definitions go on the next line
File src/soc/mediatek/mt8195/i2c.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129585):
https://review.coreboot.org/c/coreboot/+/58074/comment/a8a82931_58088321
PS2, Line 359: void mtk_i2c_dump_more_info(struct mt_i2c_regs *regs) {
open brace '{' following function definitions go on the next line
--
To view, visit https://review.coreboot.org/c/coreboot/+/58074
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3228c6953be5fac18a76029702b878a34c7563f7
Gerrit-Change-Number: 58074
Gerrit-PatchSet: 2
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Comment-Date: Fri, 01 Oct 2021 06:48:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment