Attention is currently required from: Rex-BC Chen.
Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58055
to look at the new patch set (#8).
Change subject: util/cbfstool: Add support for ARM64 UefiPayload
......................................................................
util/cbfstool: Add support for ARM64 UefiPayload
UEFI payload is supported on some ARM64 platforms, for example MT8195.
As a result, add MACHINE_TYPE_ARM64 to support ARM SystemReady.
Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Change-Id: I4c0c6e263bd2f518a62ff9db44d72dd31086756a
---
M util/cbfstool/cbfs-mkpayload.c
M util/cbfstool/coff.h
2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/58055/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/58055
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c0c6e263bd2f518a62ff9db44d72dd31086756a
Gerrit-Change-Number: 58055
Gerrit-PatchSet: 8
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Xi Chen.
Hello Xi Chen, Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58074
to look at the new patch set (#4).
Change subject: soc/mediatek: add debug dump for ltiming and clock_div
......................................................................
soc/mediatek: add debug dump for ltiming and clock_div
ltiming and clock_div are not support for MT8173, so we separate them
to weak function: mtk_i2c_dump_more_info()
Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Change-Id: I3228c6953be5fac18a76029702b878a34c7563f7
---
M src/soc/mediatek/mt8183/i2c.c
M src/soc/mediatek/mt8192/i2c.c
M src/soc/mediatek/mt8195/i2c.c
3 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/58074/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/58074
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3228c6953be5fac18a76029702b878a34c7563f7
Gerrit-Change-Number: 58074
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Rex-BC Chen.
Hello Jg Daolongzhu, Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58053
to look at the new patch set (#4).
Change subject: soc/mediatek: Fix I2C failures by adjusting AC timing and bus speed
......................................................................
soc/mediatek: Fix I2C failures by adjusting AC timing and bus speed
1. The original algorithm for I2C speed cannot always make the
timing meet I2C specification so a new algorithm is introduced
to calculate the timing parameters more correctly.
2. Some I2C buses should be initialized in a different speed while
the original implementation was fixed at fast mode (400Khz).
So the mtk_i2c_bus_init is now also taking an extra speed
parameter.
There is an equivalent change in kernel side:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/d…
BUG=b:189899864
TEST=Test on Tomato, boot pass and timing pass
at 100/300/400/500/800/1000Khz.
Signed-off-by: Daolong Zhu <jg_daolongzhu(a)mediatek.corp-partner.google.com>
Change-Id: Id25b7bb3a76908a7943b940eb5bee799e80626a0
---
M src/mainboard/google/cherry/bootblock.c
M src/mainboard/google/cherry/mainboard.c
M src/mainboard/google/cherry/romstage.c
M src/soc/mediatek/common/i2c.c
M src/soc/mediatek/common/include/soc/i2c_common.h
M src/soc/mediatek/mt8195/i2c.c
M src/soc/mediatek/mt8195/include/soc/i2c.h
7 files changed, 341 insertions(+), 74 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/58053/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/58053
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id25b7bb3a76908a7943b940eb5bee799e80626a0
Gerrit-Change-Number: 58053
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jg Daolongzhu <jg_daolongzhu(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Tim Wawrzynczak.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58057 )
Change subject: src/ec/google/chromeec: Update google_chromeec_usb_pd_control()
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58057/comment/07fd5df7_64ee89aa
PS1, Line 8:
> Please introduce the topic, by saying what cable types there are, and why this information is necess […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/58057
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie91a3096d49d5dde75e60ab0f2f38152cef720f6
Gerrit-Change-Number: 58057
Gerrit-PatchSet: 2
Gerrit-Owner: Derek Huang <derek.huang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Fri, 01 Oct 2021 10:02:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Tim Wawrzynczak.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58058 )
Change subject: src/ec/google/chromeec: Update some PD and DisplayPort APIs
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58058/comment/d5d301da_ffccd41d
PS1, Line 7: some
> some PD and DisplayPort
Done
https://review.coreboot.org/c/coreboot/+/58058/comment/3f83fa01_d28e56fa
PS1, Line 9: Update google_chromeec_pd_get_amode() to return bitmask. Update
: google_chromeec_wait_for_displayport() to handle the updated return
: value of google_chromeec_pd_get_amode(). Drop
: google_chromeec_pd_get_amode() from ec.h and make it static because
: it's not used outside of ec.c
> Please format this as a list. Even better, please make one commit per change.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/58058
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6020c4305e30018d4c97d862c16e8d642c951765
Gerrit-Change-Number: 58058
Gerrit-PatchSet: 2
Gerrit-Owner: Derek Huang <derek.huang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Fri, 01 Oct 2021 10:02:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment