Attention is currently required from: shkim, Henry Sun, SH Kim, Karthik Ramasubramanian.
Edward Doan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58073 )
Change subject: mb/google/dedede/var/bugzzy: Update GPP_D5 configuration
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/58073
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53e4fc52ceb14ba23c22d3c105f65634b09029f1
Gerrit-Change-Number: 58073
Gerrit-PatchSet: 1
Gerrit-Owner: shkim <sh_.kim(a)samsung.com>
Gerrit-Reviewer: Edward Doan <edoan(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: shkim <sh_.kim(a)samsung.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Fri, 01 Oct 2021 17:43:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Paul Menzel, Jan Dabros.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57555 )
Change subject: tests: Add lib/lzma-test test case
......................................................................
Patch Set 3:
(1 comment)
File tests/lib/lzma-test.c:
https://review.coreboot.org/c/coreboot/+/57555/comment/3929b613_f85327ec
PS3, Line 43: 4
Make ".bin" and ".lzma.bin" into constant variables, then use strlen here instead of a magic number. Then use the strings in the snprintf calls below.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57555
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id75e0b41991382d4c391b031862106de58eacdf7
Gerrit-Change-Number: 57555
Gerrit-PatchSet: 3
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Comment-Date: Fri, 01 Oct 2021 17:24:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Derek Huang.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58059 )
Change subject: src/ec/google/chromeec: Add new API for USB-C mux handling
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/58059
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc27f23214c2d5b91334ae3efe248100329964ba
Gerrit-Change-Number: 58059
Gerrit-PatchSet: 2
Gerrit-Owner: Derek Huang <derek.huang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Derek Huang <derek.huang(a)intel.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 01 Oct 2021 17:20:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Derek Huang.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58058 )
Change subject: src/ec/google/chromeec: Update some PD and DisplayPort APIs
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/58058
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6020c4305e30018d4c97d862c16e8d642c951765
Gerrit-Change-Number: 58058
Gerrit-PatchSet: 2
Gerrit-Owner: Derek Huang <derek.huang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Derek Huang <derek.huang(a)intel.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 01 Oct 2021 17:11:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Derek Huang.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58002 )
Change subject: include/device: Generic interface for USB-C mux operations
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/include/usbc_mux.h:
https://review.coreboot.org/c/coreboot/+/58002/comment/9c173222_26eca731
PS3, Line 13: uint8_t
> This field indicates DP pin assignment: […]
Can you please add the mode details to the comment as well? I think that would be helpful for users in the future.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58002
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5435f2054d1c9f114b06c3b4643e34713290e0d
Gerrit-Change-Number: 58002
Gerrit-PatchSet: 4
Gerrit-Owner: Derek Huang <derek.huang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Derek Huang <derek.huang(a)intel.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 01 Oct 2021 17:08:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Derek Huang <derek.huang(a)intel.corp-partner.google.com>
Gerrit-MessageType: comment