coreboot-gerrit October 2021

coreboot-gerrit@coreboot.org

1 participants
5514 discussions

Change in coreboot[master]: payloads: Add UefiPayload support to ARM64 platforms
by Hung-Te Lin (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Martin Roth, Rex-BC Chen, Paul Menzel, Julius Werner, Marty E. Plummer. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58054 ) Change subject: payloads: Add UefiPayload support to ARM64 platforms ...................................................................... Patch Set 6: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/58054/comment/18b432a1_c642b501 PS6, Line 9: is are Patchset: PS6: > is this patch ready for merged? I think we are pending on Marty's issue. Can you describe precisely how you tested this? (e.g., which board config selected, and which option turned on, ...) -- To view, visit https://review.coreboot.org/c/coreboot/+/58054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10777a341d46240b91ceeeb1be26c33a0c5db839 Gerrit-Change-Number: 58054 Gerrit-PatchSet: 6 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Comment-Date: Wed, 06 Oct 2021 01:51:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Update vboot submodule to upstream main
by Yu-Ping Wu (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Hsuan Ting Chen, Hsuan-ting Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58107 ) Change subject: Update vboot submodule to upstream main ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58107 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b7c117aab3a680db292c38e1f7e635e8005ab1c Gerrit-Change-Number: 58107 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Comment-Date: Wed, 06 Oct 2021 01:48:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads: Add UefiPayload support to ARM64 platforms
by Rex-BC Chen (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Martin Roth, Paul Menzel, Julius Werner, Marty E. Plummer. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58054 ) Change subject: payloads: Add UefiPayload support to ARM64 platforms ...................................................................... Patch Set 6: Code-Review+1 (1 comment) Patchset: PS6: is this patch ready for merged? -- To view, visit https://review.coreboot.org/c/coreboot/+/58054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10777a341d46240b91ceeeb1be26c33a0c5db839 Gerrit-Change-Number: 58054 Gerrit-PatchSet: 6 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Comment-Date: Wed, 06 Oct 2021 01:44:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/ocp/deltalake: Fix SMBIOS type 9 bugs
by Johnny Lin (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Jonathan Zhang, Christian Walter, Jingle Hsu, Angel Pons, Arthur Heymans, Morgan Jang, Tim Chu, Shelly_Chang(a)wiwynn.com. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58100 ) Change subject: mb/ocp/deltalake: Fix SMBIOS type 9 bugs ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/58100 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea437cdf3da5410b6b7a749a1be970f0948d92d9 Gerrit-Change-Number: 58100 Gerrit-PatchSet: 5 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Shelly_Chang(a)wiwynn.com Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Shelly_Chang(a)wiwynn.com Gerrit-Comment-Date: Wed, 06 Oct 2021 00:55:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/ocp/deltalake: Fix SMBIOS type 9 bugs
by Johnny Lin (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Jonathan Zhang, Christian Walter, Jingle Hsu, Angel Pons, Arthur Heymans, Morgan Jang, Tim Chu, Shelly_Chang(a)wiwynn.com. Hello build bot (Jenkins), Jonathan Zhang, Christian Walter, Jingle Hsu, Angel Pons, Arthur Heymans, Morgan Jang, Shelly_Chang(a)wiwynn.com, Tim Chu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58100 to look at the new patch set (#5). Change subject: mb/ocp/deltalake: Fix SMBIOS type 9 bugs ...................................................................... mb/ocp/deltalake: Fix SMBIOS type 9 bugs 1. Fix PCIe slot capabilities was not really read from an IIO root port device. The Hot-Plug capability of IIO root port cannot be enabled due to FSP limitation, but the code should reflect the true capabilities by reading the root port device's CSR. 2. Initiailize the characteristics flags to 0 in the for-loop. Tested=On OCP Delta Lake, dmidecode -t 9 shows expected results. Change-Id: Iea437cdf3da5410b6b7a749a1be970f0948d92d9 Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com> --- M src/mainboard/ocp/deltalake/ramstage.c 1 file changed, 13 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/58100/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/58100 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea437cdf3da5410b6b7a749a1be970f0948d92d9 Gerrit-Change-Number: 58100 Gerrit-PatchSet: 5 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Shelly_Chang(a)wiwynn.com Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Shelly_Chang(a)wiwynn.com Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/ocp/deltalake: Fix SMBIOS type 9 bugs
by Johnny Lin (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Jonathan Zhang, Christian Walter, Jingle Hsu, Angel Pons, Arthur Heymans, Morgan Jang, Tim Chu, Shelly_Chang(a)wiwynn.com. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58100 ) Change subject: mb/ocp/deltalake: Fix SMBIOS type 9 bugs ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/mainboard/ocp/deltalake/ramstage.c: https://review.coreboot.org/c/coreboot/+/58100/comment/abe96fa7_c690d786 PS3, Line 197: uint8_t characteristics_1 = 0; : uint8_t characteristics_2 = 0; > I'd move these declarations inside the loop: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/58100 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea437cdf3da5410b6b7a749a1be970f0948d92d9 Gerrit-Change-Number: 58100 Gerrit-PatchSet: 4 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Shelly_Chang(a)wiwynn.com Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Shelly_Chang(a)wiwynn.com Gerrit-Comment-Date: Wed, 06 Oct 2021 00:52:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/ocp/deltalake: Fix SMBIOS type 9 bugs
by Johnny Lin (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, Jingle Hsu, Arthur Heymans, Morgan Jang, Tim Chu, Shelly_Chang(a)wiwynn.com. Hello build bot (Jenkins), Jonathan Zhang, Christian Walter, Jingle Hsu, Angel Pons, Arthur Heymans, Morgan Jang, Shelly_Chang(a)wiwynn.com, Tim Chu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58100 to look at the new patch set (#4). Change subject: mb/ocp/deltalake: Fix SMBIOS type 9 bugs ...................................................................... mb/ocp/deltalake: Fix SMBIOS type 9 bugs 1. Fix PCIe slot capabilities was not really read from an IIO root port device. The Hot-Plug capability of IIO root port cannot be enabled due to FSP limitation, but the code should reflect the true capabilities by reading the root port device's CSR. 2. Clear the characteristics flags before the next for-loop iteration. Tested=On OCP Delta Lake, dmidecode -t 9 shows expected results. Change-Id: Iea437cdf3da5410b6b7a749a1be970f0948d92d9 Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com> --- M src/mainboard/ocp/deltalake/ramstage.c 1 file changed, 13 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/58100/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/58100 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea437cdf3da5410b6b7a749a1be970f0948d92d9 Gerrit-Change-Number: 58100 Gerrit-PatchSet: 4 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Shelly_Chang(a)wiwynn.com Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Shelly_Chang(a)wiwynn.com Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/trogdor: Add new vaviant quackingstick
by Sheng-Liang Pan (Code Review) 06 Oct '21

06 Oct '21

Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58033 ) Change subject: mb/google/trogdor: Add new vaviant quackingstick ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/58033/comment/1266d5da_15e3ecef PS1, Line 7: vaviant > Apparently it was not. […] sorry about that, patch set 2 corrected it but patchset3 wrong again. -- To view, visit https://review.coreboot.org/c/coreboot/+/58033 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8299ddda14eb82103f17f8464a14992aa757afa6 Gerrit-Change-Number: 58033 Gerrit-PatchSet: 4 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 06 Oct 2021 00:30:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp_m: Enable touchpad
by Bernardo Perez Priego (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Bora Guvendik, Anil Kumar K, Tim Wawrzynczak, Selma Bensaid, Raju Rajakumar. Bernardo Perez Priego has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57863 ) Change subject: mb/intel/adlrvp_m: Enable touchpad ...................................................................... Patch Set 5: (2 comments) File src/mainboard/intel/adlrvp/gpio_m.c: https://review.coreboot.org/c/coreboot/+/57863/comment/f447c678_8dc50c3f PS4, Line 175: PAD_CFG_GPO(GPP_E4, 0, DEEP), > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/57863/comment/f80e2511_311320a6 PS4, Line 175: PAD_CFG_GPO(GPP_E4, 0, DEEP), > please, no spaces at the start of a line Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/57863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I78e5e133f7d3af47395819a79638a90fee4fd19e Gerrit-Change-Number: 57863 Gerrit-PatchSet: 5 Gerrit-Owner: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Raju Rajakumar <raju.rajakumar(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Raju Rajakumar <raju.rajakumar(a)intel.com> Gerrit-Comment-Date: Wed, 06 Oct 2021 00:24:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp_m: Enable touchpad
by Bernardo Perez Priego (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Bora Guvendik, Anil Kumar K, Tim Wawrzynczak, Selma Bensaid, Raju Rajakumar. Hello Bora Guvendik, Anil Kumar K, build bot (Jenkins), Tim Wawrzynczak, Selma Bensaid, Raju Rajakumar, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57863 to look at the new patch set (#5). Change subject: mb/intel/adlrvp_m: Enable touchpad ...................................................................... mb/intel/adlrvp_m: Enable touchpad This changes will include ELAN touchpad to ACPI tables and configure GPIO's. Signed-off-by: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Change-Id: I78e5e133f7d3af47395819a79638a90fee4fd19e --- M src/mainboard/intel/adlrvp/devicetree_m.cb M src/mainboard/intel/adlrvp/gpio_m.c 2 files changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/57863/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/57863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I78e5e133f7d3af47395819a79638a90fee4fd19e Gerrit-Change-Number: 57863 Gerrit-PatchSet: 5 Gerrit-Owner: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Raju Rajakumar <raju.rajakumar(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Raju Rajakumar <raju.rajakumar(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2021