coreboot-gerrit October 2021

coreboot-gerrit@coreboot.org

1 participants
5514 discussions

Change in coreboot[master]: Rename ECAM-specific MMCONF Kconfigs
by Furquan Shaikh (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Raul Rangel, Mariusz Szafrański, Jonathan Zhang, Stefan Reinauer, Kyösti Mälkki, Andrey Petrov, Patrick Rudolph, Nico Huber, Anjaneya "Reddy" Chagam, Johnny Lin, Suresh Bellampalli, Morgan Jang, Michal Motyl, Alexander Couzens, Felix Held, Shelley Chen, Angel Pons, Lance Zhao, Jason Glenesk, Martin Roth, Damien Zammit, Lee Leahy, Marshall Dawson, Tim Wawrzynczak, Vanessa Eusebio, Huang Jin. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57333 ) Change subject: Rename ECAM-specific MMCONF Kconfigs ...................................................................... Patch Set 8: (2 comments) File src/device/Kconfig: https://review.coreboot.org/c/coreboot/+/57333/comment/649aa7d0_5093e909 PS8, Line 501: : config PCI_NO_MMIO_OPS : bool : default n : help : If this config is selected, the MMIO access for PCI config : space is disabled. : > Are there scenarios where this is different from !PCI_ECAM? At least the previous naming suggested t […] Yes, the platforms might use any of the following mechanisms to access PCI config space: 1. No MMIO ops for accessing PCI config space --> Fall back to IO ops (only applicable to x86) 2. MMIO ops and PCI_ECAM --> Use MMIO ops and config space is mapped in address space as defined by ECAM in PCIe spec. 3. MMIO ops but !PCI_ECAM --> Use MMIO ops and config space is mapped in address space as defined by some platform specific mechanism. Before this change, we only supported #1 and #2 in coreboot. So, NO_MMCONF_SUPPORT indicated #1. Now, we want to support #1, #2 and #3. PCI_NO_MMIO_OPS refers to case #1. File src/drivers/intel/fsp1_1/romstage.c: https://review.coreboot.org/c/coreboot/+/57333/comment/321b37bd_573e5221 PS8, Line 107: if (!CONFIG(PCI_NO_MMIO_OPS)) > In the Kconfig we defined: […] +1 to use of PCI_ECAM here. -- To view, visit https://review.coreboot.org/c/coreboot/+/57333 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e196a1ed52d131a71f00cba1d93a23e54aca3e2 Gerrit-Change-Number: 57333 Gerrit-PatchSet: 8 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Lance Zhao Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Damien Zammit Gerrit-Attention: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Huang Jin <huang.jin(a)intel.com> Gerrit-Comment-Date: Wed, 06 Oct 2021 07:07:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp_m: Enable touchpad
by Paul Menzel (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Bora Guvendik, Anil Kumar K, Tim Wawrzynczak, Selma Bensaid, Raju Rajakumar, Bernardo Perez Priego. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57863 ) Change subject: mb/intel/adlrvp_m: Enable touchpad ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/57863/comment/b4a20f37_fb6b075b PS5, Line 9: will include Present tense: includes -- To view, visit https://review.coreboot.org/c/coreboot/+/57863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I78e5e133f7d3af47395819a79638a90fee4fd19e Gerrit-Change-Number: 57863 Gerrit-PatchSet: 5 Gerrit-Owner: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Raju Rajakumar <raju.rajakumar(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Raju Rajakumar <raju.rajakumar(a)intel.com> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Comment-Date: Wed, 06 Oct 2021 07:06:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: cbgfx: Clear screen by sequential access
by Yu-Ping Wu (Code Review) 06 Oct '21

06 Oct '21

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57104 ) Change subject: libpayload: cbgfx: Clear screen by sequential access ...................................................................... Patch Set 5: (1 comment) File payloads/libpayload/drivers/video/graphics.c: https://review.coreboot.org/c/coreboot/+/57104/comment/326fe993_73dad340 PS4, Line 637: memset(FB, color & 0xff, fbinfo->y_resolution * bpl); > The problem is probably memcpy()ing out of the framebuffer, since it's likely mapped with a memory t […] Yeah you are right. I think using alloca() is discouraged because of the undefined behavior when stack overflow. Anyway, let's discuss this on CB:58128. -- To view, visit https://review.coreboot.org/c/coreboot/+/57104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iecaff5b6abc24ba4b3859cbc44c0d61b2a90b2d9 Gerrit-Change-Number: 57104 Gerrit-PatchSet: 5 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 06 Oct 2021 06:40:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: cbgfx: Clear screen by memcpy
by Yu-Ping Wu (Code Review) 06 Oct '21

06 Oct '21

Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58128 ) Change subject: libpayload: cbgfx: Clear screen by memcpy ...................................................................... libpayload: cbgfx: Clear screen by memcpy Instead of setting each pixel in the framebuffer, use memcpy() to clear screen faster. As this method should be fast enough, remove the fast path using memset(). The speed of clear_screen() on brya (x_resolution = 1920, bytes_per_line = 7680): - Using memset(): 15ms - Setting each pixel: 25ms - Using memcpy(): 14ms Also remove set_pixel_raw() since it's now used in only one place. BUG=none TEST=emerge-brya libpayload TEST=Saw developer screen on brya BRANCH=none Change-Id: I5f08fb50faab48d3db6b61ae022af3226914f72b Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M payloads/libpayload/drivers/video/graphics.c 1 file changed, 18 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/58128/1 diff --git a/payloads/libpayload/drivers/video/graphics.c b/payloads/libpayload/drivers/video/graphics.c index 53de302..7f08d40 100644 --- a/payloads/libpayload/drivers/video/graphics.c +++ b/payloads/libpayload/drivers/video/graphics.c @@ -274,19 +274,12 @@ * Plot a pixel in a framebuffer. This is called from tight loops. Keep it slim * and do the validation at callers' site. */ -static inline void set_pixel_raw(struct vector *rcoord, uint32_t color) +static inline void set_pixel(struct vector *coord, uint32_t color) { const int bpp = fbinfo->bits_per_pixel; const int bpl = fbinfo->bytes_per_line; - int i; - uint8_t * const pixel = FB + rcoord->y * bpl + rcoord->x * bpp / 8; - for (i = 0; i < bpp / 8; i++) - pixel[i] = (color >> (i * 8)); -} - -static inline void set_pixel(struct vector *coord, uint32_t color) -{ struct vector rcoord; + int i; switch (fbinfo->orientation) { case CB_FB_ORIENTATION_NORMAL: @@ -308,7 +301,9 @@ break; } - set_pixel_raw(&rcoord, color); + uint8_t * const pixel = FB + rcoord.y * bpl + rcoord.x * bpp / 8; + for (i = 0; i < bpp / 8; i++) + pixel[i] = (color >> (i * 8)); } /* @@ -625,22 +620,25 @@ if (cbgfx_init()) return CBGFX_ERROR_INIT; - struct vector p; + int x, y, i; uint32_t color = calculate_color(rgb, 0); const int bpp = fbinfo->bits_per_pixel; const int bpl = fbinfo->bytes_per_line; + uint8_t *line = malloc(bpl); - /* If all significant bytes in color are equal, fastpath through memset. - * We assume that for 32bpp the high byte gets ignored anyway. */ - if ((((color >> 8) & 0xff) == (color & 0xff)) && (bpp == 16 || - (((color >> 16) & 0xff) == (color & 0xff)))) { - memset(FB, color & 0xff, fbinfo->y_resolution * bpl); - } else { - for (p.y = 0; p.y < fbinfo->y_resolution; p.y++) - for (p.x = 0; p.x < fbinfo->x_resolution; p.x++) - set_pixel_raw(&p, color); + if (!line) { + LOG("Failed to allocate line buffer (%u bytes)\n", bpl); + return CBGFX_ERROR_UNKNOWN; } + /* Set line buffer pixels, then memcpy to framebuffer */ + for (x = 0; x < fbinfo->x_resolution; x++) + for (i = 0; i < bpp / 8; i++) + line[x * bpp / 8 + i] = (color >> (i * 8)); + for (y = 0; y < fbinfo->y_resolution; y++) + memcpy(FB + y * bpl, line, bpl); + + free(line); return CBGFX_SUCCESS; } -- To view, visit https://review.coreboot.org/c/coreboot/+/58128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f08fb50faab48d3db6b61ae022af3226914f72b Gerrit-Change-Number: 58128 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: libpayload: Add mock architecture
by Yu-Ping Wu (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Jakub Czapiga, Paul Menzel, Julius Werner, Jan Dabros. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57708 ) Change subject: libpayload: Add mock architecture ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/57708 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie3a6e6f6cad2f8a2e48a8e546d3b79c577653080 Gerrit-Change-Number: 57708 Gerrit-PatchSet: 9 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-Comment-Date: Wed, 06 Oct 2021 05:18:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-M RVP
by Bora Guvendik (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Selma Bensaid, Tim Wawrzynczak. Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57323 ) Change subject: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-M RVP ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/57323/comment/9a4751ce_e6cc22ac PS2, Line 7: adlrvp_m: Enable eNEM > nit? […] Done https://review.coreboot.org/c/coreboot/+/57323/comment/3a990359_f0d508a8 PS2, Line 11: TEST=Boot to OS > nit? […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/57323 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69959f4c53f4073e6e8b51491747d8358b4c907b Gerrit-Change-Number: 57323 Gerrit-PatchSet: 3 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 06 Oct 2021 03:56:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-M RVP
by Bora Guvendik (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Bora Guvendik, Selma Bensaid, Tim Wawrzynczak. Hello build bot (Jenkins), Selma Bensaid, Tim Wawrzynczak, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57323 to look at the new patch set (#3). Change subject: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-M RVP ...................................................................... mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-M RVP This patch enables eNEM flow for ADL-M TEST=Able to build and boot ADL-M RVP using eNEM mode. Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> Change-Id: I69959f4c53f4073e6e8b51491747d8358b4c907b --- M src/mainboard/intel/adlrvp/Kconfig.name 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/57323/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/57323 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69959f4c53f4073e6e8b51491747d8358b4c907b Gerrit-Change-Number: 57323 Gerrit-PatchSet: 3 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: payloads: Add UefiPayload support to ARM64 platforms
by Hung-Te Lin (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Martin Roth, Rex-BC Chen, Paul Menzel, Julius Werner, Marty E. Plummer. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58054 ) Change subject: payloads: Add UefiPayload support to ARM64 platforms ...................................................................... Patch Set 7: (1 comment) Patchset: PS6: > I have encounter this error: […] When buliding without cros env, you have to build the toolchain first like what the error msg said: "make crosgcc". -- To view, visit https://review.coreboot.org/c/coreboot/+/58054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10777a341d46240b91ceeeb1be26c33a0c5db839 Gerrit-Change-Number: 58054 Gerrit-PatchSet: 7 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Comment-Date: Wed, 06 Oct 2021 03:47:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads: Add UefiPayload support to ARM64 platforms
by Rex-BC Chen (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Hung-Te Lin, Martin Roth, Paul Menzel, Julius Werner, Marty E. Plummer. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58054 ) Change subject: payloads: Add UefiPayload support to ARM64 platforms ...................................................................... Patch Set 7: (1 comment) Patchset: PS6: > > modify sys-boot/edk2/edk2-9999.ebuild for this. […] I have encounter this error: cros/src/third_party/coreboot$ make -j toolchain.inc:166: The coreboot toolchain for 'arm64' architecture was not found. toolchain.inc:176: The coreboot toolchain version of iasl '20210331' was not found toolchain.inc:202: toolchain.inc:203: To build the entire coreboot toolchain: run 'make crossgcc' toolchain.inc:205: To build just IASL: run 'make iasl' toolchain.inc:207: For more toolchain build targets: run 'make help_toolchain' toolchain.inc:208: toolchain.inc:210: To try to use any toolchain in your path, run 'make menuconfig', then select toolchain.inc:212: the config option: 'General setup', and 'Allow building with any toolchain' toolchain.inc:214: Note that this is NOT supported. Using it means you're on your own. toolchain.inc:216: toolchain.inc:218: *** Halting the build. Stop. -- To view, visit https://review.coreboot.org/c/coreboot/+/58054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10777a341d46240b91ceeeb1be26c33a0c5db839 Gerrit-Change-Number: 58054 Gerrit-PatchSet: 7 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Comment-Date: Wed, 06 Oct 2021 03:44:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads: Add UefiPayload support to ARM64 platforms
by Hung-Te Lin (Code Review) 06 Oct '21

06 Oct '21

Attention is currently required from: Martin Roth, Rex-BC Chen, Paul Menzel, Julius Werner, Marty E. Plummer. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58054 ) Change subject: payloads: Add UefiPayload support to ARM64 platforms ...................................................................... Patch Set 7: (1 comment) Patchset: PS6: > modify sys-boot/edk2/edk2-9999.ebuild for this. That's chromeos build environment, not pure coreboot env. > This is my typo. We only use toolchain of coreboot-sdk and do not use any tool from chromeos. It's not about coreboot-sdk or not. Given you are changing the payloads, non-chromeos coreboot developers should be able to build the tianocore without chromeos repos. Please verify again with my steps, inside a pure coreboot checkout: 1. make menuconfig 2. select Mainboard -> Vendor=Google, model=Cherry 3. select Payload -> Add a payload -> Tianocore 4. make -j 5. build/cbfstool build/coreboot.rom extract --name fallback/payload --file out.elf -m arm64 6. file out.elf # ELF 64-bit LSB executable, ARM aarch64 7. strings out.elf | grep tianocore # lots of tianocore stuff You may update this to the description if that also works for you. -- To view, visit https://review.coreboot.org/c/coreboot/+/58054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10777a341d46240b91ceeeb1be26c33a0c5db839 Gerrit-Change-Number: 58054 Gerrit-PatchSet: 7 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Comment-Date: Wed, 06 Oct 2021 03:36:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2021