Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57104 )
Change subject: libpayload: cbgfx: Clear screen by sequential access
......................................................................
Patch Set 5:
(1 comment)
File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/57104/comment/326fe993_73dad340
PS4, Line 637: memset(FB, color & 0xff, fbinfo->y_resolution * bpl);
> The problem is probably memcpy()ing out of the framebuffer, since it's likely mapped with a memory t […]
Yeah you are right. I think using alloca() is discouraged because of the undefined behavior when stack overflow. Anyway, let's discuss this on CB:58128.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57104
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecaff5b6abc24ba4b3859cbc44c0d61b2a90b2d9
Gerrit-Change-Number: 57104
Gerrit-PatchSet: 5
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 06 Oct 2021 06:40:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Paul Menzel, Julius Werner, Jan Dabros.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57708 )
Change subject: libpayload: Add mock architecture
......................................................................
Patch Set 9: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/57708
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3a6e6f6cad2f8a2e48a8e546d3b79c577653080
Gerrit-Change-Number: 57708
Gerrit-PatchSet: 9
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Comment-Date: Wed, 06 Oct 2021 05:18:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Bora Guvendik, Selma Bensaid, Tim Wawrzynczak.
Hello build bot (Jenkins), Selma Bensaid, Tim Wawrzynczak, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57323
to look at the new patch set (#3).
Change subject: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-M RVP
......................................................................
mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-M RVP
This patch enables eNEM flow for ADL-M
TEST=Able to build and boot ADL-M RVP using eNEM mode.
Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com>
Change-Id: I69959f4c53f4073e6e8b51491747d8358b4c907b
---
M src/mainboard/intel/adlrvp/Kconfig.name
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/57323/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/57323
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69959f4c53f4073e6e8b51491747d8358b4c907b
Gerrit-Change-Number: 57323
Gerrit-PatchSet: 3
Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Rex-BC Chen, Paul Menzel, Julius Werner, Marty E. Plummer.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58054 )
Change subject: payloads: Add UefiPayload support to ARM64 platforms
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS6:
> I have encounter this error: […]
When buliding without cros env, you have to build the toolchain first like what the error msg said: "make crosgcc".
--
To view, visit https://review.coreboot.org/c/coreboot/+/58054
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10777a341d46240b91ceeeb1be26c33a0c5db839
Gerrit-Change-Number: 58054
Gerrit-PatchSet: 7
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marty E. Plummer <hanetzer(a)startmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Marty E. Plummer <hanetzer(a)startmail.com>
Gerrit-Comment-Date: Wed, 06 Oct 2021 03:47:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Martin Roth, Paul Menzel, Julius Werner, Marty E. Plummer.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58054 )
Change subject: payloads: Add UefiPayload support to ARM64 platforms
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS6:
> > modify sys-boot/edk2/edk2-9999.ebuild for this. […]
I have encounter this error:
cros/src/third_party/coreboot$ make -j
toolchain.inc:166: The coreboot toolchain for 'arm64' architecture was not found.
toolchain.inc:176: The coreboot toolchain version of iasl '20210331' was not found
toolchain.inc:202:
toolchain.inc:203: To build the entire coreboot toolchain: run 'make crossgcc'
toolchain.inc:205: To build just IASL: run 'make iasl'
toolchain.inc:207: For more toolchain build targets: run 'make help_toolchain'
toolchain.inc:208:
toolchain.inc:210: To try to use any toolchain in your path, run 'make menuconfig', then select
toolchain.inc:212: the config option: 'General setup', and 'Allow building with any toolchain'
toolchain.inc:214: Note that this is NOT supported. Using it means you're on your own.
toolchain.inc:216:
toolchain.inc:218: *** Halting the build. Stop.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58054
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10777a341d46240b91ceeeb1be26c33a0c5db839
Gerrit-Change-Number: 58054
Gerrit-PatchSet: 7
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marty E. Plummer <hanetzer(a)startmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Marty E. Plummer <hanetzer(a)startmail.com>
Gerrit-Comment-Date: Wed, 06 Oct 2021 03:44:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Rex-BC Chen, Paul Menzel, Julius Werner, Marty E. Plummer.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58054 )
Change subject: payloads: Add UefiPayload support to ARM64 platforms
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS6:
> modify sys-boot/edk2/edk2-9999.ebuild for this.
That's chromeos build environment, not pure coreboot env.
> This is my typo. We only use toolchain of coreboot-sdk and do not use any tool from chromeos.
It's not about coreboot-sdk or not. Given you are changing the payloads, non-chromeos coreboot developers should be able to build the tianocore without chromeos repos.
Please verify again with my steps, inside a pure coreboot checkout:
1. make menuconfig
2. select Mainboard -> Vendor=Google, model=Cherry
3. select Payload -> Add a payload -> Tianocore
4. make -j
5. build/cbfstool build/coreboot.rom extract --name fallback/payload --file out.elf -m arm64
6. file out.elf # ELF 64-bit LSB executable, ARM aarch64
7. strings out.elf | grep tianocore # lots of tianocore stuff
You may update this to the description if that also works for you.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58054
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10777a341d46240b91ceeeb1be26c33a0c5db839
Gerrit-Change-Number: 58054
Gerrit-PatchSet: 7
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marty E. Plummer <hanetzer(a)startmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Marty E. Plummer <hanetzer(a)startmail.com>
Gerrit-Comment-Date: Wed, 06 Oct 2021 03:36:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Bora Guvendik, Selma Bensaid, Tim Wawrzynczak.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57323 )
Change subject: adlrvp_m: Enable eNEM
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57323/comment/0b665d15_81bc4b87
PS2, Line 7: adlrvp_m: Enable eNEM
nit?
mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-M RVP
https://review.coreboot.org/c/coreboot/+/57323/comment/ea1f9d61_8792f5dc
PS2, Line 11: TEST=Boot to OS
nit?
TEST=Able to build and boot ADL-M RVP using eNEM mode.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57323
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69959f4c53f4073e6e8b51491747d8358b4c907b
Gerrit-Change-Number: 57323
Gerrit-PatchSet: 2
Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Wed, 06 Oct 2021 03:28:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Martin Roth, Paul Menzel, Julius Werner, Marty E. Plummer.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58054 )
Change subject: payloads: Add UefiPayload support to ARM64 platforms
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS6:
> Please list "related files" with details. […]
modify sys-boot/edk2/edk2-9999.ebuild for this.
Version of edk2 on CrOS is out-of-date and there is no ARM64 UefuPayload for default edk2.
cherry build environment => This is my typo. We only use toolchain of coreboot-sdk and do not use any tool from chromeos.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58054
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10777a341d46240b91ceeeb1be26c33a0c5db839
Gerrit-Change-Number: 58054
Gerrit-PatchSet: 7
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marty E. Plummer <hanetzer(a)startmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Marty E. Plummer <hanetzer(a)startmail.com>
Gerrit-Comment-Date: Wed, 06 Oct 2021 03:20:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: comment