coreboot-gerrit October 2021

coreboot-gerrit@coreboot.org

1 participants
5514 discussions

Change in coreboot[master]: mb/google/guybrush: Build chromeos.c in verstage
by Hsuan-ting Chen (Code Review) 08 Oct '21

08 Oct '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58193 to look at the new patch set (#2). Change subject: mb/google/guybrush: Build chromeos.c in verstage ...................................................................... mb/google/guybrush: Build chromeos.c in verstage Before attempting another commit 6260bf71, ensure that guybrush build chromeos.c in verstage to call get_ec_is_trusted() in vboot verstage_main(). Signed-off-by: Hsuan Ting Chen <roccochen(a)chromium.org> Change-Id: Ic22519fdde1b18f6ce0237022dee02ca37181a74 --- M src/mainboard/google/guybrush/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/58193/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic22519fdde1b18f6ce0237022dee02ca37181a74 Gerrit-Change-Number: 58193 Gerrit-PatchSet: 2 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/guybrush: Build chromeos.c in verstage
by Hsuan-ting Chen (Code Review) 08 Oct '21

08 Oct '21

Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58193 ) Change subject: mb/google/guybrush: Build chromeos.c in verstage ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/58193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic22519fdde1b18f6ce0237022dee02ca37181a74 Gerrit-Change-Number: 58193 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Comment-Date: Fri, 08 Oct 2021 08:53:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tests: Add lib/lzma-test test case
by Jakub Czapiga (Code Review) 08 Oct '21

08 Oct '21

Attention is currently required from: Julius Werner, Jan Dabros. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57555 ) Change subject: tests: Add lib/lzma-test test case ...................................................................... Patch Set 8: (8 comments) File tests/lib/Makefile.inc: https://review.coreboot.org/c/coreboot/+/57555/comment/a95aff3e_9a43460f PS7, Line 240: lzma-test-cflags += -I "$(src)/lib" > Why not just write `#include <lib/lzmadecode. […] Done https://review.coreboot.org/c/coreboot/+/57555/comment/fceae1d6_e22d855e PS7, Line 241: lzma-test-cflags += -DLZMA_TEST_DATA_PATH=\"$(testsrc)/data/lib/lzma-test/\" > Maybe just define a `-DTEST_DATA_DIR=\"$(testsrc)/data\" in the base tests/Makefile. […] Done File tests/lib/lzma-test.c: https://review.coreboot.org/c/coreboot/+/57555/comment/c023a46e_ffbc0468 PS7, Line 52: goto finish; > Weird way to write `return 1`? Done https://review.coreboot.org/c/coreboot/+/57555/comment/84f09922_3f2778ac PS7, Line 57: s->raw_filename = test_malloc(raw_filename_size); > nit: you can just use asprintf() to make all of this a lot easier. Oh, I didn't know this function existed. But, unfortunately, coreboot does not have prototype of this function in its headers (and these headers are overriding system ones), so I am not able to use it. I do not want to copy prototype of every libc function missing form coreboot headers. https://review.coreboot.org/c/coreboot/+/57555/comment/2006541d_799bcbe5 PS7, Line 65: goto error; > Nope. teardown() expects *state to point to s, but at this point it still points to fname_base. If setup function exits with non-zero exit code, the teardown function is not called by CMocka. I am calling it in the error section and passing correct pointer `(void **)&s)` before returning from setup function. > In general, I don't think you need to worry about allocation cleanup in error cases that much, the program is gonna exit soon after anyway... I think it's fine to just return here. Just don't make it segfault. One test setup failing does not make other tests fail/skip instantly. In this test we can skip error handling and just return. But in some cases we still should handle them. If we are using test_malloc(), CMocka will report non-freed memory blocks if we return without calling test_free(). https://review.coreboot.org/c/coreboot/+/57555/comment/95e29e29_0b2f6178 PS7, Line 88: goto finish; > nit: just write `return 0`? Done https://review.coreboot.org/c/coreboot/+/57555/comment/7324b887_aec43c0f PS7, Line 154: ( > Do these parens do anything? (Also, in general please prefer struct initializers with designated mem […] I was following convention of CMocma macro cmocka_unit_test_prestate_setup_teardown(). But yes, it looks better, when written with member names. https://review.coreboot.org/c/coreboot/+/57555/comment/0d4507de_a5c2ea64 PS7, Line 161: ULZMAN_CORRECT_FILE_TEST("data.1"), > It would be good if somewhere (e.g. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/57555 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id75e0b41991382d4c391b031862106de58eacdf7 Gerrit-Change-Number: 57555 Gerrit-PatchSet: 8 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-Comment-Date: Fri, 08 Oct 2021 08:52:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/ocp/deltalake: Fix SMBIOS type 9 bugs
by Angel Pons (Code Review) 08 Oct '21

08 Oct '21

Attention is currently required from: Johnny Lin, Christian Walter, Jingle Hsu, Arthur Heymans, Morgan Jang, Tim Chu, Shelly_Chang(a)wiwynn.com. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58100 ) Change subject: mb/ocp/deltalake: Fix SMBIOS type 9 bugs ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58100 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea437cdf3da5410b6b7a749a1be970f0948d92d9 Gerrit-Change-Number: 58100 Gerrit-PatchSet: 8 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shelly_Chang(a)wiwynn.com Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Shelly_Chang(a)wiwynn.com Gerrit-Comment-Date: Fri, 08 Oct 2021 08:41:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [DO-NOT-SUBMIT] 3rdparty uprev
by Hsuan-ting Chen (Code Review) 08 Oct '21

08 Oct '21

Attention is currently required from: Hsuan Ting Chen. Hello Hsuan Ting Chen, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/58194 to review the following change. Change subject: [DO-NOT-SUBMIT] 3rdparty uprev ...................................................................... [DO-NOT-SUBMIT] 3rdparty uprev Signed-off-by: Hsuan Ting Chen <roccochen(a)chromium.org> Change-Id: I22b2b2e59acf270b6b4f4442282ea13664169259 --- M 3rdparty/chromeec M 3rdparty/vboot 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/58194/1 diff --git a/3rdparty/chromeec b/3rdparty/chromeec index 4c21b57..f48b299 160000 --- a/3rdparty/chromeec +++ b/3rdparty/chromeec @@ -1 +1 @@ -Subproject commit 4c21b57eb9619cc3dc86d11226917d25f62f1bc8 +Subproject commit f48b29920036c69793eb1fdca0af7f8d945a20ab diff --git a/3rdparty/vboot b/3rdparty/vboot index 13f601f..2cf7657 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit 13f601fbd4c1b128f333391e4552082594f0ff25 +Subproject commit 2cf76574dbf57c70da3a835f2a45d5619dc058f5 -- To view, visit https://review.coreboot.org/c/coreboot/+/58194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22b2b2e59acf270b6b4f4442282ea13664169259 Gerrit-Change-Number: 58194 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/guybrush: Build chromeos.c in verstage
by Hsuan-ting Chen (Code Review) 08 Oct '21

08 Oct '21

Hsuan-ting Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58193 ) Change subject: mb/google/guybrush: Build chromeos.c in verstage ...................................................................... mb/google/guybrush: Build chromeos.c in verstage Before attempting another commit 6260bf71, ensure that guybrush build chromeos.c in verstage to call get_ec_is_trusted() in vboot verstage_main(). Change-Id: Ic22519fdde1b18f6ce0237022dee02ca37181a74 --- M src/mainboard/google/guybrush/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/58193/1 diff --git a/src/mainboard/google/guybrush/Makefile.inc b/src/mainboard/google/guybrush/Makefile.inc index 85649b6..f3140dd 100644 --- a/src/mainboard/google/guybrush/Makefile.inc +++ b/src/mainboard/google/guybrush/Makefile.inc @@ -18,6 +18,7 @@ ramstage-$(CONFIG_CHROMEOS) += chromeos.c verstage-y += verstage.c +verstage-$(CONFIG_CHROMEOS) += chromeos.c subdirs-y += variants/baseboard subdirs-y += variants/$(VARIANT_DIR) -- To view, visit https://review.coreboot.org/c/coreboot/+/58193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic22519fdde1b18f6ce0237022dee02ca37181a74 Gerrit-Change-Number: 58193 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: tests: Fix JUNIT_OUTPUT=y to write to files instead of stderr
by Jakub Czapiga (Code Review) 08 Oct '21

08 Oct '21

Attention is currently required from: Julius Werner, Jan Dabros, Yu-Ping Wu. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58163 ) Change subject: tests: Fix JUNIT_OUTPUT=y to write to files instead of stderr ...................................................................... Patch Set 2: (1 comment) File tests/Makefile.inc: https://review.coreboot.org/c/coreboot/+/58163/comment/2d0ed4c8_e25a4aff PS2, Line 232: rm -f $(testobj)/junit-$(subst /,_,$(patsubst $(testobj)/%/,%,$(dir $^)))$*$.xml > so many nested parens .... CMocka does not help with making build system simple. If it was able to write all test groups to JUnit.xml, there would be no problem (I hope). -- To view, visit https://review.coreboot.org/c/coreboot/+/58163 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09891aca923bf1271cafeaa09f89b6539022709c Gerrit-Change-Number: 58163 Gerrit-PatchSet: 2 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 08 Oct 2021 08:29:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com> Comment-In-Reply-To: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tests: Add lib/lzma-test test case
by Jakub Czapiga (Code Review) 08 Oct '21

08 Oct '21

Attention is currently required from: Jakub Czapiga, Jan Dabros. Hello build bot (Jenkins), Paul Fagerburg, Julius Werner, Jan Dabros, Werner Zeh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57555 to look at the new patch set (#8). Change subject: tests: Add lib/lzma-test test case ...................................................................... tests: Add lib/lzma-test test case Files used by this test are in: tests/data/lib/lzma-test/ file.bin - files with uncompressed data file.lzma.bin - files with LZMA-compressed data from file.bin How to prepare compressed file: util/cbfs-compression-tool compress file.bin /tmp/file.lzma.bin lzma dd if=/tmp/file.lzma.bin of=file.lzma.bin skip=8 ibs=1 Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> Change-Id: Id75e0b41991382d4c391b031862106de58eacdf7 --- M tests/Makefile.inc A tests/data/lib/lzma-test/data.1.bin A tests/data/lib/lzma-test/data.1.lzma.bin A tests/data/lib/lzma-test/data.2.bin A tests/data/lib/lzma-test/data.2.lzma.bin A tests/data/lib/lzma-test/data.3.bin A tests/data/lib/lzma-test/data.3.lzma.bin A tests/data/lib/lzma-test/data.4.bin A tests/data/lib/lzma-test/data.4.lzma.bin M tests/lib/Makefile.inc A tests/lib/lzma-test.c 11 files changed, 1,054 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/57555/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/57555 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id75e0b41991382d4c391b031862106de58eacdf7 Gerrit-Change-Number: 57555 Gerrit-PatchSet: 8 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/siemens/mc_ehl2: Adjust Legacy IRQ routing for PCI devices
by Mario Scheithauer (Code Review) 08 Oct '21

08 Oct '21

Attention is currently required from: Paul Menzel, Werner Zeh. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58172 ) Change subject: mb/siemens/mc_ehl2: Adjust Legacy IRQ routing for PCI devices ...................................................................... Patch Set 2: (1 comment) File src/mainboard/siemens/mc_ehl/variants/mc_ehl2/mainboard.c: https://review.coreboot.org/c/coreboot/+/58172/comment/5488e65e_c33c9992 PS1, Line 14: SOC2 > What is SOC2? SOC2 is a Siemens ASIC -- To view, visit https://review.coreboot.org/c/coreboot/+/58172 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6bb8d00458c4d1e3fefd01ac3848078355868d9 Gerrit-Change-Number: 58172 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Fri, 08 Oct 2021 08:25:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/siemens/mc_ehl2: Adjust Legacy IRQ routing for PCI devices
by Mario Scheithauer (Code Review) 08 Oct '21

08 Oct '21

Attention is currently required from: Werner Zeh. Hello build bot (Jenkins), Werner Zeh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58172 to look at the new patch set (#2). Change subject: mb/siemens/mc_ehl2: Adjust Legacy IRQ routing for PCI devices ...................................................................... mb/siemens/mc_ehl2: Adjust Legacy IRQ routing for PCI devices On this mainboard there is a legacy PCI device, which is connected to the PCIe root port via a PCIe-2-PCI bridge. This device only supports legacy interrupt routing. For this reason, we have to adjust the PIR8 register (0x3150) which is responsible for PCIe device 25h. The bridge is connected to PCIe root port 7. The following routing is required: INTA#->PIRQC#, INTB#->PIRQD#, INTC#->PIRQA#, INTD#-> PIRQB# TEST: - Boot into system software Change-Id: Id6bb8d00458c4d1e3fefd01ac3848078355868d9 Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/mainboard/siemens/mc_ehl/variants/mc_ehl2/Makefile.inc A src/mainboard/siemens/mc_ehl/variants/mc_ehl2/mainboard.c 2 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/58172/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58172 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6bb8d00458c4d1e3fefd01ac3848078355868d9 Gerrit-Change-Number: 58172 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2021