coreboot-gerrit October 2021

coreboot-gerrit@coreboot.org

1 participants
5514 discussions

Change in coreboot[master]: soc/intel/alderlake: Enable support for CSE stitching
by Furquan Shaikh (Code Review) 09 Oct '21

09 Oct '21

Attention is currently required from: Cliff Huang, Tim Wawrzynczak, Sridhar Siricilla, Bernardo Perez Priego, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58125 ) Change subject: soc/intel/alderlake: Enable support for CSE stitching ...................................................................... Patch Set 13: (1 comment) File src/soc/intel/alderlake/Makefile.inc: https://review.coreboot.org/c/coreboot/+/58125/comment/d8b2874d_cce8a256 PS13, Line 63: This currently mimics whatever FIT tool does for adding partitions. We will have to experiment which ones are really required and which ones can be dropped. Additionally, we will have to tie adding of firmware like TBTP to enabling of USB4. -- To view, visit https://review.coreboot.org/c/coreboot/+/58125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b14405aab2a4919431d9c16bc7ff2eb1abf1f6b Gerrit-Change-Number: 58125 Gerrit-PatchSet: 13 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 08 Oct 2021 21:05:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/cse: Reorganize firmware update checks for CSE Lite
by Furquan Shaikh (Code Review) 09 Oct '21

09 Oct '21

Attention is currently required from: Tim Wawrzynczak, Sridhar Siricilla, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58157 ) Change subject: soc/intel/common/cse: Reorganize firmware update checks for CSE Lite ...................................................................... Patch Set 5: (1 comment) File src/soc/intel/common/block/cse/cse_lite.c: https://review.coreboot.org/c/coreboot/+/58157/comment/c45ec1cf_301528d3 PS5, Line 651: (status == CSE_UPDATE_CORRUPTED > Why is that? How would we know if this is an upgrade or downgrade instance if the CSE partition is c […] I added the check for corrupted case here because it seems safe to clear off data in case we encounter this condition. Do you envision any problems with that? -- To view, visit https://review.coreboot.org/c/coreboot/+/58157 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iabecab8e373e65a11ba7fe1bfc125467571a0588 Gerrit-Change-Number: 58157 Gerrit-PatchSet: 5 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 08 Oct 2021 20:59:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cse_fpt: Add a new tool for managing Intel CSE FPT binaries
by Furquan Shaikh (Code Review) 09 Oct '21

09 Oct '21

Attention is currently required from: Cliff Huang, Furquan Shaikh, Martin Roth, Rizwan Qureshi, Sridhar Siricilla, Bernardo Perez Priego, Andrew McRae. Hello build bot (Jenkins), Cliff Huang, Martin Roth, Patrick Georgi, Tim Wawrzynczak, Rizwan Qureshi, Sridhar Siricilla, Bernardo Perez Priego, Andrew McRae, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55259 to look at the new patch set (#20). Change subject: util/cse_fpt: Add a new tool for managing Intel CSE FPT binaries ...................................................................... util/cse_fpt: Add a new tool for managing Intel CSE FPT binaries This change adds a new tool `cse_fpt` which can be used to print and dump CSE partitions in Flash Partition Table (FPT) format. BUG=b:189167923 Change-Id: I93c8d33e9baa327cbdab918a14f2f7a039953be6 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M Makefile.inc M util/cbfstool/Makefile M util/cbfstool/Makefile.inc A util/cbfstool/cse_fpt.c A util/cbfstool/cse_fpt.h A util/cbfstool/fpt_formats/Makefile.inc A util/cbfstool/fpt_formats/fpt_hdr_20.c A util/cbfstool/fpt_formats/fpt_hdr_21.c 8 files changed, 721 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/55259/20 -- To view, visit https://review.coreboot.org/c/coreboot/+/55259 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I93c8d33e9baa327cbdab918a14f2f7a039953be6 Gerrit-Change-Number: 55259 Gerrit-PatchSet: 20 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Andrew McRae <amcrae(a)google.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Attention: Andrew McRae <amcrae(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common/cse: Split CSE metadata into two CBFS files
by Furquan Shaikh (Code Review) 09 Oct '21

09 Oct '21

Attention is currently required from: Tim Wawrzynczak, Sridhar Siricilla, Bernardo Perez Priego, Patrick Rudolph. Hello build bot (Jenkins), Tim Wawrzynczak, Sridhar Siricilla, Bernardo Perez Priego, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58158 to look at the new patch set (#10). Change subject: soc/intel/common/cse: Split CSE metadata into two CBFS files ...................................................................... soc/intel/common/cse: Split CSE metadata into two CBFS files This change splits CSE metadata structure (added to CBFS) into two separate CBFS files (me_rw.hash and me_rw.version). Since `struct cse_rw_metadata` is now used, it is dropped completely. This change is being made in order to prepare for the upcoming changes to stitch CSE binary at build time. Since the binary might not be available pre-built, it complicates the order of operations for the addition of CSE metadata structure and declaring hash and version as CPPFLAGS_common. Instead rules can be enabled for individual CBFS file targets for hash and version that ensure proper ordering as well. BUG=b:184892226 TEST=Ensured that update works correctly on brya by forcing version mismatch. In case of version match, no update is triggered. Signed-off-by: Furquan Shaikh <furquan(a)google.com> Change-Id: I7c9bb165e6a64415affcd0b3331628092195fa0d --- M src/soc/intel/common/block/cse/Kconfig M src/soc/intel/common/block/cse/Makefile.inc M src/soc/intel/common/block/cse/cse_lite.c M src/soc/intel/common/block/include/intelblocks/cse.h 4 files changed, 85 insertions(+), 52 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/58158/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/58158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c9bb165e6a64415affcd0b3331628092195fa0d Gerrit-Change-Number: 58158 Gerrit-PatchSet: 10 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common/cse: Split CSE metadata into two CBFS files
by Furquan Shaikh (Code Review) 09 Oct '21

09 Oct '21

Attention is currently required from: Tim Wawrzynczak, Sridhar Siricilla, Bernardo Perez Priego, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58158 ) Change subject: soc/intel/common/cse: Split CSE metadata into two CBFS files ...................................................................... Patch Set 9: (1 comment) File src/soc/intel/common/block/cse/cse_lite.c: https://review.coreboot.org/c/coreboot/+/58158/comment/8aca6bbd_a0b5a999 PS9, Line 598: if (!read_ver_field(version_str, &ptr, size, &cbfs_rw_version.major)) : return CSE_UPDATE_METADATA_ERROR; : if (!read_ver_field(version_str, &ptr, size, &cbfs_rw_version.minor)) : return CSE_UPDATE_METADATA_ERROR; : if (!read_ver_field(version_str, &ptr, size, &cbfs_rw_version.hotfix)) : return CSE_UPDATE_METADATA_ERROR; : if (!read_ver_field(version_str, &ptr, size, &cbfs_rw_version.build)) : return CSE_UPDATE_METADATA_ERROR; > I think version_str still needs to be unmapped here on the errors?, maybe reorganizing it would work […] 😢. Yes, that's required! Fixed in latest patchset. -- To view, visit https://review.coreboot.org/c/coreboot/+/58158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c9bb165e6a64415affcd0b3331628092195fa0d Gerrit-Change-Number: 58158 Gerrit-PatchSet: 9 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 08 Oct 2021 20:57:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sc7280: Add SHRM firmware support
by Shelley Chen (Code Review) 09 Oct '21

09 Oct '21

Attention is currently required from: Ravi kumar. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49392 ) Change subject: sc7280: Add SHRM firmware support ...................................................................... Patch Set 79: (1 comment) File src/soc/qualcomm/sc7280/Makefile.inc: https://review.coreboot.org/c/coreboot/+/49392/comment/80d16cc1_64b2ca41 PS79, Line 110: none > Oh, sorry, yeah... I only pay occasional attention to these so I missed Ravi's response. […] Please see https://review.coreboot.org/c/coreboot/+/58191 -- To view, visit https://review.coreboot.org/c/coreboot/+/49392 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44484573a829eaefbd34907c6fe78d427506a762 Gerrit-Change-Number: 49392 Gerrit-PatchSet: 79 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Comment-Date: Fri, 08 Oct 2021 20:55:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shelley Chen <shchen(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cse_fpt: Add a new tool for managing Intel CSE FPT binaries
by Tim Wawrzynczak (Code Review) 09 Oct '21

09 Oct '21

Attention is currently required from: Cliff Huang, Furquan Shaikh, Martin Roth, Rizwan Qureshi, Sridhar Siricilla, Bernardo Perez Priego, Andrew McRae. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55259 ) Change subject: util/cse_fpt: Add a new tool for managing Intel CSE FPT binaries ...................................................................... Patch Set 19: Code-Review+1 (2 comments) File util/cbfstool/cse_fpt.h: https://review.coreboot.org/c/coreboot/+/55259/comment/eaf1a56c_cef391b9 PS17, Line 14: r tab after `)` File util/cbfstool/cse_fpt.c: https://review.coreboot.org/c/coreboot/+/55259/comment/0333cc96_3cf28053 PS17, Line 2: /* SPDX-License-Identifier: GPL-2.0-only */ nit: should this go on the first line? -- To view, visit https://review.coreboot.org/c/coreboot/+/55259 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I93c8d33e9baa327cbdab918a14f2f7a039953be6 Gerrit-Change-Number: 55259 Gerrit-PatchSet: 19 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Andrew McRae <amcrae(a)google.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Attention: Andrew McRae <amcrae(a)google.com> Gerrit-Comment-Date: Fri, 08 Oct 2021 20:51:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/cse: Split CSE metadata into two CBFS files
by Tim Wawrzynczak (Code Review) 09 Oct '21

09 Oct '21

Attention is currently required from: Furquan Shaikh, Sridhar Siricilla, Bernardo Perez Priego, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58158 ) Change subject: soc/intel/common/cse: Split CSE metadata into two CBFS files ...................................................................... Patch Set 9: (1 comment) File src/soc/intel/common/block/cse/cse_lite.c: https://review.coreboot.org/c/coreboot/+/58158/comment/26e484b1_2f1c18df PS9, Line 598: if (!read_ver_field(version_str, &ptr, size, &cbfs_rw_version.major)) : return CSE_UPDATE_METADATA_ERROR; : if (!read_ver_field(version_str, &ptr, size, &cbfs_rw_version.minor)) : return CSE_UPDATE_METADATA_ERROR; : if (!read_ver_field(version_str, &ptr, size, &cbfs_rw_version.hotfix)) : return CSE_UPDATE_METADATA_ERROR; : if (!read_ver_field(version_str, &ptr, size, &cbfs_rw_version.build)) : return CSE_UPDATE_METADATA_ERROR; I think version_str still needs to be unmapped here on the errors?, maybe reorganizing it would work better ``` if (!read_ver_field(version_str, &ptr, size, &cbfs_rw_version.major) || !read_ver_field(version_str, &ptr, size, &cbfs_rw_version.minor) || !read_ver_field(version_str, &ptr, size, &cbfs_rw_version.hotfix) || !read_ver_field(version_str, &ptr, size, &cbfs_rw_version.build)) { cbfs_unmap(version_str); return CSE_UPDATE_METADATA_ERROR; } ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/58158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c9bb165e6a64415affcd0b3331628092195fa0d Gerrit-Change-Number: 58158 Gerrit-PatchSet: 9 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 08 Oct 2021 20:50:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Makefile: Add src/soc/* to subdirs
by Tim Wawrzynczak (Code Review) 09 Oct '21

09 Oct '21

Attention is currently required from: Cliff Huang, Furquan Shaikh, Martin Roth, Sridhar Siricilla, Bernardo Perez Priego. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58124 ) Change subject: Makefile: Add src/soc/* to subdirs ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91579a87016fdc2b9ca2d798b81969c21c18b4a3 Gerrit-Change-Number: 58124 Gerrit-PatchSet: 10 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Comment-Date: Fri, 08 Oct 2021 20:34:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/cse: Reorganize firmware update checks for CSE Lite
by Furquan Shaikh (Code Review) 09 Oct '21

09 Oct '21

Attention is currently required from: Tim Wawrzynczak, Sridhar Siricilla, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58157 ) Change subject: soc/intel/common/cse: Reorganize firmware update checks for CSE Lite ...................................................................... Patch Set 5: (1 comment) File src/soc/intel/common/block/cse/cse_lite.c: https://review.coreboot.org/c/coreboot/+/58157/comment/a511bfd4_ab08595d PS5, Line 651: (status == CSE_UPDATE_CORRUPTED > coreboot need not send DATA CLEAR command when there is an UPDATE CORRUPTED. […] Why is that? How would we know if this is an upgrade or downgrade instance if the CSE partition is corrupted? -- To view, visit https://review.coreboot.org/c/coreboot/+/58157 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iabecab8e373e65a11ba7fe1bfc125467571a0588 Gerrit-Change-Number: 58157 Gerrit-PatchSet: 5 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 08 Oct 2021 20:33:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2021