coreboot-gerrit October 2021

coreboot-gerrit@coreboot.org

1 participants
5514 discussions

Change in coreboot[master]: arch/x86/smbios: Add generation of type 20 table
by Matt DeVillier (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Angel Pons, Michael Niewöhner. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58271 ) Change subject: arch/x86/smbios: Add generation of type 20 table ...................................................................... Patch Set 4: (2 comments) File src/arch/x86/smbios.c: https://review.coreboot.org/c/coreboot/+/58271/comment/6aed41c9_d8b6eb99 PS4, Line 1073: (end_addr + 1) > nit: braces not needed Ack https://review.coreboot.org/c/coreboot/+/58271/comment/7e899bee_2a3e5dc2 PS4, Line 1073: += > Is the `+=` correct? I'd use `=` instead. there's one type20 table per dimm; start_addr starts at 0 and increments by the size of the dimm for each loop iteration -- To view, visit https://review.coreboot.org/c/coreboot/+/58271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2574d6209d973a8e7f112eb3ef61f5d26986e47b Gerrit-Change-Number: 58271 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Tue, 12 Oct 2021 15:44:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/haswell: Add HDAU ACPI device
by Angel Pons (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Matt DeVillier, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58272 ) Change subject: nb/haswell: Add HDAU ACPI device ...................................................................... Patch Set 2: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/58272/comment/e64bc7c9_b03da7a7 PS1, Line 7: nb/haswell/acpi > Done sorry, missing `intel` https://review.coreboot.org/c/coreboot/+/58272/comment/e8e3407a_714a4f66 PS1, Line 9: The HDAU stub device enables HDMI audio under MacOS > just various posts on reddit, hackintosh forums, and https://github. […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/58272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifa2155512dd909a4e4a753f6475541e9410dfe91 Gerrit-Change-Number: 58272 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 12 Oct 2021 15:43:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86/smbios: Add generation of type 20 table
by Angel Pons (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Matt DeVillier, Tim Wawrzynczak, Paul Menzel, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58271 ) Change subject: arch/x86/smbios: Add generation of type 20 table ...................................................................... Patch Set 4: (2 comments) File src/arch/x86/smbios.c: https://review.coreboot.org/c/coreboot/+/58271/comment/654ec24f_b4e0e2c9 PS4, Line 1073: (end_addr + 1) nit: braces not needed https://review.coreboot.org/c/coreboot/+/58271/comment/6b730fb1_f5646b4c PS4, Line 1073: += Is the `+=` correct? I'd use `=` instead. -- To view, visit https://review.coreboot.org/c/coreboot/+/58271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2574d6209d973a8e7f112eb3ef61f5d26986e47b Gerrit-Change-Number: 58271 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Tue, 12 Oct 2021 15:41:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/haswell: Add HDAU ACPI device
by Matt DeVillier (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Angel Pons, Patrick Rudolph. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58272 ) Change subject: nb/haswell: Add HDAU ACPI device ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/58272/comment/2dbe44d4_765d27cd PS1, Line 7: nb/haswell/acpi > `nb/intel/haswell`, ACPI is already mentioned later. Done https://review.coreboot.org/c/coreboot/+/58272/comment/24d173fe_08c3b667 PS1, Line 9: MacOS > missing a period. Done https://review.coreboot.org/c/coreboot/+/58272/comment/5fc6d7e7_5bcc522b PS1, Line 9: The HDAU stub device enables HDMI audio under MacOS > Do you have any references to this issue? just various posts on reddit, hackintosh forums, and https://github.com/MrChromebox/firmware/issues/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/58272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifa2155512dd909a4e4a753f6475541e9410dfe91 Gerrit-Change-Number: 58272 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 12 Oct 2021 15:39:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/haswell: Add HDAU ACPI device
by Matt DeVillier (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Matt DeVillier, Patrick Rudolph. Hello build bot (Jenkins), Angel Pons, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58272 to look at the new patch set (#2). Change subject: nb/haswell: Add HDAU ACPI device ...................................................................... nb/haswell: Add HDAU ACPI device The HDAU stub device enables HDMI audio under MacOS. Change-Id: Ifa2155512dd909a4e4a753f6475541e9410dfe91 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/northbridge/intel/haswell/acpi/hostbridge.asl 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/58272/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifa2155512dd909a4e4a753f6475541e9410dfe91 Gerrit-Change-Number: 58272 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/wyvern: use SaGv_FixedHigh
by Angel Pons (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Matt DeVillier, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58230 ) Change subject: mb/google/wyvern: use SaGv_FixedHigh ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: > Seems OK to me, agree it seems unnecessary for a desktop system. […] Disabled and FixedHigh seem to do the same thing -- To view, visit https://review.coreboot.org/c/coreboot/+/58230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ad773d1c616b746235ec67b98b83c5910464140 Gerrit-Change-Number: 58230 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Tue, 12 Oct 2021 15:36:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/haswell/acpi: Add HDAU ACPI device
by Angel Pons (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Matt DeVillier, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58272 ) Change subject: nb/haswell/acpi: Add HDAU ACPI device ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/58272/comment/5fc21d10_55cc9e86 PS1, Line 7: nb/haswell/acpi `nb/intel/haswell`, ACPI is already mentioned later. https://review.coreboot.org/c/coreboot/+/58272/comment/ba1facb6_efdba8a0 PS1, Line 9: The HDAU stub device enables HDMI audio under MacOS Do you have any references to this issue? https://review.coreboot.org/c/coreboot/+/58272/comment/428a8233_d43debc8 PS1, Line 9: MacOS missing a period. -- To view, visit https://review.coreboot.org/c/coreboot/+/58272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifa2155512dd909a4e4a753f6475541e9410dfe91 Gerrit-Change-Number: 58272 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 12 Oct 2021 15:35:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Add unit-tests framework and first test case
by Paul Fagerburg (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Nico Huber, Jakub Czapiga, Julius Werner, Yu-Ping Wu. Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58242 ) Change subject: libpayload: Add unit-tests framework and first test case ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/58242/comment/47a77941_f7edfa63 PS3, Line 9: framewok framework -- To view, visit https://review.coreboot.org/c/coreboot/+/58242 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa94ee4dcdc3f74af830113813df0e8fb0b31e4f Gerrit-Change-Number: 58242 Gerrit-PatchSet: 3 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 12 Oct 2021 15:34:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tests: Add lib/lzma-test test case
by Paul Fagerburg (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Jakub Czapiga, Julius Werner, Jan Dabros. Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57555 ) Change subject: tests: Add lib/lzma-test test case ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/57555 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id75e0b41991382d4c391b031862106de58eacdf7 Gerrit-Change-Number: 57555 Gerrit-PatchSet: 9 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-Comment-Date: Tue, 12 Oct 2021 15:32:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Assert WWAN_AUX_RST_L on S0i3 entry
by Karthik Ramasubramanian (Code Review) 13 Oct '21

13 Oct '21

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58275 ) Change subject: mb/google/guybrush: Assert WWAN_AUX_RST_L on S0i3 entry ...................................................................... mb/google/guybrush: Assert WWAN_AUX_RST_L on S0i3 entry Currently WWAN_AUX_RST_L is in S5 domain and does not get asserted on S0i3 entry. Based on the schematics, the pull-down on that signal leads to 10 mW power leakage on S0i3 entry. Assert the signal on S0i3 entry to achieve some power savings and de-assert it on S0i3 exit. BUG=b:195748540 TEST=Build and boot to OS in Guybrush. Ensure that the signal gets asserted on S0i3 entry and de-asserted on S0i3 exit. Trigger suspend/resume cycles and ensure that the WWAN module is enumerated after each cycle. Change-Id: I43c8655ee5209779748e4365db973e094cb08aca Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> --- M src/mainboard/google/guybrush/mainboard.c 1 file changed, 28 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/58275/1 diff --git a/src/mainboard/google/guybrush/mainboard.c b/src/mainboard/google/guybrush/mainboard.c index 3626157..39ef2a0 100644 --- a/src/mainboard/google/guybrush/mainboard.c +++ b/src/mainboard/google/guybrush/mainboard.c @@ -13,11 +13,13 @@ #include <vendorcode/google/chromeos/chromeos.h> #define BACKLIGHT_GPIO GPIO_129 +#define WWAN_AUX_RST_GPIO GPIO_18 #define METHOD_BACKLIGHT_ENABLE "\\_SB.BKEN" #define METHOD_BACKLIGHT_DISABLE "\\_SB.BKDS" #define METHOD_MAINBOARD_INI "\\_SB.MINI" #define METHOD_MAINBOARD_WAK "\\_SB.MWAK" #define METHOD_MAINBOARD_PTS "\\_SB.MPTS" +#define METHOD_MAINBOARD_S0X "\\_SB.MS0X" /* * These arrays set up the FCH PCI_INTR registers 0xC00/0xC01. @@ -151,6 +153,31 @@ acpigen_pop_len(); } +static void mainboard_assert_wwan_aux_reset(void) +{ + if (variant_has_pcie_wwan()) + acpigen_soc_clear_tx_gpio(WWAN_AUX_RST_GPIO); +} + +static void mainboard_deassert_wwan_aux_reset(void) +{ + if (variant_has_pcie_wwan()) + acpigen_soc_set_tx_gpio(WWAN_AUX_RST_GPIO); +} + +static void mainboard_write_ms0x(void) +{ + acpigen_write_method_serialized(METHOD_MAINBOARD_S0X, 1); + /* S0ix Entry */ + acpigen_write_if_lequal_op_int(ARG0_OP, 1); + mainboard_assert_wwan_aux_reset(); + /* S0ix Exit */ + acpigen_write_else(); + mainboard_deassert_wwan_aux_reset(); + acpigen_pop_len(); + acpigen_pop_len(); +} + static void mainboard_fill_ssdt(const struct device *dev) { mainboard_write_blken(); @@ -158,6 +185,7 @@ mainboard_write_mini(); mainboard_write_mpts(); mainboard_write_mwak(); + mainboard_write_ms0x(); } static void mainboard_enable(struct device *dev) -- To view, visit https://review.coreboot.org/c/coreboot/+/58275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I43c8655ee5209779748e4365db973e094cb08aca Gerrit-Change-Number: 58275 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2021