coreboot-gerrit October 2021

coreboot-gerrit@coreboot.org

1 participants
5514 discussions

Change in coreboot[master]: soc/amd/common/acpi/upep: Add Low Power State Entry Notifications
by Karthik Ramasubramanian (Code Review) 13 Oct '21

13 Oct '21

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58274 ) Change subject: soc/amd/common/acpi/upep: Add Low Power State Entry Notifications ...................................................................... soc/amd/common/acpi/upep: Add Low Power State Entry Notifications Add support to handle S0ix entry and exit notifications by adding the corresponding _DSM functions. The function indices are chosen based on the s2idle kernel driver - https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drive…. Inside the notification functions perform any mainboard specific S0ix entry and exit actions. BUG=b:195748540 TEST=Build and boot to OS in Guybrush. Ensure that the notification functions are invoked on S0ix entry and exit. Perform suspend/resume cycles for multiple iterations. Change-Id: I3014551f6e281d466628559453a0141a3dd6abad Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> --- M src/soc/amd/common/acpi/upep.asl 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/58274/1 diff --git a/src/soc/amd/common/acpi/upep.asl b/src/soc/amd/common/acpi/upep.asl index ef06845..5443efd 100644 --- a/src/soc/amd/common/acpi/upep.asl +++ b/src/soc/amd/common/acpi/upep.asl @@ -4,10 +4,14 @@ #define PEPD_DSM_LPI_ENUM_FUNCTIONS 0 #define PEPD_DSM_LPI_ADDITIONAL_FUNCTIONS 1 #define PEPD_DSM_LPI_GET_DEVICE_CONSTRAINTS 1 +#define PEPD_DSM_LPI_S0IX_ENTRY 2 +#define PEPD_DSM_LPI_S0IX_EXIT 3 #define PEPD_DSM_NOTIFICATIONS_UUID "11e00d56-ce64-47ce-837b-1f898f9aa461" #define PEPD_DSM_NOTIFICATION_ENUM_FUNCTIONS 0 +External(\_SB.MS0X, MethodObj) + /* * Power Engine Plug-in Device * @@ -64,12 +68,28 @@ SUPP = PEPD_DSM_LPI_ADDITIONAL_FUNCTIONS SUPP |= 1 << PEPD_DSM_LPI_GET_DEVICE_CONSTRAINTS + SUPP |= 1 << PEPD_DSM_LPI_S0IX_ENTRY + SUPP |= 1 << PEPD_DSM_LPI_S0IX_EXIT Return (Local0) } Case (PEPD_DSM_LPI_GET_DEVICE_CONSTRAINTS) { Return (DEVL) } + Case (PEPD_DSM_LPI_S0IX_ENTRY) { + /* provide board level S0ix hook */ + If (CondRefOf (\_SB.MS0X)) { + \_SB.MS0X(1) + } + Return (Buffer() { 0x00 }) + } + Case (PEPD_DSM_LPI_S0IX_EXIT) { + /* provide board level S0ix hook */ + If (CondRefOf (\_SB.MS0X)) { + \_SB.MS0X(0) + } + Return (Buffer() { 0x00 }) + } Default { /* Unknown function */ Return (Buffer() { 0x00 }) -- To view, visit https://review.coreboot.org/c/coreboot/+/58274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3014551f6e281d466628559453a0141a3dd6abad Gerrit-Change-Number: 58274 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/dedede/var/corori: Configure I2C times for Touchpad
by Henry Sun (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Ian Feng, Aseda Aboagye, Shou-Chieh Hsu, Karthik Ramasubramanian. Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58238 ) Change subject: mb/google/dedede/var/corori: Configure I2C times for Touchpad ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: LGTM, differ to Karthik to approve. Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/58238 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f9d062fc611de0062a39849aee1174268391682 Gerrit-Change-Number: 58238 Gerrit-PatchSet: 2 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-CC: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 12 Oct 2021 15:24:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86/smbios: Add generation of type 20 table
by Matt DeVillier (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Paul Menzel, Angel Pons, Michael Niewöhner. Hello build bot (Jenkins), Paul Menzel, Angel Pons, Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58271 to look at the new patch set (#4). Change subject: arch/x86/smbios: Add generation of type 20 table ...................................................................... arch/x86/smbios: Add generation of type 20 table If available, use data from MEMINFO CBMEM table and saved handles from type 17/19 tables to generate type 20 (Memory Device Mapped Address) SMBIOS table. Windows 10/11 and some other OSes use this table to report the total memory available on a given device. Change-Id: I2574d6209d973a8e7f112eb3ef61f5d26986e47b Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/arch/x86/smbios.c M src/include/smbios.h 2 files changed, 63 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/58271/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/58271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2574d6209d973a8e7f112eb3ef61f5d26986e47b Gerrit-Change-Number: 58271 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel: replace dt option PmTimerDisabled by Kconfig
by Tim Wawrzynczak (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Felix Singer, Furquan Shaikh, Tim Wawrzynczak, Jeremy Soller, Paul Menzel, Angel Pons, Subrata Banik, Michael Niewöhner, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58016 ) Change subject: soc/intel: replace dt option PmTimerDisabled by Kconfig ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58016 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1811c6b98847b22272acfa35ca44f4fbca68947 Gerrit-Change-Number: 58016 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 12 Oct 2021 15:23:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86/smbios: Add generation of type 20 table
by Matt DeVillier (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Paul Menzel, Angel Pons, Michael Niewöhner. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58271 ) Change subject: arch/x86/smbios: Add generation of type 20 table ...................................................................... Patch Set 3: (7 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/58271/comment/e4363307_bb0d427a PS2, Line 10: type 20 > Could you please explain what the "type 20" SMBIOS table is about? At least mention the name in the […] Done https://review.coreboot.org/c/coreboot/+/58271/comment/83f78413_2a8ef336 PS2, Line 10: from type 17/19 tables to generate type 20 SMBIOS table > Missing a period. Done File src/arch/x86/smbios.c: https://review.coreboot.org/c/coreboot/+/58271/comment/b566e230_ef03e02c PS2, Line 1038: sizeof(struct smbios_type20) > Please don't. […] Done https://review.coreboot.org/c/coreboot/+/58271/comment/46b933b3_9aca6dd3 PS2, Line 1042: ++ > Dead increment Done https://review.coreboot.org/c/coreboot/+/58271/comment/859f34d2_347504f8 PS2, Line 1046: 0xFF > nit: use lowercase for hex values Done https://review.coreboot.org/c/coreboot/+/58271/comment/2177d484_1ce51977 PS2, Line 1051: t->length = len - 2; > Please use `smbios_carve_table` added in CB:55907 and `smbios_full_table_len` added in CB:55909 Done File src/include/smbios.h: https://review.coreboot.org/c/coreboot/+/58271/comment/00e6888f_22838c02 PS2, Line 885: u8 type; : u8 length; : u16 handle; > Please use `struct smbios_header header;` instead, like the other tables do. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/58271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2574d6209d973a8e7f112eb3ef61f5d26986e47b Gerrit-Change-Number: 58271 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Tue, 12 Oct 2021 15:22:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86/smbios: Add generation of type 20 table
by Matt DeVillier (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Matt DeVillier, Paul Menzel, Michael Niewöhner. Hello build bot (Jenkins), Paul Menzel, Angel Pons, Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58271 to look at the new patch set (#3). Change subject: arch/x86/smbios: Add generation of type 20 table ...................................................................... arch/x86/smbios: Add generation of type 20 table If available, use data from MEMINFO CBMEM table and saved handles from type 17/19 tables to generate type 20 (Memory Device Mapped Address) SMBIOS table. Windows 10/11 and some other OSes use this table to report the total memory available on a given device. Change-Id: I2574d6209d973a8e7f112eb3ef61f5d26986e47b Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/arch/x86/smbios.c M src/include/smbios.h 2 files changed, 64 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/58271/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/58271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2574d6209d973a8e7f112eb3ef61f5d26986e47b Gerrit-Change-Number: 58271 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/fizz: use SaGv_FixedHigh
by Tim Wawrzynczak (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Matt DeVillier. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58231 ) Change subject: mb/google/fizz: use SaGv_FixedHigh ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58231 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0295bac619af45a0d82da2bf39985c8bdcb77d5e Gerrit-Change-Number: 58231 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Tue, 12 Oct 2021 14:55:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/wyvern: use SaGv_FixedHigh
by Tim Wawrzynczak (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Matt DeVillier, Edward O'Callaghan. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58230 ) Change subject: mb/google/wyvern: use SaGv_FixedHigh ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: Seems OK to me, agree it seems unnecessary for a desktop system. I believe though you would also get the same effect from disabling SaGv (it will by default use the highest frequency if not overridden). -- To view, visit https://review.coreboot.org/c/coreboot/+/58230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ad773d1c616b746235ec67b98b83c5910464140 Gerrit-Change-Number: 58230 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Tue, 12 Oct 2021 14:55:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/{mp_init,smm}: Remove cpu member from smm_module_params
by Raul Rangel (Code Review) 13 Oct '21

13 Oct '21

Raul Rangel has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/58148 ) Change subject: cpu/x86/{mp_init,smm}: Remove cpu member from smm_module_params ...................................................................... Abandoned CPU_INFO_V2 is no longer required in smm. -- To view, visit https://review.coreboot.org/c/coreboot/+/58148 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67b31b6f2aea9e255db01ab29bd9a55416f67a7d Gerrit-Change-Number: 58148 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: cpu/x86: Remove cpu parameter to ap_init
by Raul Rangel (Code Review) 13 Oct '21

13 Oct '21

Attention is currently required from: Julius Werner, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58147 ) Change subject: cpu/x86: Remove cpu parameter to ap_init ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Looks like Jenkins didn't run the new version... -- To view, visit https://review.coreboot.org/c/coreboot/+/58147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8997683b6613b7031784cabf7039a400f0efdea1 Gerrit-Change-Number: 58147 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 12 Oct 2021 14:52:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2021