Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49025 )
Change subject: mb/clevo/cml-u: Rework Kconfig
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/49025/3/src/mainboard/clevo/cml-u/…
File src/mainboard/clevo/cml-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/49025/3/src/mainboard/clevo/cml-u/…
PS3, Line 21: _OPTIONS
nit: I don't think we really need that suffix
https://review.coreboot.org/c/coreboot/+/49025/3/src/mainboard/clevo/cml-u/…
PS3, Line 21: onfig BOARD_CLEVO_L140CU_OPTIONS
: bool
: select BOARD_CLEVO_CMLU_COMMON
: select EC_SYSTEM76_EC
: select HAVE_SPD_IN_CBFS
just an idea: we could have a separate Kconfig for each variant in variants/<variant>/Kconfig where these overrides go to. wdyt?
--
To view, visit https://review.coreboot.org/c/coreboot/+/49025
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f5b6f535597149f28dd8c8322acc2e988f11505
Gerrit-Change-Number: 49025
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 04 Jan 2021 00:09:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello build bot (Jenkins), Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49025
to look at the new patch set (#3).
Change subject: mb/clevo/cml-u: Rework Kconfig
......................................................................
mb/clevo/cml-u: Rework Kconfig
Rework Kconfig file so that each variant has its own config option with
their specific selects / configuration and move common selects to a
seperate config option, which is used as base for each variant.
Built clevo/l140cu with BUILD_TIMELESS=1, coreboot.rom remains the same.
Change-Id: I1f5b6f535597149f28dd8c8322acc2e988f11505
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M src/mainboard/clevo/cml-u/Kconfig
M src/mainboard/clevo/cml-u/Kconfig.name
2 files changed, 11 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/49025/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/49025
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f5b6f535597149f28dd8c8322acc2e988f11505
Gerrit-Change-Number: 49025
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49025 )
Change subject: mb/clevo/cml-u: Rework Kconfig
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/49025
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f5b6f535597149f28dd8c8322acc2e988f11505
Gerrit-Change-Number: 49025
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sun, 03 Jan 2021 20:53:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47984 )
Change subject: mb/clevo/cml-u: Configure IRQ as level triggered for HID over I2C
......................................................................
Patch Set 9:
> Patch Set 9:
>
> (2 comments)
>
> Given that the touchpad worked before
erm. that was stale... just ignore
--
To view, visit https://review.coreboot.org/c/coreboot/+/47984
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia232c0a11546aa6d17614f4cab07c255e58f2fed
Gerrit-Change-Number: 47984
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Sun, 03 Jan 2021 16:55:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment