Attention is currently required from: Damien Zammit, Martin Roth, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49365 )
Change subject: nb/intel/pineview: Extract HPET setup and delay function
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Do you intend to use hpet_delay on other platforms? […]
I suspect the hysterical DQS probe on x4x might benefit from using more accurate `hpet_udelay` for small delays.
--
To view, visit https://review.coreboot.org/c/coreboot/+/49365
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a28cc4d12c6d79cd8ec45dfc8100f15e6eac303
Gerrit-Change-Number: 49365
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 12 Jan 2021 22:30:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Damien Zammit, Martin Roth, Angel Pons, Patrick Rudolph.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49365 )
Change subject: nb/intel/pineview: Extract HPET setup and delay function
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Do you intend to use hpet_delay on other platforms?
I was planning to use the regular udelay on pineview: https://review.coreboot.org/c/coreboot/+/35759
--
To view, visit https://review.coreboot.org/c/coreboot/+/49365
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a28cc4d12c6d79cd8ec45dfc8100f15e6eac303
Gerrit-Change-Number: 49365
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 12 Jan 2021 22:26:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph, EricR Lai.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49338 )
Change subject: spd: Create new folder for SPD files
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> weird.... anyone have any idea why they're not allowed?
Looks like: https://review.coreboot.org/17633
> Another way I could think of is to have a Kconfig per-platform that points
to the appropriate SPD directory
I think we might be able to do this even without the Kconfig. Basically, what we need is:
1. Tool generates all SPDs for a platform under a particular directory
2. Tool sets the correct directory path when generating the mainboard Makefiles. This can be done using some variable like SPD_DIR which will be then used to pull in all the required SPDs during the build.
So, if the tool takes care of handling the path to the directory, then we don't need to worry about symlinks or setting another config.
--
To view, visit https://review.coreboot.org/c/coreboot/+/49338
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a871981642485020adaeaafd062f718c636a708
Gerrit-Change-Number: 49338
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 12 Jan 2021 21:54:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49358 )
Change subject: build system: Structure and serialize INTERMEDIATE
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> This was already discussed in CB:48241 and I wrote CB:49190 to address it. […]
I'm not too keen on hunting down parallel executions every time somebody adds a rule and forget to add a flock in the right place(s) - and that can be non-trivial with larger modifications: `flock sh -c "command to read from coreboot.pre; modify that data; command to write the result to coreboot.pre"` gets annoying fast.
I'm also not sure how portable flock is, so I like to have the freedom of kicking it out if anybody complains without reintroducing race conditions.
Compared to CB:48241 there are no sub-makes involved, it's just serialization using make's order-only rules, eliminating the risks you outlined on context getting lost when calling $(MAKE).
--
To view, visit https://review.coreboot.org/c/coreboot/+/49358
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5803806e6c33083dfe5dec8904a65c46436e756
Gerrit-Change-Number: 49358
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Tue, 12 Jan 2021 21:52:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49358 )
Change subject: build system: Structure and serialize INTERMEDIATE
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/49358
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5803806e6c33083dfe5dec8904a65c46436e756
Gerrit-Change-Number: 49358
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 12 Jan 2021 21:47:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49358 )
Change subject: build system: Structure and serialize INTERMEDIATE
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
This was already discussed in CB:48241 and I wrote CB:49190 to address it. Is this still necessary?
--
To view, visit https://review.coreboot.org/c/coreboot/+/49358
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5803806e6c33083dfe5dec8904a65c46436e756
Gerrit-Change-Number: 49358
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Tue, 12 Jan 2021 21:47:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kyösti Mälkki.
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49344
to look at the new patch set (#3).
Change subject: sb/intel: Select ACPI_SOC_NVS where suitable
......................................................................
sb/intel: Select ACPI_SOC_NVS where suitable
Since GNVS creation is now controlled by ACPI_SOC_NVS,
drivers/amd/agesa/nvs.c became obsolete and soc/amd/cezanne
cannot have this selected while <soc/nvs.h> does not exist.
Change-Id: Ia9ec853ff7f5e7908f7e8fc179ac27d0da08e19d
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
---
M src/acpi/nvs.c
M src/drivers/amd/agesa/Makefile.inc
D src/drivers/amd/agesa/nvs.c
M src/lib/hardwaremain.c
M src/mainboard/acer/g43t-am3/acpi_tables.c
M src/mainboard/apple/macbook21/acpi_tables.c
M src/mainboard/apple/macbook21/smihandler.c
M src/mainboard/apple/macbookair4_2/gnvs.c
M src/mainboard/asrock/b75pro3-m/acpi_tables.c
M src/mainboard/asrock/b85m_pro4/acpi_tables.c
M src/mainboard/asrock/g41c-gs/acpi_tables.c
M src/mainboard/asus/p5qc/acpi_tables.c
M src/mainboard/asus/p5ql-em/acpi_tables.c
M src/mainboard/asus/p5qpl-am/acpi_tables.c
M src/mainboard/asus/p8h61-m_lx3_r2_0/acpi_tables.c
M src/mainboard/asus/p8h61-m_pro/acpi_tables.c
M src/mainboard/asus/p8z77-m_pro/acpi_tables.c
M src/mainboard/asus/p8z77-v_lx2/acpi_tables.c
M src/mainboard/compulab/intense_pc/acpi_tables.c
M src/mainboard/dell/optiplex_9010/acpi_tables.c
M src/mainboard/emulation/qemu-q35/acpi_tables.c
M src/mainboard/foxconn/g41s-k/acpi_tables.c
M src/mainboard/getac/p470/acpi_tables.c
M src/mainboard/getac/p470/smihandler.c
M src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c
M src/mainboard/gigabyte/ga-g41m-es2l/acpi_tables.c
M src/mainboard/google/beltino/acpi_tables.c
M src/mainboard/google/beltino/smihandler.c
M src/mainboard/google/butterfly/acpi_tables.c
M src/mainboard/google/butterfly/mainboard_smi.c
M src/mainboard/google/link/acpi_tables.c
M src/mainboard/google/link/mainboard_smi.c
M src/mainboard/google/parrot/acpi_tables.c
M src/mainboard/google/parrot/smihandler.c
M src/mainboard/google/slippy/acpi_tables.c
M src/mainboard/google/slippy/smihandler.c
M src/mainboard/google/stout/acpi_tables.c
M src/mainboard/google/stout/mainboard_smi.c
M src/mainboard/hp/compaq_8200_elite_sff/acpi_tables.c
M src/mainboard/hp/folio_9480m/acpi_tables.c
M src/mainboard/hp/snb_ivb_laptops/acpi_tables.c
M src/mainboard/hp/z220_sff_workstation/acpi_tables.c
M src/mainboard/ibase/mb899/acpi_tables.c
M src/mainboard/intel/baskingridge/acpi_tables.c
M src/mainboard/intel/baskingridge/mainboard_smi.c
M src/mainboard/intel/dcp847ske/acpi_tables.c
M src/mainboard/intel/dg41wv/acpi_tables.c
M src/mainboard/intel/dg43gt/acpi_tables.c
M src/mainboard/intel/emeraldlake2/acpi_tables.c
M src/mainboard/intel/emeraldlake2/smihandler.c
M src/mainboard/kontron/986lcd-m/acpi_tables.c
M src/mainboard/kontron/ktqm77/acpi_tables.c
M src/mainboard/lenovo/l520/acpi_tables.c
M src/mainboard/lenovo/s230u/acpi_tables.c
M src/mainboard/lenovo/t400/acpi_tables.c
M src/mainboard/lenovo/t410/acpi_tables.c
M src/mainboard/lenovo/t410/smihandler.c
M src/mainboard/lenovo/t420/acpi_tables.c
M src/mainboard/lenovo/t420s/acpi_tables.c
M src/mainboard/lenovo/t430/acpi_tables.c
M src/mainboard/lenovo/t430s/acpi_tables.c
M src/mainboard/lenovo/t440p/acpi_tables.c
M src/mainboard/lenovo/t520/acpi_tables.c
M src/mainboard/lenovo/t530/acpi_tables.c
M src/mainboard/lenovo/t60/acpi_tables.c
M src/mainboard/lenovo/t60/smihandler.c
M src/mainboard/lenovo/thinkcentre_a58/acpi_tables.c
M src/mainboard/lenovo/x131e/acpi_tables.c
M src/mainboard/lenovo/x1_carbon_gen1/acpi_tables.c
M src/mainboard/lenovo/x200/acpi_tables.c
M src/mainboard/lenovo/x201/acpi_tables.c
M src/mainboard/lenovo/x201/smihandler.c
M src/mainboard/lenovo/x220/acpi_tables.c
M src/mainboard/lenovo/x230/acpi_tables.c
M src/mainboard/lenovo/x60/acpi_tables.c
M src/mainboard/lenovo/x60/smihandler.c
M src/mainboard/msi/ms7707/acpi_tables.c
M src/mainboard/packardbell/ms2290/smihandler.c
M src/mainboard/roda/rk886ex/acpi_tables.c
M src/mainboard/roda/rk9/acpi_tables.c
M src/mainboard/roda/rk9/smihandler.c
M src/mainboard/roda/rv11/acpi_tables.c
M src/mainboard/samsung/lumpy/acpi_tables.c
M src/mainboard/samsung/lumpy/smihandler.c
M src/mainboard/samsung/stumpy/acpi_tables.c
M src/mainboard/samsung/stumpy/smihandler.c
M src/mainboard/sapphire/pureplatinumh61/acpi_tables.c
M src/mainboard/supermicro/x9scl/acpi_tables.c
M src/soc/amd/cezanne/Kconfig
M src/southbridge/intel/bd82x6x/Kconfig
M src/southbridge/intel/bd82x6x/Makefile.inc
R src/southbridge/intel/bd82x6x/include/soc/nvs.h
M src/southbridge/intel/bd82x6x/lpc.c
M src/southbridge/intel/bd82x6x/smihandler.c
M src/southbridge/intel/i82371eb/acpi_tables.c
M src/southbridge/intel/i82801dx/fadt.c
M src/southbridge/intel/i82801gx/Kconfig
M src/southbridge/intel/i82801gx/Makefile.inc
R src/southbridge/intel/i82801gx/include/soc/nvs.h
M src/southbridge/intel/i82801gx/lpc.c
M src/southbridge/intel/i82801gx/smihandler.c
M src/southbridge/intel/i82801ix/Kconfig
M src/southbridge/intel/i82801ix/Makefile.inc
R src/southbridge/intel/i82801ix/include/soc/nvs.h
M src/southbridge/intel/i82801ix/lpc.c
M src/southbridge/intel/i82801ix/smihandler.c
M src/southbridge/intel/i82801jx/Kconfig
M src/southbridge/intel/i82801jx/Makefile.inc
R src/southbridge/intel/i82801jx/include/soc/nvs.h
M src/southbridge/intel/i82801jx/lpc.c
M src/southbridge/intel/i82801jx/smihandler.c
M src/southbridge/intel/ibexpeak/Kconfig
M src/southbridge/intel/ibexpeak/Makefile.inc
R src/southbridge/intel/ibexpeak/include/soc/nvs.h
M src/southbridge/intel/ibexpeak/lpc.c
M src/southbridge/intel/ibexpeak/smihandler.c
M src/southbridge/intel/lynxpoint/Kconfig
M src/southbridge/intel/lynxpoint/Makefile.inc
M src/southbridge/intel/lynxpoint/acpi.c
R src/southbridge/intel/lynxpoint/include/soc/nvs.h
M src/southbridge/intel/lynxpoint/lpc.c
M src/southbridge/intel/lynxpoint/serialio.c
M src/southbridge/intel/lynxpoint/smihandler.c
123 files changed, 121 insertions(+), 180 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/49344/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/49344
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9ec853ff7f5e7908f7e8fc179ac27d0da08e19d
Gerrit-Change-Number: 49344
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-MessageType: newpatchset