coreboot-gerrit September 2020

coreboot-gerrit@coreboot.org

1 participants
2628 discussions

Change in coreboot[master]: util/spd_tools: output binaries instead of hexdumps
by Michael Niewöhner (Code Review) 01 Sep '20

01 Sep '20

Hello Felix Singer, build bot (Jenkins), Nico Huber, Furquan Shaikh, Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/44878 to look at the new patch set (#2). Change subject: util/spd_tools: output binaries instead of hexdumps ...................................................................... util/spd_tools: output binaries instead of hexdumps Instead of generating hexdumps, output binary SPD files since we plan to convert all hex SPD files to binary. Also adjust the file ending where needed. Test: compared generated binaries with converted binaries from hex files Change-Id: Ie99d108ca90758d09dbefad20fe6c9f7fc263ef1 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M util/spd_tools/ddr4/README.md M util/spd_tools/ddr4/gen_part_id.go M util/spd_tools/ddr4/gen_spd.go M util/spd_tools/lp4x/README.md M util/spd_tools/lp4x/gen_spd.go 5 files changed, 39 insertions(+), 47 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/44878/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/44878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie99d108ca90758d09dbefad20fe6c9f7fc263ef1 Gerrit-Change-Number: 44878 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb: remove duplicated Make code for spd.bin generation
by Michael Niewöhner (Code Review) 01 Sep '20

01 Sep '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44774 ) Change subject: mb: remove duplicated Make code for spd.bin generation ...................................................................... Patch Set 8: (1 comment) https://review.coreboot.org/c/coreboot/+/44774/7/src/mainboard/google/deded… File src/mainboard/google/dedede/spd/Makefile.inc: https://review.coreboot.org/c/coreboot/+/44774/7/src/mainboard/google/deded… PS7, Line 3: ifneq ($(SPD_SOURCES),) > The check looks like a no-op now. Also makes me wonder, if the […] 1. Yes, that can be dropped indeed. 2. Ouch... good catch. An empty file gets added to cbfs. However, CONFIG_GENERIC_SPD_BIN should be disabled for dedede, anyways, as long as there is no spd specified. -- To view, visit https://review.coreboot.org/c/coreboot/+/44774 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd3ac0fd6c901228554115c6350d88bb49874587 Gerrit-Change-Number: 44774 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 01 Sep 2020 21:58:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb: remove duplicated Make code for spd.bin generation
by Michael Niewöhner (Code Review) 01 Sep '20

01 Sep '20

Hello Felix Singer, build bot (Jenkins), Nico Huber, David Guckian, Patrick Georgi, Martin Roth, Vanessa Eusebio, Angel Pons, Alexander Couzens, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/44774 to look at the new patch set (#8). Change subject: mb: remove duplicated Make code for spd.bin generation ...................................................................... mb: remove duplicated Make code for spd.bin generation Drop duplicated code for spd.bin generation that is provided globally in lib/Makefile.inc. For all affected boards it has been verified that the output binary functionally matches the original one. The changed execution order of Make instructions influenced the cbfs file order. Hence, the rom images can't be compared directly. Thus, the output files of the two timeless abuild runs have been compared. Further, it was verified that the final files in cbfs stay identical, by comparing the extracted cbfs of each board. The boards (possibly) needing modification could be found with something like this (with false positives, though): find src/mainboard -name Makefile.inc | \ xargs egrep 'SPD_BIN|SPD_DEPS' | cut -d: -f1 | sort -u Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Change-Id: Icd3ac0fd6c901228554115c6350d88bb49874587 --- M src/mainboard/bap/ode_e20XX/Kconfig M src/mainboard/bap/ode_e20XX/Makefile.inc R src/mainboard/bap/ode_e20XX/spd/BAP_Q7_1066.spd.hex R src/mainboard/bap/ode_e20XX/spd/BAP_Q7_800.spd.hex M src/mainboard/gizmosphere/gizmo/Kconfig M src/mainboard/gizmosphere/gizmo/Makefile.inc R src/mainboard/gizmosphere/gizmo/spd/Elpida_EDJ2116DEBG.spd.hex M src/mainboard/gizmosphere/gizmo2/Kconfig M src/mainboard/gizmosphere/gizmo2/Makefile.inc R src/mainboard/gizmosphere/gizmo2/spd/Micron_MT41J128M16JT.spd.hex M src/mainboard/google/auron/Kconfig M src/mainboard/google/auron/variants/auron_paine/spd/Makefile.inc M src/mainboard/google/auron/variants/auron_yuna/spd/Makefile.inc M src/mainboard/google/auron/variants/gandof/spd/Makefile.inc M src/mainboard/google/auron/variants/lulu/spd/Makefile.inc M src/mainboard/google/auron/variants/samus/spd/Makefile.inc M src/mainboard/google/cyan/Kconfig M src/mainboard/google/cyan/variants/banon/Makefile.inc M src/mainboard/google/cyan/variants/celes/Makefile.inc M src/mainboard/google/cyan/variants/cyan/Makefile.inc M src/mainboard/google/cyan/variants/edgar/Makefile.inc M src/mainboard/google/cyan/variants/kefka/Makefile.inc M src/mainboard/google/cyan/variants/reks/Makefile.inc M src/mainboard/google/cyan/variants/relm/Makefile.inc M src/mainboard/google/cyan/variants/setzer/Makefile.inc M src/mainboard/google/cyan/variants/terra/Makefile.inc M src/mainboard/google/cyan/variants/ultima/Makefile.inc M src/mainboard/google/cyan/variants/wizpig/Makefile.inc M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/spd/Makefile.inc M src/mainboard/google/drallion/Kconfig M src/mainboard/google/drallion/spd/Makefile.inc M src/mainboard/google/eve/Kconfig M src/mainboard/google/eve/spd/Makefile.inc M src/mainboard/google/glados/Kconfig M src/mainboard/google/glados/variants/asuka/Makefile.inc M src/mainboard/google/glados/variants/caroline/Makefile.inc M src/mainboard/google/glados/variants/cave/Makefile.inc M src/mainboard/google/glados/variants/chell/Makefile.inc M src/mainboard/google/glados/variants/glados/Makefile.inc M src/mainboard/google/glados/variants/lars/Makefile.inc M src/mainboard/google/glados/variants/sentry/Makefile.inc M src/mainboard/google/hatch/Kconfig D src/mainboard/google/hatch/spd/Makefile.inc M src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc M src/mainboard/google/kahlee/variants/careena/spd/Makefile.inc M src/mainboard/google/kahlee/variants/nuwani/spd/Makefile.inc M src/mainboard/google/kahlee/variants/treeya/spd/Makefile.inc M src/mainboard/google/poppy/Kconfig M src/mainboard/google/poppy/spd/Makefile.inc M src/mainboard/google/rambi/Kconfig M src/mainboard/google/rambi/variants/banjo/Makefile.inc M src/mainboard/google/rambi/variants/candy/Makefile.inc M src/mainboard/google/rambi/variants/clapper/Makefile.inc M src/mainboard/google/rambi/variants/enguarde/Makefile.inc M src/mainboard/google/rambi/variants/glimmer/Makefile.inc M src/mainboard/google/rambi/variants/gnawty/Makefile.inc M src/mainboard/google/rambi/variants/heli/Makefile.inc M src/mainboard/google/rambi/variants/kip/Makefile.inc M src/mainboard/google/rambi/variants/ninja/Makefile.inc M src/mainboard/google/rambi/variants/orco/Makefile.inc M src/mainboard/google/rambi/variants/quawks/Makefile.inc M src/mainboard/google/rambi/variants/rambi/Makefile.inc M src/mainboard/google/rambi/variants/squawks/Makefile.inc M src/mainboard/google/rambi/variants/sumo/Makefile.inc M src/mainboard/google/rambi/variants/swanky/Makefile.inc M src/mainboard/google/rambi/variants/winky/Makefile.inc M src/mainboard/google/slippy/Kconfig M src/mainboard/google/slippy/variants/falco/Makefile.inc M src/mainboard/google/slippy/variants/leon/Makefile.inc M src/mainboard/google/slippy/variants/peppy/Makefile.inc M src/mainboard/google/slippy/variants/wolf/Makefile.inc M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/spd/Makefile.inc M src/mainboard/intel/cannonlake_rvp/spd/Makefile.inc M src/mainboard/intel/harcuvar/Kconfig M src/mainboard/intel/harcuvar/spd/Makefile.inc M src/mainboard/intel/icelake_rvp/spd/Makefile.inc M src/mainboard/intel/jasperlake_rvp/spd/Makefile.inc M src/mainboard/intel/kblrvp/spd/Makefile.inc M src/mainboard/intel/kunimitsu/Kconfig M src/mainboard/intel/kunimitsu/spd/Makefile.inc M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/intel/tglrvp/spd/Makefile.inc M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/t430s/variants/t431s/spd/Makefile.inc M src/mainboard/lenovo/x1_carbon_gen1/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc R src/mainboard/lenovo/x1_carbon_gen1/spd/elpida.spd.hex R src/mainboard/lenovo/x1_carbon_gen1/spd/hynix.spd.hex R src/mainboard/lenovo/x1_carbon_gen1/spd/samsung.spd.hex M src/mainboard/razer/blade_stealth_kbl/spd/Makefile.inc M src/mainboard/samsung/lumpy/Kconfig M src/mainboard/samsung/lumpy/Makefile.inc D src/mainboard/samsung/lumpy/spd.hex A src/mainboard/samsung/lumpy/spd/lumpy.spd.hex 96 files changed, 133 insertions(+), 1,029 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/44774/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/44774 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd3ac0fd6c901228554115c6350d88bb49874587 Gerrit-Change-Number: 44774 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/intel/car/non-evict/cache_as_ram.S: Drop unused "BBL_CR_CTL3_MSR"...
by HAOUAS Elyes (Code Review) 01 Sep '20

01 Sep '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44983 ) Change subject: cpu/intel/car/non-evict/cache_as_ram.S: Drop unused "BBL_CR_CTL3_MSR" macro ...................................................................... cpu/intel/car/non-evict/cache_as_ram.S: Drop unused "BBL_CR_CTL3_MSR" macro Change-Id: I5896b546281f859eba2955403021fbca233803cb Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/intel/car/non-evict/cache_as_ram.S 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/44983/1 diff --git a/src/cpu/intel/car/non-evict/cache_as_ram.S b/src/cpu/intel/car/non-evict/cache_as_ram.S index d087365..3ac4a8b 100644 --- a/src/cpu/intel/car/non-evict/cache_as_ram.S +++ b/src/cpu/intel/car/non-evict/cache_as_ram.S @@ -5,7 +5,6 @@ #include <cpu/x86/post_code.h> #define NoEvictMod_MSR 0x2e0 -#define BBL_CR_CTL3_MSR 0x11e .global bootblock_pre_c_entry -- To view, visit https://review.coreboot.org/c/coreboot/+/44983 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5896b546281f859eba2955403021fbca233803cb Gerrit-Change-Number: 44983 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 1

Change in em100[master]: em100: Return exit status 1 when verify fails
by Ryan O'Leary (Code Review) 01 Sep '20

01 Sep '20

Ryan O'Leary has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/44877 ) Change subject: em100: Return exit status 1 when verify fails ...................................................................... em100: Return exit status 1 when verify fails Change-Id: I6fb21c0f6070eab5a700e4675b2e6da2f2f97930 Signed-off-by: Ryan O'Leary <ryanoleary(a)google.com> --- M em100.c 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/em100 refs/changes/77/44877/1 diff --git a/em100.c b/em100.c index e4f5e44..49d0d1e 100644 --- a/em100.c +++ b/em100.c @@ -1159,8 +1159,13 @@ done = read_sdram(&em100, readback, spi_start_address, length); if (done && (memcmp(data, readback, length) == 0)) printf("Verify: PASS\n"); - else + else { printf("Verify: FAIL\n"); + free(readback); + free(data); + em100_detach(&em100); + return 1; + } free(readback); } -- To view, visit https://review.coreboot.org/c/em100/+/44877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I6fb21c0f6070eab5a700e4675b2e6da2f2f97930 Gerrit-Change-Number: 44877 Gerrit-PatchSet: 1 Gerrit-Owner: Ryan O'Leary <ryanoleary(a)google.com> Gerrit-MessageType: newchange

2 2

Change in em100[refs/meta/config]: Review access change
by Stefan Reinauer (Code Review) 01 Sep '20

01 Sep '20

Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/44992 ) Change subject: Review access change ...................................................................... Review access change Change-Id: I9db9346a3275d584de7fd1f925e94bae8665fae0 --- M groups M project.config 2 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/em100 refs/changes/92/44992/1 diff --git a/groups b/groups index 4a3f76d..6711993 100644 --- a/groups +++ b/groups @@ -1,3 +1,4 @@ # UUID Group Name # global:Project-Owners Project Owners +user:rjoleary user/Ryan O'Leary (rjoleary) diff --git a/project.config b/project.config index 34fe2bf..e6a5d99 100644 --- a/project.config +++ b/project.config @@ -10,3 +10,5 @@ mergeContent = true [access "refs/heads/*"] label-Verified = -1..+1 group Project Owners +[access "refs/for/*"] + submit = group user/Ryan O'Leary (rjoleary) -- To view, visit https://review.coreboot.org/c/em100/+/44992 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I9db9346a3275d584de7fd1f925e94bae8665fae0 Gerrit-Change-Number: 44992 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

1 2

Change in coreboot[master]: cpu/x86/smm: Enable SMM support for Xeon-SP
by Rocky Phagura (Code Review) 01 Sep '20

01 Sep '20

Rocky Phagura has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41829 ) Change subject: cpu/x86/smm: Enable SMM support for Xeon-SP ...................................................................... Abandoned This patch has been superseded by https://review.coreboot.org/c/coreboot/+/43684 -- To view, visit https://review.coreboot.org/c/coreboot/+/41829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I78bd74c11ca42fb430f63711b5ec87d4bfe6ca2a Gerrit-Change-Number: 41829 Gerrit-PatchSet: 8 Gerrit-Owner: Rocky Phagura Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: Eugene Myers <cedarhouse(a)comcast.net> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki.2011(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Ron Minnich <rminnich(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: mb/google/dedede/var/boten: Add audio configuration
by Karthik Ramasubramanian (Code Review) 01 Sep '20

01 Sep '20

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44920 ) Change subject: mb/google/dedede/var/boten: Add audio configuration ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/44920/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/44920/1//COMMIT_MSG@13 PS1, Line 13: TEST=Build the boten board. > … and hear some sound? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/44920 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I835db854543e6282c102c86a7073b432fd89d0a5 Gerrit-Change-Number: 44920 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Ben Zhang <benzh(a)google.com> Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 01 Sep 2020 17:20:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/boten: Add audio configuration
by Karthik Ramasubramanian (Code Review) 01 Sep '20

01 Sep '20

Hello build bot (Jenkins), Ben Zhang, Justin TerAvest, Evan Green, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/44920 to look at the new patch set (#2). Change subject: mb/google/dedede/var/boten: Add audio configuration ...................................................................... mb/google/dedede/var/boten: Add audio configuration Add configuration for ALC5682 headphone jack and ALC1015 speaker amplifier. Also turn on the HDA PCI device. BUG=b:161667665 TEST=Build the boten board and verified the audio functionality. Change-Id: I835db854543e6282c102c86a7073b432fd89d0a5 Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> --- M src/mainboard/google/dedede/variants/boten/overridetree.cb 1 file changed, 28 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/44920/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/44920 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I835db854543e6282c102c86a7073b432fd89d0a5 Gerrit-Change-Number: 44920 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Ben Zhang <benzh(a)google.com> Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/alderlake/bootblock: Do initial SoC commit till bootblock
by Tim Wawrzynczak (Code Review) 01 Sep '20

01 Sep '20

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44857 ) Change subject: soc/intel/alderlake/bootblock: Do initial SoC commit till bootblock ...................................................................... Patch Set 2: (10 comments) https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/Kc… File src/soc/intel/alderlake/Kconfig: https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/Kc… PS2, Line 131: 0xe00 0x1400 is typical https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/bo… File src/soc/intel/alderlake/bootblock/cpu.c: https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/bo… PS2, Line 16: only booting from SPI device "SPI flash" https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/bo… File src/soc/intel/alderlake/bootblock/pch.c: https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/bo… PS2, Line 102: uint32_t dmi_control = pcr_read32(PID_DMI, PCR_DMI_DMICTL); nit: const https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/bo… File src/soc/intel/alderlake/bootblock/report_platform.c: https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/bo… PS2, Line 5: 619362 This is the ADL-S EDS https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/bo… PS2, Line 99: PCI_DEVICE_ID_INTEL_ADL_S_GT1 Would any ADL-P SoC have the ADL-S GT1 IGD ? https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/bo… PS2, Line 136: aes = (cpu_feature_flag & CPUID_AES) ? 1 : 0; : txt = (cpu_feature_flag & CPUID_SMX) ? 1 : 0; : vt = (cpu_feature_flag & CPUID_VMX) ? 1 : 0; suggestion: you could use !!(cpu_feature_flag & CPUID...) https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/in… File src/soc/intel/alderlake/include/soc/espi.h: https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/in… PS2, Line 5: 621483 this is ADL-S, is there going to be a separate EDS for -P? https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/in… PS2, Line 12: #include <stdint.h> not used here https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/in… File src/soc/intel/alderlake/include/soc/iomap.h: https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/in… PS2, Line 65: What about IOM_BASE_ADDRESS ? https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/in… File src/soc/intel/alderlake/include/soc/pcr_ids.h: https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/in… PS2, Line 14: */ SDCX controller ? -- To view, visit https://review.coreboot.org/c/coreboot/+/44857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I204e692fabb84fce297bebee465f4ca624c6fe56 Gerrit-Change-Number: 44857 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Sep 2020 16:53:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2020