coreboot-gerrit September 2020

coreboot-gerrit@coreboot.org

1 participants
2629 discussions

Change in coreboot[master]: soc/intel/alderlake/bootblock: Do initial SoC commit till bootblock
by Tim Wawrzynczak (Code Review) 01 Sep '20

01 Sep '20

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44857 ) Change subject: soc/intel/alderlake/bootblock: Do initial SoC commit till bootblock ...................................................................... Patch Set 2: (10 comments) https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/Kc… File src/soc/intel/alderlake/Kconfig: https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/Kc… PS2, Line 131: 0xe00 0x1400 is typical https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/bo… File src/soc/intel/alderlake/bootblock/cpu.c: https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/bo… PS2, Line 16: only booting from SPI device "SPI flash" https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/bo… File src/soc/intel/alderlake/bootblock/pch.c: https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/bo… PS2, Line 102: uint32_t dmi_control = pcr_read32(PID_DMI, PCR_DMI_DMICTL); nit: const https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/bo… File src/soc/intel/alderlake/bootblock/report_platform.c: https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/bo… PS2, Line 5: 619362 This is the ADL-S EDS https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/bo… PS2, Line 99: PCI_DEVICE_ID_INTEL_ADL_S_GT1 Would any ADL-P SoC have the ADL-S GT1 IGD ? https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/bo… PS2, Line 136: aes = (cpu_feature_flag & CPUID_AES) ? 1 : 0; : txt = (cpu_feature_flag & CPUID_SMX) ? 1 : 0; : vt = (cpu_feature_flag & CPUID_VMX) ? 1 : 0; suggestion: you could use !!(cpu_feature_flag & CPUID...) https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/in… File src/soc/intel/alderlake/include/soc/espi.h: https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/in… PS2, Line 5: 621483 this is ADL-S, is there going to be a separate EDS for -P? https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/in… PS2, Line 12: #include <stdint.h> not used here https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/in… File src/soc/intel/alderlake/include/soc/iomap.h: https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/in… PS2, Line 65: What about IOM_BASE_ADDRESS ? https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/in… File src/soc/intel/alderlake/include/soc/pcr_ids.h: https://review.coreboot.org/c/coreboot/+/44857/2/src/soc/intel/alderlake/in… PS2, Line 14: */ SDCX controller ? -- To view, visit https://review.coreboot.org/c/coreboot/+/44857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I204e692fabb84fce297bebee465f4ca624c6fe56 Gerrit-Change-Number: 44857 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Sep 2020 16:53:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake/bootblock: Do initial SoC commit till bootblock
by Tim Wawrzynczak (Code Review) 01 Sep '20

01 Sep '20

1 0

Change in coreboot[master]: cpu/x86/mp_init.c: Drop unused "MAX_APIC_IDS" macro
by HAOUAS Elyes (Code Review) 01 Sep '20

01 Sep '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44982 ) Change subject: cpu/x86/mp_init.c: Drop unused "MAX_APIC_IDS" macro ...................................................................... cpu/x86/mp_init.c: Drop unused "MAX_APIC_IDS" macro Change-Id: I2c91248be5d95bd1087a16fc6dca1c13107670b9 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/x86/mp_init.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/44982/1 diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index 5807831..667d830 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -28,8 +28,6 @@ #include <security/intel/stm/SmmStm.h> -#define MAX_APIC_IDS 256 - struct mp_callback { void (*func)(void *); void *arg; -- To view, visit https://review.coreboot.org/c/coreboot/+/44982 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2c91248be5d95bd1087a16fc6dca1c13107670b9 Gerrit-Change-Number: 44982 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/cnl: Allow using the remaining Comet Lake FSPs
by Michael Niewöhner (Code Review) 01 Sep '20

01 Sep '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44954 ) Change subject: soc/intel/cnl: Allow using the remaining Comet Lake FSPs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/44954 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4272a6ee08e19769a8a17c93bb3ce2421be0bbc9 Gerrit-Change-Number: 44954 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 01 Sep 2020 13:48:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: 3rdparty/fsp: Update submodule pointer to current master
by Michael Niewöhner (Code Review) 01 Sep '20

01 Sep '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44953 ) Change subject: 3rdparty/fsp: Update submodule pointer to current master ...................................................................... Patch Set 1: Code-Review+2 Current CML Fsp has been tested successfully on l141cu/lemp9; Current KBL Fsp was tested on X11SSM-F -- To view, visit https://review.coreboot.org/c/coreboot/+/44953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I50bac5a70425495832649e0d6d6e91aad623f25c Gerrit-Change-Number: 44953 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 01 Sep 2020 13:48:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/cnl: Add new Kconfig option which matches its FSPs name
by Michael Niewöhner (Code Review) 01 Sep '20

01 Sep '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44952 ) Change subject: soc/intel/cnl: Add new Kconfig option which matches its FSPs name ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/44952 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44b717bb942fbcd359c7a06ef1a0ef4306697f64 Gerrit-Change-Number: 44952 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 01 Sep 2020 13:47:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake/bootblock: Do initial SoC commit till bootblock
by Subrata Banik (Code Review) 01 Sep '20

01 Sep '20

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44857 ) Change subject: soc/intel/alderlake/bootblock: Do initial SoC commit till bootblock ...................................................................... Patch Set 2: @Tim, if you can take a look -- To view, visit https://review.coreboot.org/c/coreboot/+/44857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I204e692fabb84fce297bebee465f4ca624c6fe56 Gerrit-Change-Number: 44857 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Sep 2020 12:18:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in gerrit-avatars[master]: Add my avatar
by Scott Chao (Code Review) 01 Sep '20

01 Sep '20

Hello Jenny Ro, I'd like you to do a code review. Please visit https://review.coreboot.org/c/gerrit-avatars/+/44977 to review the following change. Change subject: Add my avatar ...................................................................... Add my avatar Signed-off-by: jennyro <jenny_ro(a)wistron.corp-partner.google.com> Change-Id: I5a4ec9887704e6cef82a25831b5f7eedb2cfaab8 --- A 1002712.jpg 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/gerrit-avatars refs/changes/77/44977/1 diff --git a/1002712.jpg b/1002712.jpg new file mode 100644 index 0000000..a05f7be --- /dev/null +++ b/1002712.jpg Binary files differ -- To view, visit https://review.coreboot.org/c/gerrit-avatars/+/44977 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: gerrit-avatars Gerrit-Branch: master Gerrit-Change-Id: I5a4ec9887704e6cef82a25831b5f7eedb2cfaab8 Gerrit-Change-Number: 44977 Gerrit-PatchSet: 1 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Jenny Ro <jenny_ro(a)wistron.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mainboard: add Dell Latitude E7240
by HAOUAS Elyes (Code Review) 01 Sep '20

01 Sep '20

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40300 ) Change subject: mainboard: add Dell Latitude E7240 ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/c/coreboot/+/40300/2/src/mainboard/dell/latitud… File src/mainboard/dell/latitude_e7240/Kconfig: https://review.coreboot.org/c/coreboot/+/40300/2/src/mainboard/dell/latitud… PS2, Line 6: select CPU_INTEL_HASWELL already selected by 'NORTHBRIDGE_INTEL_HASWELL' https://review.coreboot.org/c/coreboot/+/40300/2/src/mainboard/dell/latitud… PS2, Line 20: default dell/latitude_e7240 default "dell/latitude_e7240" -- To view, visit https://review.coreboot.org/c/coreboot/+/40300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6933bdbcc8d0bbb85d62657624740266284ac71c Gerrit-Change-Number: 40300 Gerrit-PatchSet: 2 Gerrit-Owner: Iru Cai (vimacs) <mytbk920423(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 01 Sep 2020 07:45:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mainboard: add Dell Latitude E7240
by Michał Żygowski (Code Review) 01 Sep '20

01 Sep '20

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40300 ) Change subject: mainboard: add Dell Latitude E7240 ...................................................................... Patch Set 2: Cool stuff. I have a Latitude 6430u I wanted to port, which have MEC5055 or MEC5054(?) too. Will gladly review it in free time. -- To view, visit https://review.coreboot.org/c/coreboot/+/40300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6933bdbcc8d0bbb85d62657624740266284ac71c Gerrit-Change-Number: 40300 Gerrit-PatchSet: 2 Gerrit-Owner: Iru Cai (vimacs) <mytbk920423(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 01 Sep 2020 07:36:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2020