Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45147 )
Change subject: treewide: rename GENERIC_SPD_BIN to HAVE_SPD_BIN_IN_CBFS
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45147
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4004c48da205949e05101039abd4cf32666787df
Gerrit-Change-Number: 45147
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 07 Sep 2020 12:28:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45146 )
Change subject: mb/*: drop GENERIC_SPD_BIN from boards not having soldered memory
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45146
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id05fe45007d5662ff9bee326f28470df1206fcff
Gerrit-Change-Number: 45146
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 07 Sep 2020 12:28:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45145 )
Change subject: lib/Kconfig: GENERIC_SPD_BIN: drop historic part of help text
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45145
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I603ab012760684021be1b5eca5d0ddff69463b79
Gerrit-Change-Number: 45145
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 07 Sep 2020 12:28:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Felix Singer, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Frans Hendriks, Jeremy Soller, Angel Pons, Patrick Rudolph, Piotr Król, Nico Huber, Michał Żygowski, David Guckian, Martin Roth, Vanessa Eusebio, Alexander Couzens, Wim Vervoorn,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44775
to look at the new patch set (#19).
Change subject: treewide: stop using hexdumps for spd files
......................................................................
treewide: stop using hexdumps for spd files
SPD files normally don't get edited. Keeping the files as hexdump does
not have any advantage and conversion from hex to bin adds complexity
with a high chance for bugs and other sorts of problems.
One example for such problem is an issue that only appeared on one of my
systems, where conversion of '01 02 03' to binary resulted in
\x01\x32\x03 instead of \x01\x02\x03:
for c in 01 02 03; do printf $(printf '\%o' 0x$c); done | xxd -g 1
00000000: 01 32 03 .2.
The reason for this was that the syntax in lib/Makefile.inc is wrong and
should have been `printf $(printf '\\%03o' 0x$c)`.
Instead of fixing this, we should remove some of the aforementioned
complexity to lower the probability of future encoding problems. Thus,
convert all spd hexdumps to binaries and adapt the Makefiles to just
concatenate them to `spd.bin`.
The SPDs, manifests and Makefiles for soc/intel/{tiger,jasper}lake and
mainboard/google/{dedede,volteer,zork} have been regenerated using the
following commands:
go run util/spd_tools/ddr4/gen_spd.go src/soc/intel/tigerlake/spd/ \
util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt TGL
go run util/spd_tools/lp4x/gen_spd.go src/soc/intel/tigerlake/spd/ \
util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt TGL
go run util/spd_tools/lp4x/gen_spd.go src/soc/intel/jasperlake/spd/ \
util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt JSL
for v in src/mainboard/google/zork/variants/*; do
[ -f ${v}/spd/mem_parts_used.txt ] || continue
go run util/spd_tools/ddr4/gen_part_id.go \
src/mainboard/google/zork/spd \
${v}/spd ${v}/spd/mem_parts_used.txt
done
for v in src/mainboard/google/{dedede,volteer}/variants/*; do
[ -f ${v}/memory/mem_list_variant.txt ] || continue
for m in ddr4 lp4x; do
go run ./util/spd_tools/${m}/gen_part_id.go \
src/soc/intel/tigerlake/spd ${v}/memory \
${v}/memory/mem_list_variant.txt
done
done
All other spd files have been converted with `grep -v "^#" | xxd -ps -r`
or `xxd -rg1`, depending on the format.
Documentation has been updated where needed.
For all affected boards the output binary has been verified to remain
identical, using timeless abuild.
Exception: google/volteer/variants/lindar will have an empty spd.bin
until CB:44848 gets merged.
Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de>
Change-Id: I0f24183a872924cddcfdf7587cc0c126da900f91
---
M .gitignore
M Documentation/Intel/Board/board.html
M Documentation/soc/amd/family17h.md
M src/lib/Kconfig
M src/lib/Makefile.inc
A src/mainboard/bap/ode_e20XX/spd/BAP_Q7_1066.spd.bin
D src/mainboard/bap/ode_e20XX/spd/BAP_Q7_1066.spd.hex
A src/mainboard/bap/ode_e20XX/spd/BAP_Q7_800.spd.bin
D src/mainboard/bap/ode_e20XX/spd/BAP_Q7_800.spd.hex
A src/mainboard/facebook/fbg1701/spd/KINGSTON_B5116ECMDXGGB.spd.bin
D src/mainboard/facebook/fbg1701/spd/KINGSTON_B5116ECMDXGGB.spd.hex
A src/mainboard/facebook/fbg1701/spd/MICRON_MT41K512M16HA-125A.spd.bin
D src/mainboard/facebook/fbg1701/spd/MICRON_MT41K512M16HA-125A.spd.hex
A src/mainboard/facebook/fbg1701/spd/SAMSUNG_K4B8G1646D-MYKO.spd.bin
D src/mainboard/facebook/fbg1701/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex
A src/mainboard/gizmosphere/gizmo/spd/Elpida_EDJ2116DEBG.spd.bin
D src/mainboard/gizmosphere/gizmo/spd/Elpida_EDJ2116DEBG.spd.hex
A src/mainboard/gizmosphere/gizmo2/spd/Micron_MT41J128M16JT.spd.bin
D src/mainboard/gizmosphere/gizmo2/spd/Micron_MT41J128M16JT.spd.hex
A src/mainboard/google/auron/variants/auron_paine/spd/Hynix_HMT425S6AFR6A.spd.bin
D src/mainboard/google/auron/variants/auron_paine/spd/Hynix_HMT425S6AFR6A.spd.hex
A src/mainboard/google/auron/variants/auron_paine/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.bin
D src/mainboard/google/auron/variants/auron_paine/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.hex
M src/mainboard/google/auron/variants/auron_paine/spd/Makefile.inc
A src/mainboard/google/auron/variants/auron_paine/spd/Micron_4KTF25664HZ.spd.bin
D src/mainboard/google/auron/variants/auron_paine/spd/Micron_4KTF25664HZ.spd.hex
A src/mainboard/google/auron/variants/auron_paine/spd/empty.spd.bin
D src/mainboard/google/auron/variants/auron_paine/spd/empty.spd.hex
A src/mainboard/google/auron/variants/auron_yuna/spd/Hynix_HMT425S6AFR6A.spd.bin
D src/mainboard/google/auron/variants/auron_yuna/spd/Hynix_HMT425S6AFR6A.spd.hex
A src/mainboard/google/auron/variants/auron_yuna/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.bin
D src/mainboard/google/auron/variants/auron_yuna/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.hex
M src/mainboard/google/auron/variants/auron_yuna/spd/Makefile.inc
A src/mainboard/google/auron/variants/auron_yuna/spd/Micron_4KTF25664HZ.spd.bin
D src/mainboard/google/auron/variants/auron_yuna/spd/Micron_4KTF25664HZ.spd.hex
A src/mainboard/google/auron/variants/auron_yuna/spd/empty.spd.bin
D src/mainboard/google/auron/variants/auron_yuna/spd/empty.spd.hex
A src/mainboard/google/auron/variants/gandof/spd/Hynix_HMT425S6AFR6A.spd.bin
D src/mainboard/google/auron/variants/gandof/spd/Hynix_HMT425S6AFR6A.spd.hex
A src/mainboard/google/auron/variants/gandof/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.bin
D src/mainboard/google/auron/variants/gandof/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.hex
M src/mainboard/google/auron/variants/gandof/spd/Makefile.inc
A src/mainboard/google/auron/variants/gandof/spd/Micron_4KTF25664HZ.spd.bin
D src/mainboard/google/auron/variants/gandof/spd/Micron_4KTF25664HZ.spd.hex
A src/mainboard/google/auron/variants/gandof/spd/Samsung_M471B5674EB0-YK0.spd.bin
D src/mainboard/google/auron/variants/gandof/spd/Samsung_M471B5674EB0-YK0.spd.hex
A src/mainboard/google/auron/variants/gandof/spd/empty.spd.bin
D src/mainboard/google/auron/variants/gandof/spd/empty.spd.hex
M src/mainboard/google/auron/variants/lulu/spd/Makefile.inc
A src/mainboard/google/auron/variants/lulu/spd/empty.spd.bin
D src/mainboard/google/auron/variants/lulu/spd/empty.spd.hex
A src/mainboard/google/auron/variants/lulu/spd/hynix_2GiB_dimm_H5TC4G63AFR-PBA.spd.bin
D src/mainboard/google/auron/variants/lulu/spd/hynix_2GiB_dimm_H5TC4G63AFR-PBA.spd.hex
A src/mainboard/google/auron/variants/lulu/spd/hynix_4GiB_dimm_H5TC8G63CMR-PBA.spd.bin
D src/mainboard/google/auron/variants/lulu/spd/hynix_4GiB_dimm_H5TC8G63CMR-PBA.spd.hex
A src/mainboard/google/auron/variants/lulu/spd/micron_2GiB_dimm_MT41K256M16HA-125.spd.bin
D src/mainboard/google/auron/variants/lulu/spd/micron_2GiB_dimm_MT41K256M16HA-125.spd.hex
A src/mainboard/google/auron/variants/lulu/spd/micron_4GiB_dimm_MT41K512M16TNA-125.spd.bin
D src/mainboard/google/auron/variants/lulu/spd/micron_4GiB_dimm_MT41K512M16TNA-125.spd.hex
A src/mainboard/google/auron/variants/lulu/spd/samsung_2GiB_dimm_K4B4G1646E-BYK0.spd.bin
D src/mainboard/google/auron/variants/lulu/spd/samsung_2GiB_dimm_K4B4G1646E-BYK0.spd.hex
A src/mainboard/google/auron/variants/lulu/spd/samsung_2GiB_dimm_K4B4G1646Q-HYK0.spd.bin
D src/mainboard/google/auron/variants/lulu/spd/samsung_2GiB_dimm_K4B4G1646Q-HYK0.spd.hex
A src/mainboard/google/auron/variants/lulu/spd/samsung_4GiB_dimm_K4B8G1646Q-MYK0.spd.bin
D src/mainboard/google/auron/variants/lulu/spd/samsung_4GiB_dimm_K4B8G1646Q-MYK0.spd.hex
M src/mainboard/google/auron/variants/samus/spd/Makefile.inc
A src/mainboard/google/auron/variants/samus/spd/elpida_16.spd.bin
D src/mainboard/google/auron/variants/samus/spd/elpida_16.spd.hex
A src/mainboard/google/auron/variants/samus/spd/elpida_4.spd.bin
D src/mainboard/google/auron/variants/samus/spd/elpida_4.spd.hex
A src/mainboard/google/auron/variants/samus/spd/elpida_8.spd.bin
D src/mainboard/google/auron/variants/samus/spd/elpida_8.spd.hex
A src/mainboard/google/auron/variants/samus/spd/empty.spd.bin
D src/mainboard/google/auron/variants/samus/spd/empty.spd.hex
A src/mainboard/google/auron/variants/samus/spd/hynix_16.spd.bin
D src/mainboard/google/auron/variants/samus/spd/hynix_16.spd.hex
A src/mainboard/google/auron/variants/samus/spd/hynix_4.spd.bin
D src/mainboard/google/auron/variants/samus/spd/hynix_4.spd.hex
A src/mainboard/google/auron/variants/samus/spd/hynix_8.spd.bin
D src/mainboard/google/auron/variants/samus/spd/hynix_8.spd.hex
A src/mainboard/google/auron/variants/samus/spd/samsung_4.spd.bin
D src/mainboard/google/auron/variants/samus/spd/samsung_4.spd.hex
A src/mainboard/google/auron/variants/samus/spd/samsung_8.spd.bin
D src/mainboard/google/auron/variants/samus/spd/samsung_8.spd.hex
A src/mainboard/google/cyan/spd/empty.spd.bin
D src/mainboard/google/cyan/spd/empty.spd.hex
A src/mainboard/google/cyan/spd/hynix_2GiB_dimm_H5TC4G63AFR-PBA.spd.bin
D src/mainboard/google/cyan/spd/hynix_2GiB_dimm_H5TC4G63AFR-PBA.spd.hex
A src/mainboard/google/cyan/spd/hynix_2GiB_dimm_H9CCNNN8GTMLAR-NUD.spd.bin
D src/mainboard/google/cyan/spd/hynix_2GiB_dimm_H9CCNNN8GTMLAR-NUD.spd.hex
A src/mainboard/google/cyan/spd/hynix_2GiB_dimm_HMT425S6CFR6A_H5TC4G63CFR.spd.bin
D src/mainboard/google/cyan/spd/hynix_2GiB_dimm_HMT425S6CFR6A_H5TC4G63CFR.spd.hex
A src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8GTALAR-NUD.spd.bin
D src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8GTALAR-NUD.spd.hex
A src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8GTMLAR-NUD.spd.bin
D src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8GTMLAR-NUD.spd.hex
A src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD-1G-1866.spd.bin
D src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD-1G-1866.spd.hex
A src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD.spd.bin
D src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD.spd.hex
A src/mainboard/google/cyan/spd/micron_2GiB_dimm_EDF8132A3MA-GD-F-R.spd.bin
D src/mainboard/google/cyan/spd/micron_2GiB_dimm_EDF8132A3MA-GD-F-R.spd.hex
A src/mainboard/google/cyan/spd/micron_2GiB_dimm_EDF8132A3MA-JD-F.spd.bin
D src/mainboard/google/cyan/spd/micron_2GiB_dimm_EDF8132A3MA-JD-F.spd.hex
A src/mainboard/google/cyan/spd/micron_2GiB_dimm_MT41K256M16TW-107.spd.bin
D src/mainboard/google/cyan/spd/micron_2GiB_dimm_MT41K256M16TW-107.spd.hex
A src/mainboard/google/cyan/spd/micron_2GiB_dimm_MT52L256M32D1PF-107WT.spd.bin
D src/mainboard/google/cyan/spd/micron_2GiB_dimm_MT52L256M32D1PF-107WT.spd.hex
A src/mainboard/google/cyan/spd/micron_2GiB_dimm_MT52L256M32D1PF.spd.bin
D src/mainboard/google/cyan/spd/micron_2GiB_dimm_MT52L256M32D1PF.spd.hex
A src/mainboard/google/cyan/spd/micron_dimm_MT52L256M32D1PF-107.spd.bin
D src/mainboard/google/cyan/spd/micron_dimm_MT52L256M32D1PF-107.spd.hex
A src/mainboard/google/cyan/spd/nanya_dimm_NT6CL256T32CM-H1.spd.bin
D src/mainboard/google/cyan/spd/nanya_dimm_NT6CL256T32CM-H1.spd.hex
A src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4B4G1646E-BYK0.spd.bin
D src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4B4G1646E-BYK0.spd.hex
A src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4B4G1646Q-HYK0.spd.bin
D src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4B4G1646Q-HYK0.spd.hex
A src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4E8E304EE-EGCE.spd.bin
D src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4E8E304EE-EGCE.spd.hex
A src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4E8E304EE-EGCF.spd.bin
D src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4E8E304EE-EGCF.spd.hex
A src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4E8E324EB-EGCF.spd.bin
D src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4E8E324EB-EGCF.spd.hex
A src/mainboard/google/cyan/spd/samsung_dimm_K4E8E304EE-EGCE.spd.bin
D src/mainboard/google/cyan/spd/samsung_dimm_K4E8E304EE-EGCE.spd.hex
A src/mainboard/google/cyan/spd/samsung_dimm_K4E8E304EE-EGCF.spd.bin
D src/mainboard/google/cyan/spd/samsung_dimm_K4E8E304EE-EGCF.spd.hex
A src/mainboard/google/cyan/spd/samsung_dimm_K4E8E324EB-EGCF.spd.bin
D src/mainboard/google/cyan/spd/samsung_dimm_K4E8E324EB-EGCF.spd.hex
M src/mainboard/google/dedede/spd/Makefile.inc
M src/mainboard/google/dedede/variants/boten/memory/Makefile.inc
M src/mainboard/google/dedede/variants/drawcia/memory/Makefile.inc
M src/mainboard/google/dedede/variants/madoo/memory/Makefile.inc
M src/mainboard/google/dedede/variants/magolor/memory/Makefile.inc
M src/mainboard/google/dedede/variants/waddledee/memory/Makefile.inc
M src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc
M src/mainboard/google/dedede/variants/wheelie/memory/Makefile.inc
M src/mainboard/google/drallion/spd/Makefile.inc
A src/mainboard/google/drallion/spd/empty_ddr4.spd.bin
D src/mainboard/google/drallion/spd/empty_ddr4.spd.hex
A src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.bin
D src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex
A src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NDJR-XNC.spd.bin
D src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NDJR-XNC.spd.hex
A src/mainboard/google/drallion/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.bin
D src/mainboard/google/drallion/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.hex
A src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KD-062EE.spd.bin
D src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KD-062EE.spd.hex
A src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KNR-075E.spd.bin
D src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KNR-075E.spd.hex
A src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16LY-075E.spd.bin
D src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16LY-075E.spd.hex
A src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16TB-062EJ.spd.bin
D src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex
A src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCTD.spd.bin
D src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCTD.spd.hex
A src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCWE.spd.bin
D src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCWE.spd.hex
A src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WA-BCWE.spd.bin
D src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WA-BCWE.spd.hex
A src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WB-MCTD.spd.bin
D src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WB-MCTD.spd.hex
A src/mainboard/google/eve/spd/empty.spd.bin
D src/mainboard/google/eve/spd/empty.spd.hex
A src/mainboard/google/eve/spd/hynix_dimm_H9CCNNN8GTALAR.spd.bin
D src/mainboard/google/eve/spd/hynix_dimm_H9CCNNN8GTALAR.spd.hex
A src/mainboard/google/eve/spd/hynix_dimm_H9CCNNNBJTALAR.spd.bin
D src/mainboard/google/eve/spd/hynix_dimm_H9CCNNNBJTALAR.spd.hex
A src/mainboard/google/eve/spd/hynix_dimm_H9CCNNNCLTMLAR.spd.bin
D src/mainboard/google/eve/spd/hynix_dimm_H9CCNNNCLTMLAR.spd.hex
A src/mainboard/google/eve/spd/samsung_dimm_K4E6E304EB.spd.bin
D src/mainboard/google/eve/spd/samsung_dimm_K4E6E304EB.spd.hex
A src/mainboard/google/eve/spd/samsung_dimm_K4E8E324EB.spd.bin
D src/mainboard/google/eve/spd/samsung_dimm_K4E8E324EB.spd.hex
A src/mainboard/google/eve/spd/samsung_dimm_K4EBE304EB.spd.bin
D src/mainboard/google/eve/spd/samsung_dimm_K4EBE304EB.spd.hex
A src/mainboard/google/glados/spd/empty.spd.bin
D src/mainboard/google/glados/spd/empty.spd.hex
A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8GTALAR.spd.bin
D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8GTALAR.spd.hex
A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8GTMLAR-NUD.spd.bin
D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8GTMLAR-NUD.spd.hex
A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8GTMLAR.spd.bin
D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8GTMLAR.spd.hex
A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD-1G-1866.spd.bin
D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD-1G-1866.spd.hex
A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8JTBLAR.spd.bin
D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8JTBLAR.spd.hex
A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBJTALAR.spd.bin
D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBJTALAR.spd.hex
A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBJTMLAR-NUD.spd.bin
D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBJTMLAR-NUD.spd.hex
A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBJTMLAR.spd.bin
D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBJTMLAR.spd.hex
A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBLTALAR.spd.bin
D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBLTALAR.spd.hex
A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBLTBLAR-NUD-2G-1866.spd.bin
D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBLTBLAR-NUD-2G-1866.spd.hex
A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNCLGALAR.spd.bin
D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNCLGALAR.spd.hex
A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNCLTMLAR.spd.bin
D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNCLTMLAR.spd.hex
A src/mainboard/google/glados/spd/micron_16GiB_dimm_MT52L1G32D4PG.spd.bin
D src/mainboard/google/glados/spd/micron_16GiB_dimm_MT52L1G32D4PG.spd.hex
A src/mainboard/google/glados/spd/micron_4GiB_dimm_MT52L256M32D1PF.spd.bin
D src/mainboard/google/glados/spd/micron_4GiB_dimm_MT52L256M32D1PF.spd.hex
A src/mainboard/google/glados/spd/micron_8GiB_dimm_MT52L512M32D2PF.spd.bin
D src/mainboard/google/glados/spd/micron_8GiB_dimm_MT52L512M32D2PF.spd.hex
A src/mainboard/google/glados/spd/micron_dimm_MT52L256M32D1PF-107-1G-1866.spd.bin
D src/mainboard/google/glados/spd/micron_dimm_MT52L256M32D1PF-107-1G-1866.spd.hex
A src/mainboard/google/glados/spd/micron_dimm_MT52L512M32D2PF-107-2G-1866.spd.bin
D src/mainboard/google/glados/spd/micron_dimm_MT52L512M32D2PF-107-2G-1866.spd.hex
A src/mainboard/google/glados/spd/samsung_dimm_K4E6E304EB-EGCF-2G-1866.spd.bin
D src/mainboard/google/glados/spd/samsung_dimm_K4E6E304EB-EGCF-2G-1866.spd.hex
A src/mainboard/google/glados/spd/samsung_dimm_K4E6E304EB-EGCF.spd.bin
D src/mainboard/google/glados/spd/samsung_dimm_K4E6E304EB-EGCF.spd.hex
A src/mainboard/google/glados/spd/samsung_dimm_K4E6E304EE-EGCF.spd.bin
D src/mainboard/google/glados/spd/samsung_dimm_K4E6E304EE-EGCF.spd.hex
A src/mainboard/google/glados/spd/samsung_dimm_K4E8E304EE-EGCE.spd.bin
D src/mainboard/google/glados/spd/samsung_dimm_K4E8E304EE-EGCE.spd.hex
A src/mainboard/google/glados/spd/samsung_dimm_K4E8E304EE-EGCF.spd.bin
D src/mainboard/google/glados/spd/samsung_dimm_K4E8E304EE-EGCF.spd.hex
A src/mainboard/google/glados/spd/samsung_dimm_K4E8E324EB-EGCF-1G-1866.spd.bin
D src/mainboard/google/glados/spd/samsung_dimm_K4E8E324EB-EGCF-1G-1866.spd.hex
A src/mainboard/google/glados/spd/samsung_dimm_K4E8E324EB-EGCF.spd.bin
D src/mainboard/google/glados/spd/samsung_dimm_K4E8E324EB-EGCF.spd.hex
A src/mainboard/google/glados/spd/samsung_dimm_K4EBE304EB-EGCF.spd.bin
D src/mainboard/google/glados/spd/samsung_dimm_K4EBE304EB-EGCF.spd.hex
A src/mainboard/google/glados/spd/samsung_dimm_K4EBE304EB-EGCG.spd.bin
D src/mainboard/google/glados/spd/samsung_dimm_K4EBE304EB-EGCG.spd.hex
A src/mainboard/google/hatch/spd/16G_2400.spd.bin
D src/mainboard/google/hatch/spd/16G_2400.spd.hex
A src/mainboard/google/hatch/spd/16G_2666.spd.bin
D src/mainboard/google/hatch/spd/16G_2666.spd.hex
A src/mainboard/google/hatch/spd/16G_2666_2bg.spd.bin
D src/mainboard/google/hatch/spd/16G_2666_2bg.spd.hex
A src/mainboard/google/hatch/spd/16G_3200.spd.bin
D src/mainboard/google/hatch/spd/16G_3200.spd.hex
A src/mainboard/google/hatch/spd/16G_3200_4bg.spd.bin
D src/mainboard/google/hatch/spd/16G_3200_4bg.spd.hex
A src/mainboard/google/hatch/spd/4G_2400.spd.bin
D src/mainboard/google/hatch/spd/4G_2400.spd.hex
A src/mainboard/google/hatch/spd/8G_2400.spd.bin
D src/mainboard/google/hatch/spd/8G_2400.spd.hex
A src/mainboard/google/hatch/spd/8G_2666.spd.bin
D src/mainboard/google/hatch/spd/8G_2666.spd.hex
A src/mainboard/google/hatch/spd/8G_3200.spd.bin
D src/mainboard/google/hatch/spd/8G_3200.spd.hex
A src/mainboard/google/hatch/spd/LP_16G_2133.spd.bin
D src/mainboard/google/hatch/spd/LP_16G_2133.spd.hex
A src/mainboard/google/hatch/spd/LP_4G_2133.spd.bin
D src/mainboard/google/hatch/spd/LP_4G_2133.spd.hex
A src/mainboard/google/hatch/spd/LP_8G_2133.spd.bin
D src/mainboard/google/hatch/spd/LP_8G_2133.spd.hex
A src/mainboard/google/hatch/spd/empty_ddr4.spd.bin
D src/mainboard/google/hatch/spd/empty_ddr4.spd.hex
A src/mainboard/google/kahlee/spd/empty.spd.bin
D src/mainboard/google/kahlee/spd/empty.spd.hex
A src/mainboard/google/kahlee/spd/hynix-H5AN8G6NAFR-UH.spd.bin
D src/mainboard/google/kahlee/spd/hynix-H5AN8G6NAFR-UH.spd.hex
A src/mainboard/google/kahlee/spd/hynix-H5AN8G6NCJR-VKC.spd.bin
D src/mainboard/google/kahlee/spd/hynix-H5AN8G6NCJR-VKC.spd.hex
A src/mainboard/google/kahlee/spd/hynix-H5AN8G6NCJR-XNC.spd.bin
D src/mainboard/google/kahlee/spd/hynix-H5AN8G6NCJR-XNC.spd.hex
A src/mainboard/google/kahlee/spd/hynix-H5ANAG6NAMR-UH.spd.bin
D src/mainboard/google/kahlee/spd/hynix-H5ANAG6NAMR-UH.spd.hex
A src/mainboard/google/kahlee/spd/hynix-H5ANAG6NCMR-VKC.spd.bin
D src/mainboard/google/kahlee/spd/hynix-H5ANAG6NCMR-VKC.spd.hex
A src/mainboard/google/kahlee/spd/hynix-H5ANAG6NCMR-XNC.spd.bin
D src/mainboard/google/kahlee/spd/hynix-H5ANAG6NCMR-XNC.spd.hex
A src/mainboard/google/kahlee/spd/micron-MT40A1G16KNR-075-E.spd.bin
D src/mainboard/google/kahlee/spd/micron-MT40A1G16KNR-075-E.spd.hex
A src/mainboard/google/kahlee/spd/micron-MT40A1G16RC-062E-B.spd.bin
D src/mainboard/google/kahlee/spd/micron-MT40A1G16RC-062E-B.spd.hex
A src/mainboard/google/kahlee/spd/micron-MT40A512M16JY-083E-B.spd.bin
D src/mainboard/google/kahlee/spd/micron-MT40A512M16JY-083E-B.spd.hex
A src/mainboard/google/kahlee/spd/micron-MT40A512M16LY-075-E.spd.bin
D src/mainboard/google/kahlee/spd/micron-MT40A512M16LY-075-E.spd.hex
A src/mainboard/google/kahlee/spd/micron-MT40A512M16TB-062E-J.spd.bin
D src/mainboard/google/kahlee/spd/micron-MT40A512M16TB-062E-J.spd.hex
A src/mainboard/google/kahlee/spd/samsung-K4A8G165WB-BCRC.spd.bin
D src/mainboard/google/kahlee/spd/samsung-K4A8G165WB-BCRC.spd.hex
A src/mainboard/google/kahlee/spd/samsung-K4A8G165WC-BCTD.spd.bin
D src/mainboard/google/kahlee/spd/samsung-K4A8G165WC-BCTD.spd.hex
A src/mainboard/google/kahlee/spd/samsung-K4A8G165WC-BCWE.spd.bin
D src/mainboard/google/kahlee/spd/samsung-K4A8G165WC-BCWE.spd.hex
A src/mainboard/google/kahlee/spd/samsung-K4AAG165WA-BCTD.spd.bin
D src/mainboard/google/kahlee/spd/samsung-K4AAG165WA-BCTD.spd.hex
A src/mainboard/google/kahlee/spd/samsung-K4AAG165WA-BCWE.spd.bin
D src/mainboard/google/kahlee/spd/samsung-K4AAG165WA-BCWE.spd.hex
A src/mainboard/google/kahlee/spd/samsung-K4AAG165WB-MCRC.spd.bin
D src/mainboard/google/kahlee/spd/samsung-K4AAG165WB-MCRC.spd.hex
A src/mainboard/google/kahlee/spd/samsung-K4AAG165WB-MCTD.spd.bin
D src/mainboard/google/kahlee/spd/samsung-K4AAG165WB-MCTD.spd.hex
A src/mainboard/google/link/spd/elpida_4Gb_1600_x16.spd.bin
D src/mainboard/google/link/spd/elpida_4Gb_1600_x16.spd.hex
A src/mainboard/google/link/spd/micron_4Gb_1600_1.35v_x16.spd.bin
D src/mainboard/google/link/spd/micron_4Gb_1600_1.35v_x16.spd.hex
A src/mainboard/google/link/spd/samsung_4Gb_1600_1.35v_x16.spd.bin
D src/mainboard/google/link/spd/samsung_4Gb_1600_1.35v_x16.spd.hex
M src/mainboard/google/poppy/spd/Makefile.inc
A src/mainboard/google/poppy/spd/empty.spd.bin
D src/mainboard/google/poppy/spd/empty.spd.hex
A src/mainboard/google/poppy/spd/empty_ddr4.spd.bin
D src/mainboard/google/poppy/spd/empty_ddr4.spd.hex
A src/mainboard/google/poppy/spd/hynix_dimm_H5AN4G6NAFR-UHC.spd.bin
D src/mainboard/google/poppy/spd/hynix_dimm_H5AN4G6NAFR-UHC.spd.hex
A src/mainboard/google/poppy/spd/hynix_dimm_H5AN4G6NBJR-UHC.spd.bin
D src/mainboard/google/poppy/spd/hynix_dimm_H5AN4G6NBJR-UHC.spd.hex
A src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NAFR-UHC.spd.bin
D src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NAFR-UHC.spd.hex
A src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.bin
D src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex
A src/mainboard/google/poppy/spd/hynix_dimm_H5ANAG6NAMR-UHC.spd.bin
D src/mainboard/google/poppy/spd/hynix_dimm_H5ANAG6NAMR-UHC.spd.hex
A src/mainboard/google/poppy/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.bin
D src/mainboard/google/poppy/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.hex
A src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNN8GTALAR-NUD.spd.bin
D src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNN8GTALAR-NUD.spd.hex
A src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBJTALAR-NUD.spd.bin
D src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBJTALAR-NUD.spd.hex
A src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.bin
D src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.hex
A src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNCLGALAR-NUD.spd.bin
D src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNCLGALAR-NUD.spd.hex
A src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNCLGALAR-NVD.spd.bin
D src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNCLGALAR-NVD.spd.hex
A src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNCPTALBR-NUD.spd.bin
D src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNCPTALBR-NUD.spd.hex
A src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNFAGMLLR-NUD.spd.bin
D src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNFAGMLLR-NUD.spd.hex
A src/mainboard/google/poppy/spd/micron_dimm_MT40A1G16KNR-075E.spd.bin
D src/mainboard/google/poppy/spd/micron_dimm_MT40A1G16KNR-075E.spd.hex
A src/mainboard/google/poppy/spd/micron_dimm_MT40A256M16GE-083E.spd.bin
D src/mainboard/google/poppy/spd/micron_dimm_MT40A256M16GE-083E.spd.hex
A src/mainboard/google/poppy/spd/micron_dimm_MT40A256M16LY-075F.spd.bin
D src/mainboard/google/poppy/spd/micron_dimm_MT40A256M16LY-075F.spd.hex
A src/mainboard/google/poppy/spd/micron_dimm_MT40A512M16LY-075E.spd.bin
D src/mainboard/google/poppy/spd/micron_dimm_MT40A512M16LY-075E.spd.hex
A src/mainboard/google/poppy/spd/micron_dimm_MT40A512M16TB-062EJ.spd.bin
D src/mainboard/google/poppy/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex
A src/mainboard/google/poppy/spd/micron_dimm_MT52L1G32D4PG-107.spd.bin
D src/mainboard/google/poppy/spd/micron_dimm_MT52L1G32D4PG-107.spd.hex
A src/mainboard/google/poppy/spd/micron_dimm_MT52L1G64D8QC-107.spd.bin
D src/mainboard/google/poppy/spd/micron_dimm_MT52L1G64D8QC-107.spd.hex
A src/mainboard/google/poppy/spd/micron_dimm_MT52L256M32D1PF-093.spd.bin
D src/mainboard/google/poppy/spd/micron_dimm_MT52L256M32D1PF-093.spd.hex
A src/mainboard/google/poppy/spd/micron_dimm_MT52L256M32D1PF-107.spd.bin
D src/mainboard/google/poppy/spd/micron_dimm_MT52L256M32D1PF-107.spd.hex
A src/mainboard/google/poppy/spd/micron_dimm_MT52L256M64D2PP-107.spd.bin
D src/mainboard/google/poppy/spd/micron_dimm_MT52L256M64D2PP-107.spd.hex
A src/mainboard/google/poppy/spd/micron_dimm_MT52L512M32D2PF-093.spd.bin
D src/mainboard/google/poppy/spd/micron_dimm_MT52L512M32D2PF-093.spd.hex
A src/mainboard/google/poppy/spd/micron_dimm_MT52L512M32D2PF-107.spd.bin
D src/mainboard/google/poppy/spd/micron_dimm_MT52L512M32D2PF-107.spd.hex
A src/mainboard/google/poppy/spd/micron_dimm_MT52L512M64D4PQ-107.spd.bin
D src/mainboard/google/poppy/spd/micron_dimm_MT52L512M64D4PQ-107.spd.hex
A src/mainboard/google/poppy/spd/nayna_dimm_NT6CL256T32CM-H1.spd.bin
D src/mainboard/google/poppy/spd/nayna_dimm_NT6CL256T32CM-H1.spd.hex
A src/mainboard/google/poppy/spd/samsung_dimm_K3QF3F30BM-AGCF.spd.bin
D src/mainboard/google/poppy/spd/samsung_dimm_K3QF3F30BM-AGCF.spd.hex
A src/mainboard/google/poppy/spd/samsung_dimm_K3QF4F40BM-AGCF.spd.bin
D src/mainboard/google/poppy/spd/samsung_dimm_K3QF4F40BM-AGCF.spd.hex
A src/mainboard/google/poppy/spd/samsung_dimm_K3QFAFA0CM-AGCF.spd.bin
D src/mainboard/google/poppy/spd/samsung_dimm_K3QFAFA0CM-AGCF.spd.hex
A src/mainboard/google/poppy/spd/samsung_dimm_K4A4G165WE-BCRC.spd.bin
D src/mainboard/google/poppy/spd/samsung_dimm_K4A4G165WE-BCRC.spd.hex
A src/mainboard/google/poppy/spd/samsung_dimm_K4A8G165WB-BCRC.spd.bin
D src/mainboard/google/poppy/spd/samsung_dimm_K4A8G165WB-BCRC.spd.hex
A src/mainboard/google/poppy/spd/samsung_dimm_K4A8G165WC-BCTD.spd.bin
D src/mainboard/google/poppy/spd/samsung_dimm_K4A8G165WC-BCTD.spd.hex
A src/mainboard/google/poppy/spd/samsung_dimm_K4AAG165WB-MCRC.spd.bin
D src/mainboard/google/poppy/spd/samsung_dimm_K4AAG165WB-MCRC.spd.hex
A src/mainboard/google/poppy/spd/samsung_dimm_K4E6E304EB-EGCF.spd.bin
D src/mainboard/google/poppy/spd/samsung_dimm_K4E6E304EB-EGCF.spd.hex
A src/mainboard/google/poppy/spd/samsung_dimm_K4E6E304EC-EGCF.spd.bin
D src/mainboard/google/poppy/spd/samsung_dimm_K4E6E304EC-EGCF.spd.hex
A src/mainboard/google/poppy/spd/samsung_dimm_K4E6E304ED-EGCG.spd.bin
D src/mainboard/google/poppy/spd/samsung_dimm_K4E6E304ED-EGCG.spd.hex
A src/mainboard/google/poppy/spd/samsung_dimm_K4E8E324EB-EGCF.spd.bin
D src/mainboard/google/poppy/spd/samsung_dimm_K4E8E324EB-EGCF.spd.hex
A src/mainboard/google/poppy/spd/samsung_dimm_K4E8E324ED-EGCG.spd.bin
D src/mainboard/google/poppy/spd/samsung_dimm_K4E8E324ED-EGCG.spd.hex
A src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EB-EGCG.spd.bin
D src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EB-EGCG.spd.hex
A src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EC-EGCF.spd.bin
D src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EC-EGCF.spd.hex
A src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EC-EGCG.spd.bin
D src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EC-EGCG.spd.hex
A src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304ED-EGCG.spd.bin
D src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304ED-EGCG.spd.hex
A src/mainboard/google/rambi/spd/HT_micron_HTTC4G63CFR-PBA_x16_4Gb.spd.bin
D src/mainboard/google/rambi/spd/HT_micron_HTTC4G63CFR-PBA_x16_4Gb.spd.hex
A src/mainboard/google/rambi/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.bin
D src/mainboard/google/rambi/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.hex
A src/mainboard/google/rambi/spd/Samsung_2Gib_K4B4G1646Q-HYK0.spd.bin
D src/mainboard/google/rambi/spd/Samsung_2Gib_K4B4G1646Q-HYK0.spd.hex
A src/mainboard/google/rambi/spd/Samsung_2Gib_M471B5674QH0.spd.bin
D src/mainboard/google/rambi/spd/Samsung_2Gib_M471B5674QH0.spd.hex
A src/mainboard/google/rambi/spd/elpida_2GiB_dimm_EDJ4216EFBG-GNL-F.spd.bin
D src/mainboard/google/rambi/spd/elpida_2GiB_dimm_EDJ4216EFBG-GNL-F.spd.hex
A src/mainboard/google/rambi/spd/empty.spd.bin
D src/mainboard/google/rambi/spd/empty.spd.hex
A src/mainboard/google/rambi/spd/hynix_1GiB_dimm_H5TC2G63FFR-PBA.spd.bin
D src/mainboard/google/rambi/spd/hynix_1GiB_dimm_H5TC2G63FFR-PBA.spd.hex
A src/mainboard/google/rambi/spd/hynix_2GiB_dimm_H5TC4G63AFR-PBA.spd.bin
D src/mainboard/google/rambi/spd/hynix_2GiB_dimm_H5TC4G63AFR-PBA.spd.hex
A src/mainboard/google/rambi/spd/hynix_2GiB_dimm_H5TC4G63CFR-PBA.spd.bin
D src/mainboard/google/rambi/spd/hynix_2GiB_dimm_H5TC4G63CFR-PBA.spd.hex
A src/mainboard/google/rambi/spd/hynix_2GiB_dimm_H5TC4G63MFR-PBA.spd.bin
D src/mainboard/google/rambi/spd/hynix_2GiB_dimm_H5TC4G63MFR-PBA.spd.hex
A src/mainboard/google/rambi/spd/micron_1GiB_dimm_MT41K128M16JT-125.spd.bin
D src/mainboard/google/rambi/spd/micron_1GiB_dimm_MT41K128M16JT-125.spd.hex
A src/mainboard/google/rambi/spd/micron_2GiB_dimm_MT41K256M16HA-125.spd.bin
D src/mainboard/google/rambi/spd/micron_2GiB_dimm_MT41K256M16HA-125.spd.hex
A src/mainboard/google/rambi/spd/micron_2GiB_dimm_MT41K256M16HA-125a.spd.bin
D src/mainboard/google/rambi/spd/micron_2GiB_dimm_MT41K256M16HA-125a.spd.hex
A src/mainboard/google/rambi/spd/micron_2GiB_dimm_MT41K256M16TW-107.spd.bin
D src/mainboard/google/rambi/spd/micron_2GiB_dimm_MT41K256M16TW-107.spd.hex
A src/mainboard/google/rambi/spd/samsung_1GiB_dimm_K4B2G1646Q-BYK0.spd.bin
D src/mainboard/google/rambi/spd/samsung_1GiB_dimm_K4B2G1646Q-BYK0.spd.hex
A src/mainboard/google/rambi/spd/samsung_2GiB_dimm_K4B4G1646E-BYK0.spd.bin
D src/mainboard/google/rambi/spd/samsung_2GiB_dimm_K4B4G1646E-BYK0.spd.hex
A src/mainboard/google/rambi/spd/samsung_2GiB_dimm_K4B4G1646Q-HYK0.spd.bin
D src/mainboard/google/rambi/spd/samsung_2GiB_dimm_K4B4G1646Q-HYK0.spd.hex
M src/mainboard/google/slippy/variants/falco/Makefile.inc
A src/mainboard/google/slippy/variants/falco/spd/Elpida_EDJ4216EFBG.spd.bin
D src/mainboard/google/slippy/variants/falco/spd/Elpida_EDJ4216EFBG.spd.hex
A src/mainboard/google/slippy/variants/falco/spd/Hynix_HMT425S6AFR6A.spd.bin
D src/mainboard/google/slippy/variants/falco/spd/Hynix_HMT425S6AFR6A.spd.hex
A src/mainboard/google/slippy/variants/falco/spd/Micron_4KTF25664HZ.spd.bin
D src/mainboard/google/slippy/variants/falco/spd/Micron_4KTF25664HZ.spd.hex
A src/mainboard/google/slippy/variants/falco/spd/Samsung_M471B5674QH0.spd.bin
D src/mainboard/google/slippy/variants/falco/spd/Samsung_M471B5674QH0.spd.hex
M src/mainboard/google/slippy/variants/leon/Makefile.inc
A src/mainboard/google/slippy/variants/leon/spd/Hynix_HMT425S6AFR6A.spd.bin
D src/mainboard/google/slippy/variants/leon/spd/Hynix_HMT425S6AFR6A.spd.hex
A src/mainboard/google/slippy/variants/leon/spd/Micron_4KTF25664HZ.spd.bin
D src/mainboard/google/slippy/variants/leon/spd/Micron_4KTF25664HZ.spd.hex
A src/mainboard/google/slippy/variants/leon/spd/Samsung_K4B4G1646Q.spd.bin
D src/mainboard/google/slippy/variants/leon/spd/Samsung_K4B4G1646Q.spd.hex
M src/mainboard/google/slippy/variants/peppy/Makefile.inc
A src/mainboard/google/slippy/variants/peppy/spd/Elpida_EDJ4216EFBG.spd.bin
D src/mainboard/google/slippy/variants/peppy/spd/Elpida_EDJ4216EFBG.spd.hex
A src/mainboard/google/slippy/variants/peppy/spd/Hynix_HMT425S6AFR6A.spd.bin
D src/mainboard/google/slippy/variants/peppy/spd/Hynix_HMT425S6AFR6A.spd.hex
A src/mainboard/google/slippy/variants/peppy/spd/Hynix_HMT425S6CFR6A.spd.bin
D src/mainboard/google/slippy/variants/peppy/spd/Hynix_HMT425S6CFR6A.spd.hex
A src/mainboard/google/slippy/variants/peppy/spd/Micron_4KTF25664HZ.spd.bin
D src/mainboard/google/slippy/variants/peppy/spd/Micron_4KTF25664HZ.spd.hex
M src/mainboard/google/slippy/variants/wolf/Makefile.inc
A src/mainboard/google/slippy/variants/wolf/spd/Hynix_HMT425S6AFR6A.spd.bin
D src/mainboard/google/slippy/variants/wolf/spd/Hynix_HMT425S6AFR6A.spd.hex
A src/mainboard/google/slippy/variants/wolf/spd/Micron_4KTF25664HZ.spd.bin
D src/mainboard/google/slippy/variants/wolf/spd/Micron_4KTF25664HZ.spd.hex
A src/mainboard/google/slippy/variants/wolf/spd/Samsung_K4B4G1646B.spd.bin
D src/mainboard/google/slippy/variants/wolf/spd/Samsung_K4B4G1646B.spd.hex
M src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc
M src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc
M src/mainboard/google/volteer/variants/elemi/memory/Makefile.inc
M src/mainboard/google/volteer/variants/halvor/memory/Makefile.inc
M src/mainboard/google/volteer/variants/malefor/memory/Makefile.inc
M src/mainboard/google/volteer/variants/terrador/memory/Makefile.inc
M src/mainboard/google/volteer/variants/todor/memory/Makefile.inc
M src/mainboard/google/volteer/variants/volteer/memory/Makefile.inc
M src/mainboard/google/volteer/variants/volteer2/memory/Makefile.inc
M src/mainboard/google/volteer/variants/voxel/memory/Makefile.inc
A src/mainboard/google/zork/spd/ddr4-spd-1.bin
D src/mainboard/google/zork/spd/ddr4-spd-1.hex
A src/mainboard/google/zork/spd/ddr4-spd-2.bin
D src/mainboard/google/zork/spd/ddr4-spd-2.hex
A src/mainboard/google/zork/spd/ddr4-spd-3.bin
D src/mainboard/google/zork/spd/ddr4-spd-3.hex
A src/mainboard/google/zork/spd/ddr4-spd-4.bin
D src/mainboard/google/zork/spd/ddr4-spd-4.hex
A src/mainboard/google/zork/spd/ddr4-spd-5.bin
D src/mainboard/google/zork/spd/ddr4-spd-5.hex
A src/mainboard/google/zork/spd/ddr4-spd-6.bin
D src/mainboard/google/zork/spd/ddr4-spd-6.hex
A src/mainboard/google/zork/spd/ddr4-spd-7.bin
D src/mainboard/google/zork/spd/ddr4-spd-7.hex
A src/mainboard/google/zork/spd/ddr4-spd-8.bin
D src/mainboard/google/zork/spd/ddr4-spd-8.hex
A src/mainboard/google/zork/spd/ddr4-spd-empty.bin
D src/mainboard/google/zork/spd/ddr4-spd-empty.hex
M src/mainboard/google/zork/spd/ddr4_spd_manifest.generated.txt
M src/mainboard/google/zork/variants/berknip/spd/Makefile.inc
M src/mainboard/google/zork/variants/dalboz/spd/Makefile.inc
M src/mainboard/google/zork/variants/dirinboz/spd/Makefile.inc
M src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc
M src/mainboard/google/zork/variants/morphius/spd/Makefile.inc
M src/mainboard/google/zork/variants/trembyle/spd/Makefile.inc
M src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc
M src/mainboard/google/zork/variants/woomax/spd/Makefile.inc
A src/mainboard/hp/snb_ivb_laptops/spd/hynix_4g.spd.bin
D src/mainboard/hp/snb_ivb_laptops/spd/hynix_4g.spd.hex
A src/mainboard/intel/cannonlake_rvp/spd/empty.spd.bin
D src/mainboard/intel/cannonlake_rvp/spd/empty.spd.hex
A src/mainboard/intel/cannonlake_rvp/spd/samsung_ddr4_4GB.spd.bin
D src/mainboard/intel/cannonlake_rvp/spd/samsung_ddr4_4GB.spd.hex
A src/mainboard/intel/cannonlake_rvp/spd/samsung_lpddr4_8GB.spd.bin
D src/mainboard/intel/cannonlake_rvp/spd/samsung_lpddr4_8GB.spd.hex
A src/mainboard/intel/harcuvar/spd/micron_4GiB_dimm_MTA9ASF51272PZ-2G1A2.spd.bin
D src/mainboard/intel/harcuvar/spd/micron_4GiB_dimm_MTA9ASF51272PZ-2G1A2.spd.hex
A src/mainboard/intel/icelake_rvp/spd/empty.spd.bin
D src/mainboard/intel/icelake_rvp/spd/empty.spd.hex
A src/mainboard/intel/icelake_rvp/spd/samsung_K4F6E304HBMGCJ.spd.bin
D src/mainboard/intel/icelake_rvp/spd/samsung_K4F6E304HBMGCJ.spd.hex
A src/mainboard/intel/jasperlake_rvp/spd/empty.spd.bin
D src/mainboard/intel/jasperlake_rvp/spd/empty.spd.hex
A src/mainboard/intel/jasperlake_rvp/spd/jslrvp.spd.bin
D src/mainboard/intel/jasperlake_rvp/spd/jslrvp.spd.hex
A src/mainboard/intel/kblrvp/spd/empty.spd.bin
D src/mainboard/intel/kblrvp/spd/empty.spd.hex
A src/mainboard/intel/kblrvp/spd/hynix_dimm_H9CCNNNBJTMLAR.spd.bin
D src/mainboard/intel/kblrvp/spd/hynix_dimm_H9CCNNNBJTMLAR.spd.hex
A src/mainboard/intel/kblrvp/spd/rvp3.spd.bin
D src/mainboard/intel/kblrvp/spd/rvp3.spd.hex
A src/mainboard/intel/kunimitsu/spd/empty.spd.bin
D src/mainboard/intel/kunimitsu/spd/empty.spd.hex
A src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNN8JTALAR-NUD-1G-1866.spd.bin
D src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNN8JTALAR-NUD-1G-1866.spd.hex
A src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD-1G-1866.spd.bin
D src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD-1G-1866.spd.hex
A src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNNBLTALAR-NUD-2G-1866.spd.bin
D src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNNBLTALAR-NUD-2G-1866.spd.hex
A src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNNBLTBLAR-NUD-2G-1866.spd.bin
D src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNNBLTBLAR-NUD-2G-1866.spd.hex
A src/mainboard/intel/kunimitsu/spd/mic_dimm_EDF8132A3MA-JD-F-1G-1866.spd.bin
D src/mainboard/intel/kunimitsu/spd/mic_dimm_EDF8132A3MA-JD-F-1G-1866.spd.hex
A src/mainboard/intel/kunimitsu/spd/samsung_dimm_K4E6E304EE-EGCF-2G-1866.spd.bin
D src/mainboard/intel/kunimitsu/spd/samsung_dimm_K4E6E304EE-EGCF-2G-1866.spd.hex
A src/mainboard/intel/kunimitsu/spd/samsung_dimm_K4E8E304EE-EGCE.spd.bin
D src/mainboard/intel/kunimitsu/spd/samsung_dimm_K4E8E304EE-EGCE.spd.hex
A src/mainboard/intel/kunimitsu/spd/samsung_dimm_K4E8E304EE-EGCF-1G-1866.spd.bin
D src/mainboard/intel/kunimitsu/spd/samsung_dimm_K4E8E304EE-EGCF-1G-1866.spd.hex
A src/mainboard/intel/tglrvp/spd/Hynix-H9HKNNNEBMAV-4267.spd.bin
D src/mainboard/intel/tglrvp/spd/Hynix-H9HKNNNEBMAV-4267.spd.hex
A src/mainboard/intel/tglrvp/spd/Micron-MT53D1G64D8SQ-046.spd.bin
D src/mainboard/intel/tglrvp/spd/Micron-MT53D1G64D8SQ-046.spd.hex
A src/mainboard/intel/tglrvp/spd/Samsung-K4UBE3D4AA-MGCL.spd.bin
D src/mainboard/intel/tglrvp/spd/Samsung-K4UBE3D4AA-MGCL.spd.hex
A src/mainboard/intel/tglrvp/spd/empty.spd.bin
D src/mainboard/intel/tglrvp/spd/empty.spd.hex
A src/mainboard/lenovo/s230u/spd/elpida_2gb.spd.bin
D src/mainboard/lenovo/s230u/spd/elpida_2gb.spd.hex
A src/mainboard/lenovo/s230u/spd/elpida_4gb.spd.bin
D src/mainboard/lenovo/s230u/spd/elpida_4gb.spd.hex
A src/mainboard/lenovo/s230u/spd/elpida_8gb.spd.bin
D src/mainboard/lenovo/s230u/spd/elpida_8gb.spd.hex
A src/mainboard/lenovo/s230u/spd/hynix_2gb.spd.bin
D src/mainboard/lenovo/s230u/spd/hynix_2gb.spd.hex
A src/mainboard/lenovo/s230u/spd/hynix_4gb.spd.bin
D src/mainboard/lenovo/s230u/spd/hynix_4gb.spd.hex
A src/mainboard/lenovo/s230u/spd/samsung_2gb.spd.bin
D src/mainboard/lenovo/s230u/spd/samsung_2gb.spd.hex
A src/mainboard/lenovo/s230u/spd/samsung_4gb.spd.bin
D src/mainboard/lenovo/s230u/spd/samsung_4gb.spd.hex
M src/mainboard/lenovo/t430s/variants/t431s/spd/Makefile.inc
A src/mainboard/lenovo/t430s/variants/t431s/spd/samsung_4gb.spd.bin
D src/mainboard/lenovo/t430s/variants/t431s/spd/samsung_4gb.spd.hex
A src/mainboard/lenovo/x1_carbon_gen1/spd/elpida.spd.bin
D src/mainboard/lenovo/x1_carbon_gen1/spd/elpida.spd.hex
A src/mainboard/lenovo/x1_carbon_gen1/spd/hynix.spd.bin
D src/mainboard/lenovo/x1_carbon_gen1/spd/hynix.spd.hex
A src/mainboard/lenovo/x1_carbon_gen1/spd/samsung.spd.bin
D src/mainboard/lenovo/x1_carbon_gen1/spd/samsung.spd.hex
A src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ2G83CFR.spd.bin
D src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ2G83CFR.spd.hex
A src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ4G83MFR.spd.bin
D src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ4G83MFR.spd.hex
A src/mainboard/pcengines/apu2/spd/HYNIX-2G-1333.spd.bin
D src/mainboard/pcengines/apu2/spd/HYNIX-2G-1333.spd.hex
A src/mainboard/pcengines/apu2/spd/HYNIX-4G-1333-ECC.spd.bin
D src/mainboard/pcengines/apu2/spd/HYNIX-4G-1333-ECC.spd.hex
A src/mainboard/portwell/m107/spd/KINGSTON_B5116ECMDXGGB.spd.bin
D src/mainboard/portwell/m107/spd/KINGSTON_B5116ECMDXGGB.spd.hex
A src/mainboard/portwell/m107/spd/MICRON_MT41K512M16HA-125A.spd.bin
D src/mainboard/portwell/m107/spd/MICRON_MT41K512M16HA-125A.spd.hex
A src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.bin
D src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex
A src/mainboard/razer/blade_stealth_kbl/spd/micron_dimm_MT52L1G32D4PG-107.spd.bin
D src/mainboard/razer/blade_stealth_kbl/spd/micron_dimm_MT52L1G32D4PG-107.spd.hex
A src/mainboard/razer/blade_stealth_kbl/spd/micron_dimm_MT52L512M32D2PF-107.spd.bin
D src/mainboard/razer/blade_stealth_kbl/spd/micron_dimm_MT52L512M32D2PF-107.spd.hex
A src/mainboard/samsung/lumpy/spd/lumpy.spd.bin
D src/mainboard/samsung/lumpy/spd/lumpy.spd.hex
A src/mainboard/system76/lemp9/spd/samsung-K4AAG165WA-BCTD.spd.bin
D src/mainboard/system76/lemp9/spd/samsung-K4AAG165WA-BCTD.spd.hex
M src/soc/amd/picasso/Makefile.inc
A src/soc/intel/jasperlake/spd/lp4x-spd-1.bin
D src/soc/intel/jasperlake/spd/lp4x-spd-1.hex
A src/soc/intel/jasperlake/spd/lp4x-spd-2.bin
D src/soc/intel/jasperlake/spd/lp4x-spd-2.hex
A src/soc/intel/jasperlake/spd/lp4x-spd-3.bin
D src/soc/intel/jasperlake/spd/lp4x-spd-3.hex
A src/soc/intel/jasperlake/spd/lp4x-spd-4.bin
D src/soc/intel/jasperlake/spd/lp4x-spd-4.hex
A src/soc/intel/jasperlake/spd/lp4x-spd-5.bin
D src/soc/intel/jasperlake/spd/lp4x-spd-5.hex
A src/soc/intel/jasperlake/spd/lp4x-spd-6.bin
D src/soc/intel/jasperlake/spd/lp4x-spd-6.hex
A src/soc/intel/jasperlake/spd/lp4x-spd-7.bin
D src/soc/intel/jasperlake/spd/lp4x-spd-7.hex
M src/soc/intel/jasperlake/spd/lp4x_spd_manifest.generated.txt
A src/soc/intel/tigerlake/spd/ddr4-spd-1.bin
D src/soc/intel/tigerlake/spd/ddr4-spd-1.hex
A src/soc/intel/tigerlake/spd/ddr4-spd-2.bin
D src/soc/intel/tigerlake/spd/ddr4-spd-2.hex
A src/soc/intel/tigerlake/spd/ddr4-spd-3.bin
D src/soc/intel/tigerlake/spd/ddr4-spd-3.hex
A src/soc/intel/tigerlake/spd/ddr4-spd-4.bin
D src/soc/intel/tigerlake/spd/ddr4-spd-4.hex
A src/soc/intel/tigerlake/spd/ddr4-spd-5.bin
D src/soc/intel/tigerlake/spd/ddr4-spd-5.hex
A src/soc/intel/tigerlake/spd/ddr4-spd-6.bin
D src/soc/intel/tigerlake/spd/ddr4-spd-6.hex
A src/soc/intel/tigerlake/spd/ddr4-spd-7.bin
D src/soc/intel/tigerlake/spd/ddr4-spd-7.hex
A src/soc/intel/tigerlake/spd/ddr4-spd-8.bin
D src/soc/intel/tigerlake/spd/ddr4-spd-8.hex
A src/soc/intel/tigerlake/spd/ddr4-spd-empty.bin
D src/soc/intel/tigerlake/spd/ddr4-spd-empty.hex
M src/soc/intel/tigerlake/spd/ddr4_spd_manifest.generated.txt
A src/soc/intel/tigerlake/spd/lp4x-spd-1.bin
D src/soc/intel/tigerlake/spd/lp4x-spd-1.hex
A src/soc/intel/tigerlake/spd/lp4x-spd-2.bin
D src/soc/intel/tigerlake/spd/lp4x-spd-2.hex
A src/soc/intel/tigerlake/spd/lp4x-spd-3.bin
D src/soc/intel/tigerlake/spd/lp4x-spd-3.hex
A src/soc/intel/tigerlake/spd/lp4x-spd-4.bin
D src/soc/intel/tigerlake/spd/lp4x-spd-4.hex
A src/soc/intel/tigerlake/spd/lp4x-spd-5.bin
D src/soc/intel/tigerlake/spd/lp4x-spd-5.hex
M src/soc/intel/tigerlake/spd/lp4x_spd_manifest.generated.txt
636 files changed, 182 insertions(+), 10,841 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/44775/19
--
To view, visit https://review.coreboot.org/c/coreboot/+/44775
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f24183a872924cddcfdf7587cc0c126da900f91
Gerrit-Change-Number: 44775
Gerrit-PatchSet: 19
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44545 )
Change subject: mb/ocp/deltalake: Add SMBIOS OEM string for SPD register vendor ID
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/44545
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15ab9b4c709eb97a03d6e08fe0bcdcb7f8607db0
Gerrit-Change-Number: 44545
Gerrit-PatchSet: 7
Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 07 Sep 2020 10:04:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44814 )
Change subject: Documentation: Add ASan documentation
......................................................................
Patch Set 6: Code-Review+1
(3 comments)
Thank you Harshit, this makes it more clear.
Just a few small things left before we merge this part.
https://review.coreboot.org/c/coreboot/+/44814/6/Documentation/technotes/as…
File Documentation/technotes/asan.md:
https://review.coreboot.org/c/coreboot/+/44814/6/Documentation/technotes/as…
PS6, Line 156: Let's subtract the
: start address of the stage from `ip`
For this, the start address of the stage is missing in your text, or? This address depends on where the stage relocator has put the entire stage at in the DRAM and is shown in the log. You should add this information here in order to allow the reader to follow your computation.
https://review.coreboot.org/c/coreboot/+/44814/6/Documentation/technotes/as…
PS6, Line 205: we
We (Start uppercase after the "Voilà!"?)
https://review.coreboot.org/c/coreboot/+/44814/6/Documentation/technotes/as…
PS6, Line 298:
Extra white space.
--
To view, visit https://review.coreboot.org/c/coreboot/+/44814
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I710ea495798597189941620c7e48fd5aa7476781
Gerrit-Change-Number: 44814
Gerrit-PatchSet: 6
Gerrit-Owner: Harshit Sharma <harshitsharmajs(a)gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 07 Sep 2020 05:03:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44545 )
Change subject: mb/ocp/deltalake: Add SMBIOS OEM string for SPD register vendor ID
......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44545/6/src/mainboard/ocp/deltalak…
File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/44545/6/src/mainboard/ocp/deltalak…
PS6, Line 73: #define SPD_REGVID_LEN 5
: /* Add leading zeros if needed to make it 4-digit long */
: static void string_fixup(uint16_t val, char *str)
: {
: if ((val & 0xffff) == 0)
: snprintf(str, SPD_REGVID_LEN, "0000");
: else if ((val & 0xfff0) == 0)
: snprintf(str, SPD_REGVID_LEN, "000%x", val);
: else if ((val & 0xff00) == 0)
: snprintf(str, SPD_REGVID_LEN, "00%x", val);
: else if ((val & 0xf000) == 0)
: snprintf(str, SPD_REGVID_LEN, "0%x", val);
: else
: snprintf(str, SPD_REGVID_LEN, "%x", val);
: }
> This can be simplified into a single line: […]
Done
https://review.coreboot.org/c/coreboot/+/44545/6/src/mainboard/ocp/deltalak…
PS6, Line 94: char *oem_str7 = NULL;
> If you initialize this to "" (empty string), then you don't need to specially handle the first loop […]
Done
https://review.coreboot.org/c/coreboot/+/44545/6/src/mainboard/ocp/deltalak…
PS6, Line 105: oem_str7 = strconcat(spd_reg_vid, " ");
> Instead of adding the space here, why not do it in the helper function above? That way, only one `st […]
Thanks for the suggestion.
--
To view, visit https://review.coreboot.org/c/coreboot/+/44545
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15ab9b4c709eb97a03d6e08fe0bcdcb7f8607db0
Gerrit-Change-Number: 44545
Gerrit-PatchSet: 7
Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 07 Sep 2020 00:54:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment