coreboot-gerrit September 2020

coreboot-gerrit@coreboot.org

1 participants
2629 discussions

Change in coreboot[master]: lib/Makefile.inc: fail build when SPD would be empty
by Angel Pons (Code Review) 07 Sep '20

07 Sep '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45131 ) Change subject: lib/Makefile.inc: fail build when SPD would be empty ...................................................................... Patch Set 6: Does anyone know which kind of memory (slotted or memory-down) Google Sushi and Google Trondo use? -- To view, visit https://review.coreboot.org/c/coreboot/+/45131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6db1dbe5fed5f242e408bcad4f36dda1b1fa1b4 Gerrit-Change-Number: 45131 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 07 Sep 2020 13:48:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: treewide: rename GENERIC_SPD_BIN to HAVE_SPD_BIN_IN_CBFS
by Angel Pons (Code Review) 07 Sep '20

07 Sep '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45147 ) Change subject: treewide: rename GENERIC_SPD_BIN to HAVE_SPD_BIN_IN_CBFS ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://review.coreboot.org/c/coreboot/+/45147/2/src/lib/Makefile.inc File src/lib/Makefile.inc: https://review.coreboot.org/c/coreboot/+/45147/2/src/lib/Makefile.inc@369 PS2, Line 369: $(CONFIG_HAVE_SPD_IN_CBFS) For another patch: This is within the ifeq block above, so it's always true -- To view, visit https://review.coreboot.org/c/coreboot/+/45147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4004c48da205949e05101039abd4cf32666787df Gerrit-Change-Number: 45147 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 07 Sep 2020 13:45:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/*: drop GENERIC_SPD_BIN from boards not having soldered memory
by Angel Pons (Code Review) 07 Sep '20

07 Sep '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45146 ) Change subject: mb/*: drop GENERIC_SPD_BIN from boards not having soldered memory ...................................................................... Patch Set 2: Code-Review+1 (9 comments) https://review.coreboot.org/c/coreboot/+/45146/2//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/45146/2//COMMIT_MSG@7 PS2, Line 7: not having without https://review.coreboot.org/c/coreboot/+/45146/2//COMMIT_MSG@10 PS2, Line 10: warning I see CB:45131 and "fail build" isn't just a warning https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/asrock/h110m… File src/mainboard/asrock/h110m/Kconfig: https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/asrock/h110m… PS2, Line 14: select GENERIC_SPD_BIN OK: Has DIMM slots https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/google/auron… File src/mainboard/google/auron/Kconfig: https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/google/auron… PS2, Line 18: select GENERIC_SPD_BIN OK: Buddy is a Chromebase and has DIMM slots: https://www.reddit.com/r/chrultrabook/comments/fyr0qm/acer_chromebase_24_bu… https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/google/fizz/… File src/mainboard/google/fizz/Kconfig: https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/google/fizz/… PS2, Line 25: select GENERIC_SPD_BIN OK: Fizz is a Chromebox (except Endeavour, which seems to be a server-like thing with TPUs). Also, it selects SPD_READ_BY_WORD https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/google/sarie… File src/mainboard/google/sarien/Kconfig: https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/google/sarie… PS2, Line 12: select GENERIC_SPD_BIN Seems to be correct, since this is mutually exclusive with SPD_READ_BY_WORD. However, there's no information about this thing anywhere. https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/intel/coffee… File src/mainboard/intel/coffeelake_rvp/Kconfig: https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/intel/coffee… PS2, Line 7: select GENERIC_SPD_BIN OK: RVPs often have DIMM slots. Plus, the current code only allows reading SPDs from SMBus https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/intel/saddle… File src/mainboard/intel/saddlebrook/Kconfig: https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/intel/saddle… PS2, Line 9: select GENERIC_SPD_BIN OK: Seems to have memory slots, but the only picture I could find of this board is tiny: https://autocad.space/wp-content/uploads/saddle_brook_small.png https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/prodrive/her… File src/mainboard/prodrive/hermes/Kconfig: https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/prodrive/her… PS2, Line 5: select GENERIC_SPD_BIN OK: Server board, has DIMM slots -- To view, visit https://review.coreboot.org/c/coreboot/+/45146 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id05fe45007d5662ff9bee326f28470df1206fcff Gerrit-Change-Number: 45146 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 07 Sep 2020 13:43:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/system76/lemp9: Enable SataPortsDevSlp
by Felix Singer (Code Review) 07 Sep '20

07 Sep '20

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45119 ) Change subject: mb/system76/lemp9: Enable SataPortsDevSlp ...................................................................... mb/system76/lemp9: Enable SataPortsDevSlp Enable SataPortsDevSlp for SATA ports 2 and 3. Change-Id: Id6c69f4a6fe45cb5c6aad3f42c741a2724c6166c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/45119/1 diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index 621a284..e455f18 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -141,7 +141,9 @@ register "SataMode" = "Sata_AHCI" register "SataSalpSupport" = "0" register "SataPortsEnable[1]" = "1" + register "SataPortsDevSlp[1]" = "1" register "SataPortsEnable[2]" = "1" + register "SataPortsDevSlp[2]" = "1" end device pci 19.0 off end # I2C #4 device pci 19.1 off end # I2C #5 -- To view, visit https://review.coreboot.org/c/coreboot/+/45119 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6c69f4a6fe45cb5c6aad3f42c741a2724c6166c Gerrit-Change-Number: 45119 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-MessageType: newchange

3 3

Change in coreboot[master]: util/spd_tools: output binaries instead of hexdumps
by Angel Pons (Code Review) 07 Sep '20

07 Sep '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44878 ) Change subject: util/spd_tools: output binaries instead of hexdumps ...................................................................... Patch Set 3: Code-Review+1 (2 comments) https://review.coreboot.org/c/coreboot/+/44878/3//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/44878/3//COMMIT_MSG@10 PS3, Line 10: file ending minor nit: I'd call this `file extension`. At first, I confused this with `line ending`, a completely different thing. https://review.coreboot.org/c/coreboot/+/44878/3/util/spd_tools/ddr4/gen_sp… File util/spd_tools/ddr4/gen_spd.go: https://review.coreboot.org/c/coreboot/+/44878/3/util/spd_tools/ddr4/gen_sp… PS3, Line 972: bytes.Buffer Probably not for this patch, but is there a way to tell Go this buffer is supposed to be 512 (or whatever) bytes in size? -- To view, visit https://review.coreboot.org/c/coreboot/+/44878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie99d108ca90758d09dbefad20fe6c9f7fc263ef1 Gerrit-Change-Number: 44878 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 07 Sep 2020 13:14:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/apcb_edit: fix handling of binary spd files
by Angel Pons (Code Review) 07 Sep '20

07 Sep '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44778 ) Change subject: util/apcb_edit: fix handling of binary spd files ...................................................................... Patch Set 8: Code-Review+1 (1 comment) Is this tool used as part of the build procedure for some board? https://review.coreboot.org/c/coreboot/+/44778/8//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/44778/8//COMMIT_MSG@7 PS8, Line 7: spd nit: I'd spell `SPD` in uppercase, as it's an acronym -- To view, visit https://review.coreboot.org/c/coreboot/+/44778 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b75a9e1234e71667bdc8cb4eb10daf8c0ac3c17 Gerrit-Change-Number: 44778 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 07 Sep 2020 13:06:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib/Kconfig: GENERIC_SPD_BIN: drop historic part of help text
by Angel Pons (Code Review) 07 Sep '20

07 Sep '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45145 ) Change subject: lib/Kconfig: GENERIC_SPD_BIN: drop historic part of help text ...................................................................... Patch Set 1: Code-Review+2 (2 comments) https://review.coreboot.org/c/coreboot/+/45145/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/45145/1//COMMIT_MSG@7 PS1, Line 7: GENERIC_SPD_BIN: drop historic part of help text I'd use `obsolete` instead of `historic`. To avoid having two levels of colons, I'd use: Drop obsolete help text from GENERIC_SPD_BIN https://review.coreboot.org/c/coreboot/+/45145/1//COMMIT_MSG@9 PS1, Line 9: 0e3c59e To allow Gerrit (and possibly other programs) to consider this as a short commit hash, prepend it with `commit`: commit 0e3c59e ^ see how it's a link? 😄 -- To view, visit https://review.coreboot.org/c/coreboot/+/45145 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I603ab012760684021be1b5eca5d0ddff69463b79 Gerrit-Change-Number: 45145 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 07 Sep 2020 13:05:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: treewide: rename GENERIC_SPD_BIN to HAVE_SPD_BIN_IN_CBFS
by Michael Niewöhner (Code Review) 07 Sep '20

07 Sep '20

Hello Felix Singer, build bot (Jenkins), Patrick Georgi, Frans Hendriks, Jeremy Soller, Paul Menzel, Angel Pons, Patrick Rudolph, Aaron Durbin, Piotr Król, Nico Huber, Michał Żygowski, David Guckian, Martin Roth, Vanessa Eusebio, Alexander Couzens, Wim Vervoorn, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45147 to look at the new patch set (#2). Change subject: treewide: rename GENERIC_SPD_BIN to HAVE_SPD_BIN_IN_CBFS ...................................................................... treewide: rename GENERIC_SPD_BIN to HAVE_SPD_BIN_IN_CBFS The name GENERIC_SPD_BIN doesn't reflect anymore what that config is used for, so rename it to HAVE_SPD_BIN_IN_CBFS. Change-Id: I4004c48da205949e05101039abd4cf32666787df Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/lib/Kconfig M src/lib/Makefile.inc M src/mainboard/bap/ode_e20XX/Kconfig M src/mainboard/facebook/fbg1701/Kconfig M src/mainboard/gizmosphere/gizmo/Kconfig M src/mainboard/gizmosphere/gizmo2/Kconfig M src/mainboard/google/auron/Kconfig M src/mainboard/google/cyan/Kconfig M src/mainboard/google/dedede/Kconfig M src/mainboard/google/drallion/Kconfig M src/mainboard/google/eve/Kconfig M src/mainboard/google/glados/Kconfig M src/mainboard/google/hatch/Kconfig M src/mainboard/google/kahlee/Kconfig M src/mainboard/google/link/Kconfig M src/mainboard/google/poppy/Kconfig M src/mainboard/google/rambi/Kconfig M src/mainboard/google/slippy/Kconfig M src/mainboard/google/volteer/Kconfig M src/mainboard/hp/snb_ivb_laptops/Kconfig.name M src/mainboard/intel/cannonlake_rvp/Kconfig M src/mainboard/intel/harcuvar/Kconfig M src/mainboard/intel/icelake_rvp/Kconfig M src/mainboard/intel/jasperlake_rvp/Kconfig M src/mainboard/intel/kblrvp/Kconfig M src/mainboard/intel/kunimitsu/Kconfig M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/lenovo/s230u/Kconfig M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/Kconfig M src/mainboard/pcengines/apu1/Kconfig M src/mainboard/pcengines/apu2/Kconfig M src/mainboard/portwell/m107/Kconfig M src/mainboard/razer/blade_stealth_kbl/Kconfig M src/mainboard/samsung/lumpy/Kconfig M src/mainboard/system76/lemp9/Kconfig 36 files changed, 39 insertions(+), 39 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/45147/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/45147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4004c48da205949e05101039abd4cf32666787df Gerrit-Change-Number: 45147 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/*: drop GENERIC_SPD_BIN from boards not having soldered memory
by Michael Niewöhner (Code Review) 07 Sep '20

07 Sep '20

Hello Felix Singer, build bot (Jenkins), Nico Huber, Patrick Georgi, Paul Menzel, Angel Pons, Aaron Durbin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45146 to look at the new patch set (#2). Change subject: mb/*: drop GENERIC_SPD_BIN from boards not having soldered memory ...................................................................... mb/*: drop GENERIC_SPD_BIN from boards not having soldered memory Some boards select GENERIC_SPD_BIN, despite having no soldered memory. Drop the option to silence the warning about empty SPD_SOURCES, that gets added in the follow-up change. TODO: these boards are unclear - src/mainboard/google/volteer/variants/trondo - src/mainboard/google/hatch/variants/sushi Change-Id: Id05fe45007d5662ff9bee326f28470df1206fcff Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/mainboard/asrock/h110m/Kconfig M src/mainboard/google/auron/Kconfig M src/mainboard/google/fizz/Kconfig M src/mainboard/google/sarien/Kconfig M src/mainboard/intel/coffeelake_rvp/Kconfig M src/mainboard/intel/saddlebrook/Kconfig M src/mainboard/prodrive/hermes/Kconfig 7 files changed, 1 insertion(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/45146/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/45146 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id05fe45007d5662ff9bee326f28470df1206fcff Gerrit-Change-Number: 45146 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/system76/lemp9: Move SATA options into devicetree
by Felix Singer (Code Review) 07 Sep '20

07 Sep '20

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45107 ) Change subject: mb/system76/lemp9: Move SATA options into devicetree ...................................................................... mb/system76/lemp9: Move SATA options into devicetree Change-Id: Idf64d98b36ca95a8bc17a6544993c26e23851cd8 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 6 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/45107/1 diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index 2e17a81..8576ee2 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -35,13 +35,6 @@ #register "enable_c6dram" = "1" # FSP Silicon (soc/intel/cannonlake/fsp_params.c) - # SATA - register "SataMode" = "Sata_AHCI" - register "SataSalpSupport" = "0" - - register "SataPortsEnable[1]" = "1" - register "SataPortsEnable[2]" = "1" - # Audio register "PchHdaDspEnable" = "0" register "PchHdaAudioLinkHda" = "1" @@ -172,7 +165,12 @@ register "Heci3Enabled" = "0" end device pci 16.5 off end # Management Engine Interface 4 - device pci 17.0 on end # SATA + device pci 17.0 on # SATA + register "SataMode" = "Sata_AHCI" + register "SataSalpSupport" = "0" + register "SataPortsEnable[1]" = "1" + register "SataPortsEnable[2]" = "1" + end device pci 19.0 off end # I2C #4 device pci 19.1 off end # I2C #5 device pci 19.2 on end # UART #2 -- To view, visit https://review.coreboot.org/c/coreboot/+/45107 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf64d98b36ca95a8bc17a6544993c26e23851cd8 Gerrit-Change-Number: 45107 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-MessageType: newchange

2 5

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2020