Hello Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/45812
to review the following change.
Change subject: amdfwtool: Use a variable to get the return value of write
......................................................................
amdfwtool: Use a variable to get the return value of write
New Jenkins complaint about the original code that return
value gets to nowhere. Fix that with a new variable.
Change-Id: I8099b856ccb751dc380d0e95f5fe319cc3e2c6cc
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M util/amdfwtool/amdfwtool.c
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/45812/1
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c
index f385068..30ef90b 100644
--- a/util/amdfwtool/amdfwtool.c
+++ b/util/amdfwtool/amdfwtool.c
@@ -1753,7 +1753,10 @@
targetfd = open(output, O_RDWR | O_CREAT | O_TRUNC, 0666);
if (targetfd >= 0) {
- write(targetfd, amd_romsig, ctx.current - romsig_offset);
+ ssize_t bytes;
+ bytes = write(targetfd, amd_romsig, ctx.current - romsig_offset);
+ if (bytes != ctx.current - romsig_offset)
+ retval = 1;
close(targetfd);
} else {
printf("Error: could not open file: %s\n", output);
--
To view, visit https://review.coreboot.org/c/coreboot/+/45812
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8099b856ccb751dc380d0e95f5fe319cc3e2c6cc
Gerrit-Change-Number: 45812
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-MessageType: newchange
Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35855 )
Change subject: asus/f2a85m_pro: Fix superio type in devicetree
......................................................................
asus/f2a85m_pro: Fix superio type in devicetree
The superio driver that was linked in is nct6779d but static
devicetree expected symbol superio_nuvoton_nct5572d_ops.
Change-Id: I648b7680bb39b9ff5b38cc3bd5147bd336e0b282
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
---
M src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/35855/1
diff --git a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb
index e261505..7637565 100644
--- a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb
+++ b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb
@@ -42,7 +42,7 @@
device pci 14.1 off end # unused
device pci 14.2 on end # HDA 0x4383
device pci 14.3 on # LPC 0x780e
- chip superio/nuvoton/nct5572d
+ chip superio/nuvoton/nct6779d
device pnp 2e.0 off end # FDC
device pnp 2e.1 off end # LPT1
device pnp 2e.2 on # COM1
--
To view, visit https://review.coreboot.org/c/coreboot/+/35855
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I648b7680bb39b9ff5b38cc3bd5147bd336e0b282
Gerrit-Change-Number: 35855
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-MessageType: newchange
Marc Jones has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45834 )
Change subject: soc/intel/xeon_sp/acpi: Rename pci_irq.asl
......................................................................
soc/intel/xeon_sp/acpi: Rename pci_irq.asl
Rename pci_irq.asl to pci_irqs.asl to match other intel soc file
names. This makes comparing differences much easier.
Change-Id: I622dfef675c3df2dff7a3024ccbe14c356a5cd86
Signed-off-by: Marc Jones <marcjones(a)sysproconsulting.com>
---
R src/soc/intel/xeon_sp/acpi/pci_irqs.asl
M src/soc/intel/xeon_sp/acpi/uncore.asl
2 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/45834/1
diff --git a/src/soc/intel/xeon_sp/acpi/pci_irq.asl b/src/soc/intel/xeon_sp/acpi/pci_irqs.asl
similarity index 100%
rename from src/soc/intel/xeon_sp/acpi/pci_irq.asl
rename to src/soc/intel/xeon_sp/acpi/pci_irqs.asl
diff --git a/src/soc/intel/xeon_sp/acpi/uncore.asl b/src/soc/intel/xeon_sp/acpi/uncore.asl
index b1b5f6c..236ae75 100644
--- a/src/soc/intel/xeon_sp/acpi/uncore.asl
+++ b/src/soc/intel/xeon_sp/acpi/uncore.asl
@@ -26,7 +26,7 @@
Scope (\_SB)
{
- #include "pci_irq.asl"
+ #include "pci_irqs.asl"
#include "uncore_irq.asl"
#include "iiostack.asl"
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/45834
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I622dfef675c3df2dff7a3024ccbe14c356a5cd86
Gerrit-Change-Number: 45834
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newchange