Tim Chu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41604 )
Change subject: mb/ocp/tiogapass: Implement set POST start/end command
......................................................................
mb/ocp/tiogapass: Implement set POST start/end command
Implemented sending POST start and POST end command to BMC in ramstage.
Tested=Read POST command in OpenBMC,
if success message may show as below,
root@bmc:~# cat /var/log/messages |grep -i "POST"
Aug 10 00:11:24 bmc user.info ipmid: POST Start Event for Payload#1
Aug 10 00:11:28 bmc user.info ipmid: POST End Event for Payload#1
root@bmc:~#
Signed-off-by: TimChu <Tim.Chu(a)quantatw.com>
Change-Id: Ia283c5e8d539bfeb47a73d32d8bfb5e666f27170
---
M src/mainboard/ocp/tiogapass/Kconfig
M src/mainboard/ocp/tiogapass/devicetree.cb
2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/41604/1
diff --git a/src/mainboard/ocp/tiogapass/Kconfig b/src/mainboard/ocp/tiogapass/Kconfig
index 5cb2421..2ec47ed 100644
--- a/src/mainboard/ocp/tiogapass/Kconfig
+++ b/src/mainboard/ocp/tiogapass/Kconfig
@@ -9,6 +9,7 @@
select HAVE_ACPI_TABLES
select MAINBOARD_USES_FSP2_0
select IPMI_KCS
+ select IPMI_OCP
select SOC_INTEL_SKYLAKE_SP
select SUPERIO_ASPEED_AST2400
diff --git a/src/mainboard/ocp/tiogapass/devicetree.cb b/src/mainboard/ocp/tiogapass/devicetree.cb
index 19dba55..35e74b0 100644
--- a/src/mainboard/ocp/tiogapass/devicetree.cb
+++ b/src/mainboard/ocp/tiogapass/devicetree.cb
@@ -77,6 +77,9 @@
register "bmc_i2c_address" = "0x20"
register "bmc_boot_timeout" = "60"
end
+ chip drivers/ocp/ipmi # OCP specific IPMI porting
+ device pnp ca2.1 on end
+ end
end # Intel Corporation C621 Series Chipset LPC/eSPI Controller
device pci 1f.2 on end # Intel Corporation C620 Series Chipset Family Power Management Controller
device pci 1f.4 on end # Intel Corporation C620 Series Chipset Family SMBus
--
To view, visit https://review.coreboot.org/c/coreboot/+/41604
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia283c5e8d539bfeb47a73d32d8bfb5e666f27170
Gerrit-Change-Number: 41604
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-MessageType: newchange
Paul Fagerburg has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES
......................................................................
templates: add an empty SPD to SPD_SOURCES
Add an empty SPD in SPD_SOURCES when creating a new variant of hatch, volteer,
waddledee, or waddledoo, so that coreboot can build successfully.
For variants that use spd_tools, add an empty mem_parts_used.txt so that
the developer can add the supported memory parts and regenerate the
Makefile.inc with the correct SPD references.
BUG=b:169422833
TEST=create a new variant of hatch, volteer, waddledee, and waddledoo, and
observe that each one succeeds.
Signed-off-by: Paul Fagerburg <pfagerburg(a)google.com>
Change-Id: I06dfb6103701bf8949180595f1e98fac48bcc585
---
M util/mainboard/google/hatch/template/Makefile.inc
A util/mainboard/google/volteer/template/memory/Makefile.inc
A util/mainboard/google/volteer/template/memory/dram_id.generated.txt
A util/mainboard/google/volteer/template/memory/mem_parts_used.txt
A util/mainboard/google/waddledee/template/memory/Makefile.inc
A util/mainboard/google/waddledee/template/memory/dram_id.generated.txt
A util/mainboard/google/waddledee/template/memory/mem_parts_used.txt
A util/mainboard/google/waddledoo/template/memory/Makefile.inc
A util/mainboard/google/waddledoo/template/memory/dram_id.generated.txt
A util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt
10 files changed, 48 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/45746/1
diff --git a/util/mainboard/google/hatch/template/Makefile.inc b/util/mainboard/google/hatch/template/Makefile.inc
index 61b23ed..599cfcc 100644
--- a/util/mainboard/google/hatch/template/Makefile.inc
+++ b/util/mainboard/google/hatch/template/Makefile.inc
@@ -1,4 +1,6 @@
##
## SPDX-License-Identifier: GPL-2.0-only
-SPD_SOURCES =
+## TODO engineer creating a new variant needs to add SPDs for memory parts
+
+SPD_SOURCES = empty_ddr4
diff --git a/util/mainboard/google/volteer/template/memory/Makefile.inc b/util/mainboard/google/volteer/template/memory/Makefile.inc
new file mode 100644
index 0000000..3edeb96
--- /dev/null
+++ b/util/mainboard/google/volteer/template/memory/Makefile.inc
@@ -0,0 +1,5 @@
+## SPDX-License-Identifier: GPL-2.0-or-later
+## This is an auto-generated file. Do not edit!!
+## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
+
+SPD_SOURCES = ddr4-spd-empty.hex
diff --git a/util/mainboard/google/volteer/template/memory/dram_id.generated.txt b/util/mainboard/google/volteer/template/memory/dram_id.generated.txt
new file mode 100644
index 0000000..fa24790
--- /dev/null
+++ b/util/mainboard/google/volteer/template/memory/dram_id.generated.txt
@@ -0,0 +1 @@
+DRAM Part Name ID to assign
diff --git a/util/mainboard/google/volteer/template/memory/mem_parts_used.txt b/util/mainboard/google/volteer/template/memory/mem_parts_used.txt
new file mode 100644
index 0000000..106a705
--- /dev/null
+++ b/util/mainboard/google/volteer/template/memory/mem_parts_used.txt
@@ -0,0 +1,9 @@
+# This is a CSV file containing a list of memory parts used by this variant.
+# One part per line with an optional fixed ID in column 2.
+# Only include a fixed ID if it is required for legacy reasons!
+# Each part must also be listed in util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt.
+# Generate an updated Makefile.inc and dram_id.generated.txt by running the
+# gen_part_id tool from util/spd_tools/ddr4.
+# See util/spd_tools/ddr4/README.md for more details and instructions.
+
+# Part Name, Fixed ID (optional)
diff --git a/util/mainboard/google/waddledee/template/memory/Makefile.inc b/util/mainboard/google/waddledee/template/memory/Makefile.inc
new file mode 100644
index 0000000..3edeb96
--- /dev/null
+++ b/util/mainboard/google/waddledee/template/memory/Makefile.inc
@@ -0,0 +1,5 @@
+## SPDX-License-Identifier: GPL-2.0-or-later
+## This is an auto-generated file. Do not edit!!
+## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
+
+SPD_SOURCES = ddr4-spd-empty.hex
diff --git a/util/mainboard/google/waddledee/template/memory/dram_id.generated.txt b/util/mainboard/google/waddledee/template/memory/dram_id.generated.txt
new file mode 100644
index 0000000..fa24790
--- /dev/null
+++ b/util/mainboard/google/waddledee/template/memory/dram_id.generated.txt
@@ -0,0 +1 @@
+DRAM Part Name ID to assign
diff --git a/util/mainboard/google/waddledee/template/memory/mem_parts_used.txt b/util/mainboard/google/waddledee/template/memory/mem_parts_used.txt
new file mode 100644
index 0000000..106a705
--- /dev/null
+++ b/util/mainboard/google/waddledee/template/memory/mem_parts_used.txt
@@ -0,0 +1,9 @@
+# This is a CSV file containing a list of memory parts used by this variant.
+# One part per line with an optional fixed ID in column 2.
+# Only include a fixed ID if it is required for legacy reasons!
+# Each part must also be listed in util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt.
+# Generate an updated Makefile.inc and dram_id.generated.txt by running the
+# gen_part_id tool from util/spd_tools/ddr4.
+# See util/spd_tools/ddr4/README.md for more details and instructions.
+
+# Part Name, Fixed ID (optional)
diff --git a/util/mainboard/google/waddledoo/template/memory/Makefile.inc b/util/mainboard/google/waddledoo/template/memory/Makefile.inc
new file mode 100644
index 0000000..3edeb96
--- /dev/null
+++ b/util/mainboard/google/waddledoo/template/memory/Makefile.inc
@@ -0,0 +1,5 @@
+## SPDX-License-Identifier: GPL-2.0-or-later
+## This is an auto-generated file. Do not edit!!
+## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
+
+SPD_SOURCES = ddr4-spd-empty.hex
diff --git a/util/mainboard/google/waddledoo/template/memory/dram_id.generated.txt b/util/mainboard/google/waddledoo/template/memory/dram_id.generated.txt
new file mode 100644
index 0000000..fa24790
--- /dev/null
+++ b/util/mainboard/google/waddledoo/template/memory/dram_id.generated.txt
@@ -0,0 +1 @@
+DRAM Part Name ID to assign
diff --git a/util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt b/util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt
new file mode 100644
index 0000000..106a705
--- /dev/null
+++ b/util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt
@@ -0,0 +1,9 @@
+# This is a CSV file containing a list of memory parts used by this variant.
+# One part per line with an optional fixed ID in column 2.
+# Only include a fixed ID if it is required for legacy reasons!
+# Each part must also be listed in util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt.
+# Generate an updated Makefile.inc and dram_id.generated.txt by running the
+# gen_part_id tool from util/spd_tools/ddr4.
+# See util/spd_tools/ddr4/README.md for more details and instructions.
+
+# Part Name, Fixed ID (optional)
--
To view, visit https://review.coreboot.org/c/coreboot/+/45746
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06dfb6103701bf8949180595f1e98fac48bcc585
Gerrit-Change-Number: 45746
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-MessageType: newchange