Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45037 )
Change subject: soc/intel/icelake: Select CPU_INTEL_COMMON
......................................................................
soc/intel/icelake: Select CPU_INTEL_COMMON
This is necessary to show the prompt for ENABLE_VMX, whose value is
written to a FSP UPD. Otherwise, it is always set to zero.
Drop CPU_INTEL_COMMON_SMM since CPU_INTEL_COMMON enables it by default.
Tested with BUILD_TIMELESS=1: Without including the config file in the
coreboot.rom and ENABLE_VMX not selected, the resulting binary remains
identical. Selecting ENABLE_VMX changes a single byte from 0x00 to 0x01.
Change-Id: I9b0ca209b60f9804b8f56497046eff96da01cb5c
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M src/soc/intel/icelake/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/45037/1
diff --git a/src/soc/intel/icelake/Kconfig b/src/soc/intel/icelake/Kconfig
index 1230675..2aeb6d6 100644
--- a/src/soc/intel/icelake/Kconfig
+++ b/src/soc/intel/icelake/Kconfig
@@ -15,6 +15,7 @@
select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY if BOOT_DEVICE_SPI_FLASH
select BOOT_DEVICE_SUPPORTS_WRITES
select CACHE_MRC_SETTINGS
+ select CPU_INTEL_COMMON
select CPU_INTEL_FIRMWARE_INTERFACE_TABLE
select FSP_M_XIP
select GENERIC_GPIO_LIB
@@ -34,7 +35,6 @@
select FSP_PEIM_TO_PEIM_INTERFACE
select REG_SCRIPT
select PMC_GLOBAL_RESET_ENABLE_LOCK
- select CPU_INTEL_COMMON_SMM
select SOC_INTEL_COMMON
select SOC_INTEL_COMMON_ACPI_WAKE_SOURCE
select SOC_INTEL_COMMON_BLOCK
--
To view, visit https://review.coreboot.org/c/coreboot/+/45037
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b0ca209b60f9804b8f56497046eff96da01cb5c
Gerrit-Change-Number: 45037
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newchange
Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45820 )
Change subject: cpu/qemu-x86/cache_as_ram_bootblock: Fix wrong instruction
......................................................................
cpu/qemu-x86/cache_as_ram_bootblock: Fix wrong instruction
The shld instruction does an arithmetic shift left on 64bit operants,
but it's not the instruction we want, because what it actually does is
shifting by cl, and storing the result in address 32.
This wasn't notices as the DRAM is up and address 32 is valid. On real
hardware when CAR is running this instruction would cause a crash.
Replace the instruction with the correct 64bit arithmetic left shift.
Change-Id: Iedad9f4b693b1ea05898456eac2050a9389f6f19
Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
---
M src/cpu/qemu-x86/cache_as_ram_bootblock.S
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/45820/1
diff --git a/src/cpu/qemu-x86/cache_as_ram_bootblock.S b/src/cpu/qemu-x86/cache_as_ram_bootblock.S
index 415ed24..eb7d2d9 100644
--- a/src/cpu/qemu-x86/cache_as_ram_bootblock.S
+++ b/src/cpu/qemu-x86/cache_as_ram_bootblock.S
@@ -30,7 +30,7 @@
/* Restore the BIST result and timestamps. */
#if defined(__x86_64__)
movd %mm2, %rdi
- shld %rdi, 32
+ shlq $32, %rdi
movd %mm1, %rsi
or %rsi, %rdi
--
To view, visit https://review.coreboot.org/c/coreboot/+/45820
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iedad9f4b693b1ea05898456eac2050a9389f6f19
Gerrit-Change-Number: 45820
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-MessageType: newchange