Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42708 )
Change subject: AGESA fam14: Use AMD_ACPIMMIO_GPIO_BASE_100
......................................................................
Patch Set 3: Code-Review+1
Could you please add a comment in src/soc/amd/common/block/include/amdblocks/acpimmio_map.h describing this only applies to certain families? That macro is not correct for all chipsets.
--
To view, visit https://review.coreboot.org/c/coreboot/+/42708
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29fbc82fffc69b864adb4ddbda1425db98e2e48a
Gerrit-Change-Number: 42708
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 25 Jun 2020 05:27:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42486 )
Change subject: Revert "soc/amd/common/block/acpimmio: Update acpimmio for psp_verstage"
......................................................................
Patch Set 5:
Shouldn't we combine this w/ a resulting full solution? I suspect we should let Martin's series land then modify files as needed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/42486
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d632f52745bc6cd3c3dbddb1ea5ff9ba962c2e8
Gerrit-Change-Number: 42486
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 25 Jun 2020 05:23:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42692 )
Change subject: soc/amd/common: Avoid aliasing on ACPIMMIO writes
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/42692
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7369b8b07a23e9b52c2961c527dc8d29ad4b505b
Gerrit-Change-Number: 42692
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 25 Jun 2020 04:46:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42691 )
Change subject: soc/amd/common: Refactor single GPIO programming
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/42691
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7aa6bd6996fd14dde4b1abcccbd2ae6ef933c87b
Gerrit-Change-Number: 42691
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 25 Jun 2020 04:46:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42690 )
Change subject: soc/amd/common: Complete ACPIMMIO GPIO bank separation
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/42690
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c8c3f2028ca89dca5c7f0548fcd18e1045999d6
Gerrit-Change-Number: 42690
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 25 Jun 2020 04:46:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42689 )
Change subject: [WIP,RFC] soc/amd/common: Move sb_reset_i2c_slaves()
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/42689
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e761236fc0602babb9a96956b143ecd0d2c61de
Gerrit-Change-Number: 42689
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 25 Jun 2020 04:46:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42733 )
Change subject: [WIP] sb/amd/pi/hudson: Fixes for common GPIO API
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/42733
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86ae40a3cdf335263d7e9e3dcfdd588947cdd9b1
Gerrit-Change-Number: 42733
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 25 Jun 2020 04:46:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment