Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37441 )
Change subject: mb/supermicro/x11-lga1151v2-series: Add support for X11SCH-F
......................................................................
Patch Set 57:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37441/51//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37441/51//COMMIT_MSG@23
PS51, Line 23: 84
> decimal
No it's hex.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37441
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ab1cb9462607b9af068bc2374508d99c60d0a30
Gerrit-Change-Number: 37441
Gerrit-PatchSet: 57
Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Guido Beyer @ Prodrive Technologies <guido.beyer(a)prodrive-technologies.com>
Gerrit-Reviewer: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Stef van Os <stef.van.os(a)prodrive-technologies.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: wouter.eckhardt(a)prodrive-technologies.com
Gerrit-CC: Jonas Löffelholz
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 25 Jun 2020 07:16:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonas Löffelholz
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42793 )
Change subject: lib: Add a function to print hex dump with prefix
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42793/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42793/2//COMMIT_MSG@12
PS2, Line 12: around the location where a memory bug is found.
So the prefix before was the pointer address(?), and now instead of it, a custom prefix can be added?
--
To view, visit https://review.coreboot.org/c/coreboot/+/42793
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I94869b10cd2d388a39cd5d86b1db936eff5473fa
Gerrit-Change-Number: 42793
Gerrit-PatchSet: 2
Gerrit-Owner: Harshit Sharma <harshitsharmajs(a)gmail.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 25 Jun 2020 06:19:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Harshit Sharma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42793 )
Change subject: lib: Add a function to print hex dump with prefix
......................................................................
Patch Set 2:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/42793
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I94869b10cd2d388a39cd5d86b1db936eff5473fa
Gerrit-Change-Number: 42793
Gerrit-PatchSet: 2
Gerrit-Owner: Harshit Sharma <harshitsharmajs(a)gmail.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 25 Jun 2020 06:13:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42691 )
Change subject: soc/amd/common: Refactor single GPIO programming
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42691/4/src/soc/amd/common/block/g…
File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42691/4/src/soc/amd/common/block/g…
PS4, Line 216: if (gev_tbl == NULL)
I'm sorry I'm currently being lazy. Could we lift the logic exactly in one patch and then modify accordingly to see the diff? I understand if you don't want to. I'll just need to come back w/ more scrutiny later. general approach looks good to me: let the compiler optimize whatever it wants and make things more readable.
--
To view, visit https://review.coreboot.org/c/coreboot/+/42691
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7aa6bd6996fd14dde4b1abcccbd2ae6ef933c87b
Gerrit-Change-Number: 42691
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 25 Jun 2020 06:00:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42690 )
Change subject: soc/amd/common: Complete ACPIMMIO GPIO bank separation
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42690/4/src/soc/amd/common/block/g…
File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42690/4/src/soc/amd/common/block/g…
PS4, Line 83: return acpimmio_gpio0 + gpio_num * sizeof(uint32_t);
I skipped ahead a few patches to this one. I thought we already established this function? Why is it reintroduced? Or am I just confused now?
--
To view, visit https://review.coreboot.org/c/coreboot/+/42690
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c8c3f2028ca89dca5c7f0548fcd18e1045999d6
Gerrit-Change-Number: 42690
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 25 Jun 2020 05:57:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment