coreboot-gerrit April 2020

coreboot-gerrit@coreboot.org

1 participants
2501 discussions

Change in coreboot[master]: mb/intel/jasperlake_rvp: SD Card gpio config for JSLRVP
by Ronak Kanabar (Code Review) 06 Apr '20

06 Apr '20

Hello Deepti Vaidya, Maulik V Vaghela, Meera Ravindranath, Usha P, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/39492 to look at the new patch set (#2). Change subject: mb/intel/jasperlake_rvp: SD Card gpio config for JSLRVP ...................................................................... mb/intel/jasperlake_rvp: SD Card gpio config for JSLRVP Change-Id: I8114d6980a2a542538b05f812ca2cffc15c88c22 Signed-off-by: Ronak Kanabar <ronak.kanabar(a)intel.com> --- M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c 2 files changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/39492/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/39492 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8114d6980a2a542538b05f812ca2cffc15c88c22 Gerrit-Change-Number: 39492 Gerrit-PatchSet: 2 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Deepti Vaidya <deepti.vaidya(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/intel/jasperlake_rvp: add JSLRVP USB configration
by Ronak Kanabar (Code Review) 06 Apr '20

06 Apr '20

Hello build bot (Jenkins), Maulik V Vaghela, Meera Ravindranath, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/39403 to look at the new patch set (#15). Change subject: mb/intel/jasperlake_rvp: add JSLRVP USB configration ...................................................................... mb/intel/jasperlake_rvp: add JSLRVP USB configration Configure USB OC pins for JSLRVP Change-Id: If9df8e330d31ed81207dfdfa2ab96fd4d49f3f0c Signed-off-by: Ronak Kanabar <ronak.kanabar(a)intel.com> --- M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb 1 file changed, 13 insertions(+), 25 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/39403/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/39403 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If9df8e330d31ed81207dfdfa2ab96fd4d49f3f0c Gerrit-Change-Number: 39403 Gerrit-PatchSet: 15 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: intel/fsp2_0: automatically split FSP into fsp{t,m,s}.bin
by Krystian Hebel (Code Review) 06 Apr '20

06 Apr '20

Krystian Hebel has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/28385 ) Change subject: intel/fsp2_0: automatically split FSP into fsp{t,m,s}.bin ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/28385 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7b7ab6197e72ef06f90d4fc41d937cbb570bbbc Gerrit-Change-Number: 28385 Gerrit-PatchSet: 3 Gerrit-Owner: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com> Gerrit-CC: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: util/fsptool: add scripts for splitting FSP binaries
by Krystian Hebel (Code Review) 06 Apr '20

06 Apr '20

Krystian Hebel has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/28375 ) Change subject: util/fsptool: add scripts for splitting FSP binaries ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/28375 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie75ad6e55f1e4047c310f50da32a90efff324c4b Gerrit-Change-Number: 28375 Gerrit-PatchSet: 3 Gerrit-Owner: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: arch/x86/acpi: add definitions for IVHD type 11h
by Michał Żygowski (Code Review) 06 Apr '20

06 Apr '20

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40041 ) Change subject: arch/x86/acpi: add definitions for IVHD type 11h ...................................................................... arch/x86/acpi: add definitions for IVHD type 11h Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I698ac6f6a2e0bc5736fbb14ef583bbe031baee28 --- M src/arch/x86/include/arch/acpi.h M src/arch/x86/include/arch/acpi_ivrs.h 2 files changed, 60 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/40041/1 diff --git a/src/arch/x86/include/arch/acpi.h b/src/arch/x86/include/arch/acpi.h index d5040ad..644f52f 100644 --- a/src/arch/x86/include/arch/acpi.h +++ b/src/arch/x86/include/arch/acpi.h @@ -290,6 +290,33 @@ struct acpi_ivrs_ivhd ivhd; } __packed acpi_ivrs_t; +/* IVHD Type 11h IOMMU Attributes */ +typedef struct ivhd11_iommu_attr { + uint32_t reserved1 : 13; + uint32_t perf_counters : 4; + uint32_t perf_counter_banks : 6; + uint32_t msi_num_ppr : 5; + uint32_t reserved2 : 4; +} __packed ivhd11_iommu_attr_t; + +/* IVRS IVHD (I/O Virtualization Hardware Definition Block) Type 11h */ +typedef struct acpi_ivrs_ivhd_11 { + uint8_t type; + uint8_t flags; + uint16_t length; + uint16_t device_id; + uint16_t capability_offset; + uint32_t iommu_base_low; + uint32_t iommu_base_high; + uint16_t pci_segment_group; + uint16_t iommu_info; + struct ivhd11_iommu_attr iommu_attributes; + uint32_t efr_reg_image_low; + uint32_t efr_reg_image_high; + uint32_t reserved[2]; + uint8_t entry[0]; +} __packed acpi_ivrs_ivhd11_t; + enum dev_scope_type { SCOPE_PCI_ENDPOINT = 1, SCOPE_PCI_SUB = 2, diff --git a/src/arch/x86/include/arch/acpi_ivrs.h b/src/arch/x86/include/arch/acpi_ivrs.h index d8d62d4..83abfb6 100644 --- a/src/arch/x86/include/arch/acpi_ivrs.h +++ b/src/arch/x86/include/arch/acpi_ivrs.h @@ -107,4 +107,37 @@ #define IVHD_UID_INT 0x01 #define IVHD_UID_STRING 0x02 +/* IVHD (I/O Virtualization Hardware Definition Block) 4-byte entry */ +typedef struct ivrs_ivhd_generic { + uint8_t type; + uint16_t dev_id; + uint8_t dte_setting; +} __packed ivrs_ivhd_generic_t; + +/* IVHD (I/O Virtualization Hardware Definition Block) 8-byte entries */ +typedef struct ivrs_ivhd_alias { + uint8_t type; + uint16_t dev_id; + uint8_t dte_setting; + uint8_t reserved1; + uint16_t source_dev_id; + uint8_t reserved2; +} __packed ivrs_ivhd_alias_t; + +typedef struct ivrs_ivhd_extended { + uint8_t type; + uint16_t dev_id; + uint8_t dte_setting; + uint32_t extended_dte_setting; +} __packed ivrs_ivhd_extended_t; + +typedef struct ivrs_ivhd_special { + uint8_t type; + uint16_t reserved; + uint8_t dte_setting; + uint8_t handle; + uint16_t source_dev_id; + uint8_t variety; +} __packed ivrs_ivhd_special_t; + #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/40041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I698ac6f6a2e0bc5736fbb14ef583bbe031baee28 Gerrit-Change-Number: 40041 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newchange

5 10

Change in coreboot[master]: sb/intel/bd82x6x/sata: Set values as described in BIOS spec
by Felix Singer (Code Review) 06 Apr '20

06 Apr '20

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40231 ) Change subject: sb/intel/bd82x6x/sata: Set values as described in BIOS spec ...................................................................... Patch Set 3: (1 comment) This change is ready for review. https://review.coreboot.org/c/coreboot/+/40231/2//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40231/2//COMMIT_MSG@12 PS2, Line 12: (It won't get better than this, the spec also just lists numbers) > That was just a comment, please don't quote me too literally ;) Done -- To view, visit https://review.coreboot.org/c/coreboot/+/40231 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27360d6ea5d1f00b1ed350f47ff40a22f19dfb05 Gerrit-Change-Number: 40231 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 06 Apr 2020 10:03:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/jasperlake_rvp: add JSLRVP USB configration
by Maulik V Vaghela (Code Review) 06 Apr '20

06 Apr '20

Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39403 ) Change subject: mb/intel/jasperlake_rvp: add JSLRVP USB configration ...................................................................... Patch Set 13: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/39403 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If9df8e330d31ed81207dfdfa2ab96fd4d49f3f0c Gerrit-Change-Number: 39403 Gerrit-PatchSet: 13 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 06 Apr 2020 07:34:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/purism/librem_skl: Use ACPI backlight controls
by Wim Vervoorn (Code Review) 06 Apr '20

06 Apr '20

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40145 ) Change subject: mb/purism/librem_skl: Use ACPI backlight controls ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/40145 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iccf50f427b7555ee1a3ef9cc11a89d532789ac54 Gerrit-Change-Number: 40145 Gerrit-PatchSet: 3 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 06 Apr 2020 07:18:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/razer/blade_stealth_kbl: Use ACPI brightness controls
by Wim Vervoorn (Code Review) 06 Apr '20

06 Apr '20

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40146 ) Change subject: mb/razer/blade_stealth_kbl: Use ACPI brightness controls ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/40146 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8979f74b583e9fca4a1b57fe9166e433cd1d596b Gerrit-Change-Number: 40146 Gerrit-PatchSet: 3 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 06 Apr 2020 07:17:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/kunimitsu: Use ACPI backlight controls
by Wim Vervoorn (Code Review) 06 Apr '20

06 Apr '20

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39638 ) Change subject: mb/intel/kunimitsu: Use ACPI backlight controls ...................................................................... Patch Set 24: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/39638 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c2f0e8fe1ef91334d494c8a8605dd46cda80e3d Gerrit-Change-Number: 39638 Gerrit-PatchSet: 24 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 06 Apr 2020 07:16:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2020