coreboot-gerrit April 2020

coreboot-gerrit@coreboot.org

1 participants
2500 discussions

Change in coreboot[master]: mb/google/kukui: correct board name
by Scott Chao (Code Review) 09 Apr '20

09 Apr '20

Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40283 ) Change subject: mb/google/kukui: correct board name ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/c/coreboot/+/40283/4//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40283/4//COMMIT_MSG@12 PS4, Line 12: TEST > Please add BRANCH=kukui so we know this must be merged back to fw branch Done -- To view, visit https://review.coreboot.org/c/coreboot/+/40283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf387b0e0153315ff2ab5c19381db44a61c14e96 Gerrit-Change-Number: 40283 Gerrit-PatchSet: 6 Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com> Gerrit-Comment-Date: Thu, 09 Apr 2020 04:03:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/kukui: correct board name
by Scott Chao (Code Review) 09 Apr '20

09 Apr '20

Hello Hung-Te Lin, build bot (Jenkins), Martin Roth, Patrick Georgi, Peichao Li, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40283 to look at the new patch set (#6). Change subject: mb/google/kukui: correct board name ...................................................................... mb/google/kukui: correct board name Modify board name from "Kadadu" to "Kakadu" BUG=b:153590144 TEST=CPU log show "Starting depthcharge on Kakadu..." BRANCH=kukui Signed-off-by: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Change-Id: Ibf387b0e0153315ff2ab5c19381db44a61c14e96 --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/40283/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/40283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf387b0e0153315ff2ab5c19381db44a61c14e96 Gerrit-Change-Number: 40283 Gerrit-PatchSet: 6 Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: vendorcode/intel/fsp: Update Tiger Lake FSP Headers for FSP v2527.
by Srinidhi N Kaushik (Code Review) 09 Apr '20

09 Apr '20

Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40026 ) Change subject: vendorcode/intel/fsp: Update Tiger Lake FSP Headers for FSP v2527. ...................................................................... Patch Set 9: Code-Review+1 (1 comment) https://review.coreboot.org/c/coreboot/+/40026/7//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40026/7//COMMIT_MSG@11 PS7, Line 11: > FSP-M UPDs added: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/40026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cdce28b01f291dbb02a01ded7629e94c77b7e47 Gerrit-Change-Number: 40026 Gerrit-PatchSet: 9 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 09 Apr 2020 04:00:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vendorcode/intel/fsp: Update Tiger Lake FSP Headers for FSP v2527.
by Srinidhi N Kaushik (Code Review) 09 Apr '20

09 Apr '20

Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Nick Vaccaro, Ronak Kanabar, Raj Astekar, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40026 to look at the new patch set (#9). Change subject: vendorcode/intel/fsp: Update Tiger Lake FSP Headers for FSP v2527. ...................................................................... vendorcode/intel/fsp: Update Tiger Lake FSP Headers for FSP v2527. Update FSP headers for Tiger Lake platform generated based FSP version 2527. Which includes below additional UPDs FSPM: - PchTraceHubMode - CpuTraceHubMode - CpuPcieRpEnableMask FSPS: - D3HotEnable - D3ColdEnable - RtcMemoryLock - PchLockDownGlobalSmi - PchLockDownBiosInterface - PchUnlockGpioPads - CpuMpPpi - ThcPort0Assignment - ThcPort1Assignment BUG=b:150357377 BRANCH=none TEST=build and boot ripto/volteer Signed-off-by: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Change-Id: I0cdce28b01f291dbb02a01ded7629e94c77b7e47 --- M src/vendorcode/intel/fsp/fsp2_0/tigerlake/FspUpd.h M src/vendorcode/intel/fsp/fsp2_0/tigerlake/FspmUpd.h M src/vendorcode/intel/fsp/fsp2_0/tigerlake/FspsUpd.h 3 files changed, 168 insertions(+), 66 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/40026/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/40026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cdce28b01f291dbb02a01ded7629e94c77b7e47 Gerrit-Change-Number: 40026 Gerrit-PatchSet: 9 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/kukui: correct board name
by Hung-Te Lin (Code Review) 09 Apr '20

09 Apr '20

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40283 ) Change subject: mb/google/kukui: correct board name ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/c/coreboot/+/40283/4//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40283/4//COMMIT_MSG@12 PS4, Line 12: TEST Please add BRANCH=kukui so we know this must be merged back to fw branch -- To view, visit https://review.coreboot.org/c/coreboot/+/40283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf387b0e0153315ff2ab5c19381db44a61c14e96 Gerrit-Change-Number: 40283 Gerrit-PatchSet: 5 Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com> Gerrit-Comment-Date: Thu, 09 Apr 2020 03:53:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/kukui: correct board name
by Scott Chao (Code Review) 09 Apr '20

09 Apr '20

Hello Hung-Te Lin, build bot (Jenkins), Martin Roth, Patrick Georgi, Peichao Li, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40283 to look at the new patch set (#5). Change subject: mb/google/kukui: correct board name ...................................................................... mb/google/kukui: correct board name Modify board name from "Kadadu" to "Kakadu" BUG=b:153590144 TEST=CPU log show "Starting depthcharge on Kakadu..." Signed-off-by: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Change-Id: Ibf387b0e0153315ff2ab5c19381db44a61c14e96 --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/40283/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/40283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf387b0e0153315ff2ab5c19381db44a61c14e96 Gerrit-Change-Number: 40283 Gerrit-PatchSet: 5 Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/kukui: modify board name
by Scott Chao (Code Review) 09 Apr '20

09 Apr '20

Hello Hung-Te Lin, build bot (Jenkins), Martin Roth, Patrick Georgi, Peichao Li, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40283 to look at the new patch set (#4). Change subject: mb/google/kukui: modify board name ...................................................................... mb/google/kukui: modify board name Modify board name from "Kadadu" to "Kakadu" BUG=b:153590144 TEST=CPU log show "Starting depthcharge on Kakadu..." Signed-off-by: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Change-Id: Ibf387b0e0153315ff2ab5c19381db44a61c14e96 --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/40283/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/40283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf387b0e0153315ff2ab5c19381db44a61c14e96 Gerrit-Change-Number: 40283 Gerrit-PatchSet: 4 Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/kukui: modify board name
by Scott Chao (Code Review) 09 Apr '20

09 Apr '20

Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40283 ) Change subject: mb/google/kukui: modify board name ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/40283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf387b0e0153315ff2ab5c19381db44a61c14e96 Gerrit-Change-Number: 40283 Gerrit-PatchSet: 3 Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com> Gerrit-Comment-Date: Thu, 09 Apr 2020 03:42:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: spi: add Winbond W25Q64JW spi rom support
by Hung-Te Lin (Code Review) 09 Apr '20

09 Apr '20

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40270 ) Change subject: spi: add Winbond W25Q64JW spi rom support ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/c/coreboot/+/40270/5//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40270/5//COMMIT_MSG@10 PS5, Line 10: TEST=Able to boot to kernel > It should also boot without that change, shouldn’t it? Did you check that the MRC cache could be wri […] Without this change they will only see bootblock, and will stuck when trying to load verstage. -- To view, visit https://review.coreboot.org/c/coreboot/+/40270 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I699f6d7ba3af01436f10c9a59af4a22fc45aa300 Gerrit-Change-Number: 40270 Gerrit-PatchSet: 5 Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com> Gerrit-CC: Paul Ma <magf(a)bitland.com.cn> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 09 Apr 2020 02:11:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: spi: add Winbond W25Q64JW spi rom support
by Scott Chao (Code Review) 09 Apr '20

09 Apr '20

Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40270 ) Change subject: spi: add Winbond W25Q64JW spi rom support ...................................................................... Patch Set 5: > Patch Set 5: > > (1 comment) Without this change, I saw coreboot can't load bootblock and cpu log stuck at "Jump to BL". Yes, MRC cache can be wriiten and verify in first boot and second boot. -- To view, visit https://review.coreboot.org/c/coreboot/+/40270 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I699f6d7ba3af01436f10c9a59af4a22fc45aa300 Gerrit-Change-Number: 40270 Gerrit-PatchSet: 5 Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com> Gerrit-CC: Paul Ma <magf(a)bitland.com.cn> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 09 Apr 2020 02:05:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2020