Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38978 )
Change subject: [WIP] mainboard: Add Acer ES1-572
......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38978/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38978/4//COMMIT_MSG@7
PS4, Line 7: mainboard
> The "acer" folder is not there just yet (or at least it wasn't last time I checked), so the change h […]
Ack
https://review.coreboot.org/c/coreboot/+/38978/4//COMMIT_MSG@19
PS4, Line 19: Linux
> Honestly, I have no idea. […]
Ack
https://review.coreboot.org/c/coreboot/+/38978/4//COMMIT_MSG@19
PS4, Line 19: tianocore
> But its folder is named "tianocore" ? […]
Ack
https://review.coreboot.org/c/coreboot/+/38978/4//COMMIT_MSG@24
PS4, Line 24: need
> It's actually plural: (things that) are not working or need testing.
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/38978
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id98788a2c5e54f70fd1cacbd70d636f5e63b2619
Gerrit-Change-Number: 38978
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Comment-Date: Tue, 03 Mar 2020 12:52:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30098 )
Change subject: Fix potential NULL pointer dereferences and memory leak.
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/30098/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/30098/2//COMMIT_MSG@7
PS2, Line 7: Fix potential NULL pointer dereferences and memory leak.
Please remove the dot/period at the end of the git commit message summary.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30098
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38a8910e68b7a8ce0e97ca4cdb9ef7f595c0e319
Gerrit-Change-Number: 30098
Gerrit-PatchSet: 2
Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com>
Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 03 Mar 2020 12:21:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31384
Change subject: README: Spell Web site with one space
......................................................................
README: Spell Web site with one space
Change-Id: I4119ae6df01dbafb60b2a132c887844739839de6
Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de>
---
M payloads/libpayload/README
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/31384/1
diff --git a/payloads/libpayload/README b/payloads/libpayload/README
index fdf9b18..7348934 100644
--- a/payloads/libpayload/README
+++ b/payloads/libpayload/README
@@ -49,10 +49,10 @@
Please see the sample/ directory for details.
-Website and Mailing List
+Web site and Mailing List
------------------------
-The main website is https://www.coreboot.org/Libpayload.
+The main web site is https://www.coreboot.org/Libpayload.
For additional information, patches, and discussions, please join the
coreboot mailing list at https://www.coreboot.org/Mailinglist, where most
--
To view, visit https://review.coreboot.org/c/coreboot/+/31384
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4119ae6df01dbafb60b2a132c887844739839de6
Gerrit-Change-Number: 31384
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newchange