coreboot-gerrit March 2020

coreboot-gerrit@coreboot.org

1 participants
3326 discussions

Change in coreboot[master]: sb/lynxpoint: hook up smmstore
by Matt DeVillier (Code Review) 03 Mar '20

03 Mar '20

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39189 ) Change subject: sb/lynxpoint: hook up smmstore ...................................................................... sb/lynxpoint: hook up smmstore Adapted from implementation in sb/intel/common. Test: build/boot variants of google/{beltino,slippy} with Tianocore and SMMSTORE enabled Change-Id: I64f520d17146206b8b9b41fc4f827539c5cfd507 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/southbridge/intel/lynxpoint/smihandler.c 1 file changed, 25 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/39189/1 diff --git a/src/southbridge/intel/lynxpoint/smihandler.c b/src/southbridge/intel/lynxpoint/smihandler.c index 72c3447..44fef1c 100644 --- a/src/southbridge/intel/lynxpoint/smihandler.c +++ b/src/southbridge/intel/lynxpoint/smihandler.c @@ -29,7 +29,7 @@ #include <southbridge/intel/common/finalize.h> #include <northbridge/intel/haswell/haswell.h> #include <cpu/intel/haswell/haswell.h> - +#include <smmstore.h> #include "me.h" #include "pch.h" #include "nvs.h" @@ -266,6 +266,26 @@ *ret = gsmi_exec(sub_command, param); } +static void southbridge_smi_store(void) +{ + u8 sub_command, ret; + em64t101_smm_state_save_area_t *io_smi = + smi_apmc_find_state_save(APM_CNT_SMMSTORE); + uint32_t reg_ebx; + + if (!io_smi) + return; + /* Command and return value in EAX */ + sub_command = (io_smi->rax >> 8) & 0xff; + + /* Parameter buffer in EBX */ + reg_ebx = io_smi->rbx; + + /* drivers/smmstore/smi.c */ + ret = smmstore_exec(sub_command, (void *)reg_ebx); + io_smi->rax = ret; +} + static void southbridge_smi_apmc(void) { u8 reg8; @@ -332,6 +352,10 @@ if (CONFIG(ELOG_GSMI)) southbridge_smi_gsmi(); break; + case APM_CNT_SMMSTORE: + if (CONFIG(SMMSTORE)) + southbridge_smi_store(); + break; } mainboard_smi_apmc(reg8); -- To view, visit https://review.coreboot.org/c/coreboot/+/39189 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64f520d17146206b8b9b41fc4f827539c5cfd507 Gerrit-Change-Number: 39189 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

6 12

Change in coreboot[master]: src/soc/intel/cannonlake: Enables CSE update flow for CML
by Sridhar Siricilla (Code Review) 03 Mar '20

03 Mar '20

Sridhar Siricilla has removed Jamie Ryu from this change. ( https://review.coreboot.org/c/coreboot/+/35404 ) Change subject: src/soc/intel/cannonlake: Enables CSE update flow for CML ...................................................................... Removed reviewer Jamie Ryu. -- To view, visit https://review.coreboot.org/c/coreboot/+/35404 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87887870cdd4c492f7d228f482c8037023ac16fa Gerrit-Change-Number: 35404 Gerrit-PatchSet: 43 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: src/soc/intel/cannonlake: Enables CSE update flow for CML
by Sridhar Siricilla (Code Review) 03 Mar '20

03 Mar '20

Sridhar Siricilla has removed V Sowmya from this change. ( https://review.coreboot.org/c/coreboot/+/35404 ) Change subject: src/soc/intel/cannonlake: Enables CSE update flow for CML ...................................................................... Removed reviewer V Sowmya. -- To view, visit https://review.coreboot.org/c/coreboot/+/35404 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87887870cdd4c492f7d228f482c8037023ac16fa Gerrit-Change-Number: 35404 Gerrit-PatchSet: 43 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: src/soc/intel/cannonlake: Enables CSE update flow for CML
by Sridhar Siricilla (Code Review) 03 Mar '20

03 Mar '20

Sridhar Siricilla has removed Sridhar Siricilla from this change. ( https://review.coreboot.org/c/coreboot/+/35404 ) Change subject: src/soc/intel/cannonlake: Enables CSE update flow for CML ...................................................................... Removed reviewer Sridhar Siricilla. -- To view, visit https://review.coreboot.org/c/coreboot/+/35404 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87887870cdd4c492f7d228f482c8037023ac16fa Gerrit-Change-Number: 35404 Gerrit-PatchSet: 43 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: src/soc/intel/cannonlake: Enables CSE update flow for CML
by Sridhar Siricilla (Code Review) 03 Mar '20

03 Mar '20

Sridhar Siricilla has removed Aamir Bohra from this change. ( https://review.coreboot.org/c/coreboot/+/35404 ) Change subject: src/soc/intel/cannonlake: Enables CSE update flow for CML ...................................................................... Removed reviewer Aamir Bohra. -- To view, visit https://review.coreboot.org/c/coreboot/+/35404 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87887870cdd4c492f7d228f482c8037023ac16fa Gerrit-Change-Number: 35404 Gerrit-PatchSet: 43 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.corp-partner.google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: src/soc/intel/cannonlake: Enables CSE update flow for CML
by Sridhar Siricilla (Code Review) 03 Mar '20

03 Mar '20

Sridhar Siricilla has removed Rizwan Qureshi from this change. ( https://review.coreboot.org/c/coreboot/+/35404 ) Change subject: src/soc/intel/cannonlake: Enables CSE update flow for CML ...................................................................... Removed reviewer Rizwan Qureshi. -- To view, visit https://review.coreboot.org/c/coreboot/+/35404 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87887870cdd4c492f7d228f482c8037023ac16fa Gerrit-Change-Number: 35404 Gerrit-PatchSet: 43 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.corp-partner.google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: src/soc/intel/cannonlake: Enables CSE update flow for CML
by Sridhar Siricilla (Code Review) 03 Mar '20

03 Mar '20

Sridhar Siricilla has removed Subrata Banik from this change. ( https://review.coreboot.org/c/coreboot/+/35404 ) Change subject: src/soc/intel/cannonlake: Enables CSE update flow for CML ...................................................................... Removed reviewer Subrata Banik. -- To view, visit https://review.coreboot.org/c/coreboot/+/35404 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87887870cdd4c492f7d228f482c8037023ac16fa Gerrit-Change-Number: 35404 Gerrit-PatchSet: 43 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.corp-partner.google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: src/soc/intel/cannonlake: Enables CSE update flow for CML
by Sridhar Siricilla (Code Review) 03 Mar '20

03 Mar '20

Sridhar Siricilla has removed Furquan Shaikh from this change. ( https://review.coreboot.org/c/coreboot/+/35404 ) Change subject: src/soc/intel/cannonlake: Enables CSE update flow for CML ...................................................................... Removed reviewer Furquan Shaikh. -- To view, visit https://review.coreboot.org/c/coreboot/+/35404 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87887870cdd4c492f7d228f482c8037023ac16fa Gerrit-Change-Number: 35404 Gerrit-PatchSet: 43 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: [WIP] mainboard: Add Acer ES1-572
by Paul Menzel (Code Review) 03 Mar '20

03 Mar '20

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38978 ) Change subject: [WIP] mainboard: Add Acer ES1-572 ...................................................................... Patch Set 4: (4 comments) https://review.coreboot.org/c/coreboot/+/38978/4//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/38978/4//COMMIT_MSG@7 PS4, Line 7: mainboard > The "acer" folder is not there just yet (or at least it wasn't last time I checked), so the change h […] Ack https://review.coreboot.org/c/coreboot/+/38978/4//COMMIT_MSG@19 PS4, Line 19: Linux > Honestly, I have no idea. […] Ack https://review.coreboot.org/c/coreboot/+/38978/4//COMMIT_MSG@19 PS4, Line 19: tianocore > But its folder is named "tianocore" ? […] Ack https://review.coreboot.org/c/coreboot/+/38978/4//COMMIT_MSG@24 PS4, Line 24: need > It's actually plural: (things that) are not working or need testing. Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/38978 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id98788a2c5e54f70fd1cacbd70d636f5e63b2619 Gerrit-Change-Number: 38978 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Comment-Date: Tue, 03 Mar 2020 12:52:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Fix potential NULL pointer dereferences and memory leak.
by Paul Menzel (Code Review) 03 Mar '20

03 Mar '20

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30098 ) Change subject: Fix potential NULL pointer dereferences and memory leak. ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/30098/2//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/30098/2//COMMIT_MSG@7 PS2, Line 7: Fix potential NULL pointer dereferences and memory leak. Please remove the dot/period at the end of the git commit message summary. -- To view, visit https://review.coreboot.org/c/coreboot/+/30098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38a8910e68b7a8ce0e97ca4cdb9ef7f595c0e319 Gerrit-Change-Number: 30098 Gerrit-PatchSet: 2 Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 03 Mar 2020 12:21:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2020