coreboot-gerrit March 2020

coreboot-gerrit@coreboot.org

1 participants
3326 discussions

Change in coreboot[master]: src/mainboard/libretrend/lt1000: Initial commit
by Paul Menzel (Code Review) 04 Mar '20

04 Mar '20

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30360 ) Change subject: src/mainboard/libretrend/lt1000: Initial commit ...................................................................... Patch Set 13: (18 comments) Nice, thank you for upstreaming this. Already use SPDX headers? https://review.coreboot.org/c/coreboot/+/30360/13//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/30360/13//COMMIT_MSG@7 PS13, Line 7: src/mainboard/libretrend/lt1000: Initial commit Please use just `mb/libretrend/lt1000:`, and use a statement by adding a verb in imperative mood. > mb/libretrend/lt1000: Do initial commit or > mb/libretrend: Add KBL based Libretrend LT1000 (Librebox) https://review.coreboot.org/c/coreboot/+/30360/13//COMMIT_MSG@8 PS13, Line 8: Please add a note, how you created that board. Note, that Libretrend contracted(?) the work? https://review.coreboot.org/c/coreboot/+/30360/13/Documentation/mainboard/l… File Documentation/mainboard/libretrend/lt1000.md: https://review.coreboot.org/c/coreboot/+/30360/13/Documentation/mainboard/l… PS13, Line 23: Kabylake Kaby Lake https://review.coreboot.org/c/coreboot/+/30360/13/Documentation/mainboard/l… PS13, Line 25: *3rdparty/fsp* submodule. Mark up as code `3rdparty/fsp`. https://review.coreboot.org/c/coreboot/+/30360/13/Documentation/mainboard/l… PS13, Line 27: microcode Microcode updates are … https://review.coreboot.org/c/coreboot/+/30360/13/Documentation/mainboard/l… PS13, Line 28: from the *3rdparty/intel-microcode* submodule. Mark up as code/monospace. https://review.coreboot.org/c/coreboot/+/30360/13/Documentation/mainboard/l… PS13, Line 42: , whose datasheet : can be found [here][W25Q64FV] Just do [datasheet][W25Q64FV]. https://review.coreboot.org/c/coreboot/+/30360/13/Documentation/mainboard/l… PS13, Line 47: Fastboot What is that? https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/… File src/mainboard/libretrend/lt1000/acpi/mainboard.asl: https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/… PS13, Line 1: /* Looks like a lot of boards use that, so it should be put in some common location. https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/… PS13, Line 21: Name (PBST, One) What is this good for? https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/… File src/mainboard/libretrend/lt1000/bootblock.c: https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/… PS13, Line 42: */ What about port 2? https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/… File src/mainboard/libretrend/lt1000/mainboard.c: https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/… PS13, Line 24: {0} Please add spaces around the 0. https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/… PS13, Line 47: MAX_SERIAL_LENGTH); Fits in 96 characters. https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/… File src/mainboard/libretrend/lt1000/ramstage.c: https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/… PS13, Line 24: * Remove. https://doc.coreboot.org/coding_style.html#commenting https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/… File src/mainboard/libretrend/lt1000/romstage.c: https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/… PS13, Line 38: /* DQS CPU<>DRAM map https://doc.coreboot.org/coding_style.html#commenting https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/… PS13, Line 50: /* Rcomp resistor */ Unneeded comment. https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/… PS13, Line 53: sizeof(RcompResistor)); One line. https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/… PS13, Line 77: */ https://doc.coreboot.org/coding_style.html#commenting -- To view, visit https://review.coreboot.org/c/coreboot/+/30360 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I32fc8a7d3177ba379d04ad8b87adefcfca2b0fab Gerrit-Change-Number: 30360 Gerrit-PatchSet: 13 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Wed, 04 Mar 2020 12:10:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/denverton_ns: Enable MC Exception
by David Guckian (Code Review) 04 Mar '20

04 Mar '20

David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25434 ) Change subject: soc/intel/denverton_ns: Enable MC Exception ...................................................................... Patch Set 14: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/25434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9773c61d06bb6c68612e498a35b5ad22cd5a8a6e Gerrit-Change-Number: 25434 Gerrit-PatchSet: 14 Gerrit-Owner: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: David Guckian Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jay Talbott <JayTalbott(a)sysproconsulting.com> Gerrit-Comment-Date: Wed, 04 Mar 2020 11:45:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/kontron/mal10: add nct7802y HWM IC support
by Paul Menzel (Code Review) 04 Mar '20

04 Mar '20

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39001 ) Change subject: mb/kontron/mal10: add nct7802y HWM IC support ...................................................................... Patch Set 17: (1 comment) https://review.coreboot.org/c/coreboot/+/39001/17//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/39001/17//COMMIT_MSG@8 PS17, Line 8: Nice. Can you describe where you got the values from? -- To view, visit https://review.coreboot.org/c/coreboot/+/39001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icdaac4836decb03c6f9b6ed003e0e78d5cf211a9 Gerrit-Change-Number: 39001 Gerrit-PatchSet: 17 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Wed, 04 Mar 2020 11:40:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/apl: add options to override USB port config
by Paul Menzel (Code Review) 04 Mar '20

04 Mar '20

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38815 ) Change subject: soc/apl: add options to override USB port config ...................................................................... Patch Set 17: Code-Review+1 (2 comments) https://review.coreboot.org/c/coreboot/+/38815/17//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/38815/17//COMMIT_MSG@9 PS17, Line 9: overload override? https://review.coreboot.org/c/coreboot/+/38815/17/src/soc/intel/apollolake/… File src/soc/intel/apollolake/chip.c: https://review.coreboot.org/c/coreboot/+/38815/17/src/soc/intel/apollolake/… PS17, Line 571: cfg->usb2_port[port].oc_pin; Does this fit into 96 characters? -- To view, visit https://review.coreboot.org/c/coreboot/+/38815 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia94a2be1647f7743ef0c918ae3b34437a179261c Gerrit-Change-Number: 38815 Gerrit-PatchSet: 17 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 04 Mar 2020 11:39:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Fix potential NULL pointer dereferences and memory leak.
by Subrata Banik (Code Review) 04 Mar '20

04 Mar '20

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30098 ) Change subject: Fix potential NULL pointer dereferences and memory leak. ...................................................................... Patch Set 2: > Patch Set 2: > > Subrata, do you know if Francois is still working on this? Let me check Paul, i will get back on this -- To view, visit https://review.coreboot.org/c/coreboot/+/30098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38a8910e68b7a8ce0e97ca4cdb9ef7f595c0e319 Gerrit-Change-Number: 30098 Gerrit-PatchSet: 2 Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Comment-Date: Wed, 04 Mar 2020 11:36:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Fix potential NULL pointer dereferences and memory leak.
by Paul Menzel (Code Review) 04 Mar '20

04 Mar '20

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30098 ) Change subject: Fix potential NULL pointer dereferences and memory leak. ...................................................................... Patch Set 2: Subrata, do you know if Francois is still working on this? -- To view, visit https://review.coreboot.org/c/coreboot/+/30098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38a8910e68b7a8ce0e97ca4cdb9ef7f595c0e319 Gerrit-Change-Number: 30098 Gerrit-PatchSet: 2 Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Comment-Date: Wed, 04 Mar 2020 11:29:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/denverton_ns: Enable MC Exception
by Patrick Georgi (Code Review) 04 Mar '20

04 Mar '20

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25434 ) Change subject: soc/intel/denverton_ns: Enable MC Exception ...................................................................... Patch Set 14: Mimoja, you seem to be active on the Denverton NS side, so maybe these commits pique your interest? -- To view, visit https://review.coreboot.org/c/coreboot/+/25434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9773c61d06bb6c68612e498a35b5ad22cd5a8a6e Gerrit-Change-Number: 25434 Gerrit-PatchSet: 14 Gerrit-Owner: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jay Talbott <JayTalbott(a)sysproconsulting.com> Gerrit-Comment-Date: Wed, 04 Mar 2020 11:18:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload/drivers/nvram: Add function to write RTC
by Patrick Georgi (Code Review) 04 Mar '20

04 Mar '20

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23585 ) Change subject: libpayload/drivers/nvram: Add function to write RTC ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/c/coreboot/+/23585/2/payloads/libpayload/driver… File payloads/libpayload/drivers/nvram.c: https://review.coreboot.org/c/coreboot/+/23585/2/payloads/libpayload/driver… PS2, Line 179: NVRAM_RTC_STATUSB > defined in uncommitted parent commit (commenting here to prevent out of order submission) Done -- To view, visit https://review.coreboot.org/c/coreboot/+/23585 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17b4c1ee0dcc649738ac6a7400b087d07213eaf0 Gerrit-Change-Number: 23585 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 04 Mar 2020 11:08:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/cbui: Add new payload CBUI
by build bot (Jenkins) (Code Review) 04 Mar '20

04 Mar '20

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 ) Change subject: payloads/cbui: Add new payload CBUI ...................................................................... Patch Set 5: (320 comments) https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/Kconfig File payloads/cbui/Kconfig: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/Kconfig@37 PS5, Line 37: config LANG_PREFERED 'PREFERED' may be misspelled - perhaps 'PREFERRED'? https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/Kconfig@38 PS5, Line 38: string "Prefered UI language" 'Prefered' may be misspelled - perhaps 'Preferred'? https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearCombo.h: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 23: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearDatePicker.h: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 24: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearDatePicker.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 32: switch (month) { switch and case should be at the same indent https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 278: struct nuklear_datepicker* obj; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearGroup.h: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 23: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearIntegerRange.h: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 23: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearLabel.h: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 23: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 34: void NuklearLabel_dtor(void* obj); "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearLabel.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 81: void NuklearLabel_dtor(void* obj) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearObject.h: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 21: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 44: void NuklearObject_ctor(struct nuklear_object* obj, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 49: void NuklearObject_dtor(void* obj); "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearRoot.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 24: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 100: } else { else is not generally useful after a break or return https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 219: struct nuklear_root* NuklearRoot_ctor(void) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearTabView.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 25: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 31: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 43: struct nuklear_tabview_map* map = NULL; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 126: NuklearTabView_set_focus(this, +1); need consistent spacing around '+' (ctx:WxV) https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 220: struct nk_context *ctx, struct nuklear_vector* modules) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 324: struct nuklear_tabview_map* map = "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 355: for (size_t i = 1; i < NKUI_KEY_LAST; i<<=1) { spaces required around that '<<=' (ctx:VxV) https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearTextView.h: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 24: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearTextView.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 76: if (nk_input_is_key_pressed(i, NK_KEY_UP)) { braces {} are not necessary for any arm of this statement https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearTextfield.h: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 23: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearTextfield.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 121: void NuklearTextfield_dtor(void* obj) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 165: struct nuklear_textfield* obj; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearTimePicker.h: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 25: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearTimePicker.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 180: struct nuklear_timepicker* obj; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearUI.h: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 76: struct nuklear_root* NuklearRoot_ctor(void); "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 298: struct nuklear_root* root; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 319: struct nuklear_tabview* NuklearTabView_new(const struct nuklear_desc *desc); "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearVector.h: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 20: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 26: struct nuklear_vector* NuklearVector_ctor(void); "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 37: struct { struct nuklear_vector *vecptr; t *y; } it = \ need consistent spacing around '*' (ctx:WxV) https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… File payloads/cbui/NuklearUI/NuklearVector.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 59: for (;i > 0 && base; i--) space required after that ';' (ctx:BxV) https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/NuklearUI/Nu… PS5, Line 90: for (;i > 0 && base; i--) space required after that ';' (ctx:BxV) https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… File payloads/cbui/arch/x86/int32.h: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 21: unsigned short di, si, bp, sp, bx, dx, cx, ax; please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 22: unsigned short gs, fs, es, ds, eflags; please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 24: trailing whitespace https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 24: please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… File payloads/cbui/arch/x86/int32.nasm: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 1: ; trailing whitespace https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 4: ; trailing whitespace https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 7: ; trailing whitespace https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 10: ; trailing whitespace https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 12: ; trailing whitespace https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 22: ; trailing whitespace https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 32: ; trailing whitespace https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 33: ; trailing whitespace https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'? https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 80: mov [REBASE(ib)], al ; set intrrupt immediate byte from our arguments 'intrrupt' may be misspelled - perhaps 'interrupt'? https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 80: mov [REBASE(ib)], al ; set intrrupt immediate byte from our arguments trailing whitespace https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 141: trailing whitespace https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 144: trailing whitespace https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 148: trailing whitespace https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 152: trailing whitespace https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 156: trailing whitespace https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 161: trailing whitespace https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 169: trailing whitespace https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 177: trailing whitespace https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 185: trailing whitespace https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 193: trailing whitespace https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/arch/x86/int… PS5, Line 197: trailing whitespace https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/cbui.h File payloads/cbui/cbui.h: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/cbui.h@35 PS5, Line 35: } while(0) space required before the open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/cbui.h@37 PS5, Line 37: #define NK_ASSERT(x) do {} while(0) space required before the open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/cbui.h@41 PS5, Line 41: #define assert(x) do {} while(0); space required before the open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/cbui.h@41 PS5, Line 41: #define assert(x) do {} while(0); do {} while (0) macros should not be semicolon terminated https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/cbui.h@46 PS5, Line 46: extern void usb_poll (void); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/cbui.c File payloads/cbui/cbui.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/cbui.c@63 PS5, Line 63: switch(rawfb->font_tex.format) { space required before the open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/cbui.c@163 PS5, Line 163: switch(key) { space required before the open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/cbui.c@318 PS5, Line 318: struct nuklear_tabview* nktv; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/cbui.c@325 PS5, Line 325: lang_set_country(CONFIG_LANG_PREFERED); 'PREFERED' may be misspelled - perhaps 'PREFERRED'? https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c File payloads/cbui/gfx/splash.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 22: unsigned width; Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 23: unsigned heigth; 'heigth' may be misspelled - perhaps 'height'? https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 23: unsigned heigth; Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 24: unsigned first_pixel_c; Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 37: .heigth = 370, 'heigth' may be misspelled - perhaps 'height'? https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 40: 0x83, 0xa6, 0x03, 0x81, 0x8e, 0x06, 0x81, 0x8b, 0x08, 0x81, 0x89, 0x0a, 0x81, 0x88, 0x0b, 0x81, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 41: 0x86, 0x0d, 0x81, 0x84, 0x0f, 0x81, 0x82, 0x11, 0x81, 0x80, 0x12, 0x81, 0x80, 0x13, 0x81, 0x7e, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 42: 0x14, 0x81, 0x7d, 0x15, 0x81, 0x7c, 0x17, 0x81, 0x7b, 0x17, 0x81, 0x7a, 0x18, 0x81, 0x79, 0x19, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 43: 0x81, 0x78, 0x1a, 0x81, 0x78, 0x1a, 0x81, 0x77, 0x1b, 0x81, 0x76, 0x1c, 0x81, 0x75, 0x1d, 0x81, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 44: 0x46, 0x0c, 0x21, 0x1d, 0x81, 0x40, 0x19, 0x19, 0x1e, 0x81, 0x3d, 0x20, 0x14, 0x1f, 0x81, 0x3b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 45: 0x24, 0x11, 0x1f, 0x81, 0x3a, 0x29, 0x0e, 0x1f, 0x81, 0x38, 0x2c, 0x0c, 0x20, 0x81, 0x36, 0x30, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 46: 0x09, 0x21, 0x81, 0x35, 0x32, 0x07, 0x21, 0x81, 0x35, 0x34, 0x06, 0x21, 0x81, 0x34, 0x36, 0x04, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 47: 0x22, 0x81, 0x32, 0x39, 0x01, 0x23, 0x81, 0x32, 0x60, 0x81, 0x31, 0x61, 0x81, 0x30, 0x61, 0x81, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 48: 0x30, 0x62, 0x81, 0x2f, 0x62, 0x81, 0x2f, 0x63, 0x81, 0x2e, 0x63, 0x81, 0x2e, 0x64, 0x81, 0x2d, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 49: 0x65, 0x81, 0x2c, 0x65, 0x81, 0x2c, 0x66, 0x81, 0x2b, 0x66, 0x81, 0x2b, 0x67, 0x81, 0x2a, 0x67, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 50: 0x81, 0x2a, 0x67, 0x81, 0x2a, 0x68, 0x81, 0x29, 0x68, 0x81, 0x29, 0x69, 0x81, 0x29, 0x68, 0x81, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 51: 0x29, 0x69, 0x81, 0x28, 0x69, 0x81, 0x28, 0x69, 0x81, 0x29, 0x69, 0x81, 0x28, 0x69, 0x81, 0x28, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 52: 0x6a, 0x81, 0x27, 0x6a, 0x81, 0x28, 0x69, 0x81, 0x28, 0x6a, 0x81, 0x28, 0x69, 0x81, 0x28, 0x69, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 53: 0x81, 0x28, 0x6a, 0x81, 0x28, 0x69, 0x81, 0x28, 0x69, 0x81, 0x29, 0x69, 0x81, 0x28, 0x69, 0x81, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 54: 0x29, 0x68, 0x81, 0x2a, 0x68, 0x81, 0x29, 0x68, 0x81, 0x2a, 0x67, 0x81, 0x2b, 0x66, 0x81, 0x2b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 55: 0x67, 0x81, 0x2b, 0x66, 0x81, 0x2c, 0x65, 0x81, 0x2d, 0x65, 0x81, 0x2c, 0x65, 0x81, 0x2d, 0x64, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 56: 0x81, 0x2e, 0x63, 0x81, 0x2f, 0x63, 0x81, 0x2f, 0x62, 0x81, 0x30, 0x61, 0x81, 0x30, 0x62, 0x81, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 57: 0x30, 0x61, 0x81, 0x31, 0x60, 0x81, 0x32, 0x5f, 0x81, 0x06, 0x0d, 0x1e, 0x5f, 0x80, 0xfa, 0x1f, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 58: 0x18, 0x5e, 0x80, 0xf3, 0x29, 0x16, 0x5d, 0x80, 0xed, 0x31, 0x15, 0x5c, 0x80, 0xe8, 0x38, 0x14, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 59: 0x5c, 0x80, 0xe2, 0x3e, 0x14, 0x5b, 0x80, 0xde, 0x43, 0x14, 0x5a, 0x80, 0xdb, 0x47, 0x13, 0x5b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 60: 0x80, 0xd7, 0x4a, 0x14, 0x5a, 0x80, 0xd3, 0x4f, 0x14, 0x5a, 0x80, 0xcf, 0x53, 0x14, 0x59, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 61: 0xcc, 0x56, 0x15, 0x59, 0x80, 0xc9, 0x58, 0x16, 0x59, 0x80, 0xc5, 0x5c, 0x16, 0x58, 0x80, 0xc2, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 62: 0x5f, 0x18, 0x57, 0x80, 0xbf, 0x61, 0x19, 0x57, 0x80, 0xbb, 0x64, 0x1a, 0x58, 0x80, 0xb7, 0x66, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 63: 0x1b, 0x58, 0x80, 0xb3, 0x6a, 0x1b, 0x58, 0x80, 0xb0, 0x6c, 0x1c, 0x59, 0x80, 0xab, 0x6f, 0x1d, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 64: 0x5a, 0x80, 0xa7, 0x71, 0x1e, 0x5a, 0x80, 0xa4, 0x73, 0x1f, 0x5b, 0x80, 0x9f, 0x76, 0x20, 0x5c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 65: 0x80, 0x9b, 0x78, 0x21, 0x5d, 0x80, 0x97, 0x7a, 0x22, 0x5d, 0x80, 0x94, 0x4e, 0x11, 0x1b, 0x24, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 66: 0x5d, 0x80, 0x8f, 0x48, 0x1f, 0x16, 0x25, 0x5d, 0x80, 0x8c, 0x44, 0x28, 0x13, 0x26, 0x5d, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 67: 0x89, 0x41, 0x2f, 0x11, 0x27, 0x5d, 0x80, 0x86, 0x3e, 0x35, 0x10, 0x28, 0x5d, 0x80, 0x83, 0x3c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 68: 0x3b, 0x0e, 0x29, 0x5d, 0x80, 0x80, 0x3a, 0x3f, 0x0d, 0x2b, 0x5d, 0x50, 0x00, 0x2b, 0x38, 0x44, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 69: 0x0c, 0x2d, 0x5c, 0x4d, 0x02, 0x29, 0x36, 0x48, 0x0c, 0x2e, 0x5c, 0x4b, 0x03, 0x27, 0x35, 0x4c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 70: 0x0b, 0x2f, 0x5b, 0x49, 0x04, 0x26, 0x33, 0x1c, 0x0d, 0x25, 0x0b, 0x30, 0x5b, 0x46, 0x06, 0x24, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 71: 0x32, 0x18, 0x18, 0x21, 0x0b, 0x31, 0x5b, 0x44, 0x06, 0x23, 0x31, 0x16, 0x1e, 0x20, 0x0b, 0x33, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 72: 0x59, 0x42, 0x08, 0x21, 0x30, 0x14, 0x24, 0x1e, 0x0c, 0x34, 0x59, 0x40, 0x08, 0x20, 0x2f, 0x13, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 73: 0x29, 0x1d, 0x0c, 0x35, 0x58, 0x3e, 0x0a, 0x1e, 0x2e, 0x12, 0x2d, 0x1d, 0x0c, 0x36, 0x58, 0x3b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 74: 0x0b, 0x1d, 0x2d, 0x11, 0x31, 0x1c, 0x0d, 0x37, 0x57, 0x3a, 0x0c, 0x1b, 0x2d, 0x10, 0x34, 0x1c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 75: 0x0c, 0x38, 0x58, 0x37, 0x0d, 0x1a, 0x2c, 0x0f, 0x38, 0x1b, 0x0d, 0x39, 0x57, 0x36, 0x0d, 0x19, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 76: 0x2b, 0x0f, 0x3a, 0x1b, 0x0e, 0x39, 0x57, 0x34, 0x0f, 0x17, 0x2b, 0x0e, 0x3d, 0x1b, 0x0e, 0x3a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 77: 0x57, 0x31, 0x10, 0x16, 0x2a, 0x0e, 0x40, 0x1a, 0x0f, 0x3a, 0x57, 0x30, 0x10, 0x15, 0x2a, 0x0c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 78: 0x43, 0x1a, 0x10, 0x3a, 0x57, 0x2e, 0x11, 0x14, 0x29, 0x0c, 0x45, 0x1a, 0x11, 0x3b, 0x57, 0x2c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 79: 0x11, 0x13, 0x29, 0x0b, 0x48, 0x19, 0x12, 0x3b, 0x57, 0x2a, 0x13, 0x12, 0x28, 0x0a, 0x4a, 0x19, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 80: 0x12, 0x3c, 0x57, 0x29, 0x13, 0x11, 0x27, 0x0b, 0x4b, 0x19, 0x13, 0x3c, 0x57, 0x27, 0x14, 0x10, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 81: 0x27, 0x0a, 0x4d, 0x19, 0x14, 0x3c, 0x57, 0x26, 0x14, 0x0f, 0x27, 0x09, 0x50, 0x18, 0x15, 0x3b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 82: 0x58, 0x25, 0x14, 0x0f, 0x25, 0x09, 0x52, 0x18, 0x16, 0x3b, 0x58, 0x23, 0x15, 0x0e, 0x25, 0x08, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 83: 0x54, 0x17, 0x18, 0x3b, 0x58, 0x22, 0x15, 0x0d, 0x25, 0x08, 0x55, 0x17, 0x19, 0x3a, 0x59, 0x20, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 84: 0x16, 0x0c, 0x25, 0x07, 0x57, 0x17, 0x1a, 0x3a, 0x59, 0x1f, 0x16, 0x0c, 0x24, 0x06, 0x59, 0x17, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 85: 0x1a, 0x3a, 0x5a, 0x1d, 0x17, 0x0b, 0x24, 0x06, 0x5a, 0x16, 0x1c, 0x39, 0x5b, 0x1c, 0x17, 0x0a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 86: 0x25, 0x04, 0x5c, 0x16, 0x1d, 0x39, 0x5b, 0x1b, 0x17, 0x0a, 0x26, 0x00, 0x5f, 0x16, 0x1e, 0x38, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 87: 0x5c, 0x19, 0x18, 0x09, 0x80, 0x88, 0x15, 0x20, 0x37, 0x5d, 0x18, 0x18, 0x09, 0x80, 0x87, 0x16, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 88: 0x21, 0x36, 0x5e, 0x16, 0x19, 0x08, 0x80, 0x88, 0x15, 0x23, 0x35, 0x5f, 0x15, 0x19, 0x07, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 89: 0x89, 0x15, 0x24, 0x34, 0x60, 0x14, 0x19, 0x07, 0x80, 0x89, 0x15, 0x25, 0x33, 0x61, 0x12, 0x1a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 90: 0x06, 0x80, 0x8a, 0x14, 0x27, 0x31, 0x62, 0x12, 0x19, 0x07, 0x80, 0x8a, 0x14, 0x28, 0x30, 0x63, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 91: 0x11, 0x19, 0x06, 0x80, 0x8a, 0x14, 0x2a, 0x2f, 0x64, 0x10, 0x19, 0x06, 0x80, 0x8a, 0x14, 0x2b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 92: 0x2d, 0x66, 0x0e, 0x1a, 0x05, 0x80, 0x8b, 0x13, 0x2d, 0x2b, 0x68, 0x0d, 0x1a, 0x05, 0x80, 0x8b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 93: 0x13, 0x2f, 0x29, 0x68, 0x0d, 0x1a, 0x04, 0x80, 0x8b, 0x13, 0x31, 0x27, 0x6a, 0x0c, 0x19, 0x05, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 94: 0x80, 0x8b, 0x13, 0x32, 0x25, 0x6c, 0x0a, 0x1a, 0x04, 0x80, 0x8c, 0x12, 0x17, 0x06, 0x16, 0x22, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 95: 0x6d, 0x0a, 0x1a, 0x04, 0x80, 0x8b, 0x13, 0x15, 0x0b, 0x15, 0x1f, 0x6f, 0x09, 0x1a, 0x04, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 96: 0x8b, 0x12, 0x14, 0x0f, 0x15, 0x1b, 0x72, 0x08, 0x1a, 0x03, 0x80, 0x8c, 0x12, 0x12, 0x13, 0x15, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 97: 0x17, 0x74, 0x08, 0x1a, 0x03, 0x80, 0x8b, 0x12, 0x11, 0x16, 0x18, 0x10, 0x78, 0x06, 0x1a, 0x04, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 98: 0x80, 0x8b, 0x12, 0x10, 0x19, 0x1b, 0x07, 0x7d, 0x05, 0x1a, 0x03, 0x80, 0x8b, 0x12, 0x10, 0x1b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 99: 0x80, 0xa0, 0x05, 0x1a, 0x03, 0x80, 0x8b, 0x12, 0x0e, 0x1e, 0x80, 0xa0, 0x04, 0x1a, 0x03, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 100: 0x8b, 0x11, 0x0e, 0x20, 0x80, 0x9f, 0x04, 0x1a, 0x02, 0x80, 0x8b, 0x11, 0x0e, 0x22, 0x80, 0x9d, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 101: 0x05, 0x1a, 0x02, 0x80, 0x8b, 0x11, 0x0d, 0x24, 0x80, 0x9b, 0x06, 0x1a, 0x02, 0x80, 0x8a, 0x11, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 102: 0x0c, 0x26, 0x80, 0x9b, 0x05, 0x1b, 0x02, 0x80, 0x8a, 0x11, 0x0b, 0x28, 0x80, 0x99, 0x06, 0x1b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 103: 0x02, 0x80, 0x8a, 0x10, 0x0b, 0x2a, 0x80, 0x97, 0x07, 0x1b, 0x01, 0x80, 0x8a, 0x10, 0x0b, 0x2c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 104: 0x80, 0x95, 0x08, 0x1b, 0x01, 0x80, 0x8a, 0x10, 0x0a, 0x2d, 0x80, 0x95, 0x08, 0x1c, 0x00, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 105: 0x89, 0x10, 0x0a, 0x2f, 0x80, 0x93, 0x09, 0x1c, 0x00, 0x80, 0x89, 0x10, 0x09, 0x12, 0x06, 0x16, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 106: 0x80, 0x91, 0x0b, 0x1c, 0x00, 0x80, 0x88, 0x10, 0x09, 0x10, 0x0b, 0x15, 0x80, 0x8f, 0x0c, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 107: 0xa6, 0x0f, 0x09, 0x0f, 0x0f, 0x13, 0x80, 0x8e, 0x0d, 0x80, 0xa6, 0x0f, 0x08, 0x0f, 0x11, 0x13, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 108: 0x80, 0x8b, 0x0f, 0x80, 0xa5, 0x0f, 0x08, 0x0e, 0x14, 0x12, 0x7b, 0x02, 0x0a, 0x11, 0x80, 0xa5, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 109: 0x0e, 0x08, 0x0e, 0x16, 0x12, 0x78, 0x21, 0x80, 0xa4, 0x0f, 0x07, 0x0e, 0x18, 0x11, 0x76, 0x23, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 110: 0x80, 0xa4, 0x0e, 0x07, 0x0e, 0x1a, 0x11, 0x71, 0x27, 0x80, 0xa4, 0x0d, 0x07, 0x0e, 0x1c, 0x10, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 111: 0x6d, 0x2b, 0x80, 0xa3, 0x0e, 0x06, 0x0e, 0x1d, 0x10, 0x68, 0x30, 0x80, 0xa3, 0x0d, 0x06, 0x0e, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 112: 0x1f, 0x10, 0x5e, 0x39, 0x80, 0xa2, 0x0d, 0x06, 0x0e, 0x20, 0x10, 0x4d, 0x4a, 0x80, 0xa2, 0x0d, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 113: 0x05, 0x0e, 0x22, 0x0f, 0x44, 0x54, 0x80, 0xa1, 0x0c, 0x05, 0x0d, 0x25, 0x0d, 0x43, 0x56, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 114: 0xa0, 0x0c, 0x05, 0x0d, 0x26, 0x0c, 0x43, 0x57, 0x80, 0xa0, 0x0c, 0x04, 0x0d, 0x26, 0x0c, 0x42, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 115: 0x59, 0x80, 0x9f, 0x0c, 0x05, 0x0c, 0x26, 0x0c, 0x42, 0x5a, 0x80, 0x9f, 0x0b, 0x05, 0x0c, 0x26, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 116: 0x0c, 0x42, 0x5b, 0x80, 0x9f, 0x0b, 0x04, 0x0c, 0x26, 0x0c, 0x42, 0x5d, 0x80, 0x9d, 0x0b, 0x04, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 117: 0x0c, 0x26, 0x0b, 0x44, 0x5d, 0x80, 0x9d, 0x0a, 0x04, 0x0c, 0x26, 0x0b, 0x44, 0x5e, 0x80, 0x9c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 118: 0x0b, 0x03, 0x0c, 0x26, 0x0b, 0x44, 0x5f, 0x80, 0x9c, 0x0a, 0x03, 0x0c, 0x26, 0x0b, 0x44, 0x60, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 119: 0x80, 0x9c, 0x09, 0x03, 0x0c, 0x26, 0x0b, 0x45, 0x61, 0x80, 0x9a, 0x09, 0x04, 0x0b, 0x26, 0x0b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 120: 0x45, 0x62, 0x80, 0x9a, 0x09, 0x03, 0x0b, 0x26, 0x0b, 0x45, 0x63, 0x80, 0x99, 0x09, 0x03, 0x0b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 121: 0x26, 0x0b, 0x46, 0x64, 0x80, 0x98, 0x08, 0x03, 0x0b, 0x26, 0x0b, 0x46, 0x65, 0x80, 0x98, 0x08, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 122: 0x02, 0x0b, 0x26, 0x0b, 0x47, 0x65, 0x80, 0x97, 0x08, 0x02, 0x0c, 0x25, 0x0a, 0x48, 0x67, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 123: 0x96, 0x07, 0x03, 0x0b, 0x25, 0x0a, 0x48, 0x68, 0x80, 0x96, 0x07, 0x02, 0x0b, 0x25, 0x0a, 0x49, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 124: 0x33, 0x01, 0x32, 0x80, 0x95, 0x07, 0x02, 0x0b, 0x25, 0x0a, 0x49, 0x34, 0x07, 0x2d, 0x80, 0x94, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 125: 0x06, 0x02, 0x0b, 0x25, 0x0a, 0x49, 0x34, 0x0b, 0x2a, 0x80, 0x94, 0x06, 0x02, 0x0a, 0x25, 0x0a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 126: 0x4a, 0x1b, 0x00, 0x17, 0x0f, 0x27, 0x80, 0x92, 0x06, 0x02, 0x0a, 0x25, 0x0a, 0x4a, 0x1b, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 127: 0x16, 0x0f, 0x27, 0x80, 0x92, 0x13, 0x25, 0x0a, 0x4a, 0x19, 0x05, 0x15, 0x10, 0x28, 0x80, 0x91, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 128: 0x12, 0x25, 0x0a, 0x4b, 0x18, 0x07, 0x14, 0x10, 0x28, 0x80, 0x90, 0x12, 0x25, 0x0a, 0x4b, 0x17, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 129: 0x0a, 0x12, 0x11, 0x29, 0x80, 0x8f, 0x11, 0x25, 0x09, 0x4c, 0x17, 0x0b, 0x12, 0x11, 0x29, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 130: 0x8f, 0x10, 0x25, 0x09, 0x4d, 0x15, 0x0e, 0x11, 0x11, 0x2a, 0x6d, 0x00, 0x1e, 0x10, 0x24, 0x0a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 131: 0x4d, 0x15, 0x10, 0x0f, 0x12, 0x2b, 0x6b, 0x01, 0x1e, 0x0f, 0x24, 0x0a, 0x4d, 0x15, 0x12, 0x0e, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 132: 0x11, 0x2c, 0x6a, 0x01, 0x1f, 0x0e, 0x24, 0x0a, 0x4e, 0x15, 0x12, 0x0e, 0x11, 0x2d, 0x68, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 133: 0x1f, 0x0d, 0x24, 0x0a, 0x4e, 0x16, 0x13, 0x04, 0x1a, 0x2d, 0x67, 0x02, 0x1f, 0x0d, 0x24, 0x0a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 134: 0x4e, 0x17, 0x14, 0x00, 0x1d, 0x2e, 0x65, 0x03, 0x1f, 0x0c, 0x24, 0x0a, 0x4e, 0x19, 0x32, 0x2f, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 135: 0x63, 0x03, 0x20, 0x0b, 0x24, 0x0a, 0x4f, 0x1a, 0x30, 0x31, 0x60, 0x05, 0x20, 0x0a, 0x24, 0x09, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 136: 0x50, 0x1b, 0x31, 0x31, 0x5e, 0x06, 0x20, 0x09, 0x24, 0x09, 0x50, 0x1c, 0x32, 0x30, 0x5d, 0x06, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 137: 0x21, 0x07, 0x25, 0x09, 0x50, 0x1e, 0x32, 0x12, 0x00, 0x1c, 0x5b, 0x07, 0x22, 0x05, 0x25, 0x09, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 138: 0x51, 0x1e, 0x34, 0x0e, 0x03, 0x1c, 0x59, 0x07, 0x24, 0x01, 0x27, 0x09, 0x51, 0x20, 0x34, 0x0b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 139: 0x05, 0x1d, 0x56, 0x09, 0x4d, 0x09, 0x51, 0x21, 0x36, 0x07, 0x08, 0x1d, 0x54, 0x0a, 0x4c, 0x09, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 140: 0x51, 0x23, 0x36, 0x04, 0x0b, 0x1d, 0x52, 0x0a, 0x4b, 0x0a, 0x51, 0x23, 0x38, 0x00, 0x0e, 0x1e, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 141: 0x4f, 0x0c, 0x4a, 0x0a, 0x52, 0x23, 0x49, 0x1f, 0x4c, 0x0c, 0x4a, 0x0a, 0x52, 0x23, 0x4a, 0x20, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 142: 0x49, 0x0e, 0x49, 0x09, 0x53, 0x23, 0x4c, 0x20, 0x47, 0x0f, 0x48, 0x09, 0x53, 0x23, 0x4e, 0x21, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 143: 0x43, 0x10, 0x48, 0x09, 0x53, 0x23, 0x4f, 0x22, 0x40, 0x12, 0x47, 0x09, 0x53, 0x24, 0x50, 0x23, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 144: 0x3c, 0x13, 0x47, 0x09, 0x54, 0x23, 0x51, 0x24, 0x39, 0x15, 0x46, 0x09, 0x54, 0x15, 0x06, 0x06, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 145: 0x53, 0x25, 0x35, 0x17, 0x45, 0x09, 0x54, 0x15, 0x0c, 0x01, 0x20, 0x01, 0x2f, 0x28, 0x31, 0x18, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 146: 0x44, 0x0a, 0x54, 0x16, 0x2a, 0x0c, 0x27, 0x2d, 0x2b, 0x1b, 0x43, 0x0a, 0x54, 0x17, 0x28, 0x10, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 147: 0x24, 0x30, 0x26, 0x1e, 0x42, 0x0a, 0x54, 0x17, 0x27, 0x06, 0x06, 0x06, 0x21, 0x35, 0x1f, 0x20, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 148: 0x42, 0x09, 0x55, 0x18, 0x25, 0x05, 0x0b, 0x05, 0x1e, 0x3b, 0x16, 0x25, 0x41, 0x09, 0x55, 0x19, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 149: 0x24, 0x04, 0x10, 0x03, 0x1c, 0x44, 0x05, 0x2e, 0x40, 0x09, 0x55, 0x19, 0x24, 0x03, 0x13, 0x03, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 150: 0x1a, 0x79, 0x40, 0x09, 0x56, 0x19, 0x23, 0x03, 0x08, 0x03, 0x08, 0x03, 0x17, 0x7b, 0x3f, 0x09, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 151: 0x56, 0x1a, 0x22, 0x03, 0x06, 0x09, 0x06, 0x03, 0x16, 0x7a, 0x3e, 0x0a, 0x56, 0x1b, 0x22, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 152: 0x05, 0x0d, 0x05, 0x03, 0x15, 0x7a, 0x3d, 0x0a, 0x56, 0x1c, 0x21, 0x02, 0x05, 0x0f, 0x05, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 153: 0x15, 0x7a, 0x3c, 0x0e, 0x52, 0x1d, 0x21, 0x02, 0x04, 0x11, 0x05, 0x02, 0x15, 0x78, 0x3c, 0x14, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 154: 0x4c, 0x1d, 0x21, 0x02, 0x04, 0x13, 0x04, 0x02, 0x15, 0x78, 0x3b, 0x1a, 0x46, 0x1e, 0x21, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 155: 0x04, 0x14, 0x04, 0x02, 0x14, 0x78, 0x3a, 0x23, 0x3d, 0x21, 0x1f, 0x01, 0x04, 0x15, 0x04, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 156: 0x14, 0x77, 0x3a, 0x3b, 0x25, 0x25, 0x1c, 0x01, 0x03, 0x17, 0x03, 0x02, 0x14, 0x77, 0x38, 0x3b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 157: 0x26, 0x28, 0x19, 0x02, 0x03, 0x17, 0x04, 0x01, 0x14, 0x77, 0x37, 0x3b, 0x26, 0x2c, 0x16, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 158: 0x03, 0x17, 0x04, 0x02, 0x13, 0x76, 0x37, 0x3a, 0x27, 0x30, 0x13, 0x02, 0x03, 0x18, 0x03, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 159: 0x13, 0x76, 0x36, 0x3a, 0x27, 0x31, 0x13, 0x02, 0x03, 0x18, 0x03, 0x02, 0x13, 0x76, 0x35, 0x39, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 160: 0x28, 0x32, 0x13, 0x02, 0x03, 0x18, 0x03, 0x02, 0x13, 0x76, 0x33, 0x39, 0x28, 0x34, 0x13, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 161: 0x03, 0x18, 0x03, 0x02, 0x16, 0x72, 0x33, 0x39, 0x28, 0x35, 0x13, 0x02, 0x03, 0x17, 0x04, 0x01, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 162: 0x19, 0x70, 0x32, 0x38, 0x29, 0x36, 0x13, 0x02, 0x03, 0x17, 0x03, 0x02, 0x1c, 0x6d, 0x31, 0x37, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 163: 0x2a, 0x37, 0x14, 0x01, 0x04, 0x16, 0x03, 0x02, 0x1e, 0x6a, 0x30, 0x37, 0x2b, 0x38, 0x14, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 164: 0x03, 0x15, 0x04, 0x02, 0x21, 0x67, 0x2f, 0x36, 0x2c, 0x3a, 0x13, 0x02, 0x04, 0x14, 0x03, 0x03, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 165: 0x21, 0x67, 0x2e, 0x35, 0x2d, 0x3b, 0x14, 0x02, 0x04, 0x12, 0x04, 0x02, 0x22, 0x67, 0x2d, 0x34, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 166: 0x2e, 0x3c, 0x14, 0x02, 0x04, 0x11, 0x04, 0x03, 0x21, 0x67, 0x2c, 0x33, 0x2f, 0x3e, 0x15, 0x02, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 167: 0x05, 0x0e, 0x05, 0x02, 0x22, 0x67, 0x2b, 0x32, 0x30, 0x40, 0x14, 0x03, 0x05, 0x0b, 0x06, 0x03, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 168: 0x22, 0x67, 0x2a, 0x30, 0x32, 0x40, 0x16, 0x02, 0x07, 0x07, 0x07, 0x03, 0x23, 0x67, 0x28, 0x2f, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 169: 0x34, 0x3f, 0x19, 0x03, 0x14, 0x03, 0x24, 0x67, 0x27, 0x2d, 0x35, 0x40, 0x1b, 0x03, 0x12, 0x03, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 170: 0x25, 0x67, 0x29, 0x28, 0x37, 0x40, 0x1d, 0x04, 0x0e, 0x04, 0x26, 0x66, 0x2d, 0x21, 0x3a, 0x3f, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 171: 0x20, 0x05, 0x0a, 0x05, 0x26, 0x67, 0x31, 0x18, 0x3e, 0x3f, 0x23, 0x12, 0x28, 0x67, 0x39, 0x07, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 172: 0x45, 0x40, 0x25, 0x0f, 0x29, 0x68, 0x80, 0x86, 0x3f, 0x2b, 0x08, 0x2c, 0x68, 0x80, 0x85, 0x3f, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 173: 0x53, 0x05, 0x08, 0x68, 0x80, 0x83, 0x42, 0x51, 0x0d, 0x00, 0x69, 0x80, 0x82, 0x43, 0x51, 0x78, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 174: 0x80, 0x80, 0x46, 0x4f, 0x78, 0x80, 0x80, 0x3d, 0x04, 0x04, 0x4e, 0x77, 0x80, 0x80, 0x3b, 0x0c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 175: 0x01, 0x4d, 0x75, 0x80, 0x81, 0x3c, 0x0c, 0x02, 0x4b, 0x75, 0x80, 0x80, 0x3e, 0x0c, 0x02, 0x4a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 176: 0x75, 0x80, 0x80, 0x3f, 0x0c, 0x03, 0x0e, 0x00, 0x38, 0x75, 0x7f, 0x41, 0x0c, 0x03, 0x0b, 0x04, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 177: 0x36, 0x76, 0x7e, 0x42, 0x0c, 0x04, 0x09, 0x06, 0x35, 0x75, 0x7d, 0x44, 0x0c, 0x05, 0x05, 0x0b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 178: 0x34, 0x74, 0x7b, 0x46, 0x0c, 0x06, 0x02, 0x06, 0x00, 0x06, 0x33, 0x74, 0x7a, 0x34, 0x01, 0x10, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 179: 0x0d, 0x0e, 0x03, 0x05, 0x33, 0x73, 0x78, 0x35, 0x04, 0x0e, 0x0d, 0x0d, 0x04, 0x07, 0x31, 0x73, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 180: 0x76, 0x36, 0x06, 0x0c, 0x0f, 0x0a, 0x08, 0x06, 0x31, 0x72, 0x74, 0x37, 0x08, 0x08, 0x15, 0x06, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 181: 0x0a, 0x05, 0x31, 0x72, 0x73, 0x37, 0x0a, 0x04, 0x1a, 0x03, 0x0c, 0x04, 0x32, 0x72, 0x70, 0x38, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 182: 0x0d, 0x01, 0x1d, 0x00, 0x0d, 0x04, 0x32, 0x72, 0x6e, 0x39, 0x3e, 0x03, 0x1a, 0x04, 0x13, 0x72, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 183: 0x6b, 0x3a, 0x40, 0x01, 0x12, 0x0d, 0x13, 0x73, 0x68, 0x3c, 0x40, 0x01, 0x12, 0x0e, 0x12, 0x73, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 184: 0x66, 0x3f, 0x3e, 0x02, 0x11, 0x10, 0x11, 0x74, 0x62, 0x42, 0x3d, 0x03, 0x11, 0x10, 0x10, 0x76, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 185: 0x5f, 0x45, 0x3b, 0x04, 0x11, 0x11, 0x0d, 0x79, 0x5c, 0x48, 0x39, 0x05, 0x10, 0x13, 0x0b, 0x7b, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 186: 0x59, 0x4b, 0x38, 0x05, 0x10, 0x13, 0x09, 0x7f, 0x54, 0x4f, 0x36, 0x06, 0x10, 0x14, 0x06, 0x80, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 187: 0x82, 0x50, 0x53, 0x34, 0x06, 0x10, 0x16, 0x03, 0x80, 0x86, 0x4c, 0x55, 0x34, 0x07, 0x0f, 0x17, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 188: 0x00, 0x80, 0x89, 0x47, 0x59, 0x17, 0x04, 0x18, 0x09, 0x0b, 0x80, 0xa5, 0x42, 0x5b, 0x15, 0x0a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 189: 0x15, 0x0c, 0x08, 0x80, 0xa8, 0x3b, 0x5f, 0x13, 0x05, 0x02, 0x05, 0x14, 0x0f, 0x04, 0x80, 0xaa, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 190: 0x35, 0x62, 0x12, 0x04, 0x08, 0x04, 0x12, 0x80, 0xc3, 0x2c, 0x67, 0x11, 0x03, 0x0c, 0x03, 0x11, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 191: 0x80, 0xc8, 0x20, 0x6e, 0x10, 0x02, 0x10, 0x02, 0x11, 0x80, 0xd1, 0x0b, 0x78, 0x10, 0x02, 0x04, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 192: 0x07, 0x05, 0x02, 0x10, 0x81, 0x56, 0x10, 0x01, 0x04, 0x0a, 0x03, 0x02, 0x11, 0x81, 0x4e, 0x16, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 193: 0x02, 0x03, 0x0c, 0x03, 0x02, 0x14, 0x81, 0x46, 0x1a, 0x01, 0x03, 0x0e, 0x03, 0x01, 0x1a, 0x81, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 194: 0x40, 0x19, 0x01, 0x03, 0x10, 0x02, 0x02, 0x19, 0x81, 0x40, 0x19, 0x01, 0x03, 0x10, 0x03, 0x01, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 195: 0x19, 0x81, 0x40, 0x19, 0x01, 0x02, 0x12, 0x02, 0x01, 0x19, 0x81, 0x40, 0x19, 0x01, 0x02, 0x12, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 196: 0x02, 0x01, 0x19, 0x81, 0x40, 0x19, 0x01, 0x02, 0x12, 0x02, 0x01, 0x19, 0x81, 0x40, 0x19, 0x01, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 197: 0x02, 0x12, 0x02, 0x02, 0x18, 0x81, 0x40, 0x19, 0x01, 0x02, 0x12, 0x02, 0x01, 0x19, 0x81, 0x40, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 198: 0x19, 0x01, 0x02, 0x12, 0x02, 0x01, 0x19, 0x81, 0x40, 0x19, 0x01, 0x02, 0x11, 0x03, 0x01, 0x19, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 199: 0x81, 0x40, 0x19, 0x01, 0x03, 0x10, 0x02, 0x02, 0x19, 0x81, 0x40, 0x19, 0x02, 0x02, 0x0f, 0x03, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 200: 0x02, 0x19, 0x81, 0x41, 0x19, 0x01, 0x03, 0x0e, 0x03, 0x01, 0x18, 0x81, 0x4d, 0x0f, 0x02, 0x03, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 201: 0x0c, 0x03, 0x02, 0x10, 0x81, 0x55, 0x10, 0x01, 0x04, 0x0a, 0x03, 0x02, 0x10, 0x81, 0x57, 0x10, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 202: 0x02, 0x05, 0x04, 0x05, 0x02, 0x11, 0x81, 0x57, 0x11, 0x02, 0x0e, 0x03, 0x11, 0x81, 0x57, 0x12, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 203: 0x02, 0x0c, 0x02, 0x12, 0x81, 0x59, 0x12, 0x03, 0x08, 0x03, 0x13, 0x81, 0x59, 0x13, 0x0e, 0x13, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 204: 0x81, 0x5b, 0x14, 0x0a, 0x15, 0x81, 0x5b, 0x34, 0x81, 0x5c, 0x34, 0x81, 0x5c, 0x35, 0x81, 0x5a, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 205: 0x37, 0x81, 0x58, 0x39, 0x81, 0x56, 0x3a, 0x81, 0x55, 0x3c, 0x81, 0x53, 0x3e, 0x81, 0x52, 0x3f, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 206: 0x81, 0x50, 0x40, 0x81, 0x51, 0x3f, 0x81, 0x51, 0x0e, 0x00, 0x1e, 0x00, 0x0e, 0x81, 0x53, 0x0c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 207: 0x03, 0x1b, 0x02, 0x0c, 0x81, 0x55, 0x0a, 0x06, 0x16, 0x07, 0x09, 0x81, 0x57, 0x08, 0x0a, 0x11, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 208: 0x0a, 0x07, 0x81, 0x5a, 0x05, 0x0c, 0x0e, 0x0d, 0x05, 0x81, 0x5c, 0x03, 0x0e, 0x0c, 0x0f, 0x03, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 209: 0x81, 0x5e, 0x00, 0x10, 0x0c, 0x10, 0x01, 0x81, 0x71, 0x0c, 0x81, 0x84, 0x0c, 0x81, 0x84, 0x0c, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 210: 0x81, 0x84, 0x0c, 0x81, 0x84, 0x0c, 0x81, 0x84, 0x0c, 0x81, 0x84, 0x0c, 0x81, 0x85, 0x0a, 0x65,}, line over 96 characters https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 216: unsigned ret; Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 244: (cbui_logo.heigth > fbinfo->y_resolution)) 'heigth' may be misspelled - perhaps 'height'? https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 248: offset_y = fbinfo->y_resolution / 2 - cbui_logo.heigth / 2; 'heigth' may be misspelled - perhaps 'height'? https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 259: for (y = 0; y < cbui_logo.heigth; y ++) { 'heigth' may be misspelled - perhaps 'height'? https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 259: for (y = 0; y < cbui_logo.heigth; y ++) { space prohibited before that '++' (ctx:WxB) https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 260: for (x = 0; x < cbui_logo.width; x ++) { space prohibited before that '++' (ctx:WxB) https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 288: (cbui_logo.heigth > fbinfo->y_resolution)) 'heigth' may be misspelled - perhaps 'height'? https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 293: offset_y = fbinfo->y_resolution / 2 + cbui_logo.heigth / 2 + height * 2; 'heigth' may be misspelled - perhaps 'height'? https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 299: for (x = 0; x < cbui_logo.width; x ++) { space prohibited before that '++' (ctx:WxB) https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/splash.c… PS5, Line 301: for (y = 0; y < height; y ++) { space prohibited before that '++' (ctx:WxB) https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/vbe.h File payloads/cbui/gfx/vbe.h: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/vbe.h@28 PS5, Line 28: { open brace '{' following struct go on the same line https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/vbe.c File payloads/cbui/gfx/vbe.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/vbe.c@24 PS5, Line 24: static u8 low_mem[0x1000] __attribute__ ((section (".lowmem"))); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/vbe.c@32 PS5, Line 32: memset (vbe, 0, sizeof(*vbe)); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/gfx/vbe.c@33 PS5, Line 33: memcpy (vbe->signature, "VBE2", 4); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/lang/de.c File payloads/cbui/lang/de.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/lang/de.c@39 PS5, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/lang/de.c@44 PS5, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/lang/de.c@47 PS5, Line 47: "Kein Platz auf dem Heap.\nBitte vergrößere den" \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/lang/de.c@50 PS5, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/lang/de.c@52 PS5, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/lang/de.c@65 PS5, Line 65: "Fehler: Keine CMOS Einträge gefunden. Bitte schalte die " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/lang/de.c@86 PS5, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/lang/de.c@89 PS5, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/lang/en.c File payloads/cbui/lang/en.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/lang/en.c@38 PS5, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/lang/en.c@46 PS5, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/lang/en.c@60 PS5, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/lang/en.c@81 PS5, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/lang/en.c@84 PS5, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/lang/lang.c File payloads/cbui/lang/lang.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/lang/lang.c@… PS5, Line 50: * To be used for untranslateable items. */ 'untranslateable' may be misspelled - perhaps 'untranslatable'? https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/boot… File payloads/cbui/modules/bootlog_module.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/boot… PS5, Line 66: if (buffer[i] == '\n') { braces {} are not necessary for any arm of this statement https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/boot… PS5, Line 79: } void function return statements are not generally useful https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cbfs… File payloads/cbui/modules/cbfs_module.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cbfs… PS5, Line 91: switch (ntohl(type)) { switch and case should be at the same indent https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cbfs… PS5, Line 140: struct nuklear_group* group = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/core… File payloads/cbui/modules/coreboot_module.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/core… PS5, Line 262: if (cb_info.framebuffer.tag != 0 ) { space prohibited before that close parenthesis ')' https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cpui… File payloads/cbui/modules/cpuinfo_module.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cpui… PS5, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cpui… PS5, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cpui… PS5, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cpui… PS5, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cpui… PS5, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cpui… PS5, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cpui… PS5, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cpui… PS5, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cpui… PS5, Line 100: static void mod_add_cpu_feature(struct nuklear_group* group, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cpui… PS5, Line 119: static void mod_open(struct nuklear_module* this) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cpui… PS5, Line 128: struct nuklear_group* group1 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cpui… PS5, Line 189: struct nuklear_group* group2 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cpui… PS5, Line 192: struct nuklear_group* group3 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cpui… PS5, Line 195: struct nuklear_group* group4 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cpui… PS5, Line 198: struct nuklear_group* group5 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cpui… PS5, Line 232: static void mod_close(struct nuklear_module* this, bool save) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cpui… PS5, Line 237: static bool mod_update(struct nuklear_module* this) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cpui… PS5, Line 242: static void mod_draw(struct nuklear_module* this, struct nk_context *ctx) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/cpui… PS5, Line 247: static bool mod_handlekey(struct nuklear_module* this, struct nk_context *ctx) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/lice… File payloads/cbui/modules/license_module.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/lice… PS5, Line 24: struct nuklear_group* group1 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/lice… PS5, Line 65: struct nuklear_group* group2 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/lice… PS5, Line 77: "along with this program; if not, write to the Free Software\n" Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/lice… PS5, Line 78: "Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA " Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/lice… PS5, Line 83: struct nuklear_group* group3 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/pci_… File payloads/cbui/modules/pci_module.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/pci_… PS5, Line 75: switch (class) { switch and case should be at the same indent https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/pci_… PS5, Line 93: case 0x11: return "Data Acquisition and Signal Processing" \ Avoid unnecessary line continuations https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/pci_… PS5, Line 96: if (class == 0xff) return ""; trailing statements should be on next line https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/pci_… PS5, Line 204: struct nuklear_group* group1 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/rtc_… File payloads/cbui/modules/rtc_module.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/rtc_… PS5, Line 27: static struct nuklear_timepicker* tp; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/rtc_… PS5, Line 28: static struct nuklear_datepicker* dp; "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/time… File payloads/cbui/modules/timestamps_module.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/time… PS5, Line 63: struct nuklear_group* group1 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/time… PS5, Line 121: } void function return statements are not generally useful https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/usb_… File payloads/cbui/modules/usb_module.c: https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/usb_… PS5, Line 37: struct nuklear_group* group1 = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/usb_… PS5, Line 56: switch(controller->type) { space required before the open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/usb_… PS5, Line 96: switch(controller->type) { space required before the open parenthesis '(' https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/usb_… PS5, Line 126: struct nuklear_group* group = NuklearGroup_new(this->root, "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/23586/5/payloads/cbui/modules/usb_… PS5, Line 147: switch(controller->devices[i]->speed) { space required before the open parenthesis '(' -- To view, visit https://review.coreboot.org/c/coreboot/+/23586 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib9a1a07c1065880aa675380625021750d5cab7d1 Gerrit-Change-Number: 23586 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Wed, 04 Mar 2020 11:02:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/cbui: Add new payload CBUI
by Patrick Georgi (Code Review) 04 Mar '20

04 Mar '20

Patrick Georgi has uploaded a new patch set (#5) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/23586 ) Change subject: payloads/cbui: Add new payload CBUI ...................................................................... payloads/cbui: Add new payload CBUI Depends on libpayload and nuklear. Features: * Graphical menus with scrolling. * Text rendering engine (atm only bitmap font) * Support for keyboard and mouse * Support for USB and PS/2 devices * Ported coreinfo and nvramcui * Allows to modify NVRAM and RTC * Works as ELF payload * Works as Seabios secondary payload * Basic support for multiple languages * Hacky support for BIOS calls (depends on NASM) * Runs in qemu and on real hardware * Use linker script to allocate low memory Shortcommings: * Doesn't work in VGA text mode * Untested on UEFI * int32 relocates itself to low memory Licenses: * GPLv2 (CBUI + libpayload) * BSD (libpayload) * MIT (nuklear) TODO: * Test on as much platforms as possible * Link int32 into low memory Change-Id: Ib9a1a07c1065880aa675380625021750d5cab7d1 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M payloads/Kconfig M payloads/Makefile.inc A payloads/cbui/Kconfig A payloads/cbui/Makefile A payloads/cbui/NuklearUI/NuklearCombo.c A payloads/cbui/NuklearUI/NuklearCombo.h A payloads/cbui/NuklearUI/NuklearDatePicker.c A payloads/cbui/NuklearUI/NuklearDatePicker.h A payloads/cbui/NuklearUI/NuklearGroup.c A payloads/cbui/NuklearUI/NuklearGroup.h A payloads/cbui/NuklearUI/NuklearIntegerRange.c A payloads/cbui/NuklearUI/NuklearIntegerRange.h A payloads/cbui/NuklearUI/NuklearLabel.c A payloads/cbui/NuklearUI/NuklearLabel.h A payloads/cbui/NuklearUI/NuklearObject.c A payloads/cbui/NuklearUI/NuklearObject.h A payloads/cbui/NuklearUI/NuklearRoot.c A payloads/cbui/NuklearUI/NuklearStyle.c A payloads/cbui/NuklearUI/NuklearStyle.h A payloads/cbui/NuklearUI/NuklearTabView.c A payloads/cbui/NuklearUI/NuklearTextView.c A payloads/cbui/NuklearUI/NuklearTextView.h A payloads/cbui/NuklearUI/NuklearTextfield.c A payloads/cbui/NuklearUI/NuklearTextfield.h A payloads/cbui/NuklearUI/NuklearTimePicker.c A payloads/cbui/NuklearUI/NuklearTimePicker.h A payloads/cbui/NuklearUI/NuklearUI.h A payloads/cbui/NuklearUI/NuklearVector.c A payloads/cbui/NuklearUI/NuklearVector.h A payloads/cbui/arch/x86/cpuid.c A payloads/cbui/arch/x86/cpuid.h A payloads/cbui/arch/x86/int32.h A payloads/cbui/arch/x86/int32.ld A payloads/cbui/arch/x86/int32.nasm A payloads/cbui/arch/x86/memcpy.c A payloads/cbui/arch/x86/memcpy.h A payloads/cbui/arch/x86/vga.c A payloads/cbui/arch/x86/vga.h A payloads/cbui/cbui.c A payloads/cbui/cbui.h A payloads/cbui/gfx/coreboot.c A payloads/cbui/gfx/coreboot.h A payloads/cbui/gfx/gfx.c A payloads/cbui/gfx/gfx.h A payloads/cbui/gfx/splash.c A payloads/cbui/gfx/splash.h A payloads/cbui/gfx/vbe.c A payloads/cbui/gfx/vbe.h A payloads/cbui/lang/de.c A payloads/cbui/lang/en.c A payloads/cbui/lang/lang.c A payloads/cbui/lang/lang.h A payloads/cbui/logo/cbui.png A payloads/cbui/lp.config A payloads/cbui/modules/bootlog_module.c A payloads/cbui/modules/cbfs_module.c A payloads/cbui/modules/cmos_module.c A payloads/cbui/modules/coreboot_module.c A payloads/cbui/modules/cpuinfo_module.c A payloads/cbui/modules/license_module.c A payloads/cbui/modules/modules.c A payloads/cbui/modules/nvram_module.c A payloads/cbui/modules/pci_module.c A payloads/cbui/modules/reboot_module.c A payloads/cbui/modules/rtc_module.c A payloads/cbui/modules/timestamps_module.c A payloads/cbui/modules/usb_module.c A payloads/libpayload/configs/defconfig-cbui 68 files changed, 8,715 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/23586/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/23586 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib9a1a07c1065880aa675380625021750d5cab7d1 Gerrit-Change-Number: 23586 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2020