Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39164 )
Change subject: soc/intel/apollolake: Fix flashconsole, again
......................................................................
soc/intel/apollolake: Fix flashconsole, again
This time, it failed to build if measured boot was not enabled. Fix this
problem, and make sure flashconsole will not break like that again.
Change-Id: I5f5ffd14a3225804524cb0c1518e3d99737e0a93
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
A configs/config.google_octopus_spi_flash_console
M src/soc/intel/apollolake/Makefile.inc
2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/39164/1
diff --git a/configs/config.google_octopus_spi_flash_console b/configs/config.google_octopus_spi_flash_console
new file mode 100644
index 0000000..df8889b
--- /dev/null
+++ b/configs/config.google_octopus_spi_flash_console
@@ -0,0 +1,4 @@
+CONFIG_VENDOR_GOOGLE=y
+CONFIG_BOARD_GOOGLE_OCTOPUS=y
+CONFIG_CONSOLE_SPI_FLASH=y
+# CONFIG_VBOOT_MEASURED_BOOT is not set
diff --git a/src/soc/intel/apollolake/Makefile.inc b/src/soc/intel/apollolake/Makefile.inc
index 1fbdc91..0d72bc8 100644
--- a/src/soc/intel/apollolake/Makefile.inc
+++ b/src/soc/intel/apollolake/Makefile.inc
@@ -77,7 +77,7 @@
postcar-y += heci.c
postcar-y += reset.c
postcar-y += uart.c
-postcar-$(CONFIG_VBOOT_MEASURED_BOOT) += gspi.c
+postcar-y += gspi.c
verstage-y += car.c
verstage-y += i2c.c
--
To view, visit https://review.coreboot.org/c/coreboot/+/39164
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f5ffd14a3225804524cb0c1518e3d99737e0a93
Gerrit-Change-Number: 39164
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newchange
Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38392 )
Change subject: drivers/i2c/at24rf08c: Move opening bracket to line above
......................................................................
drivers/i2c/at24rf08c: Move opening bracket to line above
Adhere to the coding style.
Change-Id: Ia12a4ed6ab2fb2c9848a2688b41fcfa70ab001b0
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
M src/drivers/i2c/at24rf08c/at24rf08c.c
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/38392/1
diff --git a/src/drivers/i2c/at24rf08c/at24rf08c.c b/src/drivers/i2c/at24rf08c/at24rf08c.c
index daf04a9..b1ea6fa 100644
--- a/src/drivers/i2c/at24rf08c/at24rf08c.c
+++ b/src/drivers/i2c/at24rf08c/at24rf08c.c
@@ -31,8 +31,7 @@
printk (BIOS_DEBUG, "Locking EEPROM RFID\n");
- for (i = 0; i < 8; i++)
- {
+ for (i = 0; i < 8; i++) {
/* After a register write AT24RF08C sometimes stops responding.
Retry several times in case of failure. */
for (j = 0; j < 100; j++)
--
To view, visit https://review.coreboot.org/c/coreboot/+/38392
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia12a4ed6ab2fb2c9848a2688b41fcfa70ab001b0
Gerrit-Change-Number: 38392
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newchange
Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38391 )
Change subject: drivers/i2c/at24rf08c: Correctly format short multi-line comments
......................................................................
drivers/i2c/at24rf08c: Correctly format short multi-line comments
Change-Id: I84e09706aceae69671ce429d77e7874128468307
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
M src/drivers/i2c/at24rf08c/at24rf08c.c
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/38391/1
diff --git a/src/drivers/i2c/at24rf08c/at24rf08c.c b/src/drivers/i2c/at24rf08c/at24rf08c.c
index 102e0e8..daf04a9 100644
--- a/src/drivers/i2c/at24rf08c/at24rf08c.c
+++ b/src/drivers/i2c/at24rf08c/at24rf08c.c
@@ -25,7 +25,7 @@
return;
/* Ensure that EEPROM/RFID chip is not accessible through RFID.
- Need to do it only on 5c. */
+ Need to do it only on 5c. */
if (dev->path.type != DEVICE_PATH_I2C || dev->path.i2c.device != 0x5c)
return;
@@ -34,8 +34,7 @@
for (i = 0; i < 8; i++)
{
/* After a register write AT24RF08C sometimes stops responding.
- Retry several times in case of failure.
- */
+ Retry several times in case of failure. */
for (j = 0; j < 100; j++)
if (smbus_write_byte(dev, i, 0x0f) >= 0)
break;
--
To view, visit https://review.coreboot.org/c/coreboot/+/38391
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I84e09706aceae69671ce429d77e7874128468307
Gerrit-Change-Number: 38391
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newchange