coreboot-gerrit March 2020

coreboot-gerrit@coreboot.org

1 participants
3326 discussions

Change in coreboot[master]: mb/tglrvp: Update Audio AIC settings for Tiger Lake
by Srinidhi N Kaushik (Code Review) 20 Mar '20

20 Mar '20

1 0

Change in coreboot[master]: mb/tglrvp: Update Audio AIC settings for Tiger Lake
by Srinidhi N Kaushik (Code Review) 20 Mar '20

20 Mar '20

Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39466 ) Change subject: mb/tglrvp: Update Audio AIC settings for Tiger Lake ...................................................................... Patch Set 5: (1 comment) > Patch Set 4: > > (1 comment) https://review.coreboot.org/c/coreboot/+/39466/4/src/mainboard/intel/tglrvp… File src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb: https://review.coreboot.org/c/coreboot/+/39466/4/src/mainboard/intel/tglrvp… PS4, Line 7: # GPE configuration : # Note that GPE events called out in ASL code rely on this : # route. i.e. If this route changes then the affected GPE : # offset bits also need to be changed. : register "pmc_gpe0_dw0" = "GPP_B" : register "pmc_gpe0_dw1" = "GPP_D" : register "pmc_gpe0_dw2" = "GPP_E" > Is it related to Audio? Not related to Audio. Moved it out -- To view, visit https://review.coreboot.org/c/coreboot/+/39466 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45935b79f6fa4ad66238eead9258a4f15feec508 Gerrit-Change-Number: 39466 Gerrit-PatchSet: 5 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Mar 2020 17:25:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/tglrvp: Update Audio AIC settings for Tiger Lake
by Srinidhi N Kaushik (Code Review) 20 Mar '20

20 Mar '20

Hello build bot (Jenkins), Shaunak Saha, Wonkyu Kim, Nick Vaccaro, Raj Astekar, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/39466 to look at the new patch set (#5). Change subject: mb/tglrvp: Update Audio AIC settings for Tiger Lake ...................................................................... mb/tglrvp: Update Audio AIC settings for Tiger Lake Update Audio AIC UPD settings and gpio pad configs for Tiger Lake. BUG=none BRANCH=none TEST=Build and boot tigerlake rvp board Signed-off-by: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Change-Id: I45935b79f6fa4ad66238eead9258a4f15feec508 --- M src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb M src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb M src/mainboard/intel/tglrvp/variants/tglrvp_up4/gpio.c 4 files changed, 24 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/39466/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/39466 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45935b79f6fa4ad66238eead9258a4f15feec508 Gerrit-Change-Number: 39466 Gerrit-PatchSet: 5 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/deltaur: add deltaur mainboard initial support
by EricR Lai (Code Review) 20 Mar '20

20 Mar '20

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39502 ) Change subject: mb/google/deltaur: add deltaur mainboard initial support ...................................................................... Patch Set 7: Code-Review+1 LGTM. -- To view, visit https://review.coreboot.org/c/coreboot/+/39502 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib98f328df22f39e7d9d625a3292954881ee15b15 Gerrit-Change-Number: 39502 Gerrit-PatchSet: 7 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kevin Chowski <chowski(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-CC: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-CC: Cliff Huang <cliff.huang(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Selma Bensaid <selma.bensaid(a)intel.corp-partner.google.com> Gerrit-CC: Varun Joshi <varun.joshi(a)intel.com> Gerrit-Comment-Date: Fri, 20 Mar 2020 17:07:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: jasperlake_rvp: UART config for JSLRVP
by Paul Menzel (Code Review) 20 Mar '20

20 Mar '20

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39196 ) Change subject: jasperlake_rvp: UART config for JSLRVP ...................................................................... Patch Set 12: (1 comment) https://review.coreboot.org/c/coreboot/+/39196/5//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/39196/5//COMMIT_MSG@7 PS5, Line 7: jasperlake_rvp: UART config for JSLRVP > Done It’s unfortunately not. -- To view, visit https://review.coreboot.org/c/coreboot/+/39196 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic042cdc449b77c2d9bdd7a63777328e47f910654 Gerrit-Change-Number: 39196 Gerrit-PatchSet: 12 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Fri, 20 Mar 2020 16:32:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Comment-In-Reply-To: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Add new GSoC projects
by Patrick Rudolph (Code Review) 20 Mar '20

20 Mar '20

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38829 ) Change subject: Documentation: Add new GSoC projects ...................................................................... Documentation: Add new GSoC projects Change-Id: I5d67361286da04819def3227b2c6cb41a063fc5b Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M Documentation/contributing/project_ideas.md 1 file changed, 51 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/38829/1 diff --git a/Documentation/contributing/project_ideas.md b/Documentation/contributing/project_ideas.md index 90164a2..4090e9e 100644 --- a/Documentation/contributing/project_ideas.md +++ b/Documentation/contributing/project_ideas.md @@ -179,3 +179,54 @@ ### Mentors * Ron Minnich <rminnich(a)google.com> + +## Complete the automatic FMAP generation +Improve automatically generated FMAPs in coreboot. + +FMAPs describe the flash layout, seperating the flash chip into regions +and sub-regions. coreboot is placed in one or multiple of this regions, +but usually additional ones are required (Intel ME, MRC cache, ...). + +Currently the FMAP needs to manually generated on non-x86 devices or if +VBOOT is to be used. It would be useful to extend the current tools +to automatically generated FMAPs based on selected architecture and +SoC. + +### Requirements +* coreboot knowledge: Have a general concept of the build system +* other knowledge: Experience with C and bash +* hardware requirements: Nothing special + +### Mentors +* Patrick Rudolph <patrick.rudolph(a)9elements.com> +* Christian Walter <christian.walter(a)9elements.com> + +## Boardstatus replacement +The [Board status page](https://coreboot.org/status/board-status.html) allows +to see last working commit of a board. The page is generated by a cron job +that runs on a huge git reposity. + +Build an open source replacement using exisiting tools and libraries, +consisting out of a backend, a frontend and client side scripts. +The backend should connect to an SQL database with can be controlled using +a REST API / gRPC / XMLRPC connection. + +The frontend should use React to display the current board status. + +Provide a script that allows to: +1. Push mainboard details from coreboot master CI +2. Push mainboard test results from authenticated users containing + * commit hash + * bootlog + * dmesg + * timestamps + * coreboot config + +### Requirements +* coreboot knowledge: Not required +* software knowledge: You must be able to implement a nice website with + client/server model using an SQL database, authentication and RPC interfaces. + +### Mentors +* Patrick Rudolph <patrick.rudolph(a)9elements.com> +* Christian Walter <christian.walter(a)9elements.com> -- To view, visit https://review.coreboot.org/c/coreboot/+/38829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d67361286da04819def3227b2c6cb41a063fc5b Gerrit-Change-Number: 38829 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

7 23

Change in coreboot[master]: acpi: correct the processor devices scope
by Michał Żygowski (Code Review) 20 Mar '20

20 Mar '20

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39698 ) Change subject: acpi: correct the processor devices scope ...................................................................... Patch Set 4: Okay, NVM. Managed to patch the tables and seems to work well. Just test on other AMD platforms please. -- To view, visit https://review.coreboot.org/c/coreboot/+/39698 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35f112e9f9f15f06ddb83b4192f082f9e51a969c Gerrit-Change-Number: 39698 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Fri, 20 Mar 2020 14:29:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/scripts/gerrit-rebase: Fix shell invocation
by Patrick Georgi (Code Review) 20 Mar '20

20 Mar '20

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39397 ) Change subject: util/scripts/gerrit-rebase: Fix shell invocation ...................................................................... util/scripts/gerrit-rebase: Fix shell invocation The single apostrophe confuses the shell that's calling the command. Change-Id: I7d3183e9a612de0121b2d208c06a45645b8d67f6 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/scripts/gerrit-rebase 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/39397/1 diff --git a/util/scripts/gerrit-rebase b/util/scripts/gerrit-rebase index d051103..27ee3c7 100755 --- a/util/scripts/gerrit-rebase +++ b/util/scripts/gerrit-rebase @@ -71,7 +71,7 @@ cut -d: -f2-)" # start rebase process, but fail immediately by enforcing an invalid todo -GIT_SEQUENCE_EDITOR="echo Ignore this error, it's intentional>" \ +GIT_SEQUENCE_EDITOR="echo 'Ignore this error, it works around a git-rebase limitation'>" \ git rebase -i --onto ${to} ${from} ${to} 2>/dev/null # write new rebase todo -- To view, visit https://review.coreboot.org/c/coreboot/+/39397 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7d3183e9a612de0121b2d208c06a45645b8d67f6 Gerrit-Change-Number: 39397 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

4 4

Change in coreboot[master]: jasperlake_rvp: UART config for JSLRVP
by Maulik V Vaghela (Code Review) 20 Mar '20

20 Mar '20

Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39196 ) Change subject: jasperlake_rvp: UART config for JSLRVP ...................................................................... Patch Set 12: (2 comments) https://review.coreboot.org/c/coreboot/+/39196/11/src/mainboard/intel/jaspe… File src/mainboard/intel/jasperlake_rvp/Kconfig: https://review.coreboot.org/c/coreboot/+/39196/11/src/mainboard/intel/jaspe… PS11, Line 14: BOARD_INTEL_JASPERLAKE_RVP > @Maulik, i don't think this assumption is valid even inside chrome team? […] @Subrata. It was to differentiate between 2 variants. JSLRVP would use legacy UART while External EC boards would use LPSS. Both UART won't get selected in single build. Sorry for confusion, I have handled in cleanly in my patch here: https://review.coreboot.org/c/coreboot/+/39584 https://review.coreboot.org/c/coreboot/+/39196/11/src/mainboard/intel/jaspe… PS11, Line 53: default 0 if !INTEL_LPSS_UART_FOR_CONSOLE > this is good idea to support both UART is same build bt technically its not possible […] @Subrata, we use 8250IO in case of jasper Lake RVP boards. We can remove this patch itself since I have corrected it in my another patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/39196 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic042cdc449b77c2d9bdd7a63777328e47f910654 Gerrit-Change-Number: 39196 Gerrit-PatchSet: 12 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Fri, 20 Mar 2020 11:05:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/jasperlake_rvp: Add memory config for Jasper Lake RVP
by Maulik V Vaghela (Code Review) 20 Mar '20

20 Mar '20

Maulik V Vaghela has uploaded a new patch set (#30) to the change originally created by Ronak Kanabar. ( https://review.coreboot.org/c/coreboot/+/39195 ) Change subject: mb/intel/jasperlake_rvp: Add memory config for Jasper Lake RVP ...................................................................... mb/intel/jasperlake_rvp: Add memory config for Jasper Lake RVP Add memory initialization parameters for Jasper Lake RVP boards Jasper Lake RVP supports two variants, one with memory LPDDR4 and another with DDR4 Based on board id, mainboard will pass correct memory parameters to the fsp. BUG=None BRANCH=None TEST=Check compilation for Jasper Lake RVP and check memory training passes. Change-Id: Idc92363a2148990df16c2068c7986013d015f604 Signed-off-by: Ronak Kanabar <ronak.kanabar(a)intel.com> Signed-off-by: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> --- M src/mainboard/intel/jasperlake_rvp/board_id.c M src/mainboard/intel/jasperlake_rvp/romstage_fsp_params.c M src/mainboard/intel/jasperlake_rvp/spd/Makefile.inc A src/mainboard/intel/jasperlake_rvp/spd/jslrvp.spd.hex M src/mainboard/intel/jasperlake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/Makefile.inc A src/mainboard/intel/jasperlake_rvp/variants/jslrvp/memory.c 7 files changed, 197 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/39195/30 -- To view, visit https://review.coreboot.org/c/coreboot/+/39195 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc92363a2148990df16c2068c7986013d015f604 Gerrit-Change-Number: 39195 Gerrit-PatchSet: 30 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2020