coreboot-gerrit February 2020

coreboot-gerrit@coreboot.org

1 participants
1797 discussions

Change in coreboot[master]: doc/tutorial/part1.md: Add information for yum- & pacman-based distro
by Patrik Tesarik (Code Review) 11 Feb '20

11 Feb '20

Patrik Tesarik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38225 ) Change subject: doc/tutorial/part1.md: Add information for yum- & pacman-based distro ...................................................................... Patch Set 7: (2 comments) https://review.coreboot.org/c/coreboot/+/38225/6/3rdparty/amd_blobs File 3rdparty/amd_blobs: PS6: > please remove this change, since it (likely unintentionally) changes a submodule pointer, which is a […] I updated the index file for the git submodule as follows: `git update-index --cacheinfo 160000,cf227316b0fbd3995854ce21e81a63270b29bfb5,3rdparty/amd_blobs` I hope that this fixes the problem in the correct way. https://review.coreboot.org/c/coreboot/+/38225/6/Documentation/tutorial/par… File Documentation/tutorial/part1.md: https://review.coreboot.org/c/coreboot/+/38225/6/Documentation/tutorial/par… PS6, Line 10: ### Step 1 - Install tools and libraries needed for coreboot > maybe mention that it depends on the distro which one of the 3 lines you should use? when i see a li […] Tanks for your feedback. In general I'd agree with you. In this particular case, where people start hacking on CPU firmware, I'd argue that the user will know which kind of package manager they need to use. I'll do more beginner-based workshops later on this year. If I get feedback that having a disclaimer would make things more comprehensible, I'll add it later on. -- To view, visit https://review.coreboot.org/c/coreboot/+/38225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifff3c8354b4bec9f195f075eb6b2f377195fc237 Gerrit-Change-Number: 38225 Gerrit-PatchSet: 7 Gerrit-Owner: Patrik Tesarik Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrik Tesarik Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Comment-Date: Tue, 11 Feb 2020 13:35:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: doc/tutorial/part1.md: Add information for yum- & pacman-based distro
by Patrik Tesarik (Code Review) 11 Feb '20

11 Feb '20

Hello Felix Held, Patrick Rudolph, Christian Walter, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/38225 to look at the new patch set (#7). Change subject: doc/tutorial/part1.md: Add information for yum- & pacman-based distro ...................................................................... doc/tutorial/part1.md: Add information for yum- & pacman-based distro * Additional information on non-debian cli tools * Improve Spellings and descriptions to the best of my knowledge Adding info about needed tools in other distribution's package managers was requested at the coreboot beginner's workshop at 36C3. Change-Id: Ifff3c8354b4bec9f195f075eb6b2f377195fc237 Signed-off-by: Patrik Tesarik <mail(a)patrik-tesarik.de> --- M Documentation/tutorial/part1.md 1 file changed, 21 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/38225/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/38225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifff3c8354b4bec9f195f075eb6b2f377195fc237 Gerrit-Change-Number: 38225 Gerrit-PatchSet: 7 Gerrit-Owner: Patrik Tesarik Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrik Tesarik Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: sc7180: Add QUPv3 FW load & config
by Roja Rani Yarubandi (Code Review) 11 Feb '20

11 Feb '20

Roja Rani Yarubandi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35499 ) Change subject: sc7180: Add QUPv3 FW load & config ...................................................................... Patch Set 37: (7 comments) > Patch Set 26: > > (7 comments) Done the changes, and shared patches with Mike. https://review.coreboot.org/c/coreboot/+/35499/26/src/soc/qualcomm/sc7180/i… File src/soc/qualcomm/sc7180/include/soc/addressmap.h: https://review.coreboot.org/c/coreboot/+/35499/26/src/soc/qualcomm/sc7180/i… PS26, Line 21: > Please standardize on tabs, not spaces for header #defines (and keep it in the same column for all # […] Done https://review.coreboot.org/c/coreboot/+/35499/26/src/soc/qualcomm/sc7180/i… File src/soc/qualcomm/sc7180/include/soc/qcom_qup_se.h: https://review.coreboot.org/c/coreboot/+/35499/26/src/soc/qualcomm/sc7180/i… PS26, Line 233: > This sort of alignment should also be done with tabs if possible. removed this struct as we are not using it anymore https://review.coreboot.org/c/coreboot/+/35499/26/src/soc/qualcomm/sc7180/q… File src/soc/qualcomm/sc7180/qupv3_config.c: https://review.coreboot.org/c/coreboot/+/35499/26/src/soc/qualcomm/sc7180/q… PS26, Line 37: struct se_cfg *scfg) > This se_cfg needs to go as well then, obviously (see below). […] Done the changes https://review.coreboot.org/c/coreboot/+/35499/26/src/soc/qualcomm/sc7180/q… PS26, Line 196: fw_list[SE_PROTOCOL_SPI] = > You should check if fw_list[protocol] is NULL here, and avoid reloading the same blob again if it's […] Done https://review.coreboot.org/c/coreboot/+/35499/26/src/soc/qualcomm/sc7180/q… PS26, Line 211: printk(BIOS_INFO, "%s: *ERROR* *INVALID PROTOCOL****\n", > You can use assert() or die() for this. Done https://review.coreboot.org/c/coreboot/+/35499/26/src/soc/qualcomm/sc7180/q… PS26, Line 220: printk(BIOS_INFO, "%s: *ERROR* *PROTOCOL MISMATCH****\n", > I... am very confused what this is supposed to be. […] Done the changes as per the comments https://review.coreboot.org/c/coreboot/+/35499/26/src/soc/qualcomm/sc7180/q… File src/soc/qualcomm/sc7180/qupv3_fw_config.c: https://review.coreboot.org/c/coreboot/+/35499/26/src/soc/qualcomm/sc7180/q… PS26, Line 1: /* > I don't understand what makes this file separate from qupv3_config.c. I think you can merge the two. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/35499 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4d91dd10488931247f81a87b0bdcc598f4bceb31 Gerrit-Change-Number: 35499 Gerrit-PatchSet: 37 Gerrit-Owner: mturney mturney <mturney(a)codeaurora.org> Gerrit-Reviewer: Doug Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Akash Asthana <akashast(a)qualcomm.corp-partner.google.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Roja Rani Yarubandi <c_rojay(a)qualcomm.corp-partner.google.com> Gerrit-CC: Satya Priya Kakitapalli <c_skakit(a)qualcomm.corp-partner.google.com> Gerrit-CC: Stephen Boyd <swboyd(a)chromium.org> Gerrit-Comment-Date: Tue, 11 Feb 2020 13:23:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/block: Move cse common functions into block/cse
by Subrata Banik (Code Review) 11 Feb '20

11 Feb '20

Hello Patrick Rudolph, Aaron Durbin, Angel Pons, Aamir Bohra, Wonkyu Kim, Maulik V Vaghela, Duncan Laurie, Paul Menzel, build bot (Jenkins), Hannah Williams, Patrick Georgi, Furquan Shaikh, Pratikkumar V Prajapati, V Sowmya, Lance Zhao, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/26133 to look at the new patch set (#37). Change subject: soc/intel/common/block: Move cse common functions into block/cse ...................................................................... soc/intel/common/block: Move cse common functions into block/cse This patch cleans soc/intel/{cnl, icl, tgl} by moving common soc code into common/block/cse. Supported SoC can select existing HECI_DISABLE_USING_SMM option to select common cse code block to make heci function disable using sideband interface during SMM mode at preboot envionment. BUG=b:78109109 TEST=Build and boot CNL, ICL and TGL platform. Change-Id: I22a4cc05d3967c7653d2abe2c829b4876516d179 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> Signed-off-by: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> --- M src/soc/intel/cannonlake/smihandler.c M src/soc/intel/common/block/cse/Kconfig M src/soc/intel/common/block/cse/Makefile.inc A src/soc/intel/common/block/cse/disable_heci.c M src/soc/intel/common/block/include/intelblocks/cse.h M src/soc/intel/icelake/smihandler.c M src/soc/intel/tigerlake/smihandler.c 7 files changed, 76 insertions(+), 117 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/26133/37 -- To view, visit https://review.coreboot.org/c/coreboot/+/26133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22a4cc05d3967c7653d2abe2c829b4876516d179 Gerrit-Change-Number: 26133 Gerrit-PatchSet: 37 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common/block: Move cse common functions into block/cse
by Subrata Banik (Code Review) 11 Feb '20

11 Feb '20

Hello Patrick Rudolph, Aaron Durbin, Maulik V Vaghela, Duncan Laurie, Paul Menzel, build bot (Jenkins), Hannah Williams, Patrick Georgi, Martin Roth, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/26133 to look at the new patch set (#36). Change subject: soc/intel/common/block: Move cse common functions into block/cse ...................................................................... soc/intel/common/block: Move cse common functions into block/cse This patch cleans soc/intel/{cnl, icl, tgl} by moving common soc code into common/block/cse. Supported SoC can select existing HECI_DISABLE_USING_SMM option to select common cse code block to make heci function disable using sideband interface during SMM mode at preboot envionment. BUG=b:78109109 TEST=Build and boot CNL, ICL and TGL platform. Change-Id: I22a4cc05d3967c7653d2abe2c829b4876516d179 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> Signed-off-by: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> --- M src/soc/intel/cannonlake/smihandler.c M src/soc/intel/common/block/cse/Kconfig M src/soc/intel/common/block/cse/Makefile.inc A src/soc/intel/common/block/cse/disable_heci.c M src/soc/intel/common/block/include/intelblocks/cse.h M src/soc/intel/icelake/smihandler.c M src/soc/intel/tigerlake/smihandler.c 7 files changed, 77 insertions(+), 117 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/26133/36 -- To view, visit https://review.coreboot.org/c/coreboot/+/26133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22a4cc05d3967c7653d2abe2c829b4876516d179 Gerrit-Change-Number: 26133 Gerrit-PatchSet: 36 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common/{block, pch}: Move smihandler common functions into ...
by Subrata Banik (Code Review) 11 Feb '20

11 Feb '20

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26138 ) Change subject: soc/intel/common/{block, pch}: Move smihandler common functions into common code ...................................................................... Patch Set 37: (1 comment) https://review.coreboot.org/c/coreboot/+/26138/35/src/soc/intel/cannonlake/… File src/soc/intel/cannonlake/include/soc/pm.h: https://review.coreboot.org/c/coreboot/+/26138/35/src/soc/intel/cannonlake/… PS35, Line 79: #define SMI_ON_SLP_EN_STS_BIT 4 > Aaron, i have realized that we shouldn't try making things unnecessary common just like this macros […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/26138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic082bc5d556dd19617d83ab86f93a53574b5bc03 Gerrit-Change-Number: 26138 Gerrit-PatchSet: 37 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Feb 2020 12:17:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aaron Durbin <adurbin(a)chromium.org> Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/block: Move cse common functions into block/cse
by Subrata Banik (Code Review) 11 Feb '20

11 Feb '20

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26133 ) Change subject: soc/intel/common/block: Move cse common functions into block/cse ...................................................................... Patch Set 35: (1 comment) https://review.coreboot.org/c/coreboot/+/26133/28/src/soc/intel/skylake/fin… File src/soc/intel/skylake/finalize.c: https://review.coreboot.org/c/coreboot/+/26133/28/src/soc/intel/skylake/fin… PS28, Line 51: static void heci_disable(void) > Done Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/26133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22a4cc05d3967c7653d2abe2c829b4876516d179 Gerrit-Change-Number: 26133 Gerrit-PatchSet: 35 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Feb 2020 12:05:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aaron Durbin <adurbin(a)chromium.org> Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/{block, pch}: Move smihandler common functions into ...
by Subrata Banik (Code Review) 11 Feb '20

11 Feb '20

Hello Aaron Durbin, Patrick Rudolph, Aamir Bohra, Maulik V Vaghela, Duncan Laurie, Paul Menzel, Shelley Chen, build bot (Jenkins), Hannah Williams, Patrick Georgi, Furquan Shaikh, Krzysztof M Sywula, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/26138 to look at the new patch set (#37). Change subject: soc/intel/common/{block, pch}: Move smihandler common functions into common code ...................................................................... soc/intel/common/{block, pch}: Move smihandler common functions into common code This patch cleans soc/intel/{apl/cnl/skl/icl/tgl} by moving common soc code into common/{block, pch}/smihandler.c BUG=b:78109109 TEST=Build and boot KBL/CNL/APL/ICL/TGL platform. Change-Id: Ic082bc5d556dd19617d83ab86f93a53574b5bc03 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/cannonlake/smihandler.c M src/soc/intel/common/block/smm/smihandler.c M src/soc/intel/common/pch/Kconfig A src/soc/intel/common/pch/smm/Kconfig A src/soc/intel/common/pch/smm/Makefile.inc R src/soc/intel/common/pch/smm/smihandler.c M src/soc/intel/icelake/smihandler.c M src/soc/intel/skylake/Makefile.inc M src/soc/intel/tigerlake/smihandler.c 9 files changed, 34 insertions(+), 188 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/26138/37 -- To view, visit https://review.coreboot.org/c/coreboot/+/26138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic082bc5d556dd19617d83ab86f93a53574b5bc03 Gerrit-Change-Number: 26138 Gerrit-PatchSet: 37 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/pcengines/apu2: Remove unnecessary variable
by Paul Menzel (Code Review) 11 Feb '20

11 Feb '20

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38786 ) Change subject: mb/pcengines/apu2: Remove unnecessary variable ...................................................................... mb/pcengines/apu2: Remove unnecessary variable The initialization of the variable is not needed, but it turns out, we can just return the sum. Change-Id: If0cba91f6ab642b0626d46fa01c9de9ca0c10a11 Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M src/mainboard/pcengines/apu2/mainboard.c 1 file changed, 3 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/38786/1 diff --git a/src/mainboard/pcengines/apu2/mainboard.c b/src/mainboard/pcengines/apu2/mainboard.c index bd2ca39..08d3b6f 100644 --- a/src/mainboard/pcengines/apu2/mainboard.c +++ b/src/mainboard/pcengines/apu2/mainboard.c @@ -235,19 +235,16 @@ unsigned long *current) { DMI_INFO *agesa_dmi; - int len = 0; agesa_dmi = agesawrapper_getlateinitptr(PICK_DMI); if (!agesa_dmi) - return len; - - len += mainboard_smbios_type16(agesa_dmi, handle, current); - len += mainboard_smbios_type17(agesa_dmi, handle, current); + return 0; *handle += 2; - return len; + return mainboard_smbios_type16(agesa_dmi, handle, current) + + mainboard_smbios_type17(agesa_dmi, handle, current); } #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/38786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0cba91f6ab642b0626d46fa01c9de9ca0c10a11 Gerrit-Change-Number: 38786 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: newchange

2 3

Change in coreboot[master]: soc/mediatek: dsi: Unify format to bpp conversion
by Yu-Ping Wu (Code Review) 11 Feb '20

11 Feb '20

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34770 ) Change subject: soc/mediatek: dsi: Unify format to bpp conversion ...................................................................... Patch Set 11: (1 comment) https://review.coreboot.org/c/coreboot/+/34770/11/src/soc/mediatek/common/d… File src/soc/mediatek/common/dsi.c: https://review.coreboot.org/c/coreboot/+/34770/11/src/soc/mediatek/common/d… PS11, Line 29: MIPI_DSI_FMT_RGB666 Happened to see this. Compared to kernel [1], should we return 24 here? [1] https://cs.corp.google.com/chromeos_public/src/third_party/kernel/v4.19/dri… -- To view, visit https://review.coreboot.org/c/coreboot/+/34770 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd405220b73859e5592c68f498af07eef8d7edbc Gerrit-Change-Number: 34770 Gerrit-PatchSet: 11 Gerrit-Owner: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Reviewer: You-Cheng Syu <youcheng(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: jitao shi <jitao.shi(a)mediatek.com> Gerrit-Reviewer: yongqiang niu <yongqiang.niu(a)mediatek.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 11 Feb 2020 10:18:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2020