coreboot-gerrit February 2020

coreboot-gerrit@coreboot.org

1 participants
1797 discussions

Change in coreboot[master]: nb/intel/sandybridge/acpi: Update PEG code
by Patrick Rudolph (Code Review) 12 Feb '20

12 Feb '20

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38831 ) Change subject: nb/intel/sandybridge/acpi: Update PEG code ...................................................................... nb/intel/sandybridge/acpi: Update PEG code * Use new ACPI syntax * Return either 0 or 0xf for PCI root port. That will make the device show up in Windows. This might help users and possibly Windows drivers working with PCIe ports. Change-Id: I1e76b735ab1472f6a4ea493c733cd6b2e6fca29e Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/northbridge/intel/sandybridge/acpi/peg.asl 1 file changed, 4 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/38831/1 diff --git a/src/northbridge/intel/sandybridge/acpi/peg.asl b/src/northbridge/intel/sandybridge/acpi/peg.asl index f98a4ce..fcec00e 100644 --- a/src/northbridge/intel/sandybridge/acpi/peg.asl +++ b/src/northbridge/intel/sandybridge/acpi/peg.asl @@ -20,8 +20,7 @@ Method (_STA) { - ShiftRight (\_SB.PCI0.MCHC.DVEN, 3, Local0) - Return (And (Local0, 1)) + Return (((\_SB.PCI0.MCHC.DVEN >> 3) & 1) * 0xf) } Device (DEV0) @@ -36,8 +35,7 @@ Method (_STA) { - ShiftRight (\_SB.PCI0.MCHC.DVEN, 2, Local0) - Return (And (Local0, 1)) + Return (((\_SB.PCI0.MCHC.DVEN >> 2) & 1) * 0xf) } Device (DEV0) @@ -52,8 +50,7 @@ Method (_STA) { - ShiftRight (\_SB.PCI0.MCHC.DVEN, 1, Local0) - Return (And (Local0, 1)) + Return (((\_SB.PCI0.MCHC.DVEN >> 1) & 1) * 0xf) } Device (DEV0) @@ -68,8 +65,7 @@ Method (_STA) { - ShiftRight (\_SB.PCI0.MCHC.DVEN, 13, Local0) - Return (And (Local0, 1)) + Return (((\_SB.PCI0.MCHC.DVEN >> 13) & 1) * 0xf) } Device (DEV0) -- To view, visit https://review.coreboot.org/c/coreboot/+/38831 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e76b735ab1472f6a4ea493c733cd6b2e6fca29e Gerrit-Change-Number: 38831 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

3 5

Change in coreboot[master]: doc/tutorial/part1.md: Add commands for yum- & pacman-based distro
by Patrik Tesarik (Code Review) 12 Feb '20

12 Feb '20

Patrik Tesarik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38225 ) Change subject: doc/tutorial/part1.md: Add commands for yum- & pacman-based distro ...................................................................... Patch Set 10: (10 comments) Thanks for your constructive feedback, Angel! https://review.coreboot.org/c/coreboot/+/38225/7//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/38225/7//COMMIT_MSG@7 PS7, Line 7: Add information for yum- & pacman-based distro > Add commands for more distros Ack https://review.coreboot.org/c/coreboot/+/38225/7//COMMIT_MSG@9 PS7, Line 9: Additional > Missing a verb: […] Ack https://review.coreboot.org/c/coreboot/+/38225/7//COMMIT_MSG@10 PS7, Line 10: S > lowercase Ack https://review.coreboot.org/c/coreboot/+/38225/7/Documentation/tutorial/par… File Documentation/tutorial/part1.md: https://review.coreboot.org/c/coreboot/+/38225/7/Documentation/tutorial/par… PS7, Line 4: From a fresh Ubuntu 16.04 or 18.04 install, here are all the steps required for > This might need an update. […] Ack https://review.coreboot.org/c/coreboot/+/38225/7/Documentation/tutorial/par… PS7, Line 11: $ sudo apt-get install -y bison build-essential curl flex git gnat libncurses5-dev m4 zlib1g-dev > Maybe indicate that these commands are for different distros? […] I introduced the package management specific instructions in the preambel. It should be clear which command to use in the following tutorial/ https://review.coreboot.org/c/coreboot/+/38225/7/Documentation/tutorial/par… PS7, Line 82: $ sudo apt-get install -y qemu > same here, these commands are for different distros Ack https://review.coreboot.org/c/coreboot/+/38225/7/Documentation/tutorial/par… PS7, Line 98: for Debian, CentOS or : Arch based > If commands for another package manager are added, this would need to be changed. […] Ack https://review.coreboot.org/c/coreboot/+/38225/7/Documentation/tutorial/par… PS7, Line 103: t : comes pre-installed on some Ubuntu flavors and maybe not on others. > I don't think this sentence is of much value, given the paragraph right before it Ack https://review.coreboot.org/c/coreboot/+/38225/7/Documentation/tutorial/par… PS7, Line 111: that does not use apt, yum or : pacman as its package manager > Same as before. I would omit it, as it's easily inferred. Ack https://review.coreboot.org/c/coreboot/+/38225/7/Documentation/tutorial/par… PS7, Line 137: coreboot's : file system > nit: as CBFS is 'CoreBoot File System' (capitals only used for emphasis), I would change this part a […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/38225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifff3c8354b4bec9f195f075eb6b2f377195fc237 Gerrit-Change-Number: 38225 Gerrit-PatchSet: 10 Gerrit-Owner: Patrik Tesarik Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrik Tesarik Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Comment-Date: Wed, 12 Feb 2020 14:12:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: doc/tutorial/part1.md: Add commands for yum- & pacman-based distro
by Patrik Tesarik (Code Review) 12 Feb '20

12 Feb '20

Hello Felix Held, Angel Pons, Patrick Rudolph, Christian Walter, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/38225 to look at the new patch set (#10). Change subject: doc/tutorial/part1.md: Add commands for yum- & pacman-based distro ...................................................................... doc/tutorial/part1.md: Add commands for yum- & pacman-based distro * Add additional information on non-debian cli tools * Improve spellings and descriptions to the best of my knowledge Adding info about needed tools in other distribution's package managers was requested at the coreboot beginner's workshop at 36C3. Change-Id: Ifff3c8354b4bec9f195f075eb6b2f377195fc237 Signed-off-by: Patrik Tesarik <mail(a)patrik-tesarik.de> --- M Documentation/tutorial/part1.md 1 file changed, 29 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/38225/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/38225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifff3c8354b4bec9f195f075eb6b2f377195fc237 Gerrit-Change-Number: 38225 Gerrit-PatchSet: 10 Gerrit-Owner: Patrik Tesarik Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrik Tesarik Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: doc/tutorial/part1.md: Add commands for yum- & pacman-based distro
by Patrik Tesarik (Code Review) 12 Feb '20

12 Feb '20

Hello Felix Held, Angel Pons, Patrick Rudolph, Christian Walter, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/38225 to look at the new patch set (#9). Change subject: doc/tutorial/part1.md: Add commands for yum- & pacman-based distro ...................................................................... doc/tutorial/part1.md: Add commands for yum- & pacman-based distro * Add additional information on non-debian cli tools * Improve spellings and descriptions to the best of my knowledge Adding info about needed tools in other distribution's package managers was requested at the coreboot beginner's workshop at 36C3. Change-Id: Ifff3c8354b4bec9f195f075eb6b2f377195fc237 Signed-off-by: Patrik Tesarik <mail(a)patrik-tesarik.de> --- M Documentation/tutorial/part1.md 1 file changed, 29 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/38225/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/38225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifff3c8354b4bec9f195f075eb6b2f377195fc237 Gerrit-Change-Number: 38225 Gerrit-PatchSet: 9 Gerrit-Owner: Patrik Tesarik Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrik Tesarik Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: doc/tutorial/part1.md: Add commands for yum- & pacman-based distro
by Patrik Tesarik (Code Review) 12 Feb '20

12 Feb '20

Hello Felix Held, Angel Pons, Patrick Rudolph, Christian Walter, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/38225 to look at the new patch set (#8). Change subject: doc/tutorial/part1.md: Add commands for yum- & pacman-based distro ...................................................................... doc/tutorial/part1.md: Add commands for yum- & pacman-based distro * Add additional information on non-debian cli tools * Improve spellings and descriptions to the best of my knowledge Adding info about needed tools in other distribution's package managers was requested at the coreboot beginner's workshop at 36C3. Change-Id: Ifff3c8354b4bec9f195f075eb6b2f377195fc237 Signed-off-by: Patrik Tesarik <mail(a)patrik-tesarik.de> --- M Documentation/tutorial/part1.md 1 file changed, 29 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/38225/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/38225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifff3c8354b4bec9f195f075eb6b2f377195fc237 Gerrit-Change-Number: 38225 Gerrit-PatchSet: 8 Gerrit-Owner: Patrik Tesarik Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrik Tesarik Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/razer: Add initial support for the Blade Stealth (late 2019) [ICL]
by Mimoja (Code Review) 12 Feb '20

12 Feb '20

Hello Kyösti Mälkki, Christoph Pomaska, Angel Pons, Jonathan Neuschäfer, Paul Menzel, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/37565 to look at the new patch set (#16). Change subject: mb/razer: Add initial support for the Blade Stealth (late 2019) [ICL] ...................................................................... mb/razer: Add initial support for the Blade Stealth (late 2019) [ICL] The Razer Blade Stealth Mercury White is a Ice Lake system using: - Intel i7-1065G7 (Ice Lake with Iris Plus GPU) - ITE IT8320VG EC (currently unsupported in coreboot) - Samsung M981 MZ-VLKB2560 256GB NVMe SSD - Four Samsung K4UBE3D4AM-GHCL LPDDR4 chips - Integrated TitanRidge Thunderbolt 3 / 4 controller - Two Realtek Audio chips: - ALC298 for the audio jack - ALC1306 for the speakers - Parade PS8802 USB Type-C Host Switch - Unlabeled Intel USB Type-C Thunderbolt Switch This commit includes basic ram init and devicetree configuration and therefore everything required to call into the payload. It is missing ACPI, power and advanced device initialization as well as EC support which should be included on its own in a future commit. Change-Id: I5711cbcd69813832d9bacc9563f651ab8702554a Signed-off-by: Johanna Schander <coreboot(a)mimoja.de> --- A src/mainboard/razer/blade_stealth_icl/Kconfig A src/mainboard/razer/blade_stealth_icl/Kconfig.name A src/mainboard/razer/blade_stealth_icl/Makefile.inc A src/mainboard/razer/blade_stealth_icl/acpi/mainboard.asl A src/mainboard/razer/blade_stealth_icl/board_info.txt A src/mainboard/razer/blade_stealth_icl/bootblock.c A src/mainboard/razer/blade_stealth_icl/devicetree.cb A src/mainboard/razer/blade_stealth_icl/dsdt.asl A src/mainboard/razer/blade_stealth_icl/gpio.h A src/mainboard/razer/blade_stealth_icl/hda_verb.c A src/mainboard/razer/blade_stealth_icl/ramstage.c A src/mainboard/razer/blade_stealth_icl/romstage.c A src/mainboard/razer/blade_stealth_icl/spd/Makefile.inc A src/mainboard/razer/blade_stealth_icl/spd/samsung_K4UBE3D4AA.spd.hex 14 files changed, 631 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/37565/16 -- To view, visit https://review.coreboot.org/c/coreboot/+/37565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5711cbcd69813832d9bacc9563f651ab8702554a Gerrit-Change-Number: 37565 Gerrit-PatchSet: 16 Gerrit-Owner: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christoph Pomaska <github(a)slrie.de> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/razer: Add initial support for the Blade Stealth Mercury White (la...
by Mimoja (Code Review) 12 Feb '20

12 Feb '20

Hello Kyösti Mälkki, Christoph Pomaska, Angel Pons, Jonathan Neuschäfer, Paul Menzel, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/37565 to look at the new patch set (#15). Change subject: mb/razer: Add initial support for the Blade Stealth Mercury White (late 2019) ...................................................................... mb/razer: Add initial support for the Blade Stealth Mercury White (late 2019) The Razer Blade Stealth Mercury White is a Ice Lake system using: - Intel i7-1065G7 (Ice Lake with Iris Plus GPU) - ITE IT8320VG EC (currently unsupported in coreboot) - Samsung M981 MZ-VLKB2560 256GB NVMe SSD - Four Samsung K4UBE3D4AM-GHCL LPDDR4 chips - Integrated TitanRidge Thunderbolt 3 / 4 controller - Two Realtek Audio chips: - ALC298 for the audio jack - ALC1306 for the speakers - Parade PS8802 USB Type-C Host Switch - Unlabeled Intel USB Type-C Thunderbolt Switch This commit includes basic ram init and devicetree configuration and therefore everything required to call into the payload. It is missing ACPI, power and advanced device initialization as well as EC support which should be included on its own in a future commit. Change-Id: I5711cbcd69813832d9bacc9563f651ab8702554a Signed-off-by: Johanna Schander <coreboot(a)mimoja.de> --- A src/mainboard/razer/blade_stealth_icl/Kconfig A src/mainboard/razer/blade_stealth_icl/Kconfig.name A src/mainboard/razer/blade_stealth_icl/Makefile.inc A src/mainboard/razer/blade_stealth_icl/acpi/mainboard.asl A src/mainboard/razer/blade_stealth_icl/board_info.txt A src/mainboard/razer/blade_stealth_icl/bootblock.c A src/mainboard/razer/blade_stealth_icl/devicetree.cb A src/mainboard/razer/blade_stealth_icl/dsdt.asl A src/mainboard/razer/blade_stealth_icl/gpio.h A src/mainboard/razer/blade_stealth_icl/hda_verb.c A src/mainboard/razer/blade_stealth_icl/ramstage.c A src/mainboard/razer/blade_stealth_icl/romstage.c A src/mainboard/razer/blade_stealth_icl/spd/Makefile.inc A src/mainboard/razer/blade_stealth_icl/spd/samsung_K4UBE3D4AA.spd.hex 14 files changed, 631 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/37565/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/37565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5711cbcd69813832d9bacc9563f651ab8702554a Gerrit-Change-Number: 37565 Gerrit-PatchSet: 15 Gerrit-Owner: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christoph Pomaska <github(a)slrie.de> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/razer: Add initial support for the Blade Stealth Mercury White (la...
by Mimoja (Code Review) 12 Feb '20

12 Feb '20

Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37565 ) Change subject: mb/razer: Add initial support for the Blade Stealth Mercury White (late 2019) ...................................................................... Patch Set 14: (3 comments) Thank you all for the review. Updated. https://review.coreboot.org/c/coreboot/+/37565/14/src/mainboard/razer/blade… File src/mainboard/razer/blade_stealth_icl/Kconfig: https://review.coreboot.org/c/coreboot/+/37565/14/src/mainboard/razer/blade… PS14, Line 11: select GENERIC_SPD_BIN > GENERIC_SPD_BIN twice. Done https://review.coreboot.org/c/coreboot/+/37565/14/src/mainboard/razer/blade… File src/mainboard/razer/blade_stealth_icl/board_info.txt: https://review.coreboot.org/c/coreboot/+/37565/14/src/mainboard/razer/blade… PS14, Line 2: Board name: Blade Stealth Ice Lake U Mercury White late 2019 (LY320) > This is not the same as the name in Kconfig.name. […] Yes. The official board name does never say Ice Lake. There is an Ice Lake and a Whiskeylake version tho. So in Kconfig I added the Ice Lake hint. https://review.coreboot.org/c/coreboot/+/37565/14/src/mainboard/razer/blade… File src/mainboard/razer/blade_stealth_icl/devicetree.cb: https://review.coreboot.org/c/coreboot/+/37565/14/src/mainboard/razer/blade… PS14, Line 167: #+-------------------+---------------------------+ > The table formatting is broken, here Done -- To view, visit https://review.coreboot.org/c/coreboot/+/37565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5711cbcd69813832d9bacc9563f651ab8702554a Gerrit-Change-Number: 37565 Gerrit-PatchSet: 14 Gerrit-Owner: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christoph Pomaska <github(a)slrie.de> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 12 Feb 2020 08:40:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Christoph Pomaska <github(a)slrie.de> Comment-In-Reply-To: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mainboard/hatch/mainboard.c: Accommodate larger SKU id space
by Furquan Shaikh (Code Review) 12 Feb '20

12 Feb '20

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38844 ) Change subject: mainboard/hatch/mainboard.c: Accommodate larger SKU id space ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/38844/2/src/mainboard/google/hatch… File src/mainboard/google/hatch/mainboard.c: https://review.coreboot.org/c/coreboot/+/38844/2/src/mainboard/google/hatch… PS2, Line 25: 0x7FFFFFFF Is this true for all of hatch or just Puff? +Shelley and +Tim. -- To view, visit https://review.coreboot.org/c/coreboot/+/38844 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic5a3f47989f596b838739becfb1da1bdaf16dd27 Gerrit-Change-Number: 38844 Gerrit-PatchSet: 2 Gerrit-Owner: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 12 Feb 2020 07:25:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/{skl, common}: Move ME Firmware SKU Types to common code
by Sridhar Siricilla (Code Review) 12 Feb '20

12 Feb '20

Sridhar Siricilla has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38796 ) Change subject: soc/intel/{skl, common}: Move ME Firmware SKU Types to common code ...................................................................... soc/intel/{skl, common}: Move ME Firmware SKU Types to common code Below changes are done in the patch: 1. Move ME firmware SKU types into common code. 2. Define ME_HFS3_FW_SKU_CUSTOM SKU. TEST=Verified on hatch & soraka. Change-Id: Iaa4cf8d5b41c1008da1e7aa63b5a6960bb9a727b Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> --- M src/soc/intel/common/block/include/intelblocks/cse.h M src/soc/intel/skylake/include/soc/me.h 2 files changed, 5 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/38796/1 diff --git a/src/soc/intel/common/block/include/intelblocks/cse.h b/src/soc/intel/common/block/include/intelblocks/cse.h index aff330a..6f8f4ff 100644 --- a/src/soc/intel/common/block/include/intelblocks/cse.h +++ b/src/soc/intel/common/block/include/intelblocks/cse.h @@ -41,6 +41,11 @@ #define ME_HFS1_COM_SOFT_TEMP_DISABLE 0x3 #define ME_HFS1_COM_SECOVER_MEI_MSG 0x5 +/* ME Firmware SKU Types */ +#define ME_HFS3_FW_SKU_CONSUMER 0x2 +#define ME_HFS3_FW_SKU_CORPORATE 0x3 +#define ME_HFS3_FW_SKU_CUSTOM 0x5 + /* HFSTS register offsets in PCI config space */ enum { PCI_ME_HFSTS1 = 0x40, diff --git a/src/soc/intel/skylake/include/soc/me.h b/src/soc/intel/skylake/include/soc/me.h index 30de219..e8de30d 100644 --- a/src/soc/intel/skylake/include/soc/me.h +++ b/src/soc/intel/skylake/include/soc/me.h @@ -168,9 +168,6 @@ } __packed fields; }; -#define ME_HFS3_FW_SKU_CONSUMER 0x2 -#define ME_HFS3_FW_SKU_CORPORATE 0x3 - union me_hfs3 { u32 data; struct { -- To view, visit https://review.coreboot.org/c/coreboot/+/38796 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa4cf8d5b41c1008da1e7aa63b5a6960bb9a727b Gerrit-Change-Number: 38796 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: newchange

5 7

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2020