Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47115 )
Change subject: ec/purism/librem/ec.asl: End comment
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/47115
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id192d665a22a8885d7cec56cd6b8ea207fb54402
Gerrit-Change-Number: 47115
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 04 Nov 2020 19:23:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45208 )
Change subject: console: Allow VPD to disable an otherwise enabled coreboot console
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45208/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45208/4//COMMIT_MSG@18
PS4, Line 18: entry is added.
> What do you mean with "a section"... […]
Yes, I meant an ELF section. And you are right, compression probably makes
it too complex. The difference to Kconfig options would be that you get to
use the exact same code. However, personally I'd just use Kconfig.
You mean verification schemes as in hashes and digital signatures? Actually,
I would want them to change.
If it's really for x86 with its memory mapped flash, VPD isn't much overhead
either, is it? I didn't look much at the code, but why would it be heavier
than the CMOS option table? Anyway, I didn't see x86 written on this patch.
Was that the intention?
--
To view, visit https://review.coreboot.org/c/coreboot/+/45208
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f1f5c45e5ea889176d04e0db438ca2aa7c536ee
Gerrit-Change-Number: 45208
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Dossym Nurmukhanov <dossym(a)google.com>
Gerrit-Reviewer: Greg Edelston <gredelston(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Wed, 04 Nov 2020 19:15:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47054 )
Change subject: mb/intel/adlrvp: Replace if-else-if ladder with switch construct
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47054/2/src/mainboard/intel/adlrvp…
File src/mainboard/intel/adlrvp/variants/adlrvp_p/memory.c:
https://review.coreboot.org/c/coreboot/+/47054/2/src/mainboard/intel/adlrvp…
PS2, Line 76: case ADL_P_LP4_1:
> It's an old habit of mine that would give you a heuristic to catch unintended fallthroughs. […]
Our current compiler flags make GCC complain on potentially-incorrect implicit fallthroughs unless there's a comment. Since having contiguous cases fall through is commonly intentional, GCC does not warn on these.
--
To view, visit https://review.coreboot.org/c/coreboot/+/47054
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I268db8bc63aaf64d4a91c9a44ef5282154b20a53
Gerrit-Change-Number: 47054
Gerrit-PatchSet: 3
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 04 Nov 2020 19:09:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47054 )
Change subject: mb/intel/adlrvp: Replace if-else-if ladder with switch construct
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47054/2/src/mainboard/intel/adlrvp…
File src/mainboard/intel/adlrvp/variants/adlrvp_p/memory.c:
https://review.coreboot.org/c/coreboot/+/47054/2/src/mainboard/intel/adlrvp…
PS2, Line 76: case ADL_P_LP4_1:
> I would agree in other cases, but I'd say this case is pretty self-explanatory already. […]
It's an old habit of mine that would give you a heuristic to catch unintended fallthroughs. This case isn't too bad, but I will also note that C++17 added support for a [[fallthrough]] attribute, which I think you can finagle into an error if the compiler catches an unmarked one. I guess code review is our tool to make sure things like this are correct here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/47054
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I268db8bc63aaf64d4a91c9a44ef5282154b20a53
Gerrit-Change-Number: 47054
Gerrit-PatchSet: 3
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 04 Nov 2020 18:47:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47115 )
Change subject: ec/purism/librem/ec.asl: End comment
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/47115
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id192d665a22a8885d7cec56cd6b8ea207fb54402
Gerrit-Change-Number: 47115
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 04 Nov 2020 18:39:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47115 )
Change subject: ec/purism/librem/ec.asl: End comment
......................................................................
Patch Set 2:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/47115
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id192d665a22a8885d7cec56cd6b8ea207fb54402
Gerrit-Change-Number: 47115
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 04 Nov 2020 16:49:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46485 )
Change subject: mb/intel/adlrvp: Add support for DDR5 memory
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46485/7/src/mainboard/intel/adlrvp…
File src/mainboard/intel/adlrvp/variants/adlrvp_p/memory.c:
https://review.coreboot.org/c/coreboot/+/46485/7/src/mainboard/intel/adlrvp…
PS7, Line 62: .rcomp_targets = {50, 30, 30, 30, 27},
> No, I meant to have something like: […]
Sounds good Angel, will wait for your observation, you can modify this later as well
--
To view, visit https://review.coreboot.org/c/coreboot/+/46485
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4711d66c7b4b7b09e15a4d06e28c876ec35bc192
Gerrit-Change-Number: 46485
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.bmg(a)gmail.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 04 Nov 2020 15:39:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-MessageType: comment