Change in coreboot[master]: util/exynos: Port *_cksum.py to python3

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Stefan Reinauer (Code Review)

12 Jun 2020 12 Jun '20

9:57 p.m.

Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42321 )

Change subject: util/exynos: Port *_cksum.py to python3 ......................................................................

util/exynos: Port *_cksum.py to python3

Manually changed shebang to reflect python3, no further porting needed.

Tested by calling the scripts on the command line.

Change-Id: I116696576081460a7d503ee4a032c5430a430888 Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M util/exynos/fixed_cksum.py M util/exynos/variable_cksum.py 2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/42321/1

diff --git a/util/exynos/fixed_cksum.py b/util/exynos/fixed_cksum.py index c6a9ddae..25537de 100755 --- a/util/exynos/fixed_cksum.py +++ b/util/exynos/fixed_cksum.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # # SPDX-License-Identifier: BSD-3-Clause

diff --git a/util/exynos/variable_cksum.py b/util/exynos/variable_cksum.py index 62a76cc..f908049 100755 --- a/util/exynos/variable_cksum.py +++ b/util/exynos/variable_cksum.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # # SPDX-License-Identifier: BSD-3-Clause

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Julius Werner (Code Review)

12 Jun 12 Jun

10:04 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42321 )

Change subject: util/exynos: Port *_cksum.py to python3 ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42321 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I116696576081460a7d503ee4a032c5430a430888 Gerrit-Change-Number: 42321 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 12 Jun 2020 22:04:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Singer (Code Review)

17 Jun 17 Jun

12:49 a.m.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42321 )

Change subject: util/exynos: Port *_cksum.py to python3 ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42321 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I116696576081460a7d503ee4a032c5430a430888 Gerrit-Change-Number: 42321 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 17 Jun 2020 00:49:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

8:22 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42321 )

Change subject: util/exynos: Port *_cksum.py to python3 ......................................................................

Patch Set 3:

Leave it with `python`, as it’s compatible with both?

-- To view, visit https://review.coreboot.org/c/coreboot/+/42321 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I116696576081460a7d503ee4a032c5430a430888 Gerrit-Change-Number: 42321 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 17 Jun 2020 08:22:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Stefan Reinauer (Code Review)

26 Jun 26 Jun

9:14 p.m.

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42321 )

Change subject: util/exynos: Port *_cksum.py to python3 ......................................................................

Patch Set 3:

...

Patch Set 3:

Leave it with `python`, as it’s compatible with both?

No, we should explicitly specify the version to create reproducible behavior (and that should be the version that we are shipping with the coreboot-sdk)

-- To view, visit https://review.coreboot.org/c/coreboot/+/42321 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I116696576081460a7d503ee4a032c5430a430888 Gerrit-Change-Number: 42321 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 26 Jun 2020 21:14:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Julius Werner (Code Review)

29 Jun 29 Jun

8:19 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42321 )

Change subject: util/exynos: Port *_cksum.py to python3 ......................................................................

Patch Set 4:

...

...
Leave it with `python`, as it’s compatible with both?

No, we should explicitly specify the version to create reproducible behavior (and that should be the version that we are shipping with the coreboot-sdk)

Do we ship Python with the SDK? Because I don't think we do, right?

Python has this sort of weird state in the coreboot build system where it's really "banned" because people don't want it as a dependency (for issues like these, for example), but individual platforms can still choose to use it (because vendors often have Python build tools already and nobody wants to rewrite it all in C). But I don't think we have an officially supported version or anything. (We don't have an officially supported HOSTCC either, after all... we're trying to just vaguely support what most people have and hope that the compiler for build tools shouldn't have an effect on the final firmware binary, which it shouldn't unless we write really bad code.)

So maybe for simple stuff that both Python 2 and 3 should be able to run (which I think should be true for most of what we have... I think the Python guys intentionally tried to backport the most stuff that needs to be changed for Python 3 to Python 2), Paul is right and we should leave the version unspecified to give it the best chance that it will run on either?

-- To view, visit https://review.coreboot.org/c/coreboot/+/42321 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I116696576081460a7d503ee4a032c5430a430888 Gerrit-Change-Number: 42321 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 29 Jun 2020 20:19:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

24 Oct 24 Oct

10:13 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42321 )

Change subject: util/exynos: Port *_cksum.py to python3 ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42321 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I116696576081460a7d503ee4a032c5430a430888 Gerrit-Change-Number: 42321 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 24 Oct 2020 10:13:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Stefan Reinauer (Code Review)

4 Nov 4 Nov

7:27 p.m.

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42321 )

Change subject: util/exynos: Port *_cksum.py to python3 ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/42321 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I116696576081460a7d503ee4a032c5430a430888 Gerrit-Change-Number: 42321 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1292

days inactive

1437

days old

coreboot-gerrit@coreboot.org

7 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
Felix Singer (Code Review)
Julius Werner (Code Review)
Paul Menzel (Code Review)
Stefan Reinauer (Code Review)