Caveh Jalali has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47654 )
Change subject: mb/google/volteer: Use SoC header for TCSS port control
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/47654
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ded34ad2316764ce42851b3d9b631ed5a30860e
Gerrit-Change-Number: 47654
Gerrit-PatchSet: 5
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: abandon
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47860 )
Change subject: soc/intel/tigerlake: Refactor TCSS port mux config
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/47860
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ca69cba646e3dcb7dc73e5d95aedc88fcde0e81
Gerrit-Change-Number: 47860
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Mon, 23 Nov 2020 11:40:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello build bot (Jenkins), Kevin Chang, Patrick Georgi, Martin Roth, Tim Wawrzynczak, Nick Vaccaro, Brandon Breitenstein,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47501
to look at the new patch set (#11).
Change subject: mb/google/volteer/v/volteer2: Add config for passive USB-C DB on C1
......................................................................
mb/google/volteer/v/volteer2: Add config for passive USB-C DB on C1
This enables support for a passive USB-C daughterboard on
volteer. This board has no retimers or redrivers which makes it
functionally very similar to the USB-C port on the MLB.
Since there is no external logic, all mux-ing happens in the TCSS.
Also, the AUX DC biasing is controlled by SoC GPIO pins which must
also be explicitly enabled.
BRANCH=volteer
BUG=b:163476857
TEST=verified external USB-C monitor shows up in both cable
orientations in combination with following patches
Change-Id: Id9939450213bac4c0d661759bef2f38f3fd3af76
Signed-off-by: Caveh Jalali <caveh(a)chromium.org>
---
M src/mainboard/google/volteer/fw_config.c
M src/mainboard/google/volteer/mainboard.c
M src/mainboard/google/volteer/variants/baseboard/gpio.c
M src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h
M src/mainboard/google/volteer/variants/volteer2/Makefile.inc
M src/mainboard/google/volteer/variants/volteer2/gpio.c
A src/mainboard/google/volteer/variants/volteer2/variant.c
7 files changed, 61 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/47501/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/47501
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9939450213bac4c0d661759bef2f38f3fd3af76
Gerrit-Change-Number: 47501
Gerrit-PatchSet: 11
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46231 )
Change subject: soc/intel/xeon_sp: Enable SMI handler
......................................................................
Patch Set 29:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46231/29/src/soc/intel/xeon_sp/smm…
File src/soc/intel/xeon_sp/smmrelocate.c:
https://review.coreboot.org/c/coreboot/+/46231/29/src/soc/intel/xeon_sp/smm…
PS29, Line 17: const uint32_t rmask = ~(4 * KiB - 1);
Why not use ALIGN_DOWN and friends?
--
To view, visit https://review.coreboot.org/c/coreboot/+/46231
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iabee5c72f0245ab988d477ac8df3d8d655a2a506
Gerrit-Change-Number: 46231
Gerrit-PatchSet: 29
Gerrit-Owner: Rocky Phagura
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 23 Nov 2020 10:22:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46231 )
Change subject: soc/intel/xeon_sp: Enable SMI handler
......................................................................
Patch Set 29: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/46231
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iabee5c72f0245ab988d477ac8df3d8d655a2a506
Gerrit-Change-Number: 46231
Gerrit-PatchSet: 29
Gerrit-Owner: Rocky Phagura
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 23 Nov 2020 10:20:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47147 )
Change subject: mb/**/cmos.layout: Indent everything with tabs
......................................................................
mb/**/cmos.layout: Indent everything with tabs
Time has shown that using spaces never converges into proper alignment.
Change-Id: I5338aeaf139580f9eab3e1e02cb910080a95d2c2
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M src/mainboard/acer/g43t-am3/cmos.layout
M src/mainboard/amd/inagua/cmos.layout
M src/mainboard/amd/olivehill/cmos.layout
M src/mainboard/amd/parmer/cmos.layout
M src/mainboard/amd/persimmon/cmos.layout
M src/mainboard/amd/south_station/cmos.layout
M src/mainboard/amd/thatcher/cmos.layout
M src/mainboard/amd/union_station/cmos.layout
M src/mainboard/apple/macbook21/cmos.layout
M src/mainboard/apple/macbookair4_2/cmos.layout
M src/mainboard/asrock/e350m1/cmos.layout
M src/mainboard/asrock/g41c-gs/cmos.layout
M src/mainboard/asrock/h110m/cmos.layout
M src/mainboard/asrock/h81m-hds/cmos.layout
M src/mainboard/asrock/imb-a180/cmos.layout
M src/mainboard/asus/a88xm-e/cmos.layout
M src/mainboard/asus/am1i-a/cmos.layout
M src/mainboard/asus/f2a85-m/cmos.layout
M src/mainboard/asus/h61m-cs/cmos.layout
M src/mainboard/asus/maximus_iv_gene-z/cmos.layout
M src/mainboard/asus/p5gc-mx/cmos.layout
M src/mainboard/asus/p5qc/cmos.layout
M src/mainboard/asus/p5ql-em/cmos.layout
M src/mainboard/asus/p5qpl-am/cmos.layout
M src/mainboard/asus/p8h61-m_lx/cmos.layout
M src/mainboard/asus/p8h61-m_pro/cmos.layout
M src/mainboard/asus/p8z77-m_pro/cmos.layout
M src/mainboard/bap/ode_e20XX/cmos.layout
M src/mainboard/biostar/a68n_5200/cmos.layout
M src/mainboard/biostar/am1ml/cmos.layout
M src/mainboard/biostar/th61-itx/cmos.layout
M src/mainboard/bostentech/gbyt4/cmos.layout
M src/mainboard/dell/optiplex_9010/cmos.layout
M src/mainboard/elmex/pcm205400/cmos.layout
M src/mainboard/emulation/qemu-i440fx/cmos.layout
M src/mainboard/emulation/qemu-q35/cmos.layout
M src/mainboard/facebook/fbg1701/cmos.layout
M src/mainboard/facebook/monolith/cmos.layout
M src/mainboard/foxconn/d41s/cmos.layout
M src/mainboard/foxconn/g41s-k/cmos.layout
M src/mainboard/getac/p470/cmos.layout
M src/mainboard/gigabyte/ga-945gcm-s2l/cmos.layout
M src/mainboard/gigabyte/ga-b75m-d3h/cmos.layout
M src/mainboard/gigabyte/ga-g41m-es2l/cmos.layout
M src/mainboard/gigabyte/ga-h61m-series/cmos.layout
M src/mainboard/gizmosphere/gizmo/cmos.layout
M src/mainboard/gizmosphere/gizmo2/cmos.layout
M src/mainboard/google/auron/cmos.layout
M src/mainboard/google/beltino/cmos.layout
M src/mainboard/google/butterfly/cmos.layout
M src/mainboard/google/cyan/cmos.layout
M src/mainboard/google/glados/cmos.layout
M src/mainboard/google/jecht/cmos.layout
M src/mainboard/google/link/cmos.layout
M src/mainboard/google/parrot/cmos.layout
M src/mainboard/google/rambi/cmos.layout
M src/mainboard/google/slippy/cmos.layout
M src/mainboard/google/stout/cmos.layout
M src/mainboard/hp/abm/cmos.layout
M src/mainboard/hp/compaq_8200_elite_sff/cmos.layout
M src/mainboard/hp/pavilion_m6_1035dx/cmos.layout
M src/mainboard/hp/snb_ivb_laptops/cmos.layout
M src/mainboard/hp/z220_sff_workstation/cmos.layout
M src/mainboard/ibase/mb899/cmos.layout
M src/mainboard/intel/baskingridge/cmos.layout
M src/mainboard/intel/d510mo/cmos.layout
M src/mainboard/intel/d945gclf/cmos.layout
M src/mainboard/intel/dg41wv/cmos.layout
M src/mainboard/intel/dg43gt/cmos.layout
M src/mainboard/intel/emeraldlake2/cmos.layout
M src/mainboard/intel/kblrvp/cmos.layout
M src/mainboard/intel/kunimitsu/cmos.layout
M src/mainboard/intel/saddlebrook/cmos.layout
M src/mainboard/intel/strago/cmos.layout
M src/mainboard/intel/wtm2/cmos.layout
M src/mainboard/jetway/nf81-t56n-lf/cmos.layout
M src/mainboard/kontron/986lcd-m/cmos.layout
M src/mainboard/kontron/bsl6/cmos.layout
M src/mainboard/kontron/ktqm77/cmos.layout
M src/mainboard/lenovo/g505s/cmos.layout
M src/mainboard/lenovo/l520/cmos.layout
M src/mainboard/lenovo/t400/cmos.layout
M src/mainboard/lenovo/t410/cmos.layout
M src/mainboard/lenovo/t420/cmos.layout
M src/mainboard/lenovo/t420s/cmos.layout
M src/mainboard/lenovo/t430/cmos.layout
M src/mainboard/lenovo/t430s/cmos.layout
M src/mainboard/lenovo/t440p/cmos.layout
M src/mainboard/lenovo/t520/cmos.layout
M src/mainboard/lenovo/t530/cmos.layout
M src/mainboard/lenovo/t60/cmos.layout
M src/mainboard/lenovo/thinkcentre_a58/cmos.layout
M src/mainboard/lenovo/x131e/cmos.layout
M src/mainboard/lenovo/x1_carbon_gen1/cmos.layout
M src/mainboard/lenovo/x200/cmos.layout
M src/mainboard/lenovo/x201/cmos.layout
M src/mainboard/lenovo/x220/cmos.layout
M src/mainboard/lenovo/x230/cmos.layout
M src/mainboard/lenovo/x60/cmos.layout
M src/mainboard/lippert/frontrunner-af/cmos.layout
M src/mainboard/msi/ms7721/cmos.layout
M src/mainboard/packardbell/ms2290/cmos.layout
M src/mainboard/pcengines/apu1/cmos.layout
M src/mainboard/pcengines/apu2/cmos.layout
M src/mainboard/portwell/m107/cmos.layout
M src/mainboard/roda/rk886ex/cmos.layout
M src/mainboard/roda/rk9/cmos.layout
M src/mainboard/roda/rv11/cmos.layout
M src/mainboard/samsung/lumpy/cmos.layout
M src/mainboard/samsung/stumpy/cmos.layout
M src/mainboard/sapphire/pureplatinumh61/cmos.layout
M src/mainboard/siemens/chili/cmos.layout
M src/mainboard/supermicro/x10slm-f/cmos.layout
M src/mainboard/supermicro/x11-lga1151-series/cmos.layout
114 files changed, 4,747 insertions(+), 4,747 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/47147/1
--
To view, visit https://review.coreboot.org/c/coreboot/+/47147
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5338aeaf139580f9eab3e1e02cb910080a95d2c2
Gerrit-Change-Number: 47147
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi>
Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com>
Gerrit-MessageType: newchange