coreboot-gerrit August 2019

coreboot-gerrit@coreboot.org

1 participants
1942 discussions

Change in coreboot[master]: libgfxinit: Add options to limit framebuffer size
by Nico Huber (Code Review) 03 Aug '19

03 Aug '19

Nico Huber has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30580 ) Change subject: libgfxinit: Add options to limit framebuffer size ...................................................................... Abandoned no idea, why there were multiple copies... -- To view, visit https://review.coreboot.org/c/coreboot/+/30580 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I95897ca6beb98500d3a735abed85fb64e28012fb Gerrit-Change-Number: 30580 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: util/abuild: Use realpath for FAILED_BOARDS/PASSED_BOARDS
by Martin Roth (Code Review) 03 Aug '19

03 Aug '19

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34526 ) Change subject: util/abuild: Use realpath for FAILED_BOARDS/PASSED_BOARDS ...................................................................... util/abuild: Use realpath for FAILED_BOARDS/PASSED_BOARDS The abuild script will `cd` into the build directory. FAILED_BOARDS defaults to a relative path, so it ends up trying to echo into a directory that doesn't exist. If we set the realpath to the file then we can correctly update the failed/passed boards file. BUG=none TEST=make what-jenkins-does and verified there was a failed_boards and passed_boards in coreboot-builds. Change-Id: Ib3af003b090668380a9425583a9f4367023820a6 Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/34526 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martinroth(a)google.com> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/abuild/abuild 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Martin Roth: Looks good to me, approved diff --git a/util/abuild/abuild b/util/abuild/abuild index b816d3f..03be0d4 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -746,13 +746,18 @@ exit 1 fi +if ! mkdir -p "$TARGET"; then + echo "Unable to create build directory" + exit 1 +fi + customizing=$(echo "$customizing" | cut -c3-) if [ "$customizing" = "" ]; then customizing="default configuration" fi -FAILED_BOARDS="${TARGET}/failed_boards" -PASSED_BOARDS="${TARGET}/passing_boards" +FAILED_BOARDS="$(realpath ${TARGET}/failed_boards)" +PASSED_BOARDS="$(realpath ${TARGET}/passing_boards)" if [ "$recursive" = "false" ]; then rm -f "$FAILED_BOARDS" "$PASSED_BOARDS" -- To view, visit https://review.coreboot.org/c/coreboot/+/34526 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3af003b090668380a9425583a9f4367023820a6 Gerrit-Change-Number: 34526 Gerrit-PatchSet: 3 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: merged

1 0

Change in libgfxinit[master]: gma bdw+ transcoder: Use always-on path for primary pipe on eDP
by Nico Huber (Code Review) 03 Aug '19

03 Aug '19

Hello Matt DeVillier, I'd like you to do a code review. Please visit https://review.coreboot.org/c/libgfxinit/+/34628 to review the following change. Change subject: gma bdw+ transcoder: Use always-on path for primary pipe on eDP ...................................................................... gma bdw+ transcoder: Use always-on path for primary pipe on eDP This was a mistake in abb16d9 (gma hsw transcoder: Choose PDW path for scaling on DDI A). We only have to do it on HSW, future CPUs support scaling on the always-on path and don't support the alternative path anymore. Change-Id: I257108fce40b73024f231ca366c0d53b700dc588 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M common/hw-gfx-gma-transcoder.adb 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/28/34628/1 diff --git a/common/hw-gfx-gma-transcoder.adb b/common/hw-gfx-gma-transcoder.adb index 1e4952d..4970208 100644 --- a/common/hw-gfx-gma-transcoder.adb +++ b/common/hw-gfx-gma-transcoder.adb @@ -237,7 +237,9 @@ Trans : Transcoder_Regs renames Transcoders (Get_Idx (Pipe, Port_Cfg.Port)); EDP_Select : constant Word32 := - (if Pipe = Primary and not Scale then + (if Pipe = Primary and + (not Config.Use_PDW_For_EDP_Scaling or else not Scale) + then DDI_FUNC_CTL_EDP_SELECT_ALWAYS_ON else DDI_FUNC_CTL_EDP_SELECT (Pipe)); -- To view, visit https://review.coreboot.org/c/libgfxinit/+/34628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I257108fce40b73024f231ca366c0d53b700dc588 Gerrit-Change-Number: 34628 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

3 6

Change in coreboot[master]: [WIP] utils/inteltool: More refactoring
by Felix Singer (Code Review) 03 Aug '19

03 Aug '19

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33422 ) Change subject: [WIP] utils/inteltool: More refactoring ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/33422 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idb0c6953aee1ace275206fa4a2c16fa477bad5ec Gerrit-Change-Number: 33422 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 03 Aug 2019 16:39:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/hatch: Enable PmTimerDisabled config to reduce S0ix power u...
by Subrata Banik (Code Review) 03 Aug '19

03 Aug '19

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34611 ) Change subject: mb/google/hatch: Enable PmTimerDisabled config to reduce S0ix power usage ...................................................................... mb/google/hatch: Enable PmTimerDisabled config to reduce S0ix power usage BRANCH=none BUG=b:138152075 TEST=Build for cometlake board with the PmTimerDisabled policy in devicetree set to 1. With PmTimerDisabled = 0 >> iotools mmio_read8 0xfe0018fc 0x00 With PmTimerDisabled = 1 >> iotools mmio_read8 0xfe0018fc 0x02 Bit 1: ACPI Timer Disable (ACPI_TIM_DIS): This bit determines whether the ACPI Timer is enabled to run. - 0: ACPI Timer is enabled - 1: ACPI Timer is disabled Change-Id: I83f49505a804c99d7978e5d541ea9fe8ead9b88f Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/34611/1 diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index 6ff90f8..eb4be43 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -47,6 +47,8 @@ # Unlock GPIO pads register "PchUnlockGpioPads" = "1" + register "PmTimerDisabled" = "1" + # VR Settings Configuration for 4 Domains #+----------------+-------+-------+-------+-------+ #| Domain/Setting | SA | IA | GTUS | GTS | -- To view, visit https://review.coreboot.org/c/coreboot/+/34611 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I83f49505a804c99d7978e5d541ea9fe8ead9b88f Gerrit-Change-Number: 34611 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newchange

4 10

Change in coreboot[master]: string: implement strspn, strcspn, atol
by Angel Pons (Code Review) 03 Aug '19

03 Aug '19

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34450 ) Change subject: string: implement strspn, strcspn, atol ...................................................................... Patch Set 7: Code-Review+1 (1 comment) https://review.coreboot.org/c/coreboot/+/34450/7/src/lib/string.c File src/lib/string.c: https://review.coreboot.org/c/coreboot/+/34450/7/src/lib/string.c@168 PS7, Line 168: long ret = 0; : long sign = 1; Nit: These two variables could be the same -- To view, visit https://review.coreboot.org/c/coreboot/+/34450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id8fa880357124b620bde8884949bd8ffff7d0762 Gerrit-Change-Number: 34450 Gerrit-PatchSet: 7 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nitheesh Sekar <nsekar(a)codeaurora.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Yuji Sasaki <sasakiy(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 03 Aug 2019 09:36:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp1_1/raminit.c: Always check FSP HOBs
by Matt DeVillier (Code Review) 03 Aug '19

03 Aug '19

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29371 ) Change subject: drivers/intel/fsp1_1/raminit.c: Always check FSP HOBs ...................................................................... Patch Set 11: (1 comment) https://review.coreboot.org/c/coreboot/+/29371/11/src/drivers/intel/fsp1_1/… File src/drivers/intel/fsp1_1/raminit.c: https://review.coreboot.org/c/coreboot/+/29371/11/src/drivers/intel/fsp1_1/… PS11, Line 264: && CONFIG(DISPLAY_HOBS)) this shouldn't have been added, no relation to HOB display and breaks MRC cache on all FSP 1.1 devices when CONFIG_DISPLAY_HOBS isn't selected. Fixed in CB:34685 -- To view, visit https://review.coreboot.org/c/coreboot/+/29371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3776fa37866c7ef3aea090842387660c22bbdd4d Gerrit-Change-Number: 29371 Gerrit-PatchSet: 11 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: York Yang <yyang024(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Sat, 03 Aug 2019 03:49:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: string: implement strspn, strcspn, atol
by Julius Werner (Code Review) 03 Aug '19

03 Aug '19

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34450 ) Change subject: string: implement strspn, strcspn, atol ...................................................................... Patch Set 7: Code-Review+2 (1 comment) https://review.coreboot.org/c/coreboot/+/34450/7/src/lib/string.c File src/lib/string.c: https://review.coreboot.org/c/coreboot/+/34450/7/src/lib/string.c@171 PS7, Line 171: str += strspn(str, " \t"); nit: if we want to be very pendantic this should be all that isspace() is true for, so " \t\n\r\f\v" -- To view, visit https://review.coreboot.org/c/coreboot/+/34450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id8fa880357124b620bde8884949bd8ffff7d0762 Gerrit-Change-Number: 34450 Gerrit-PatchSet: 7 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nitheesh Sekar <nsekar(a)codeaurora.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Yuji Sasaki <sasakiy(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Aug 2019 22:59:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: string: implement strspn, strcspn, atol
by Patrick Georgi (Code Review) 02 Aug '19

02 Aug '19

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34450 ) Change subject: string: implement strspn, strcspn, atol ...................................................................... Patch Set 7: (2 comments) https://review.coreboot.org/c/coreboot/+/34450/3/src/lib/string.c File src/lib/string.c: https://review.coreboot.org/c/coreboot/+/34450/3/src/lib/string.c@142 PS3, Line 142: while (*p != 0) { > nit: maybe better? […] Done https://review.coreboot.org/c/coreboot/+/34450/3/src/lib/string.c@147 PS3, Line 147: 0 > nit: maybe that's just me, but in string contexts I prefer to write these as '\0' for clarity. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/34450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id8fa880357124b620bde8884949bd8ffff7d0762 Gerrit-Change-Number: 34450 Gerrit-PatchSet: 7 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Nitheesh Sekar <nsekar(a)codeaurora.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Yuji Sasaki <sasakiy(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Fri, 02 Aug 2019 18:45:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: string: implement strspn, strcspn, atol
by Patrick Georgi (Code Review) 02 Aug '19

02 Aug '19

Hello Yuji Sasaki, Paul Menzel, build bot (Jenkins), Nitheesh Sekar, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34450 to look at the new patch set (#6). Change subject: string: implement strspn, strcspn, atol ...................................................................... string: implement strspn, strcspn, atol Change-Id: Id8fa880357124b620bde8884949bd8ffff7d0762 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/include/string.h M src/lib/string.c 2 files changed, 57 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/34450/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/34450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id8fa880357124b620bde8884949bd8ffff7d0762 Gerrit-Change-Number: 34450 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Nitheesh Sekar <nsekar(a)codeaurora.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Yuji Sasaki <sasakiy(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2019