Change in libgfxinit[master]: gma bdw+ transcoder: Use always-on path for primary pipe on eDP
Hello Matt DeVillier,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/libgfxinit/+/34628
to review the following change.
Change subject: gma bdw+ transcoder: Use always-on path for primary pipe on eDP ......................................................................
gma bdw+ transcoder: Use always-on path for primary pipe on eDP
This was a mistake in abb16d9 (gma hsw transcoder: Choose PDW path for scaling on DDI A). We only have to do it on HSW, future CPUs support scaling on the always-on path and don't support the alternative path anymore.
Change-Id: I257108fce40b73024f231ca366c0d53b700dc588 Signed-off-by: Nico Huber nico.huber@secunet.com --- M common/hw-gfx-gma-transcoder.adb 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/28/34628/1
diff --git a/common/hw-gfx-gma-transcoder.adb b/common/hw-gfx-gma-transcoder.adb index 1e4952d..4970208 100644 --- a/common/hw-gfx-gma-transcoder.adb +++ b/common/hw-gfx-gma-transcoder.adb @@ -237,7 +237,9 @@ Trans : Transcoder_Regs renames Transcoders (Get_Idx (Pipe, Port_Cfg.Port)); EDP_Select : constant Word32 := - (if Pipe = Primary and not Scale then + (if Pipe = Primary and + (not Config.Use_PDW_For_EDP_Scaling or else not Scale) + then DDI_FUNC_CTL_EDP_SELECT_ALWAYS_ON else DDI_FUNC_CTL_EDP_SELECT (Pipe));
Hello Matt DeVillier,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/libgfxinit/+/34628
to look at the new patch set (#2).
Change subject: gma bdw+ transcoder: Use always-on path for primary pipe on eDP ......................................................................
gma bdw+ transcoder: Use always-on path for primary pipe on eDP
This was a mistake in abb16d9 (gma hsw transcoder: Choose PDW path for scaling on DDI A). We only have to do it on HSW, future CPUs support scaling on the always-on path and don't support the alternative path anymore.
Tested on Haswell (gfx_test), Broadwell (gfx_test) and Coffee Lake (gfx_test & coreboot).
Change-Id: I257108fce40b73024f231ca366c0d53b700dc588 Signed-off-by: Nico Huber nico.huber@secunet.com --- M common/hw-gfx-gma-transcoder.adb 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/28/34628/2
Hello Matt DeVillier,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/libgfxinit/+/34628
to look at the new patch set (#3).
Change subject: gma bdw+ transcoder: Use always-on path for primary pipe on eDP ......................................................................
gma bdw+ transcoder: Use always-on path for primary pipe on eDP
This was a mistake in abb16d9 (gma hsw transcoder: Choose PDW path for scaling on DDI A). We only have to do it on HSW, future CPUs support scaling on the always-on path and don't support the alternative path anymore.
Tested on Haswell (gfx_test), Broadwell (gfx_test) and Coffee Lake (gfx_test & coreboot): Scaled picture shows up (instead of a black screen on BDW+).
Change-Id: I257108fce40b73024f231ca366c0d53b700dc588 Signed-off-by: Nico Huber nico.huber@secunet.com --- M common/hw-gfx-gma-transcoder.adb 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/28/34628/3
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/34628 )
Change subject: gma bdw+ transcoder: Use always-on path for primary pipe on eDP ......................................................................
Patch Set 3: Code-Review+1
verified scaling fixed on SKL-U (purism/librem_skl)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/34628 )
Change subject: gma bdw+ transcoder: Use always-on path for primary pipe on eDP ......................................................................
Patch Set 3: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/34628 )
Change subject: gma bdw+ transcoder: Use always-on path for primary pipe on eDP ......................................................................
Patch Set 3: Verified+1
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/libgfxinit/+/34628 )
Change subject: gma bdw+ transcoder: Use always-on path for primary pipe on eDP ......................................................................
gma bdw+ transcoder: Use always-on path for primary pipe on eDP
This was a mistake in abb16d9 (gma hsw transcoder: Choose PDW path for scaling on DDI A). We only have to do it on HSW, future CPUs support scaling on the always-on path and don't support the alternative path anymore.
Tested on Haswell (gfx_test), Broadwell (gfx_test) and Coffee Lake (gfx_test & coreboot): Scaled picture shows up (instead of a black screen on BDW+).
Change-Id: I257108fce40b73024f231ca366c0d53b700dc588 Signed-off-by: Nico Huber nico.huber@secunet.com Reviewed-on: https://review.coreboot.org/c/libgfxinit/+/34628 Reviewed-by: Matt DeVillier matt.devillier@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: Nico Huber nico.h@gmx.de --- M common/hw-gfx-gma-transcoder.adb 1 file changed, 3 insertions(+), 1 deletion(-)
Approvals: Nico Huber: Verified Matt DeVillier: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/common/hw-gfx-gma-transcoder.adb b/common/hw-gfx-gma-transcoder.adb index 1e4952d..4970208 100644 --- a/common/hw-gfx-gma-transcoder.adb +++ b/common/hw-gfx-gma-transcoder.adb @@ -237,7 +237,9 @@ Trans : Transcoder_Regs renames Transcoders (Get_Idx (Pipe, Port_Cfg.Port)); EDP_Select : constant Word32 := - (if Pipe = Primary and not Scale then + (if Pipe = Primary and + (not Config.Use_PDW_For_EDP_Scaling or else not Scale) + then DDI_FUNC_CTL_EDP_SELECT_ALWAYS_ON else DDI_FUNC_CTL_EDP_SELECT (Pipe));
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)
-
Nico Huber (Code Review)