coreboot-gerrit June 2019

coreboot-gerrit@coreboot.org

1 participants
1454 discussions

Change in ...coreboot[master]: usbdebug: Use IS_ENABLED()
by Kyösti Mälkki (Code Review) 25 Jun '19

25 Jun '19

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30556 ) Change subject: usbdebug: Use IS_ENABLED() ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/30556 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ae7e144a89a8f7e5f9d307ba4e73d4f96401a79 Gerrit-Change-Number: 30556 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: soc/intel/denverton_ns/include/soc/gpio_defs: Fix value of B_PCH_GPIO...
by Patrick Havelange (Code Review) 25 Jun '19

25 Jun '19

Patrick Havelange has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33573 Change subject: soc/intel/denverton_ns/include/soc/gpio_defs: Fix value of B_PCH_GPIO_RX_SCI_ROUTE ...................................................................... soc/intel/denverton_ns/include/soc/gpio_defs: Fix value of B_PCH_GPIO_RX_SCI_ROUTE The value for that macro should be 1<<19. This is confirmed by the intel doc and also by N_PCH_GPIO_RX_SCI_ROUTE. Signed-off-by: Patrick Havelange <patrick.havelange(a)essensium.com> Change-Id: I808d9131032a9796d837e00ad6fb3369b792e597 --- M src/soc/intel/denverton_ns/include/soc/gpio_defs.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/33573/1 diff --git a/src/soc/intel/denverton_ns/include/soc/gpio_defs.h b/src/soc/intel/denverton_ns/include/soc/gpio_defs.h index 43e0647..ae61e6d 100644 --- a/src/soc/intel/denverton_ns/include/soc/gpio_defs.h +++ b/src/soc/intel/denverton_ns/include/soc/gpio_defs.h @@ -182,7 +182,7 @@ #define V_PCH_GPIO_RX_APIC_ROUTE_EN 0x01 // GPIO Input Route SCI -#define B_PCH_GPIO_RX_SCI_ROUTE (1 << 10) +#define B_PCH_GPIO_RX_SCI_ROUTE (1 << 19) #define N_PCH_GPIO_RX_SCI_ROUTE 19 #define V_PCH_GPIO_RX_SCI_ROUTE_DIS 0x00 #define V_PCH_GPIO_RX_SCI_ROUTE_EN 0x01 -- To view, visit https://review.coreboot.org/c/coreboot/+/33573 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I808d9131032a9796d837e00ad6fb3369b792e597 Gerrit-Change-Number: 33573 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Havelange <patrick.havelange(a)essensium.com> Gerrit-MessageType: newchange

7 12

Change in ...coreboot[master]: mainboard/facebook/fbg1701: Add FMAP file
by Frans Hendriks (Code Review) 25 Jun '19

25 Jun '19

Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33484 Change subject: mainboard/facebook/fbg1701: Add FMAP file ...................................................................... mainboard/facebook/fbg1701: Add FMAP file No FMAP file is availabe for this mainboard. Add fmap.fmd and add file location to Kconfig BUG=N/A TEST=Boot Embedded Linux 4.20 and verify logging on Facebook FBG-1701 Change-Id: Iecfae4573100c6787b6e8b1c4f2583a7fb3d95a3 Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com> --- M src/mainboard/facebook/fbg1701/Kconfig A src/mainboard/facebook/fbg1701/fmap.fmd 2 files changed, 25 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/33484/1 diff --git a/src/mainboard/facebook/fbg1701/Kconfig b/src/mainboard/facebook/fbg1701/Kconfig index 3f45194..801a99a 100644 --- a/src/mainboard/facebook/fbg1701/Kconfig +++ b/src/mainboard/facebook/fbg1701/Kconfig @@ -70,6 +70,10 @@ hex default 0x08000 +config FMDFILE + string + default "$(top)/src/mainboard/$(CONFIG_MAINBOARD_DIR)/fmap.fmd" + config FSP_LOC hex default 0xfff9c000 diff --git a/src/mainboard/facebook/fbg1701/fmap.fmd b/src/mainboard/facebook/fbg1701/fmap.fmd new file mode 100644 index 0000000..dca6838 --- /dev/null +++ b/src/mainboard/facebook/fbg1701/fmap.fmd @@ -0,0 +1,21 @@ +# layout for firmware residing at top of 4GB address space +# +-------------+ <-- 4GB - ROM_SIZE / start of flash +# | unspecified | +# +-------------+ <-- 4GB - BIOS_SIZE +# | FMAP | +# +-------------+ <-- 4GB - BIOS_SIZE + FMAP_SIZE +# | CBFS | +# +-------------+ <-- 4GB / end of flash + +FLASH@0xFF800000 0x800000 { + SI_ALL@0x0 0x200000 { + SI_DESC@0x0 0x1000 + SI_ME@0x1000 0x1ff000 + } + BIOS@0x200000 0x600000 { + FMAP@0 0x200 + RW_MRC_CACHE@0x200 0x8000 + + COREBOOT(CBFS)@0x8200 0x5F7E00 + } +} -- To view, visit https://review.coreboot.org/c/coreboot/+/33484 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iecfae4573100c6787b6e8b1c4f2583a7fb3d95a3 Gerrit-Change-Number: 33484 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-MessageType: newchange

6 17

Change in ...coreboot[master]: device: Move pci_irq_info out of early devicetree
by Karthik Ramasubramanian (Code Review) 25 Jun '19

25 Jun '19

Karthik Ramasubramanian has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33376 ) Change subject: device: Move pci_irq_info out of early devicetree ...................................................................... Abandoned CB:31936 does more than this CL and does it better. -- To view, visit https://review.coreboot.org/c/coreboot/+/33376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icde376f9cf7431f09d7eb7e738b38e7dd97be8eb Gerrit-Change-Number: 33376 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: device: Move pci_irq_info out of early devicetree
by Karthik Ramasubramanian (Code Review) 25 Jun '19

25 Jun '19

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33376 ) Change subject: device: Move pci_irq_info out of early devicetree ...................................................................... Patch Set 1: > Patch Set 1: > > It's more effective to remove the node links from early tree; see CB:31936 (needs rebase). > > This does require that we resolve any nodes at compile-time already. Doing that would help us remove __SIMPLE_DEVICE__ too. CB:31936 looks good to me and is much better than this one. I will abandon this CL and use the one you uploaded. -- To view, visit https://review.coreboot.org/c/coreboot/+/33376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icde376f9cf7431f09d7eb7e738b38e7dd97be8eb Gerrit-Change-Number: 33376 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Tue, 25 Jun 2019 15:24:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: sdm845: Add QUPv3 FW load & config
by Akash Asthana (Code Review) 25 Jun '19

25 Jun '19

Akash Asthana has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25372 ) Change subject: sdm845: Add QUPv3 FW load & config ...................................................................... Patch Set 75: (8 comments) Thanks for reviewing. https://review.coreboot.org/#/c/25372/75/src/mainboard/google/cheza/mainboa… File src/mainboard/google/cheza/mainboard.c: https://review.coreboot.org/#/c/25372/75/src/mainboard/google/cheza/mainboa… PS75, Line 52: write32((void *)0x11874c, 0x21); > Note that this can't stay here like this. […] These are clock control registers(not QUP registers), we are writing them to enable DFS(dynamic frequency selection) mode for QUPs which is PORed with SPI & I2C use case(in kernel/HLOS). We are discussing this change internally, for the time being, we are moving it out into separate HACK patch to unblock this Gerrit. https://review.coreboot.org/#/c/25372/6/src/mainboard/google/cheza/qupv3_co… File src/mainboard/google/cheza/qupv3_config.c: https://review.coreboot.org/#/c/25372/6/src/mainboard/google/cheza/qupv3_co… PS6, Line 18: struct se_cfg se_mappings[QUPV3_SE_MAX] = > Whoops, sorry for missing this. […] This will violate HPG sequence requirement provided to us by the HW team which says that we have to do those common QUPV3 wrapper initialization every time before load firmware. Suppose we moved common initialization to bootblock.c and loaded FW on demand for SPI use case and it started SPI transactions, now if we want to load FW for I2C usecase on same QUPV3 wrapper's QUP instance, we still need to do common QUPV3 wrapper initialization before loading FW to QUP. This can trouble running SPI. https://review.coreboot.org/#/c/25372/75/src/soc/qualcomm/sdm845/include/so… File src/soc/qualcomm/sdm845/include/soc/qupv3_config.h: https://review.coreboot.org/#/c/25372/75/src/soc/qualcomm/sdm845/include/so… PS75, Line 23: #endif // _SDM845_QUPV3_CONFIG_H_ > Please use /* C89 */ instead of // C99 comments (please fix globally). Done https://review.coreboot.org/#/c/25372/75/src/soc/qualcomm/sdm845/qupv3_fw_c… File src/soc/qualcomm/sdm845/qupv3_fw_config.c: https://review.coreboot.org/#/c/25372/75/src/soc/qualcomm/sdm845/qupv3_fw_c… PS75, Line 166: static uintptr_t qupv3_se_base_addr[QUPV3_SE_MAX] = { > You should be using the global 'qup' array we introduced for the SPI and I2C drivers instead of this […] Done https://review.coreboot.org/#/c/25372/75/src/soc/qualcomm/sdm845/qupv3_fw_c… PS75, Line 200: reg_value = read32(se_base + GENI_OUTPUT_CTRL_REG) & > All these register accesses should be using the struct qup_regs that we introduced for the SPI/I2C d […] Done https://review.coreboot.org/#/c/25372/75/src/soc/qualcomm/sdm845/qupv3_fw_c… PS75, Line 396: reg_value = read32((void *)qupv3_common_base_list[i] + > For all these register accesses you should make a new struct overlay for the common part of the QUPV […] Done https://review.coreboot.org/#/c/25372/75/src/soc/qualcomm/sdm845/qupv3_fw_c… PS75, Line 425: write32((void *)0x0015200C + 0, 0x3FFFFFC0); > All accesses to GCC registers should be made from clock.c. Done https://review.coreboot.org/#/c/25372/75/src/soc/qualcomm/sdm845/qupv3_fw_c… PS75, Line 427: fw_init_qup_common(); > Can we change this to something like […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/25372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e87f868ecbe2a8e51d94c045ad76b99bb1b345d Gerrit-Change-Number: 25372 Gerrit-PatchSet: 75 Gerrit-Owner: mturney mturney <mturney(a)codeaurora.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mukesh Savaliya <msavaliy(a)qualcomm.corp-partner.google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Akash Asthana <akashast(a)qualcomm.corp-partner.google.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Tue, 25 Jun 2019 14:06:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Akash Asthana <akashast(a)qualcomm.corp-partner.google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/up/squared: Add kernel cmdline parameters
by Felix Singer (Code Review) 25 Jun '19

25 Jun '19

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33785 ) Change subject: mb/up/squared: Add kernel cmdline parameters ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/33785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0469226253b08328807d5401c05633296e43d22 Gerrit-Change-Number: 33785 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Tue, 25 Jun 2019 13:23:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/upsquared: Align partitions to 4KiB
by Felix Singer (Code Review) 25 Jun '19

25 Jun '19

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33784 ) Change subject: mb/upsquared: Align partitions to 4KiB ...................................................................... Patch Set 4: (2 comments) This change is ready for review. https://review.coreboot.org/#/c/33784/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/33784/2//COMMIT_MSG@7 PS2, Line 7: with > to Done https://review.coreboot.org/#/c/33784/2//COMMIT_MSG@7 PS2, Line 7: 4K > 4K as display resolution? Or is it 4KiB? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/33784 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1e99b74ded5f743a3ad4fc829ae9747276c483a Gerrit-Change-Number: 33784 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 25 Jun 2019 12:57:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/upsquared: Align partitions with 4K
by Felix Singer (Code Review) 25 Jun '19

25 Jun '19

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33784 ) Change subject: mb/upsquared: Align partitions with 4K ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/33784 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1e99b74ded5f743a3ad4fc829ae9747276c483a Gerrit-Change-Number: 33784 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 25 Jun 2019 12:56:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/upsquared: Align partitions with 4K
by Angel Pons (Code Review) 25 Jun '19

25 Jun '19

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33784 ) Change subject: mb/upsquared: Align partitions with 4K ...................................................................... Patch Set 2: Code-Review+1 (2 comments) https://review.coreboot.org/#/c/33784/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/33784/2//COMMIT_MSG@7 PS2, Line 7: with to https://review.coreboot.org/#/c/33784/2//COMMIT_MSG@7 PS2, Line 7: 4K 4K as display resolution? Or is it 4KiB? -- To view, visit https://review.coreboot.org/c/coreboot/+/33784 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1e99b74ded5f743a3ad4fc829ae9747276c483a Gerrit-Change-Number: 33784 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 25 Jun 2019 12:50:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2019