Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33522 )
Change subject: src/mb/gigabyte/ga-h61m-s2pv: Correct devicetree
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33522
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb9dd8c835bc3652e7a3a118feca5551196bb81b
Gerrit-Change-Number: 33522
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Sun, 16 Jun 2019 01:57:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33230
Change subject: [WIP]nb/intel/haswell: Increase CAR stack
......................................................................
[WIP]nb/intel/haswell: Increase CAR stack
With C_ENVIRONMENT_BOOTBLOCK the stack is placed at the bottom of the
CAR region and is of a fixed size. If the stack grows larger than
DCACHE_BSP_STACK_SIZE, it will likely fail to boot.
Some options like SPI flash console increase the stack usage and may
result in a non booting system.
TESTME...
Change-Id: Ifda1dc3456a4e75b6b295ed6aecdd9e751b8bd22
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/northbridge/intel/haswell/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/33230/1
diff --git a/src/northbridge/intel/haswell/Kconfig b/src/northbridge/intel/haswell/Kconfig
index e1067c5..8a6d1ab 100644
--- a/src/northbridge/intel/haswell/Kconfig
+++ b/src/northbridge/intel/haswell/Kconfig
@@ -79,7 +79,7 @@
config DCACHE_BSP_STACK_SIZE
hex
- default 0x2000
+ default 0x4000
help
The amount of anticipated stack usage in CAR by bootblock and
other stages.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33230
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifda1dc3456a4e75b6b295ed6aecdd9e751b8bd22
Gerrit-Change-Number: 33230
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newchange
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33341
Change subject: arch/x86/Kconfig: hide the "Bootblock behaviour" option on non-romcc
......................................................................
arch/x86/Kconfig: hide the "Bootblock behaviour" option on non-romcc
Selecting which cbfs prefix to load is only implemented with the romcc
bootblock.
Change-Id: I09523b94605f00ab15b5f0ea3986ac08e3a6afc6
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/arch/x86/Kconfig
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/33341/1
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig
index 36f2277..f8554385 100644
--- a/src/arch/x86/Kconfig
+++ b/src/arch/x86/Kconfig
@@ -239,9 +239,11 @@
Add a spin (JMP .) in assembly_entry.S during early romstage to wait
for a JTAG debugger to break into the execution sequence.
+# Selecting a cbfs prefix from the bootblock is only implemented with romcc
choice
prompt "Bootblock behaviour"
default BOOTBLOCK_SIMPLE
+ depends on !C_ENVIRONMENT_BOOTBLOCK
config BOOTBLOCK_SIMPLE
bool "Always load fallback"
--
To view, visit https://review.coreboot.org/c/coreboot/+/33341
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09523b94605f00ab15b5f0ea3986ac08e3a6afc6
Gerrit-Change-Number: 33341
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newchange
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33324
Change subject: arch/x86/Kconfig: Hide the prefix option on all but BOOTBLOCK_NORMAL
......................................................................
arch/x86/Kconfig: Hide the prefix option on all but BOOTBLOCK_NORMAL
Change-Id: Icf5e8fa18bea1cdfb85b8a4999d8fccea94d16b9
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/Kconfig
M src/arch/x86/Kconfig
M src/arch/x86/bootblock_simple.c
3 files changed, 7 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/33324/1
diff --git a/src/Kconfig b/src/Kconfig
index d30aa99..aa02001 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -32,8 +32,11 @@
the coreboot version number, so that you can easily distinguish
boot logs of different boards from each other.
+config USE_CBFS_PREFIX
+ bool
+
config CBFS_PREFIX
- string "CBFS prefix to use"
+ string "CBFS prefix to use" if USE_CBFS_PREFIX
default "fallback"
help
Select the prefix to all files put into the image. It's "fallback"
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig
index 827c1cb..36f2277 100644
--- a/src/arch/x86/Kconfig
+++ b/src/arch/x86/Kconfig
@@ -247,6 +247,7 @@
bool "Always load fallback"
config BOOTBLOCK_NORMAL
+ select USE_CBFS_PREFIX
bool "Switch to normal if CMOS says so"
endchoice
diff --git a/src/arch/x86/bootblock_simple.c b/src/arch/x86/bootblock_simple.c
index fc041c8..fd328a1 100644
--- a/src/arch/x86/bootblock_simple.c
+++ b/src/arch/x86/bootblock_simple.c
@@ -28,9 +28,9 @@
}
#if CONFIG(VBOOT_SEPARATE_VERSTAGE)
- const char *target1 = "fallback/verstage";
+ const char *target1 = "verstage";
#else
- const char *target1 = "fallback/romstage";
+ const char *target1 = "romstage";
#endif
unsigned long entry;
--
To view, visit https://review.coreboot.org/c/coreboot/+/33324
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf5e8fa18bea1cdfb85b8a4999d8fccea94d16b9
Gerrit-Change-Number: 33324
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newchange
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31316 )
Change subject: arch/x86: Make X86 specific options depend on ARCH_X86
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/31316/5/src/mainboard/packardbell/ms2290/Kc…
File src/mainboard/packardbell/ms2290/Kconfig:
https://review.coreboot.org/#/c/31316/5/src/mainboard/packardbell/ms2290/Kc…
PS5, Line 6: select ARCH_X86
: select ARCH_BOOTBLOCK_X86_32
: select ARCH_ROMSTAGE_X86_32
: select ARCH_RAMSTAGE_X86_32
> Shouldn't these be selected by the northbridge/CPU?
There is a lot of stuff that needs to get out of this and thinkpad/x201[WIP] dir. Thx for noticing.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31316
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic77b696f493d7648f317f0ba0a27fdee5212961e
Gerrit-Change-Number: 31316
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Vanny E <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: York Yang <yyang024(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Sat, 15 Jun 2019 16:52:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31316 )
Change subject: arch/x86: Make X86 specific options depend on ARCH_X86
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/31316/5/src/mainboard/packardbell/ms2290/Kc…
File src/mainboard/packardbell/ms2290/Kconfig:
https://review.coreboot.org/#/c/31316/5/src/mainboard/packardbell/ms2290/Kc…
PS5, Line 6: select ARCH_X86
: select ARCH_BOOTBLOCK_X86_32
: select ARCH_ROMSTAGE_X86_32
: select ARCH_RAMSTAGE_X86_32
Shouldn't these be selected by the northbridge/CPU?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31316
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic77b696f493d7648f317f0ba0a27fdee5212961e
Gerrit-Change-Number: 31316
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Vanny E <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: York Yang <yyang024(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Sat, 15 Jun 2019 16:51:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment