coreboot-gerrit May 2019

coreboot-gerrit@coreboot.org

1 participants
1485 discussions

Change in ...coreboot[master]: mb/lenovo: Unify thermal threshold handling
by Philipp Deppenwiese (Code Review) 07 May '19

07 May '19

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29659 ) Change subject: mb/lenovo: Unify thermal threshold handling ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29659 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If569f67c932b7fbf14893b890a5588df4994daeb Gerrit-Change-Number: 29659 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 May 2019 15:09:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mainboard/lenovo/t530: Add vboot support
by Philipp Deppenwiese (Code Review) 07 May '19

07 May '19

Philipp Deppenwiese has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/29816 ) Change subject: mainboard/lenovo/t530: Add vboot support ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/29816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28c2fb92d574c8070dbf767adc5839faf4fb47a0 Gerrit-Change-Number: 29816 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Martin Kepplinger <martink(a)posteo.de> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: test
by HAOUAS Elyes (Code Review) 07 May '19

07 May '19

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32669 Change subject: test ...................................................................... test Change-Id: I65f6195848a6e10146195a844893255e056ffd87 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/32669/1 diff --git a/src/Kconfig b/src/Kconfig index b4898bd..cd84611 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -1,4 +1,4 @@ -## +#### ## This file is part of the coreboot project. ## ## Copyright (C) 2012 Alexandru Gagniuc <mr.nuke.me(a)gmail.com> -- To view, visit https://review.coreboot.org/c/coreboot/+/32669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65f6195848a6e10146195a844893255e056ffd87 Gerrit-Change-Number: 32669 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 1

Change in ...coreboot[master]: mainboard/lenovo/t530: Add vboot support
by Martin Kepplinger (Code Review) 07 May '19

07 May '19

Martin Kepplinger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29816 ) Change subject: mainboard/lenovo/t530: Add vboot support ...................................................................... Patch Set 5: > Patch Set 5: > > so without any knowledge about coreboot's vboot: when applying your mentioned changes for the x230 and trying to build this config: > > > CONFIG_USE_OPTION_TABLE=y > CONFIG_VENDOR_LENOVO=y > CONFIG_CBFS_SIZE=0x700000 > CONFIG_FMDFILE="src/mainboard/$(CONFIG_MAINBOARD_DIR)/board.fmd" > CONFIG_VBOOT=y > CONFIG_BOARD_LENOVO_X230=y > # CONFIG_H8_BEEP_ON_DEATH is not set > CONFIG_GENERIC_LINEAR_FRAMEBUFFER=y > CONFIG_VBOOT_MEASURED_BOOT=y > CONFIG_VBOOT_SLOTS_RW_AB=y > CONFIG_GBB_FLAG_ENABLE_ALTERNATE_OS=y > CONFIG_GBB_FLAG_FORCE_DEV_SWITCH_ON=y > CONFIG_GBB_FLAG_FORCE_DEV_BOOT_LEGACY=y > CONFIG_DEBUG_TPM=y > CONFIG_DEFAULT_CONSOLE_LOGLEVEL_8=y > CONFIG_NO_POST=y > CONFIG_NVRAMCUI_SECONDARY_PAYLOAD=y > > > coreboot doesn't build: > > > Created CBFS (capacity = 6928344 bytes) > CBFS fallback/romstage > CBFS cpu_microcode_blob.bin > CBFS fallback/ramstage > CBFS vgaroms/seavgabios.bin > CBFS config > CBFS revision > CBFS cmos.default > CBFS vbt.bin > CBFS cmos_layout.bin > CBFS fallback/postcar > CBFS fallback/dsdt.aml > CBFS img/nvramcui > CBFS fallback/payload > CBFS payload_config > CBFS payload_revision > CBFS cpu_microcode_blob.bin > E: Image is missing 'FW_MAIN_A' region > E: The image will be left unmodified. > Makefile.inc:1014: die Regel für Ziel „build/coreboot.pre“ scheiterte > > > what am I doing wrong? nevermind. I was using an old config or the wrong CBFS_SIZE. it builds. -- To view, visit https://review.coreboot.org/c/coreboot/+/29816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28c2fb92d574c8070dbf767adc5839faf4fb47a0 Gerrit-Change-Number: 29816 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Martin Kepplinger <martink(a)posteo.de> Gerrit-Comment-Date: Tue, 07 May 2019 13:52:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mainboard/lenovo/t530: Add vboot support
by Martin Kepplinger (Code Review) 07 May '19

07 May '19

Martin Kepplinger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29816 ) Change subject: mainboard/lenovo/t530: Add vboot support ...................................................................... Patch Set 5: so without any knowledge about coreboot's vboot: when applying your mentioned changes for the x230 and trying to build this config: CONFIG_USE_OPTION_TABLE=y CONFIG_VENDOR_LENOVO=y CONFIG_CBFS_SIZE=0x700000 CONFIG_FMDFILE="src/mainboard/$(CONFIG_MAINBOARD_DIR)/board.fmd" CONFIG_VBOOT=y CONFIG_BOARD_LENOVO_X230=y # CONFIG_H8_BEEP_ON_DEATH is not set CONFIG_GENERIC_LINEAR_FRAMEBUFFER=y CONFIG_VBOOT_MEASURED_BOOT=y CONFIG_VBOOT_SLOTS_RW_AB=y CONFIG_GBB_FLAG_ENABLE_ALTERNATE_OS=y CONFIG_GBB_FLAG_FORCE_DEV_SWITCH_ON=y CONFIG_GBB_FLAG_FORCE_DEV_BOOT_LEGACY=y CONFIG_DEBUG_TPM=y CONFIG_DEFAULT_CONSOLE_LOGLEVEL_8=y CONFIG_NO_POST=y CONFIG_NVRAMCUI_SECONDARY_PAYLOAD=y coreboot doesn't build: Created CBFS (capacity = 6928344 bytes) CBFS fallback/romstage CBFS cpu_microcode_blob.bin CBFS fallback/ramstage CBFS vgaroms/seavgabios.bin CBFS config CBFS revision CBFS cmos.default CBFS vbt.bin CBFS cmos_layout.bin CBFS fallback/postcar CBFS fallback/dsdt.aml CBFS img/nvramcui CBFS fallback/payload CBFS payload_config CBFS payload_revision CBFS cpu_microcode_blob.bin E: Image is missing 'FW_MAIN_A' region E: The image will be left unmodified. Makefile.inc:1014: die Regel für Ziel „build/coreboot.pre“ scheiterte what am I doing wrong? -- To view, visit https://review.coreboot.org/c/coreboot/+/29816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28c2fb92d574c8070dbf767adc5839faf4fb47a0 Gerrit-Change-Number: 29816 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Martin Kepplinger <martink(a)posteo.de> Gerrit-Comment-Date: Tue, 07 May 2019 12:36:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: sb/intel/bd82x6x: Fix flashconsole after lockdown
by Patrick Rudolph (Code Review) 07 May '19

07 May '19

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25660 ) Change subject: sb/intel/bd82x6x: Fix flashconsole after lockdown ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/25660 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib802d7ee32f1fb0a68a84b0280480dcaefa9831f Gerrit-Change-Number: 25660 Gerrit-PatchSet: 7 Gerrit-Owner: Dan Elkouby <streetwalkermc(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Dan Elkouby <streetwalkermc(a)gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Tue, 07 May 2019 12:08:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: sb/intel/bd82x6x: Fix flashconsole after lockdown
by Evgeny Zinoviev (Code Review) 07 May '19

07 May '19

Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25660 ) Change subject: sb/intel/bd82x6x: Fix flashconsole after lockdown ...................................................................... Patch Set 7: (1 comment) https://review.coreboot.org/#/c/25660/6/src/southbridge/intel/bd82x6x/lpc.c File src/southbridge/intel/bd82x6x/lpc.c: https://review.coreboot.org/#/c/25660/6/src/southbridge/intel/bd82x6x/lpc.c… PS6, Line 911: if (IS_ENABLED(CONFIG_CONSOLE_SPI_FLASH)) > CONFIG() Done -- To view, visit https://review.coreboot.org/c/coreboot/+/25660 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib802d7ee32f1fb0a68a84b0280480dcaefa9831f Gerrit-Change-Number: 25660 Gerrit-PatchSet: 7 Gerrit-Owner: Dan Elkouby <streetwalkermc(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Dan Elkouby <streetwalkermc(a)gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Tue, 07 May 2019 10:06:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: sb/intel/bd82x6x: Fix flashconsole after lockdown
by Evgeny Zinoviev (Code Review) 07 May '19

07 May '19

Evgeny Zinoviev has uploaded a new patch set (#7) to the change originally created by Dan Elkouby. ( https://review.coreboot.org/c/coreboot/+/25660 ) Change subject: sb/intel/bd82x6x: Fix flashconsole after lockdown ...................................................................... sb/intel/bd82x6x: Fix flashconsole after lockdown SMM final locks the SPI BAR, which causes flashconsole to hang. Re-init it like SMM does with CONFIG_SPI_FLASH_SMM. Change-Id: Ib802d7ee32f1fb0a68a84b0280480dcaefa9831f Signed-off-by: Dan Elkouby <streetwalkermc(a)gmail.com> Signed-off-by: Evgeny Zinoviev <me(a)ch1p.io> --- M src/southbridge/intel/bd82x6x/lpc.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/25660/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/25660 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib802d7ee32f1fb0a68a84b0280480dcaefa9831f Gerrit-Change-Number: 25660 Gerrit-PatchSet: 7 Gerrit-Owner: Dan Elkouby <streetwalkermc(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Dan Elkouby <streetwalkermc(a)gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: Update vboot submodule to upstream master
by Joel Kitching (Code Review) 07 May '19

07 May '19

Joel Kitching has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32612 Change subject: Update vboot submodule to upstream master ...................................................................... Update vboot submodule to upstream master Updating from commit id 304aa429: 2019-03-12 10:38:56 -0700 - (futility: updater: Unit test for preserving sections using FMAP flags) to commit id e7edff66: 2019-05-03 07:02:32 -0700 - (vboot: implement DISPLAY_INIT context and SD flag) This brings in 45 new commits. Change-Id: I7493e43bddc553f9724de46130ccb4cb44e18573 Signed-off-by: Joel Kitching <kitching(a)google.com> --- M 3rdparty/vboot 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/32612/1 diff --git a/3rdparty/vboot b/3rdparty/vboot index 304aa42..e7edff6 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit 304aa429c1a04cda3ab2ce37b9e31af84405bfca +Subproject commit e7edff6653e16ed915c3ad12234d133d1ef4dcc9 -- To view, visit https://review.coreboot.org/c/coreboot/+/32612 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7493e43bddc553f9724de46130ccb4cb44e18573 Gerrit-Change-Number: 32612 Gerrit-PatchSet: 1 Gerrit-Owner: Joel Kitching <kitching(a)google.com> Gerrit-MessageType: newchange

2 2

Change in ...coreboot[master]: sb/intel/bd82x6x: Fix flashconsole after lockdown
by Patrick Rudolph (Code Review) 07 May '19

07 May '19

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25660 ) Change subject: sb/intel/bd82x6x: Fix flashconsole after lockdown ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/#/c/25660/6/src/southbridge/intel/bd82x6x/lpc.c File src/southbridge/intel/bd82x6x/lpc.c: https://review.coreboot.org/#/c/25660/6/src/southbridge/intel/bd82x6x/lpc.c… PS6, Line 911: if (IS_ENABLED(CONFIG_CONSOLE_SPI_FLASH)) CONFIG() -- To view, visit https://review.coreboot.org/c/coreboot/+/25660 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib802d7ee32f1fb0a68a84b0280480dcaefa9831f Gerrit-Change-Number: 25660 Gerrit-PatchSet: 6 Gerrit-Owner: Dan Elkouby <streetwalkermc(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Dan Elkouby <streetwalkermc(a)gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Tue, 07 May 2019 07:20:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2019