coreboot-gerrit April 2019

coreboot-gerrit@coreboot.org

1 participants
1219 discussions

Change in ...coreboot[master]: soc/intel/common/block/cpu: Use core apic id to get cpu_index()
by Subrata Banik (Code Review) 30 Apr '19

30 Apr '19

Hello Aaron Durbin, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/26346 to look at the new patch set (#8). Change subject: soc/intel/common/block/cpu: Use core apic id to get cpu_index() ...................................................................... soc/intel/common/block/cpu: Use core apic id to get cpu_index() This cpu_index() implementation assumes that cpu_index() function might always getting called from coreboot context (ESP stack pointer will always refer to coreboot). This might not true incase of proposed PI spec MP_SERVICES_PPI implementation, where FSP context (stack pointer refers to fsp) will request to get cpu_index(), natural alignment logic will use ESP and retrieve struct cpu_info *ci from (stack_top - 8 byte). This is not the place where cpu_index is actually stored by ramstage c_start.S Hence this patch tries to remove those dependencies while retriving cpu_index(), rather it uses cpuid to fetch lapic id and matches with cpu_mp structure to get correct cpu_index() BRANCH=none BUG=b:79562868 TEST=Ensures functions can be run on APs without any failure and cpu_index() also provides correct index number. Change-Id: I55023a3e0cf42f0496d45bc6af8ead447f402350 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/arch/x86/cpu.c M src/arch/x86/include/arch/cpu.h M src/soc/intel/common/block/cpu/cpulib.c 3 files changed, 24 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/26346/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/26346 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55023a3e0cf42f0496d45bc6af8ead447f402350 Gerrit-Change-Number: 26346 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: soc/intel/common/block/cpu: Use core apic id to get cpu_index()
by Subrata Banik (Code Review) 30 Apr '19

30 Apr '19

Subrata Banik has restored this change. ( https://review.coreboot.org/c/coreboot/+/26346 ) Change subject: soc/intel/common/block/cpu: Use core apic id to get cpu_index() ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/26346 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55023a3e0cf42f0496d45bc6af8ead447f402350 Gerrit-Change-Number: 26346 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: restore

1 0

Change in ...coreboot[master]: soc/intel/icelake: Correct the GPE DWx mapping for GPIO groups
by Subrata Banik (Code Review) 30 Apr '19

30 Apr '19

Hello Patrick Rudolph, Aamir Bohra, Maulik V Vaghela, Rizwan Qureshi, Duncan Laurie, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32508 to look at the new patch set (#2). Change subject: soc/intel/icelake: Correct the GPE DWx mapping for GPIO groups ...................................................................... soc/intel/icelake: Correct the GPE DWx mapping for GPIO groups This implementation corrects the GPE DWx mapping for GPIO groups. The assignments is done in GPIO MISCFG register for all GPIO communities. And configures the which GPIO communities get register as Tier1. Change-Id: I9c306d46e5194944def26c24cdb95f5ebada42b8 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/icelake/include/soc/gpio_soc_defs.h 1 file changed, 12 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/32508/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/32508 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c306d46e5194944def26c24cdb95f5ebada42b8 Gerrit-Change-Number: 32508 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: soc/intel/icelake: Select FSP_M_XIP
by Subrata Banik (Code Review) 30 Apr '19

30 Apr '19

Hello Patrick Rudolph, Aamir Bohra, Maulik V Vaghela, Rizwan Qureshi, Duncan Laurie, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32507 to look at the new patch set (#2). Change subject: soc/intel/icelake: Select FSP_M_XIP ...................................................................... soc/intel/icelake: Select FSP_M_XIP This patch ports CB:32275 changes from CNL to ICL. Ice Lake and family require that FSP-M component should be XIP. This change selects FSP_M_XIP so that the right arguments are passed into cbfstool when adding this component. Change-Id: Icc5550f1f94957fa1b28c8bba6fc0efee98e233e Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/icelake/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/32507/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/32507 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc5550f1f94957fa1b28c8bba6fc0efee98e233e Gerrit-Change-Number: 32507 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: soc/intel/icelake: Correct the GPE DWx mapping for GPIO groups
by Subrata Banik (Code Review) 30 Apr '19

30 Apr '19

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32508 ) Change subject: soc/intel/icelake: Correct the GPE DWx mapping for GPIO groups ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/32508/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/32508/1//COMMIT_MSG@9 PS1, Line 9: This patch ports CB:32175 changes from CNL to ICL. > mapping for CNL is very different than ICL, isn't it? agree, i have removed this line in PS2 -- To view, visit https://review.coreboot.org/c/coreboot/+/32508 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c306d46e5194944def26c24cdb95f5ebada42b8 Gerrit-Change-Number: 32508 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 30 Apr 2019 03:20:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/icelake: Select FSP_M_XIP
by Subrata Banik (Code Review) 30 Apr '19

30 Apr '19

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32507 ) Change subject: soc/intel/icelake: Select FSP_M_XIP ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/32507/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/32507/1//COMMIT_MSG@11 PS1, Line 11: Cannon > It would be good to update the message to indicate the requirement for ICL Done -- To view, visit https://review.coreboot.org/c/coreboot/+/32507 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc5550f1f94957fa1b28c8bba6fc0efee98e233e Gerrit-Change-Number: 32507 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 30 Apr 2019 03:19:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: sdm845: Add interface between CB & QCLib
by Julius Werner (Code Review) 30 Apr '19

30 Apr '19

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27360 ) Change subject: sdm845: Add interface between CB & QCLib ...................................................................... Patch Set 35: > After looking at how the whole codebase uses CONFIG_CBFS_PREFIX, this request would make sdm845 code different. In fact to fit in with the codebase, the #define for the name, e.g. pmic or aop should be removed... Yes, having the string inline is certainly acceptable as long as it's only used once in the code (which should be the case for all here). Feel free to do that if you want, but defining a named constant for it isn't "wrong" either. (But if we do have a constant, I think the CBFS prefix should be part of it.) -- To view, visit https://review.coreboot.org/c/coreboot/+/27360 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d86f360d9e5f1a50f052ab99e821a587e091946 Gerrit-Change-Number: 27360 Gerrit-PatchSet: 35 Gerrit-Owner: T.Michael Turney <tturne(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: T.Michael Turney <tturne(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-Comment-Date: Tue, 30 Apr 2019 00:49:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...libgfxinit[master]: gma config: Make Config.CPU and Config.CPU_Var variable
by Nico Huber (Code Review) 30 Apr '19

30 Apr '19

1 0

Change in ...libgfxinit[master]: gma config: Make Config.CPU and Config.CPU_Var variable
by Nico Huber (Code Review) 30 Apr '19

30 Apr '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/27068 ) Change subject: gma config: Make Config.CPU and Config.CPU_Var variable ...................................................................... Patch Set 7: (1 comment) https://review.coreboot.org/#/c/27068/6/common/hw-gfx-gma-config.ads.templa… File common/hw-gfx-gma-config.ads.template: https://review.coreboot.org/#/c/27068/6/common/hw-gfx-gma-config.ads.templa… PS6, Line 69: , > It's an ugly trick, really: Ada doesn't allow a dangling comma […] or patch set 7... but that moves the readability issue to the makefile ;) -- To view, visit https://review.coreboot.org/c/libgfxinit/+/27068 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: If409b5afbd975f3a42e28ff191a092f89ece5ae2 Gerrit-Change-Number: 27068 Gerrit-PatchSet: 7 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 29 Apr 2019 22:35:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in ...libgfxinit[master]: gma config: Make Config.CPU and Config.CPU_Var variable
by Nico Huber (Code Review) 30 Apr '19

30 Apr '19

Hello Arthur Heymans, Paul Menzel, Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/libgfxinit/+/27068 to look at the new patch set (#7). Change subject: gma config: Make Config.CPU and Config.CPU_Var variable ...................................................................... gma config: Make Config.CPU and Config.CPU_Var variable Introduce CONFIG_GFX_GMA_DYN_CPU that, if set to `y`, makes `Config.CPU` and `Config.CPU_Var` variables. All other config values derived from these are turned into expression functions. Change-Id: If409b5afbd975f3a42e28ff191a092f89ece5ae2 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/Makefile.inc M common/hw-gfx-gma-config.ads.template M common/hw-gfx-gma-registers.adb M common/hw-gfx-gma-registers.ads M common/hw-gfx-gma.adb M common/hw-gfx-gma.ads 6 files changed, 86 insertions(+), 19 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/68/27068/7 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/27068 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: If409b5afbd975f3a42e28ff191a092f89ece5ae2 Gerrit-Change-Number: 27068 Gerrit-PatchSet: 7 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2019