Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29563 )
Change subject: security/tpm: Fix TCPA log feature
......................................................................
Patch Set 66: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/29563
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic93133531b84318f48940d34bded48cbae739c44
Gerrit-Change-Number: 29563
Gerrit-PatchSet: 66
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph
Gerrit-Comment-Date: Thu, 07 Mar 2019 11:44:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30414 )
Change subject: mainboard/facebook/fbg1701: Do initial mainboard commit
......................................................................
Patch Set 17:
(2 comments)
https://review.coreboot.org/#/c/30414/17/src/mainboard/facebook/fbg1701/irq…
File src/mainboard/facebook/fbg1701/irqroute.h:
https://review.coreboot.org/#/c/30414/17/src/mainboard/facebook/fbg1701/irq…
PS17, Line 40: #define PCI_DEV_PIRQ_ROUTES \
Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/30414/17/src/mainboard/facebook/fbg1701/irq…
PS17, Line 62: #define PIRQ_PIC_ROUTES \
Macros with complex values should be enclosed in parentheses
--
To view, visit https://review.coreboot.org/c/coreboot/+/30414
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28ac78a630ee705b1e546031f024bfe7f952ab39
Gerrit-Change-Number: 30414
Gerrit-PatchSet: 17
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 07 Mar 2019 09:43:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Patrick Rudolph, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30414
to look at the new patch set (#17).
Change subject: mainboard/facebook/fbg1701: Do initial mainboard commit
......................................................................
mainboard/facebook/fbg1701: Do initial mainboard commit
Create Facebook FBG-1701 coreboot implementation
coreboot implementation is prepared for Bootblock, measured boot
and verified boot support. These features are default disabled.
This Braswell implementation is based on Intel Strago.
BUG=N/A
TEST=Facebook FBG-1701 booting Embedded Linux
Change-Id: I28ac78a630ee705b1e546031f024bfe7f952ab39
Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com>
---
A Documentation/mainboard/facebook/fbg1701.md
M Documentation/mainboard/index.md
A src/mainboard/facebook/fbg1701/Kconfig
A src/mainboard/facebook/fbg1701/Kconfig.name
A src/mainboard/facebook/fbg1701/Makefile.inc
A src/mainboard/facebook/fbg1701/acpi/dptf.asl
A src/mainboard/facebook/fbg1701/acpi/ec.asl
A src/mainboard/facebook/fbg1701/acpi/mainboard.asl
A src/mainboard/facebook/fbg1701/acpi/sleepstates.asl
A src/mainboard/facebook/fbg1701/acpi/superio.asl
A src/mainboard/facebook/fbg1701/acpi_tables.c
A src/mainboard/facebook/fbg1701/board_info.txt
A src/mainboard/facebook/fbg1701/board_mboot.c
A src/mainboard/facebook/fbg1701/board_verified_boot.c
A src/mainboard/facebook/fbg1701/board_verified_boot.h
A src/mainboard/facebook/fbg1701/bootblock.c
A src/mainboard/facebook/fbg1701/cmos.layout
A src/mainboard/facebook/fbg1701/com_init.c
A src/mainboard/facebook/fbg1701/devicetree.cb
A src/mainboard/facebook/fbg1701/dsdt.asl
A src/mainboard/facebook/fbg1701/fadt.c
A src/mainboard/facebook/fbg1701/fmap.fmd
A src/mainboard/facebook/fbg1701/gpio.c
A src/mainboard/facebook/fbg1701/hda_verb.c
A src/mainboard/facebook/fbg1701/irqroute.c
A src/mainboard/facebook/fbg1701/irqroute.h
A src/mainboard/facebook/fbg1701/logo.c
A src/mainboard/facebook/fbg1701/mainboard.c
A src/mainboard/facebook/fbg1701/mainboard.h
A src/mainboard/facebook/fbg1701/manifest.h
A src/mainboard/facebook/fbg1701/onboard.h
A src/mainboard/facebook/fbg1701/ramstage.c
A src/mainboard/facebook/fbg1701/romstage.c
A src/mainboard/facebook/fbg1701/smihandler.c
A src/mainboard/facebook/fbg1701/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex
35 files changed, 2,342 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/30414/17
--
To view, visit https://review.coreboot.org/c/coreboot/+/30414
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28ac78a630ee705b1e546031f024bfe7f952ab39
Gerrit-Change-Number: 30414
Gerrit-PatchSet: 17
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset