Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31736 )
Change subject: soc/amd/stoneyridge: Convert SMU fanless options
......................................................................
Patch Set 4:
> I can't say I'm crazy about the way you're using the subprogram here, but i don't have a better idea.
I rassled with the concept for a while. Unfortunately, it's a little deeper than may be obvious. From what I can tell, different PSP implementations interpret the subprogram differently, depending on what family/model they are. As a result, I left the decision making with the soc/makefile instead of trying to put it inside the tool.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31736
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaae4094251974b8dad48b8d2c37bb2e43a412237
Gerrit-Change-Number: 31736
Gerrit-PatchSet: 4
Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 07 Mar 2019 04:36:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31735 )
Change subject: util/amdfwtool: Split type field for PSP entries
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/31735
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If8f33000c31cba21f286f54459de185c21e46268
Gerrit-Change-Number: 31735
Gerrit-PatchSet: 4
Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 06 Mar 2019 23:35:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31735 )
Change subject: util/amdfwtool: Split type field for PSP entries
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31735/4/util/amdfwtool/amdfwtool.c
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/#/c/31735/4/util/amdfwtool/amdfwtool.c@571
PS4, Line 571: sub = 0; /* subprogram is N/A but clear anyway */
> I don't understand why you're updating sub in any of them other than 'S'. […]
Ok, I get it now.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31735
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If8f33000c31cba21f286f54459de185c21e46268
Gerrit-Change-Number: 31735
Gerrit-PatchSet: 4
Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Wed, 06 Mar 2019 23:34:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <martinroth(a)google.com>
Gerrit-MessageType: comment
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31736 )
Change subject: soc/amd/stoneyridge: Convert SMU fanless options
......................................................................
Patch Set 4:
I can't say I'm crazy about the way you're using the subprogram here, but i don't have a better idea.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31736
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaae4094251974b8dad48b8d2c37bb2e43a412237
Gerrit-Change-Number: 31736
Gerrit-PatchSet: 4
Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 06 Mar 2019 23:33:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31735 )
Change subject: util/amdfwtool: Split type field for PSP entries
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31735/4/util/amdfwtool/amdfwtool.c
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/#/c/31735/4/util/amdfwtool/amdfwtool.c@571
PS4, Line 571: sub = 0; /* subprogram is N/A but clear anyway */
I don't understand why you're updating sub in any of them other than 'S'. That seems unexpected behavior to me.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31735
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If8f33000c31cba21f286f54459de185c21e46268
Gerrit-Change-Number: 31735
Gerrit-PatchSet: 4
Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Wed, 06 Mar 2019 23:29:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29398 )
Change subject: src/soc/intel/braswell/southcluster.c: Correct serial IRQ support
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/29398/6/src/soc/intel/braswell/southcluster…
File src/soc/intel/braswell/southcluster.c:
https://review.coreboot.org/#/c/29398/6/src/soc/intel/braswell/southcluster…
PS6, Line 621:
> SERIRQ in continuous mode, interrupts from serial appear on all cores through IOAPIC irq4
I'm not seeing anything under /proc/interrupts for IRQ4, just 0/8/9 (timer, rtc0, acpi) for both stock and upstream firmware
--
To view, visit https://review.coreboot.org/c/coreboot/+/29398
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7844cad69dc0563fa6109d779d0afb7c2edd7245
Gerrit-Change-Number: 29398
Gerrit-PatchSet: 6
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Wed, 06 Mar 2019 23:18:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-MessageType: comment