coreboot-gerrit February 2019

coreboot-gerrit@coreboot.org

1 participants
1249 discussions

Change in ...coreboot[master]: ec/google/chromeec: fix the error status passing
by Daisuke Nojiri (Code Review) 26 Feb '19

26 Feb '19

Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31585 ) Change subject: ec/google/chromeec: fix the error status passing ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/31585 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f0a8a61d01d942cba57036a17dd527fdbbf940c Gerrit-Change-Number: 31585 Gerrit-PatchSet: 7 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Feb 2019 18:05:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: ec/google/chromeec: fix the error status passing
by YH Lin (Code Review) 26 Feb '19

26 Feb '19

YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31585 ) Change subject: ec/google/chromeec: fix the error status passing ...................................................................... Patch Set 7: As discussed, restore to patchset 1 to fix flapjack issue. I will upload another CL for the purpose of patchset 6. Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/31585 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f0a8a61d01d942cba57036a17dd527fdbbf940c Gerrit-Change-Number: 31585 Gerrit-PatchSet: 7 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Feb 2019 18:00:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: ec/google/chromeec: fix the error status passing
by YH Lin (Code Review) 26 Feb '19

26 Feb '19

Hello Aaron Durbin, Julius Werner, Daisuke Nojiri, Paul Menzel, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/31585 to look at the new patch set (#7). Change subject: ec/google/chromeec: fix the error status passing ...................................................................... ec/google/chromeec: fix the error status passing Various instances of google_chromeec_command() can return non-zero number (both positive and negative) to indicate error -- fixing cbi_get_uint32() and cbi_get_string() so they follow the same convention. BUG=b:123676982 BRANCH=kukui TEST=build with kukui/flapjack configurations Signed-off-by: YH Lin <yueherngl(a)google.com> Change-Id: I7f0a8a61d01d942cba57036a17dd527fdbbf940c --- M src/ec/google/chromeec/ec.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/31585/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/31585 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f0a8a61d01d942cba57036a17dd527fdbbf940c Gerrit-Change-Number: 31585 Gerrit-PatchSet: 7 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: src/mb/gigabyte/ga-h61m-s2pv: fix random things
by Nico Huber (Code Review) 26 Feb '19

26 Feb '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31558 ) Change subject: src/mb/gigabyte/ga-h61m-s2pv: fix random things ...................................................................... Patch Set 3: Code-Review+2 (2 comments) https://review.coreboot.org/#/c/31558/3//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/31558/3//COMMIT_MSG@7 PS3, Line 7: src/ Please drop src/ prefix. https://review.coreboot.org/#/c/31558/3//COMMIT_MSG@7 PS3, Line 7: src/mb/gigabyte/ga-h61m-s2pv: fix random things Doesn't look like you are "fixing" anything. Well, maybe "Fix cosmetic things". Or just "Clean up a litte". -- To view, visit https://review.coreboot.org/c/coreboot/+/31558 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice0eff7b9829816aff4d334f4ac4a2fb435a2fb0 Gerrit-Change-Number: 31558 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 26 Feb 2019 17:57:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: ACPI: Fill asl_compiler_revision field left empty
by HAOUAS Elyes (Code Review) 26 Feb '19

26 Feb '19

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31607 Change subject: ACPI: Fill asl_compiler_revision field left empty ...................................................................... ACPI: Fill asl_compiler_revision field left empty Change-Id: I1075e872e5cb1990bd330b88bb03322ab9338e86 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/x86/acpi.c 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/31607/1 diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c index f4c7d86..f8c0b48 100644 --- a/src/arch/x86/acpi.c +++ b/src/arch/x86/acpi.c @@ -217,6 +217,7 @@ memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); + header->asl_compiler_revision = asl_revision; header->length = sizeof(acpi_madt_t); header->revision = get_acpi_table_revision(MADT); @@ -245,6 +246,7 @@ memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); + header->asl_compiler_revision = asl_revision; header->length = sizeof(acpi_mcfg_t); header->revision = get_acpi_table_revision(MCFG); @@ -298,6 +300,7 @@ memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); + header->asl_compiler_revision = asl_revision; header->length = sizeof(acpi_tcpa_t); header->revision = get_acpi_table_revision(TCPA); @@ -356,6 +359,7 @@ memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); + header->asl_compiler_revision = asl_revision; header->length = sizeof(acpi_tpm2_t); header->revision = get_acpi_table_revision(TPM2); @@ -475,6 +479,7 @@ memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); + header->asl_compiler_revision = asl_revision; header->length = sizeof(acpi_srat_t); header->revision = get_acpi_table_revision(SRAT); @@ -501,6 +506,7 @@ memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); + header->asl_compiler_revision = asl_revision; header->length = sizeof(acpi_dmar_t); header->revision = get_acpi_table_revision(DMAR); @@ -634,6 +640,7 @@ memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); + header->asl_compiler_revision = asl_revision; header->length = sizeof(acpi_slit_t); header->revision = get_acpi_table_revision(SLIT); @@ -658,6 +665,7 @@ memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); + header->asl_compiler_revision = asl_revision; header->length = sizeof(acpi_hpet_t); header->revision = get_acpi_table_revision(HPET); @@ -691,6 +699,7 @@ memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); + header->asl_compiler_revision = asl_revision; header->length = sizeof(struct acpi_vfct); header->revision = get_acpi_table_revision(VFCT); @@ -716,6 +725,7 @@ memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); + header->asl_compiler_revision = asl_revision; header->length = sizeof(acpi_ivrs_t); header->revision = get_acpi_table_revision(IVRS); @@ -767,6 +777,7 @@ memcpy(header->oem_id, OEM_ID, 6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); + header->asl_compiler_revision = asl_revision; /* One debug device defined */ dbg2->devices_offset = sizeof(acpi_dbg2_header_t); @@ -886,6 +897,7 @@ memcpy(header->oem_table_id, oem_table_id, 8); memcpy(header->asl_compiler_id, ASLC, 4); + ->asl_compiler_revision = asl_revision; header->length = sizeof(acpi_rsdt_t); header->revision = get_acpi_table_revision(RSDT); @@ -905,6 +917,7 @@ memcpy(header->oem_table_id, oem_table_id, 8); memcpy(header->asl_compiler_id, ASLC, 4); + header->asl_compiler_revision = asl_revision; header->length = sizeof(acpi_xsdt_t); header->revision = get_acpi_table_revision(XSDT); @@ -1015,6 +1028,7 @@ memcpy(header->oem_id, OEM_ID, 6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); + header->asl_compiler_revision = asl_revision; header->length += sizeof(acpi_hest_t); header->revision = get_acpi_table_revision(HEST); @@ -1035,6 +1049,7 @@ memcpy(header->oem_id, OEM_ID, 6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); + header->asl_compiler_revision = asl_revision; header->length += sizeof(acpi_bert_t); header->revision = get_acpi_table_revision(BERT); -- To view, visit https://review.coreboot.org/c/coreboot/+/31607 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1075e872e5cb1990bd330b88bb03322ab9338e86 Gerrit-Change-Number: 31607 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

3 5

Change in ...coreboot[master]: flapjack: use sku_id 0 for un-provisioned board
by YH Lin (Code Review) 26 Feb '19

26 Feb '19

YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31623 ) Change subject: flapjack: use sku_id 0 for un-provisioned board ...................................................................... Patch Set 1: As discussed, change sku_id to 0 for un-provisioned boards. -- To view, visit https://review.coreboot.org/c/coreboot/+/31623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I66f29f8a46cd774b40354def7d3623ec44cb96ce Gerrit-Change-Number: 31623 Gerrit-PatchSet: 1 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Comment-Date: Tue, 26 Feb 2019 17:38:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: flapjack: get sku_id from ec (cbi)
by Daisuke Nojiri (Code Review) 26 Feb '19

26 Feb '19

Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31586 ) Change subject: flapjack: get sku_id from ec (cbi) ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/#/c/31586/4/src/mainboard/google/kukui/boardid.c File src/mainboard/google/kukui/boardid.c: https://review.coreboot.org/#/c/31586/4/src/mainboard/google/kukui/boardid.… PS4, Line 22: 2 We discussed this further and decided to use 0 to indicate unprovisioned boards or corrupted CBI. Old boards with old firmware still return 2 but we won't deal with this combination. -- To view, visit https://review.coreboot.org/c/coreboot/+/31586 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad7a52df38e2045abbdded8ba0a1f1544de961fc Gerrit-Change-Number: 31586 Gerrit-PatchSet: 4 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Nick Sanders <nsanders(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: You-Cheng Syu <youcheng(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 26 Feb 2019 17:22:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: ec/google/chromeec: fix the error status handling
by Paul Menzel (Code Review) 26 Feb '19

26 Feb '19

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31585 ) Change subject: ec/google/chromeec: fix the error status handling ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/#/c/31585/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/31585/1//COMMIT_MSG@8 PS1, Line 8: : google_chromeec_command() can return non-zero number (both positive : and negative) to indicate error. > Paul, we'll go with patchset 1 to fix the issue for flapjack. Patchset 1 and https://review. […] Sounds good to me. -- To view, visit https://review.coreboot.org/c/coreboot/+/31585 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f0a8a61d01d942cba57036a17dd527fdbbf940c Gerrit-Change-Number: 31585 Gerrit-PatchSet: 6 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Feb 2019 17:22:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Daisuke Nojiri <dnojiri(a)chromium.org> Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Comment-In-Reply-To: YH Lin <yueherngl(a)google.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: ec/google/chromeec: fix the error status handling
by Daisuke Nojiri (Code Review) 26 Feb '19

26 Feb '19

Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31585 ) Change subject: ec/google/chromeec: fix the error status handling ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/#/c/31585/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/31585/1//COMMIT_MSG@8 PS1, Line 8: : google_chromeec_command() can return non-zero number (both positive : and negative) to indicate error. > I suggest we define/discuss the return values at https://bugs.chromium. […] Paul, we'll go with patchset 1 to fix the issue for flapjack. Patchset 1 and https://review.coreboot.org/c/coreboot/+/31613 should make all consistent. YH will create a separate CL for Patchset 6, which further changes the definition of the API by additionally accepting negative integers as error code. What do you think? -- To view, visit https://review.coreboot.org/c/coreboot/+/31585 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f0a8a61d01d942cba57036a17dd527fdbbf940c Gerrit-Change-Number: 31585 Gerrit-PatchSet: 6 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Feb 2019 17:00:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Daisuke Nojiri <dnojiri(a)chromium.org> Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Comment-In-Reply-To: YH Lin <yueherngl(a)google.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: ec/google/chromeec: fix the error status handling
by YH Lin (Code Review) 26 Feb '19

26 Feb '19

YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31585 ) Change subject: ec/google/chromeec: fix the error status handling ...................................................................... Patch Set 6: Re-based. -- To view, visit https://review.coreboot.org/c/coreboot/+/31585 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f0a8a61d01d942cba57036a17dd527fdbbf940c Gerrit-Change-Number: 31585 Gerrit-PatchSet: 6 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Feb 2019 16:10:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2019