coreboot-gerrit February 2019

coreboot-gerrit@coreboot.org

1 participants
1249 discussions

Change in ...coreboot[master]: cpu/x86/pae/pgtbl: Add memset with PAE
by build bot (Jenkins) (Code Review) 27 Feb '19

27 Feb '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31549 ) Change subject: cpu/x86/pae/pgtbl: Add memset with PAE ...................................................................... Patch Set 4: (8 comments) https://review.coreboot.org/#/c/31549/4/src/include/cpu/x86/pae.h File src/include/cpu/x86/pae.h: https://review.coreboot.org/#/c/31549/4/src/include/cpu/x86/pae.h@60 PS4, Line 60: uint32_t addr_lo; code indent should use tabs where possible https://review.coreboot.org/#/c/31549/4/src/include/cpu/x86/pae.h@60 PS4, Line 60: uint32_t addr_lo; please, no spaces at the start of a line https://review.coreboot.org/#/c/31549/4/src/include/cpu/x86/pae.h@61 PS4, Line 61: uint32_t addr_hi; code indent should use tabs where possible https://review.coreboot.org/#/c/31549/4/src/include/cpu/x86/pae.h@61 PS4, Line 61: uint32_t addr_hi; please, no spaces at the start of a line https://review.coreboot.org/#/c/31549/4/src/include/cpu/x86/pae.h@64 PS4, Line 64: struct pde pd[2048]; code indent should use tabs where possible https://review.coreboot.org/#/c/31549/4/src/include/cpu/x86/pae.h@64 PS4, Line 64: struct pde pd[2048]; please, no spaces at the start of a line https://review.coreboot.org/#/c/31549/4/src/include/cpu/x86/pae.h@65 PS4, Line 65: struct pde pdp[512]; code indent should use tabs where possible https://review.coreboot.org/#/c/31549/4/src/include/cpu/x86/pae.h@65 PS4, Line 65: struct pde pdp[512]; please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/31549 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00f7ecf87b5c9227a9d58a0b61eecc38007e1a57 Gerrit-Change-Number: 31549 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jens Drenhaus <jens.drenhaus(a)9elements.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Roy Wen <rgzwen(a)arista.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 27 Feb 2019 08:16:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: arch/x86: Introduce helper to clear memory using PAE
by Patrick Rudolph (Code Review) 27 Feb '19

27 Feb '19

Hello Roy Wen, David Hendricks, Philipp Deppenwiese, build bot (Jenkins), Patrick Georgi, Martin Roth, Jens Drenhaus, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/31550 to look at the new patch set (#4). Change subject: arch/x86: Introduce helper to clear memory using PAE ...................................................................... arch/x86: Introduce helper to clear memory using PAE * Add Documentation. * Add x86 helper function to clear DRAM on a typical x86 memory map Change-Id: Idaadb8fb438e5b95557c0f65a14534e8762fde20 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M Documentation/arch/x86/index.md M src/arch/x86/Makefile.inc A src/arch/x86/include/arch/memory_clear.h A src/arch/x86/memory_clear.c 4 files changed, 162 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/31550/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/31550 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idaadb8fb438e5b95557c0f65a14534e8762fde20 Gerrit-Change-Number: 31550 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jens Drenhaus <jens.drenhaus(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Roy Wen <rgzwen(a)arista.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: SMBIOS: Add missing eos[2] at end of struct smbios_type38
by HAOUAS Elyes (Code Review) 27 Feb '19

27 Feb '19

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31625 Change subject: SMBIOS: Add missing eos[2] at end of struct smbios_type38 ...................................................................... SMBIOS: Add missing eos[2] at end of struct smbios_type38 Change-Id: Ic714bf15e2ebf0ab489a7bb1a7d9eb08b4e6b5e2 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/include/smbios.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/31625/1 diff --git a/src/include/smbios.h b/src/include/smbios.h index 38ebcdc..c046b1a 100644 --- a/src/include/smbios.h +++ b/src/include/smbios.h @@ -493,6 +493,7 @@ u64 base_address; u8 base_address_modifier; u8 irq; + u8 eos[2]; } __packed; enum smbios_bmc_interface_type { -- To view, visit https://review.coreboot.org/c/coreboot/+/31625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic714bf15e2ebf0ab489a7bb1a7d9eb08b4e6b5e2 Gerrit-Change-Number: 31625 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

2 3

Change in ...coreboot[master]: flapjack: use sku_id 0 for un-provisioned board
by Daisuke Nojiri (Code Review) 27 Feb '19

27 Feb '19

Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31623 ) Change subject: flapjack: use sku_id 0 for un-provisioned board ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/31623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I66f29f8a46cd774b40354def7d3623ec44cb96ce Gerrit-Change-Number: 31623 Gerrit-PatchSet: 4 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Feb 2019 22:52:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: flapjack: use sku_id 0 for un-provisioned board
by YH Lin (Code Review) 27 Feb '19

27 Feb '19

Hello Daisuke Nojiri, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/31623 to look at the new patch set (#4). Change subject: flapjack: use sku_id 0 for un-provisioned board ...................................................................... flapjack: use sku_id 0 for un-provisioned board Instead of using 2, 0 is now used for non-CBI provisioned board or corrupted CBI board to confrom to the sku encoding. BUG=b:123676982 BRANCH=kukui TEST=test with un-provisioned board to verify the sku_id. Signed-off-by: YH Lin <yueherngl(a)google.com> Change-Id: I66f29f8a46cd774b40354def7d3623ec44cb96ce --- M src/mainboard/google/kukui/boardid.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/31623/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/31623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I66f29f8a46cd774b40354def7d3623ec44cb96ce Gerrit-Change-Number: 31623 Gerrit-PatchSet: 4 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: flapjack: use sku_id 0 for un-provisioned board
by YH Lin (Code Review) 27 Feb '19

27 Feb '19

YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31623 ) Change subject: flapjack: use sku_id 0 for un-provisioned board ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/31623/2/src/mainboard/google/kukui/boardid.c File src/mainboard/google/kukui/boardid.c: https://review.coreboot.org/#/c/31623/2/src/mainboard/google/kukui/boardid.… PS2, Line 22: For all un-provisioned Flapjack boards > "and corrupted CBI" Updated. Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/31623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I66f29f8a46cd774b40354def7d3623ec44cb96ce Gerrit-Change-Number: 31623 Gerrit-PatchSet: 3 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Feb 2019 22:45:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: flapjack: use sku_id 0 for un-provisioned board
by build bot (Jenkins) (Code Review) 27 Feb '19

27 Feb '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31623 ) Change subject: flapjack: use sku_id 0 for un-provisioned board ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/31623/3/src/mainboard/google/kukui/boardid.c File src/mainboard/google/kukui/boardid.c: https://review.coreboot.org/#/c/31623/3/src/mainboard/google/kukui/boardid.… PS3, Line 22: #define FLAPJACK_UNDEF_SKU_ID 0 /* For CBI un-provisioned or corrupted Flapjack boards */ line over 80 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/31623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I66f29f8a46cd774b40354def7d3623ec44cb96ce Gerrit-Change-Number: 31623 Gerrit-PatchSet: 3 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Feb 2019 22:45:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: flapjack: use sku_id 0 for un-provisioned board
by YH Lin (Code Review) 27 Feb '19

27 Feb '19

Hello Daisuke Nojiri, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/31623 to look at the new patch set (#3). Change subject: flapjack: use sku_id 0 for un-provisioned board ...................................................................... flapjack: use sku_id 0 for un-provisioned board Instead of using 2, 0 is now used for non-CBI provisioned board or corrupted CBI board to confrom to the sku encoding. BUG=b:123676982 BRANCH=kukui TEST=test with un-provisioned board to verify the sku_id. Signed-off-by: YH Lin <yueherngl(a)google.com> Change-Id: I66f29f8a46cd774b40354def7d3623ec44cb96ce --- M src/mainboard/google/kukui/boardid.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/31623/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/31623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I66f29f8a46cd774b40354def7d3623ec44cb96ce Gerrit-Change-Number: 31623 Gerrit-PatchSet: 3 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: flapjack: use sku_id 0 for un-provisioned board
by Daisuke Nojiri (Code Review) 27 Feb '19

27 Feb '19

Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31623 ) Change subject: flapjack: use sku_id 0 for un-provisioned board ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/31623/2/src/mainboard/google/kukui/boardid.c File src/mainboard/google/kukui/boardid.c: https://review.coreboot.org/#/c/31623/2/src/mainboard/google/kukui/boardid.… PS2, Line 22: For all un-provisioned Flapjack boards "and corrupted CBI" -- To view, visit https://review.coreboot.org/c/coreboot/+/31623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I66f29f8a46cd774b40354def7d3623ec44cb96ce Gerrit-Change-Number: 31623 Gerrit-PatchSet: 2 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Feb 2019 22:40:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: ACPI: Fix error on asl_compiler_revision format
by HAOUAS Elyes (Code Review) 27 Feb '19

27 Feb '19

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31612 Change subject: ACPI: Fix error on asl_compiler_revision format ...................................................................... ACPI: Fix error on asl_compiler_revision format dmesg report wrong asl compiler version as this value wasn't in hexadecimal: FACP 0x00000000CFB5D6C0 0000F4 (v04 COREv4 COREBOOT 00000000 CORE 01341407) DSDT 0x00000000CFB5B280 002436 (v02 COREv4 COREBOOT 20190112 INTL 20190215) This error was introduced on change-Id: I91b54b43c8b Tested on 945G-M4 board, dmesg now report the right value: FACP 0x00000000CFB5D6C0 0000F4 (v04 COREv4 COREBOOT 00000000 CORE 20190215) DSDT 0x00000000CFB5B280 002436 (v02 COREv4 COREBOOT 20190112 INTL 20190215) Change-Id: I5494bb1e7af17eba0c2da8a0c2eb9e40ffd8d065 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M util/genbuild_h/genbuild_h.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/31612/1 diff --git a/util/genbuild_h/genbuild_h.sh b/util/genbuild_h/genbuild_h.sh index 3c02b56..340de35 100755 --- a/util/genbuild_h/genbuild_h.sh +++ b/util/genbuild_h/genbuild_h.sh @@ -67,5 +67,5 @@ printf "#define COREBOOT_DMI_DATE \"$(our_date "$DATE" +%m/%d/%Y)\"\n" printf "\n" printf "#define COREBOOT_COMPILE_TIME \"$(our_date "$DATE" +%T)\"\n" -printf "#define ASL_VERSION %d\n" `./util/crossgcc/xgcc/bin/iasl -v | grep version | sed 's/.*version //'` +printf "#define ASL_VERSION 0x%d\n" `./util/crossgcc/xgcc/bin/iasl -v | grep version | sed 's/.*version //'` printf "#endif\n" -- To view, visit https://review.coreboot.org/c/coreboot/+/31612 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5494bb1e7af17eba0c2da8a0c2eb9e40ffd8d065 Gerrit-Change-Number: 31612 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

4 4

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2019