Bill XIE has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34977 )
Change subject: security/vboot: Boot to Recovery Mode if no RW slot present
......................................................................
security/vboot: Boot to Recovery Mode if no RW slot present
Currently, even if there is no RW slot present, vboot will still try
to find one to boot, result in an infinite boot loop.
This change explicitly allows a coreboot build with vboot but without
RW slot to make use of vboot only for measured boot, by performing
"Recovery mode" boot, with stages and payloads in the RO slot.
Change-Id: Ica98afd6aeb5328515df0c11e974cc9b3e8cdde1
Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org>
---
M src/security/vboot/vboot_logic.c
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/34977/1
diff --git a/src/security/vboot/vboot_logic.c b/src/security/vboot/vboot_logic.c
index 7f00df5..48fd6db 100644
--- a/src/security/vboot/vboot_logic.c
+++ b/src/security/vboot/vboot_logic.c
@@ -347,7 +347,9 @@
"Initializing measured boot mode failed!");
}
- if (get_recovery_mode_switch()) {
+ /* Boot to Recovery Mode if no RW slot present */
+ if (!CONFIG(VBOOT_SLOTS_RW_A) ||
+ get_recovery_mode_switch()) {
ctx.flags |= VB2_CONTEXT_FORCE_RECOVERY_MODE;
if (CONFIG(VBOOT_DISABLE_DEV_ON_RECOVERY))
ctx.flags |= VB2_CONTEXT_DISABLE_DEVELOPER_MODE;
--
To view, visit https://review.coreboot.org/c/coreboot/+/34977
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica98afd6aeb5328515df0c11e974cc9b3e8cdde1
Gerrit-Change-Number: 34977
Gerrit-PatchSet: 1
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-MessageType: newchange
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36370 )
Change subject: drivers/intel/fsp1_1: Drop unused function
......................................................................
drivers/intel/fsp1_1: Drop unused function
Change-Id: Ide336fb900360c446bffcc5ca31bf51e7746cae1
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/drivers/intel/fsp1_1/fsp_util.c
M src/drivers/intel/fsp1_1/include/fsp/util.h
2 files changed, 0 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/36370/1
diff --git a/src/drivers/intel/fsp1_1/fsp_util.c b/src/drivers/intel/fsp1_1/fsp_util.c
index 2889f3f..f2c8a4d 100644
--- a/src/drivers/intel/fsp1_1/fsp_util.c
+++ b/src/drivers/intel/fsp1_1/fsp_util.c
@@ -280,10 +280,3 @@
}
}
}
-
-__attribute__((cdecl)) size_t fsp_write_line(uint8_t *buffer,
- size_t number_of_bytes)
-{
- console_write_line(buffer, number_of_bytes);
- return number_of_bytes;
-}
diff --git a/src/drivers/intel/fsp1_1/include/fsp/util.h b/src/drivers/intel/fsp1_1/include/fsp/util.h
index dca6d56..73b156f 100644
--- a/src/drivers/intel/fsp1_1/include/fsp/util.h
+++ b/src/drivers/intel/fsp1_1/include/fsp/util.h
@@ -96,15 +96,6 @@
void *get_next_guid_hob(const EFI_GUID *guid, const void *hob_start);
void *get_first_guid_hob(const EFI_GUID *guid);
-/*
- * Writes number_of_bytes data bytes from buffer to the console.
- * The number of bytes actually written to the console is returned.
- *
- * If number_of_bytes is zero, don't output any data but instead wait until
- * the console has output all data, then return 0.
- */
-__attribute__((cdecl)) size_t fsp_write_line(uint8_t *buffer,
- size_t number_of_bytes);
asmlinkage void chipset_teardown_car_main(void);
--
To view, visit https://review.coreboot.org/c/coreboot/+/36370
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide336fb900360c446bffcc5ca31bf51e7746cae1
Gerrit-Change-Number: 36370
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newchange
Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36301 )
Change subject: Doc/mb/gigabyte/ga-h61m-s2pv: Correct IFD section
......................................................................
Doc/mb/gigabyte/ga-h61m-s2pv: Correct IFD section
Change-Id: Ic94dd7381e9a107081011d083286d27005148557
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M Documentation/mainboard/gigabyte/ga-h61m-s2pv.md
1 file changed, 7 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/36301/1
diff --git a/Documentation/mainboard/gigabyte/ga-h61m-s2pv.md b/Documentation/mainboard/gigabyte/ga-h61m-s2pv.md
index 06c0ff7..501f38d 100644
--- a/Documentation/mainboard/gigabyte/ga-h61m-s2pv.md
+++ b/Documentation/mainboard/gigabyte/ga-h61m-s2pv.md
@@ -39,27 +39,22 @@
The original IFD defines the BIOS region as the whole flash chip. While this is
not an issue if flashing a complete image, it confuses flashrom and trashes the
-flash chip's contents when using the --ifd option. However, this can be easily
-fixed by reading the IFD with flashrom, editing the correct values into it with
-ifdtool and then reflashing it.
-
-Create a layout.txt with the following contents:
+flash chip's contents when using the `--ifd` option. A possible workaround is
+to create a `layout.txt` file with a non-overlapping BIOS region:
00000000:00000fff fd
00180000:003fffff bios
00001000:0017ffff me
-After that, simply run:
+After that, use flashrom with the new layout file. For example, to backup the
+BIOS region and then flash a `coreboot.rom` to it, do:
```bash
-sudo flashrom -p internal --ifd -i fd -r ifd.rom
-ifdtool -n layout.txt ifd.rom
-sudo flashrom -p internal --ifd -i fd -w ifd.rom.new
+sudo flashrom -p internal -l layout.txt -i bios -r backup.rom
+sudo flashrom -p internal -l layout.txt -i bios -w coreboot.rom
```
-After flashing, power cycle the computer to ensure the new IFD is being used.
-If only a reboot is done, the old IFD layout is still seen by flashrom, even if
-the IFD on the flash chip is correctly defining the new region layout.
+Modifying the
## Technology
--
To view, visit https://review.coreboot.org/c/coreboot/+/36301
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic94dd7381e9a107081011d083286d27005148557
Gerrit-Change-Number: 36301
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newchange
Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35102 )
Change subject: [WIP] AGESA, binaryPI: Remove generic device for SPD eeproms
......................................................................
[WIP] AGESA, binaryPI: Remove generic device for SPD eeproms
Change-Id: Ieab695022d0dd2f2671f9058db97bdd6fb29a10d
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
---
M src/mainboard/amd/bettong/devicetree.cb
M src/mainboard/amd/gardenia/devicetree.cb
M src/mainboard/amd/inagua/devicetree.cb
M src/mainboard/amd/lamar/devicetree.cb
M src/mainboard/amd/olivehill/devicetree.cb
M src/mainboard/amd/olivehillplus/devicetree.cb
M src/mainboard/amd/parmer/devicetree.cb
M src/mainboard/amd/persimmon/devicetree.cb
M src/mainboard/amd/thatcher/devicetree.cb
M src/mainboard/amd/torpedo/devicetree.cb
M src/mainboard/asrock/e350m1/devicetree.cb
M src/mainboard/asrock/imb-a180/devicetree.cb
M src/mainboard/asus/am1i-a/devicetree.cb
M src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb
M src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb
M src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb
M src/mainboard/biostar/am1ml/devicetree.cb
M src/mainboard/elmex/pcm205400/devicetree.cb
M src/mainboard/hp/abm/devicetree.cb
M src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb
M src/mainboard/jetway/nf81-t56n-lf/devicetree.cb
M src/mainboard/lenovo/g505s/devicetree.cb
M src/mainboard/lippert/frontrunner-af/devicetree.cb
M src/mainboard/lippert/toucan-af/devicetree.cb
M src/mainboard/msi/ms7721/devicetree.cb
25 files changed, 0 insertions(+), 156 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/35102/1
diff --git a/src/mainboard/amd/bettong/devicetree.cb b/src/mainboard/amd/bettong/devicetree.cb
index 84aaf41..e318b6d 100644
--- a/src/mainboard/amd/bettong/devicetree.cb
+++ b/src/mainboard/amd/bettong/devicetree.cb
@@ -43,12 +43,6 @@
device pci 11.0 on end # SATA
device pci 12.0 on end # USB
device pci 14.0 on # SM
- chip drivers/generic/generic #dimm 0-0-0
- device i2c 50 on end
- end
- chip drivers/generic/generic #dimm 0-0-1
- device i2c 51 on end
- end
end # SM
#device pci 14.2 on end # HDA 0x4383
device pci 14.3 on end # LPC 0x439d
diff --git a/src/mainboard/amd/gardenia/devicetree.cb b/src/mainboard/amd/gardenia/devicetree.cb
index e9946ad..beee845 100644
--- a/src/mainboard/amd/gardenia/devicetree.cb
+++ b/src/mainboard/amd/gardenia/devicetree.cb
@@ -41,9 +41,6 @@
device pci 11.0 on end # SATA
device pci 12.0 on end # EHCI
device pci 14.0 on # SM
- chip drivers/generic/generic # dimm 0-0-0
- device i2c 51 on end
- end
end # SM
device pci 14.3 on end # LPC 0x790e
device pci 14.7 on end # SD
diff --git a/src/mainboard/amd/inagua/devicetree.cb b/src/mainboard/amd/inagua/devicetree.cb
index 578c654..cc28124 100644
--- a/src/mainboard/amd/inagua/devicetree.cb
+++ b/src/mainboard/amd/inagua/devicetree.cb
@@ -38,12 +38,6 @@
device pci 13.0 on end # OHCI USB 5-9
device pci 13.2 on end # EHCI USB 5-9
device pci 14.0 on # SM
- chip drivers/generic/generic #dimm 0-0-0
- device i2c 50 on end
- end
- chip drivers/generic/generic #dimm 0-0-1
- device i2c 51 on end
- end
end # SM
device pci 14.1 on end # IDE 0x439c
device pci 14.2 on end # HDA 0x4383
diff --git a/src/mainboard/amd/lamar/devicetree.cb b/src/mainboard/amd/lamar/devicetree.cb
index d7f3f05..e57a6c6 100644
--- a/src/mainboard/amd/lamar/devicetree.cb
+++ b/src/mainboard/amd/lamar/devicetree.cb
@@ -54,18 +54,6 @@
device pci 13.0 on end # 0x7807 USB OHCI
device pci 13.2 on end # 0x7808 USB EHCI
device pci 14.0 on # 0x780B SMBus
- chip drivers/generic/generic #dimm 0-0-0
- device i2c 50 on end
- end
- chip drivers/generic/generic #dimm 0-0-1
- device i2c 51 on end
- end
- chip drivers/generic/generic #dimm 0-1-0
- device i2c 52 on end
- end
- chip drivers/generic/generic #dimm 0-1-1
- device i2c 53 on end
- end
end # SM
device pci 14.1 on end # 0x780C IDE
device pci 14.2 on end # 0x780D HDA
diff --git a/src/mainboard/amd/olivehill/devicetree.cb b/src/mainboard/amd/olivehill/devicetree.cb
index bf8d476..a7933ce 100644
--- a/src/mainboard/amd/olivehill/devicetree.cb
+++ b/src/mainboard/amd/olivehill/devicetree.cb
@@ -41,12 +41,6 @@
device pci 13.0 on end # USB
device pci 13.2 on end # USB
device pci 14.0 on # SM
- chip drivers/generic/generic #dimm 0-0-0
- device i2c 50 on end
- end
- chip drivers/generic/generic #dimm 0-0-1
- device i2c 51 on end
- end
end # SM
device pci 14.2 on end # HDA 0x4383
device pci 14.3 on end # LPC 0x439d
diff --git a/src/mainboard/amd/olivehillplus/devicetree.cb b/src/mainboard/amd/olivehillplus/devicetree.cb
index 430b17b..4b47642d 100644
--- a/src/mainboard/amd/olivehillplus/devicetree.cb
+++ b/src/mainboard/amd/olivehillplus/devicetree.cb
@@ -42,12 +42,6 @@
device pci 12.0 on end # EHCI #0
device pci 13.0 on end # EHCI #1
device pci 14.0 on # SMBus
- chip drivers/generic/generic #dimm 0-0-0
- device i2c 50 on end
- end
- chip drivers/generic/generic #dimm 0-0-1
- device i2c 51 on end
- end
end # SMbus
device pci 14.2 on end # HDA 0x4383
device pci 14.3 on end # LPC 0x439d
diff --git a/src/mainboard/amd/parmer/devicetree.cb b/src/mainboard/amd/parmer/devicetree.cb
index e619def..7e0fc2c 100644
--- a/src/mainboard/amd/parmer/devicetree.cb
+++ b/src/mainboard/amd/parmer/devicetree.cb
@@ -44,12 +44,6 @@
device pci 13.0 on end # USB
device pci 13.2 on end # USB
device pci 14.0 on # SMBUS
- chip drivers/generic/generic #dimm 0
- device i2c 50 on end # 7-bit SPD address
- end
- chip drivers/generic/generic #dimm 1
- device i2c 51 on end # 7-bit SPD address
- end
end # SM
device pci 14.1 on end # IDE 0x439c
device pci 14.2 on end # HDA 0x4383
diff --git a/src/mainboard/amd/persimmon/devicetree.cb b/src/mainboard/amd/persimmon/devicetree.cb
index 323e7f2..40ea282 100644
--- a/src/mainboard/amd/persimmon/devicetree.cb
+++ b/src/mainboard/amd/persimmon/devicetree.cb
@@ -37,12 +37,6 @@
device pci 13.0 on end # OHCI USB 5-9
device pci 13.2 on end # EHCI USB 5-9
device pci 14.0 on # SM
- chip drivers/generic/generic #dimm 0-0-0
- device i2c 50 on end
- end
- chip drivers/generic/generic #dimm 0-0-1
- device i2c 51 on end
- end
end # SM
device pci 14.1 on end # IDE 0x439c
device pci 14.2 on end # HDA 0x4383
diff --git a/src/mainboard/amd/thatcher/devicetree.cb b/src/mainboard/amd/thatcher/devicetree.cb
index 4ae1ba9..a55fa25 100644
--- a/src/mainboard/amd/thatcher/devicetree.cb
+++ b/src/mainboard/amd/thatcher/devicetree.cb
@@ -44,12 +44,6 @@
device pci 13.0 on end # USB
device pci 13.2 on end # USB
device pci 14.0 on # SMBUS
- chip drivers/generic/generic #dimm 0
- device i2c 50 on end # 7-bit SPD address
- end
- chip drivers/generic/generic #dimm 1
- device i2c 51 on end # 7-bit SPD address
- end
end # SM
device pci 14.1 on end # IDE 0x439c
device pci 14.2 on end # HDA 0x4383
diff --git a/src/mainboard/amd/torpedo/devicetree.cb b/src/mainboard/amd/torpedo/devicetree.cb
index 2adfb27..00923ea 100644
--- a/src/mainboard/amd/torpedo/devicetree.cb
+++ b/src/mainboard/amd/torpedo/devicetree.cb
@@ -42,12 +42,6 @@
device pci 13.0 on end # USB
device pci 13.2 on end # USB
device pci 14.0 on # SM
- chip drivers/generic/generic #dimm 0-0-0
- device i2c 50 on end
- end
- chip drivers/generic/generic #dimm 0-0-1
- device i2c 51 on end
- end
end # SM
device pci 14.1 on end # IDE
device pci 14.2 on end # HDA
diff --git a/src/mainboard/asrock/e350m1/devicetree.cb b/src/mainboard/asrock/e350m1/devicetree.cb
index e374c41..5d368fa 100644
--- a/src/mainboard/asrock/e350m1/devicetree.cb
+++ b/src/mainboard/asrock/e350m1/devicetree.cb
@@ -39,12 +39,6 @@
device pci 13.0 on end # USB
device pci 13.2 on end # USB
device pci 14.0 on # SM
- chip drivers/generic/generic #dimm 0-0-0
- device i2c 50 on end
- end
- chip drivers/generic/generic #dimm 0-0-1
- device i2c 51 on end
- end
end # SM
device pci 14.1 on end # IDE 0x439c
device pci 14.2 on end # HDA 0x4383
diff --git a/src/mainboard/asrock/imb-a180/devicetree.cb b/src/mainboard/asrock/imb-a180/devicetree.cb
index 2c4a4aa..3ade19b 100644
--- a/src/mainboard/asrock/imb-a180/devicetree.cb
+++ b/src/mainboard/asrock/imb-a180/devicetree.cb
@@ -42,12 +42,6 @@
device pci 13.0 on end # USB
device pci 13.2 on end # USB
device pci 14.0 on # SM
- chip drivers/generic/generic #dimm 0-0-0
- device i2c 50 on end
- end
- chip drivers/generic/generic #dimm 0-0-1
- device i2c 51 on end
- end
end # SM
device pci 14.2 on end # HDA 0x4383
device pci 14.3 on
diff --git a/src/mainboard/asus/am1i-a/devicetree.cb b/src/mainboard/asus/am1i-a/devicetree.cb
index 53114c1..763761a 100644
--- a/src/mainboard/asus/am1i-a/devicetree.cb
+++ b/src/mainboard/asus/am1i-a/devicetree.cb
@@ -43,12 +43,6 @@
device pci 13.0 on end # USB
device pci 13.2 on end # USB
device pci 14.0 on # SM
- chip drivers/generic/generic #dimm 0-0-0
- device i2c 50 on end
- end
- chip drivers/generic/generic #dimm 0-0-1
- device i2c 51 on end
- end
end # SM
device pci 14.2 on end # HDA 0x4383
device pci 14.3 on # LPC 0x439d
diff --git a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb
index 349a845..c95fe84 100644
--- a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb
+++ b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb
@@ -47,12 +47,6 @@
device pci 13.0 on end # USB
device pci 13.2 on end # USB
device pci 14.0 on # SMBUS
- chip drivers/generic/generic #dimm 0
- device i2c 50 on end # 7-bit SPD address
- end
- chip drivers/generic/generic #dimm 1
- device i2c 51 on end # 7-bit SPD address
- end
end # SM
device pci 14.1 off end # IDE 0x439c
device pci 14.2 on end # HDA 0x4383
diff --git a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb
index af0e4cc..3e39ef3 100644
--- a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb
+++ b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb
@@ -47,12 +47,6 @@
device pci 13.0 on end # USB
device pci 13.2 on end # USB
device pci 14.0 on # SMBUS
- chip drivers/generic/generic #dimm 0
- device i2c 50 on end # 7-bit SPD address
- end
- chip drivers/generic/generic #dimm 1
- device i2c 51 on end # 7-bit SPD address
- end
end # SM
device pci 14.1 off end # IDE 0x439c
device pci 14.2 on end # HDA 0x4383
diff --git a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb
index 238ab51..e261505 100644
--- a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb
+++ b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb
@@ -38,18 +38,6 @@
device pci 13.0 on end # USB
device pci 13.2 on end # USB
device pci 14.0 on # SMBUS
- chip drivers/generic/generic #dimm 0
- device i2c 50 on end # 7-bit SPD address
- end
- chip drivers/generic/generic #dimm 1
- device i2c 52 on end # 7-bit SPD address
- end
- chip drivers/generic/generic #dimm 2
- device i2c 51 on end # 7-bit SPD address
- end
- chip drivers/generic/generic #dimm 3
- device i2c 53 on end # 7-bit SPD address
- end
end # SM
device pci 14.1 off end # unused
device pci 14.2 on end # HDA 0x4383
diff --git a/src/mainboard/biostar/am1ml/devicetree.cb b/src/mainboard/biostar/am1ml/devicetree.cb
index 400653d..e6adc0a 100644
--- a/src/mainboard/biostar/am1ml/devicetree.cb
+++ b/src/mainboard/biostar/am1ml/devicetree.cb
@@ -42,12 +42,6 @@
device pci 13.0 on end # USB
device pci 13.2 on end # USB
device pci 14.0 on # SM
- chip drivers/generic/generic #dimm 0-0-0
- device i2c 50 on end
- end
- chip drivers/generic/generic #dimm 0-0-1
- device i2c 51 on end
- end
end # SM
device pci 14.1 on end # there is no legacy ide
device pci 14.2 on end # HDA 0x4383
diff --git a/src/mainboard/elmex/pcm205400/devicetree.cb b/src/mainboard/elmex/pcm205400/devicetree.cb
index 405f3e0..d11529b 100644
--- a/src/mainboard/elmex/pcm205400/devicetree.cb
+++ b/src/mainboard/elmex/pcm205400/devicetree.cb
@@ -37,12 +37,6 @@
device pci 13.0 on end # OHCI USB 5-9
device pci 13.2 on end # EHCI USB 5-9
device pci 14.0 on # SM
- chip drivers/generic/generic #dimm 0-0-0
- device i2c 50 on end
- end
- chip drivers/generic/generic #dimm 0-0-1
- device i2c 51 on end
- end
end # SM
device pci 14.1 on end # IDE 0x439c
device pci 14.2 off end # HDA 0x4383
diff --git a/src/mainboard/hp/abm/devicetree.cb b/src/mainboard/hp/abm/devicetree.cb
index c7a7510..2786f78 100644
--- a/src/mainboard/hp/abm/devicetree.cb
+++ b/src/mainboard/hp/abm/devicetree.cb
@@ -41,9 +41,6 @@
device pci 13.0 on end # USB
device pci 13.2 on end # USB
device pci 14.0 on # SM
- chip drivers/generic/generic #dimm 0-0-0
- device i2c 50 on end
- end
end # SM
device pci 14.2 off end # HDA 0x4383
device pci 14.3 on # LPC 0x439d
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb b/src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb
index ad59974..35ccca7 100644
--- a/src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb
+++ b/src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb
@@ -41,12 +41,6 @@
device pci 13.0 on end # USB
device pci 13.2 on end # USB
device pci 14.0 on # SMBUS
- chip drivers/generic/generic #dimm 0
- device i2c 50 on end # 7-bit SPD address
- end
- chip drivers/generic/generic #dimm 1
- device i2c 51 on end # 7-bit SPD address
- end
end # SM
device pci 14.2 on end # HDA 0x4383
device pci 14.3 on # LPC 0x439d
diff --git a/src/mainboard/jetway/nf81-t56n-lf/devicetree.cb b/src/mainboard/jetway/nf81-t56n-lf/devicetree.cb
index 6289438..faed1c5 100644
--- a/src/mainboard/jetway/nf81-t56n-lf/devicetree.cb
+++ b/src/mainboard/jetway/nf81-t56n-lf/devicetree.cb
@@ -38,12 +38,6 @@
device pci 13.0 on end # OHCI USB 5-9
device pci 13.2 on end # EHCI USB 5-9
device pci 14.0 on # SM
- chip drivers/generic/generic #dimm 0-0-0
- device i2c 50 on end
- end
- chip drivers/generic/generic #dimm 0-0-1
- device i2c 51 on end
- end
end # SM
device pci 14.1 off end # IDE 0x439c
device pci 14.2 on end # HDA 0x4383
diff --git a/src/mainboard/lenovo/g505s/devicetree.cb b/src/mainboard/lenovo/g505s/devicetree.cb
index 99f42d6..5be9111 100644
--- a/src/mainboard/lenovo/g505s/devicetree.cb
+++ b/src/mainboard/lenovo/g505s/devicetree.cb
@@ -45,12 +45,6 @@
device pci 13.0 on end # FCH USB OHCI Controller
device pci 13.2 on end # FCH USB EHCI Controller
device pci 14.0 on # SMBUS
- chip drivers/generic/generic #dimm 0
- device i2c 50 on end # 7-bit SPD address
- end
- chip drivers/generic/generic #dimm 1
- device i2c 51 on end # 7-bit SPD address
- end
end # SM
device pci 14.2 on end # FCH Azalia Controller
device pci 14.3 on # FCH LPC Bridge [1022:780e]
diff --git a/src/mainboard/lippert/frontrunner-af/devicetree.cb b/src/mainboard/lippert/frontrunner-af/devicetree.cb
index b72059a..5e84fcb 100644
--- a/src/mainboard/lippert/frontrunner-af/devicetree.cb
+++ b/src/mainboard/lippert/frontrunner-af/devicetree.cb
@@ -37,12 +37,6 @@
device pci 13.0 on end # OHCI USB 5-9
device pci 13.2 on end # EHCI USB 5-9
device pci 14.0 on # SM
- chip drivers/generic/generic #dimm 0-0-0
- device i2c 50 on end
- end
- chip drivers/generic/generic #dimm 0-0-1
- device i2c 51 off end
- end
end # SM
device pci 14.1 off end # IDE 0x439c
device pci 14.2 on end # HDA 0x4383
diff --git a/src/mainboard/lippert/toucan-af/devicetree.cb b/src/mainboard/lippert/toucan-af/devicetree.cb
index cb9aa8e..25d84db 100644
--- a/src/mainboard/lippert/toucan-af/devicetree.cb
+++ b/src/mainboard/lippert/toucan-af/devicetree.cb
@@ -38,12 +38,6 @@
device pci 13.0 on end # OHCI USB 5-9
device pci 13.2 on end # EHCI USB 5-9
device pci 14.0 on # SM
- chip drivers/generic/generic #dimm 0-0-0
- device i2c 50 on end
- end
- chip drivers/generic/generic #dimm 0-0-1
- device i2c 51 off end
- end
end # SM
device pci 14.1 off end # IDE 0x439c
device pci 14.2 on end # HDA 0x4383
diff --git a/src/mainboard/msi/ms7721/devicetree.cb b/src/mainboard/msi/ms7721/devicetree.cb
index d3991f1..1c73404 100644
--- a/src/mainboard/msi/ms7721/devicetree.cb
+++ b/src/mainboard/msi/ms7721/devicetree.cb
@@ -46,12 +46,6 @@
device pci 13.0 on end # USB OHCI
device pci 13.2 on end # USB EHCI
device pci 14.0 on # SMBUS
- chip drivers/generic/generic #dimm 0
- device i2c 50 on end # 7-bit SPD address
- end
- chip drivers/generic/generic #dimm 1
- device i2c 51 on end # 7-bit SPD address
- end
end # SM
device pci 14.1 off end # IDE 0x439c
device pci 14.2 on end # Azalia (Audio)
--
To view, visit https://review.coreboot.org/c/coreboot/+/35102
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieab695022d0dd2f2671f9058db97bdd6fb29a10d
Gerrit-Change-Number: 35102
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newchange