Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36301 )
Change subject: Doc/mb/gigabyte/ga-h61m-s2pv: Correct IFD section ......................................................................
Doc/mb/gigabyte/ga-h61m-s2pv: Correct IFD section
Change-Id: Ic94dd7381e9a107081011d083286d27005148557 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M Documentation/mainboard/gigabyte/ga-h61m-s2pv.md 1 file changed, 7 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/36301/1
diff --git a/Documentation/mainboard/gigabyte/ga-h61m-s2pv.md b/Documentation/mainboard/gigabyte/ga-h61m-s2pv.md index 06c0ff7..501f38d 100644 --- a/Documentation/mainboard/gigabyte/ga-h61m-s2pv.md +++ b/Documentation/mainboard/gigabyte/ga-h61m-s2pv.md @@ -39,27 +39,22 @@
The original IFD defines the BIOS region as the whole flash chip. While this is not an issue if flashing a complete image, it confuses flashrom and trashes the -flash chip's contents when using the --ifd option. However, this can be easily -fixed by reading the IFD with flashrom, editing the correct values into it with -ifdtool and then reflashing it. - -Create a layout.txt with the following contents: +flash chip's contents when using the `--ifd` option. A possible workaround is +to create a `layout.txt` file with a non-overlapping BIOS region:
00000000:00000fff fd 00180000:003fffff bios 00001000:0017ffff me
-After that, simply run: +After that, use flashrom with the new layout file. For example, to backup the +BIOS region and then flash a `coreboot.rom` to it, do:
```bash -sudo flashrom -p internal --ifd -i fd -r ifd.rom -ifdtool -n layout.txt ifd.rom -sudo flashrom -p internal --ifd -i fd -w ifd.rom.new +sudo flashrom -p internal -l layout.txt -i bios -r backup.rom +sudo flashrom -p internal -l layout.txt -i bios -w coreboot.rom ```
-After flashing, power cycle the computer to ensure the new IFD is being used. -If only a reboot is done, the old IFD layout is still seen by flashrom, even if -the IFD on the flash chip is correctly defining the new region layout. +Modifying the
## Technology
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36301 )
Change subject: Doc/mb/gigabyte/ga-h61m-s2pv: Correct IFD section ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36301/1/Documentation/mainboard/gig... File Documentation/mainboard/gigabyte/ga-h61m-s2pv.md:
https://review.coreboot.org/c/coreboot/+/36301/1/Documentation/mainboard/gig... PS1, Line 57: Modifying the This looks like you wanted to write something here?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36301 )
Change subject: Doc/mb/gigabyte/ga-h61m-s2pv: Correct IFD section ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36301/1/Documentation/mainboard/gig... File Documentation/mainboard/gigabyte/ga-h61m-s2pv.md:
https://review.coreboot.org/c/coreboot/+/36301/1/Documentation/mainboard/gig... PS1, Line 57: Modifying the
This looks like you wanted to write something here?
Um, yes. I think I wrote something, but I don't know where it went. Meh, I'll rewrite it.
Hello Arthur Heymans, Patrick Rudolph, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36301
to look at the new patch set (#2).
Change subject: Doc/mb/gigabyte/ga-h61m-s2pv: Correct IFD section ......................................................................
Doc/mb/gigabyte/ga-h61m-s2pv: Correct IFD section
Change-Id: Ic94dd7381e9a107081011d083286d27005148557 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M Documentation/mainboard/gigabyte/ga-h61m-s2pv.md 1 file changed, 8 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/36301/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36301 )
Change subject: Doc/mb/gigabyte/ga-h61m-s2pv: Correct IFD section ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36301/2/Documentation/mainboard/gig... File Documentation/mainboard/gigabyte/ga-h61m-s2pv.md:
https://review.coreboot.org/c/coreboot/+/36301/2/Documentation/mainboard/gig... PS2, Line 49: backup back up
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36301 )
Change subject: Doc/mb/gigabyte/ga-h61m-s2pv: Correct IFD section ......................................................................
Patch Set 2: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36301 )
Change subject: Doc/mb/gigabyte/ga-h61m-s2pv: Correct IFD section ......................................................................
Patch Set 2: Code-Review+2
Hello Arthur Heymans, Patrick Rudolph, Christian Walter, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36301
to look at the new patch set (#3).
Change subject: Doc/mb/gigabyte/ga-h61m-s2pv: Correct IFD section ......................................................................
Doc/mb/gigabyte/ga-h61m-s2pv: Correct IFD section
Change-Id: Ic94dd7381e9a107081011d083286d27005148557 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M Documentation/mainboard/gigabyte/ga-h61m-s2pv.md 1 file changed, 8 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/36301/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36301 )
Change subject: Doc/mb/gigabyte/ga-h61m-s2pv: Correct IFD section ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36301/2/Documentation/mainboard/gig... File Documentation/mainboard/gigabyte/ga-h61m-s2pv.md:
https://review.coreboot.org/c/coreboot/+/36301/2/Documentation/mainboard/gig... PS2, Line 49: backup
back up
Done
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36301 )
Change subject: Doc/mb/gigabyte/ga-h61m-s2pv: Correct IFD section ......................................................................
Patch Set 3: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36301 )
Change subject: Doc/mb/gigabyte/ga-h61m-s2pv: Correct IFD section ......................................................................
Patch Set 3: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36301 )
Change subject: Doc/mb/gigabyte/ga-h61m-s2pv: Correct IFD section ......................................................................
Doc/mb/gigabyte/ga-h61m-s2pv: Correct IFD section
Change-Id: Ic94dd7381e9a107081011d083286d27005148557 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36301 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Nico Huber nico.h@gmx.de --- M Documentation/mainboard/gigabyte/ga-h61m-s2pv.md 1 file changed, 8 insertions(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved
diff --git a/Documentation/mainboard/gigabyte/ga-h61m-s2pv.md b/Documentation/mainboard/gigabyte/ga-h61m-s2pv.md index 06c0ff7..84b72ce 100644 --- a/Documentation/mainboard/gigabyte/ga-h61m-s2pv.md +++ b/Documentation/mainboard/gigabyte/ga-h61m-s2pv.md @@ -39,27 +39,23 @@
The original IFD defines the BIOS region as the whole flash chip. While this is not an issue if flashing a complete image, it confuses flashrom and trashes the -flash chip's contents when using the --ifd option. However, this can be easily -fixed by reading the IFD with flashrom, editing the correct values into it with -ifdtool and then reflashing it. - -Create a layout.txt with the following contents: +flash chip's contents when using the `--ifd` option. A possible workaround is +to create a `layout.txt` file with a non-overlapping BIOS region:
00000000:00000fff fd 00180000:003fffff bios 00001000:0017ffff me
-After that, simply run: +After that, use flashrom with the new layout file. For example, to create a +backup of the BIOS region and then flash a `coreboot.rom`, do:
```bash -sudo flashrom -p internal --ifd -i fd -r ifd.rom -ifdtool -n layout.txt ifd.rom -sudo flashrom -p internal --ifd -i fd -w ifd.rom.new +sudo flashrom -p internal -l layout.txt -i bios -r backup.rom +sudo flashrom -p internal -l layout.txt -i bios -w coreboot.rom ```
-After flashing, power cycle the computer to ensure the new IFD is being used. -If only a reboot is done, the old IFD layout is still seen by flashrom, even if -the IFD on the flash chip is correctly defining the new region layout. +Modifying the IFD so that the BIOS region does not overlap would work as well. +However, this makes DualBIOS unable to recover from a bad flash for some reason.
## Technology
-
Angel Pons (Code Review) -
Christian Walter (Code Review)
-
HAOUAS Elyes (Code Review)
-
Nico Huber (Code Review)
-
Paul Menzel (Code Review)