Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35711 )
Change subject: gma: Give GM45 its own designation (separate from G45)
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/libgfxinit/+/35711/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/libgfxinit/+/35711/3//COMMIT_MSG@8
PS3, Line 8:
> Could you add the motivation, why this is useful?
See this change's topic on gerrit: cdclk
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/35711
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: I99bbd0582a03a9e2806ef2ebf63e466ec40133b3
Gerrit-Change-Number: 35711
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Fri, 04 Oct 2019 11:49:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: comment
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35711 )
Change subject: gma: Give GM45 its own designation (separate from G45)
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/libgfxinit/+/35711/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/libgfxinit/+/35711/3//COMMIT_MSG@8
PS3, Line 8:
Could you add the motivation, why this is useful?
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/35711
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: I99bbd0582a03a9e2806ef2ebf63e466ec40133b3
Gerrit-Change-Number: 35711
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Fri, 04 Oct 2019 11:43:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35789
to look at the new patch set (#3).
Change subject: mb/google/hatch: Add option to enable WiFi SAR configs
......................................................................
mb/google/hatch: Add option to enable WiFi SAR configs
Add "wifi_sar_defaults.hex" for helios Wifi SAR support
BUG=b:138917233
Signed-off-by: YenLu Chen <kane_chen(a)pegatron.corp-partner.google.com>
Change-Id: I2bb36dc2a68a3835d7126406c3403b2c0510202d
---
A src/mainboard/google/hatch/wifi_sar_defaults.hex
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/35789/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/35789
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bb36dc2a68a3835d7126406c3403b2c0510202d
Gerrit-Change-Number: 35789
Gerrit-PatchSet: 3
Gerrit-Owner: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Hello Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35789
to look at the new patch set (#2).
Change subject: mb/google/hatch: Add option to enable WiFi SAR configs
......................................................................
mb/google/hatch: Add option to enable WiFi SAR configs
Add "wifi_sar_defaults.hex" for helios to Wifi SAR support
BUG=b:138917233
Signed-off-by: YenLu Chen <kane_chen(a)pegatron.corp-partner.google.com>
Change-Id: I2bb36dc2a68a3835d7126406c3403b2c0510202d
---
A src/mainboard/google/hatch/wifi_sar_defaults.hex
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/35789/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/35789
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bb36dc2a68a3835d7126406c3403b2c0510202d
Gerrit-Change-Number: 35789
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35789 )
Change subject: mb/google/hatch: Add option to enable WiFi SAR configs
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/35789
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bb36dc2a68a3835d7126406c3403b2c0510202d
Gerrit-Change-Number: 35789
Gerrit-PatchSet: 1
Gerrit-Owner: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 04 Oct 2019 10:46:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35794 )
Change subject: mb/google/hatch/variants/helios: Modify DPTF parameters
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/35794
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e5c079856a167b1c2ef52e446d055404e565858
Gerrit-Change-Number: 35794
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 04 Oct 2019 10:45:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35711 )
Change subject: gma: Give GM45 its own designation (separate from G45)
......................................................................
Patch Set 3:
> Patch Set 3:
>
> > Patch Set 3: Code-Review+2
> >
> > My main concern with this change is that G45 and GM45 are dangerously similar names.
> >
> > Maybe use Eaglelake and Cantiga instead?
>
> I'd keep the same names as Linux.
Ack
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/35711
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: I99bbd0582a03a9e2806ef2ebf63e466ec40133b3
Gerrit-Change-Number: 35711
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Fri, 04 Oct 2019 10:29:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35403 )
Change subject: soc/intel/common/basecode: Implement CSE update flow
......................................................................
Patch Set 14:
(3 comments)
Documentation is still missing.
https://review.coreboot.org/c/coreboot/+/35403/14/src/soc/intel/common/base…
File src/soc/intel/common/basecode/fw_update/cse_update.c:
https://review.coreboot.org/c/coreboot/+/35403/14/src/soc/intel/common/base…
PS14, Line 33: #define CBFS_SI_ME "SI_ME"
should be defined in a common header, discussable if that should be in commonlib
same for the following defines
https://review.coreboot.org/c/coreboot/+/35403/14/src/soc/intel/common/base…
PS14, Line 85: printk(BIOS_DEBUG, "Failed to get start/end offset of partition:%d\n",
add prefix to all printk messages
https://review.coreboot.org/c/coreboot/+/35403/14/src/soc/intel/common/base…
File src/soc/intel/common/basecode/include/intelbasecode/cse_update.h:
https://review.coreboot.org/c/coreboot/+/35403/14/src/soc/intel/common/base…
PS14, Line 17: #ifndef SOC_INTEL_COMMONBASE_UCODE_UPD_H
seems to be copied from somewhere
--
To view, visit https://review.coreboot.org/c/coreboot/+/35403
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12f6bba3324069d65edabaccd234006b0840e700
Gerrit-Change-Number: 35403
Gerrit-PatchSet: 14
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Andrey Petrov <anpetrov(a)fb.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Fri, 04 Oct 2019 08:19:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35711 )
Change subject: gma: Give GM45 its own designation (separate from G45)
......................................................................
Patch Set 3:
> Patch Set 3: Code-Review+2
>
> My main concern with this change is that G45 and GM45 are dangerously similar names.
>
> Maybe use Eaglelake and Cantiga instead?
I'd keep the same names as Linux.
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/35711
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: I99bbd0582a03a9e2806ef2ebf63e466ec40133b3
Gerrit-Change-Number: 35711
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Fri, 04 Oct 2019 07:36:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment