coreboot-gerrit October 2019

coreboot-gerrit@coreboot.org

1 participants
1921 discussions

Change in coreboot[master]: soc/amd/picasso: Add cpuid for older device
by Marshall Dawson (Code Review) 17 Oct '19

17 Oct '19

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/35273 to look at the new patch set (#3). Change subject: soc/amd/picasso: Add cpuid for older device ...................................................................... soc/amd/picasso: Add cpuid for older device Make the driver work with stepping=0. Change-Id: Id0961369b9cc9cfe1b0c09ebc50e6966ccd2e919 Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/soc/amd/picasso/cpu.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/35273/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/35273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0961369b9cc9cfe1b0c09ebc50e6966ccd2e919 Gerrit-Change-Number: 35273 Gerrit-PatchSet: 3 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: _WIP_ src/amd/picasso: Update PCI bridge devices
by Marshall Dawson (Code Review) 17 Oct '19

17 Oct '19

Hello Richard Spiegel, build bot (Jenkins), Martin Roth, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34425 to look at the new patch set (#13). Change subject: _WIP_ src/amd/picasso: Update PCI bridge devices ...................................................................... _WIP_ src/amd/picasso: Update PCI bridge devices TODO: deal with Bus A & Bus B devices differently that Bus 0. Change-Id: I1fa9d52ce113eacdc5c9ba31ab46b6428a7d6ca9 Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/soc/amd/picasso/include/soc/pci_devs.h 1 file changed, 56 insertions(+), 52 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/34425/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/34425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1fa9d52ce113eacdc5c9ba31ab46b6428a7d6ca9 Gerrit-Change-Number: 34425 Gerrit-PatchSet: 13 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/picasso: Update southbridge
by Marshall Dawson (Code Review) 17 Oct '19

17 Oct '19

Hello Richard Spiegel, build bot (Jenkins), Martin Roth, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/33770 to look at the new patch set (#15). Change subject: soc/amd/picasso: Update southbridge ...................................................................... soc/amd/picasso: Update southbridge Picasso's FCH has many similarities to Stoney Ridge, so few changes are necessary. The most notable changes are: * Update the index values for the C00/C01 interrupt routing * FORCE_STPCLK_RETRY is not present * PCIB is not defined * FCH MISC Registers 0xfed80e00 numbering has changed * C-state base moves from PM register to MSR * Add option to determine the intended MUX settion for LPC vs. eMMC * Remove the LEGACY_FREE option Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> Change-Id: I69dfc4a875006639aa330385680d150331840e40 --- M src/soc/amd/picasso/Kconfig M src/soc/amd/picasso/acpi.c M src/soc/amd/picasso/include/soc/acpi.h M src/soc/amd/picasso/include/soc/amd_pci_int_defs.h M src/soc/amd/picasso/include/soc/cpu.h M src/soc/amd/picasso/include/soc/southbridge.h M src/soc/amd/picasso/smihandler.c M src/soc/amd/picasso/southbridge.c 8 files changed, 112 insertions(+), 179 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/33770/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/33770 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69dfc4a875006639aa330385680d150331840e40 Gerrit-Change-Number: 33770 Gerrit-PatchSet: 15 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/picasso: Create a hybrid romstage to begin in DRAM
by Marshall Dawson (Code Review) 17 Oct '19

17 Oct '19

Hello Edward O'Callaghan, Julius Werner, Richard Spiegel, build bot (Jenkins), Furquan Shaikh, Martin Roth, Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/33759 to look at the new patch set (#15). Change subject: soc/amd/picasso: Create a hybrid romstage to begin in DRAM ...................................................................... soc/amd/picasso: Create a hybrid romstage to begin in DRAM Add the support files to begin execution in romstage and located in DRAM. Details for this implementation are found in Documentation/amd/picasso/family17.md. Combine steps typically found in bootblock, containing the reset vector and protected mode enable, with the parts of romstage that enable the console and cbmem. Duplicate the ROMSTAGE_ADDR symbol into Kconfig and give it a safe default value in DRAM. Define EARLYRAM values for stack and early storage prior to cbmem. (A subsequent patch to add an FSP driver will rely on the storage.) Remove all postcar support. This implementation assumes only a BSP will run the main romstage code. A subsequent change will add restrictions on APs, as AGESA is put in place to release them from reset. Change-Id: Id8c6175de34a0728ad41085e9c7cd310bd280976 Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/soc/amd/picasso/Kconfig M src/soc/amd/picasso/Makefile.inc M src/soc/amd/picasso/include/soc/cpu.h M src/soc/amd/picasso/include/soc/romstage.h M src/soc/amd/picasso/romstage.c 5 files changed, 107 insertions(+), 81 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/33759/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/33759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id8c6175de34a0728ad41085e9c7cd310bd280976 Gerrit-Change-Number: 33759 Gerrit-PatchSet: 15 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in libgfxinit[master]: gma display_probing: Add Hotplug_Events()
by Nico Huber (Code Review) 17 Oct '19

17 Oct '19

Hello Angel Pons, Arthur Heymans, Matt DeVillier, Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/libgfxinit/+/35720 to look at the new patch set (#6). Change subject: gma display_probing: Add Hotplug_Events() ...................................................................... gma display_probing: Add Hotplug_Events() The Hotplug_Events() procedure returns a list of ports with hotplug events. The events are automatically cleared, so it's the caller's responsibility to act accordingly (e.g. run Update_Outputs() with updated configurations). Change-Id: Iff5e812d3119bfd44f5ea58e5086aa3ccba7c0bf Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-gma-display_probing.adb M common/hw-gfx-gma-display_probing.ads 2 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/20/35720/6 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/35720 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Iff5e812d3119bfd44f5ea58e5086aa3ccba7c0bf Gerrit-Change-Number: 35720 Gerrit-PatchSet: 6 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in libgfxinit[master]: gma display_probing: Add Hotplug_Events()
by Nico Huber (Code Review) 17 Oct '19

17 Oct '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35720 ) Change subject: gma display_probing: Add Hotplug_Events() ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/c/libgfxinit/+/35720/5//COMMIT_MSG Commit Message: https://review.coreboot.org/c/libgfxinit/+/35720/5//COMMIT_MSG@10 PS5, Line 10: And optionally clears those. > Hu? where is this done? stale commit message -- To view, visit https://review.coreboot.org/c/libgfxinit/+/35720 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Iff5e812d3119bfd44f5ea58e5086aa3ccba7c0bf Gerrit-Change-Number: 35720 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 17 Oct 2019 22:48:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in libgfxinit[master]: gma display_probing: Add Hotplug_Events()
by Arthur Heymans (Code Review) 17 Oct '19

17 Oct '19

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35720 ) Change subject: gma display_probing: Add Hotplug_Events() ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/c/libgfxinit/+/35720/5//COMMIT_MSG Commit Message: https://review.coreboot.org/c/libgfxinit/+/35720/5//COMMIT_MSG@10 PS5, Line 10: And optionally clears those. Hu? where is this done? -- To view, visit https://review.coreboot.org/c/libgfxinit/+/35720 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Iff5e812d3119bfd44f5ea58e5086aa3ccba7c0bf Gerrit-Change-Number: 35720 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 17 Oct 2019 21:37:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libgfxinit[master]: gma: Automatically update CDClk and dot clocks
by Arthur Heymans (Code Review) 17 Oct '19

17 Oct '19

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35719 ) Change subject: gma: Automatically update CDClk and dot clocks ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/35719 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I375f2bd37c921cd5ed4b0094247df5a34a087188 Gerrit-Change-Number: 35719 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 17 Oct 2019 21:35:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libgfxinit[master]: gma bxt: Implement CDClk switching
by Arthur Heymans (Code Review) 17 Oct '19

17 Oct '19

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35718 ) Change subject: gma bxt: Implement CDClk switching ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/35718 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I7bccbce0625a9893e2dd5c06fd1475a44987989d Gerrit-Change-Number: 35718 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 17 Oct 2019 21:33:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libgfxinit[master]: gma bxt: Implement CDClk switching
by Angel Pons (Code Review) 17 Oct '19

17 Oct '19

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35718 ) Change subject: gma bxt: Implement CDClk switching ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/35718 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I7bccbce0625a9893e2dd5c06fd1475a44987989d Gerrit-Change-Number: 35718 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 17 Oct 2019 21:21:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2019