coreboot-gerrit July 2018

coreboot-gerrit@coreboot.org

1 participants
877 discussions

Start a nNew thread

Change in coreboot[master]: sdm845: Add SPI QUP driver
by build bot (Jenkins) (Code Review) 20 Jul '18

20 Jul '18

1 0

Change in coreboot[master]: sdm845: Add SPI QUP driver
by build bot (Jenkins) (Code Review) 20 Jul '18

20 Jul '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27483 ) Change subject: sdm845: Add SPI QUP driver ...................................................................... Patch Set 2: (90 comments) https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/include/soc… File src/soc/qualcomm/sdm845/include/soc/qcom-geni-se.h: https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/include/soc… PS2, Line 75: (((0xFFFFFFFF) - (1UL << (l)) + 1) & (0xFFFFFFFF >> (BITS_PER_LONG - 1 - (h)))) line over 80 characters https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/include/soc… File src/soc/qualcomm/sdm845/include/soc/spi-geni-qcom.h: https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/include/soc… PS2, Line 26: }irq_status_t; space required after that close brace '}' https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/include/soc… PS2, Line 29: u8* phys_addr; "foo* bar" should be "foo *bar" https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/include/soc… PS2, Line 48: u8 *rx_buf; please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/include/soc… PS2, Line 49: u8 *tx_buf; please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c File src/soc/qualcomm/sdm845/spi_qup.c: https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@28 PS2, Line 28: //helper funtions 'funtions' may be misspelled - perhaps 'functions'? https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@1… PS2, Line 110: #define min(x,y) ({ \ space required after that ',' (ctx:VxV) https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@1… PS2, Line 117: #define IRQ_TRIGGER (M_RX_FIFO_WATERMARK_EN | M_RX_FIFO_LAST_EN | M_TX_FIFO_WATERMARK_EN \ line over 80 characters https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@1… PS2, Line 118: | M_CMD_DONE_EN | M_CMD_CANCEL_EN | M_CMD_ABORT_EN) please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@1… PS2, Line 125: #define REG_OUT(base, offset, value) \ line over 80 characters https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@1… PS2, Line 148: u8 * reg = base + offset; please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@1… PS2, Line 148: u8 * reg = base + offset; "foo * bar" should be "foo *bar" https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@1… PS2, Line 149: return *(volatile uint32_t *)(reg); please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@1… PS2, Line 161: (*(volatile uint32_t *)(base + offset) = (value)); please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@1… PS2, Line 163: } void function return statements are not generally useful https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@4… PS2, Line 418: // & SPI_CS_CLK_DELAY_MSK; line over 80 characters https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@4… PS2, Line 436: idx=1; spaces required around that '=' (ctx:VxV) https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@4… PS2, Line 437: div=2; spaces required around that '=' (ctx:VxV) https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@4… PS2, Line 439: mode =(slave_cfg->clk_polarity|slave_cfg->clk_phase); spaces required around that '=' (ctx:WxV) https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@4… PS2, Line 448: geni_write_reg(demux_output_inv, spi_bus->phys_addr, SE_SPI_DEMUX_OUTPUT_INV); line over 80 characters https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@4… PS2, Line 451: geni_write_reg(spi_delay_params, spi_bus->phys_addr, SE_SPI_DELAY_COUNTERS); line over 80 characters https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@5… PS2, Line 534: if (!mas->tx_rem_bytes) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@5… PS2, Line 544: u32 rx_fifo_status = geni_read_reg(mas->phys_addr, SE_GENI_RX_FIFO_STATUS); line over 80 characters https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@5… PS2, Line 594: if(!(m_irq & IRQ_TRIGGER)) space required before the open parenthesis '(' https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 614: geni_write_reg(0, mas->phys_addr, SE_GENI_TX_WATERMARK_REG); line over 80 characters https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 617: if (mas->rx_rem_bytes) suspect code indent for conditional statements (16, 16) https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 629: int max_delay=MAX_DELAY_STEP; spaces required around that '=' (ctx:VxV) https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 631: do{ space required before the open brace '{' https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 632: if(geni_spi_irq(mas)) space required before the open parenthesis '(' https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 636: }while(max_delay > 0); space required after that close brace '}' https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 636: }while(max_delay > 0); space required before the open parenthesis '(' https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 638: if(max_delay == 0) space required before the open parenthesis '(' https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 646: geni_write_reg(M_GENI_CMD_CANCEL, mas->phys_addr, SE_GENI_M_CMD_CTRL_REG); line over 80 characters https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 650: geni_write_reg(M_GENI_CMD_ABORT, mas->phys_addr, SE_GENI_M_CMD_CTRL_REG); line over 80 characters https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 659: struct spi_geni_master *spi_bus = to_spi_geni_master(slave); please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 662: u32 m_param = 0; code indent should use tabs where possible https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 662: u32 m_param = 0; please, no space before tabs https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 662: u32 m_param = 0; please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 664: u32 trans_len = 0; code indent should use tabs where possible https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 664: u32 trans_len = 0; please, no space before tabs https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 664: u32 trans_len = 0; please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 665: int bytes_per_word=0; spaces required around that '=' (ctx:VxV) https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 667: spi_bus->num_xfers = 1; please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 668: spi_bus->size = bytes_out > bytes_in ? bytes_out : bytes_in; please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 669: spi_bus->tx_buf = (u8 *)dout; please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 670: spi_bus->rx_buf = (u8 *)din; please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 671: spi_bus->tx_rem_bytes = 0; please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 683: if (!(spi_bus->cur_word_len % MIN_WORD_LEN)) { please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 683: if (!(spi_bus->cur_word_len % MIN_WORD_LEN)) { suspect code indent for conditional statements (4, 16) https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 684: trans_len = code indent should use tabs where possible https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 684: trans_len = please, no space before tabs https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 684: trans_len = please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 685: ((spi_bus->size << 3) / spi_bus->cur_word_len) & TRANS_LEN_MSK; line over 80 characters https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 685: ((spi_bus->size << 3) / spi_bus->cur_word_len) & TRANS_LEN_MSK; code indent should use tabs where possible https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 685: ((spi_bus->size << 3) / spi_bus->cur_word_len) & TRANS_LEN_MSK; please, no space before tabs https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 685: ((spi_bus->size << 3) / spi_bus->cur_word_len) & TRANS_LEN_MSK; please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 686: } else { code indent should use tabs where possible https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 686: } else { please, no space before tabs https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 686: } else { please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 687: bytes_per_word = (spi_bus->cur_word_len / BITS_PER_BYTE) + 1; code indent should use tabs where possible https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 687: bytes_per_word = (spi_bus->cur_word_len / BITS_PER_BYTE) + 1; please, no space before tabs https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 687: bytes_per_word = (spi_bus->cur_word_len / BITS_PER_BYTE) + 1; please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 689: trans_len = (spi_bus->size / bytes_per_word) & TRANS_LEN_MSK; code indent should use tabs where possible https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 689: trans_len = (spi_bus->size / bytes_per_word) & TRANS_LEN_MSK; please, no space before tabs https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 689: trans_len = (spi_bus->size / bytes_per_word) & TRANS_LEN_MSK; please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 690: } code indent should use tabs where possible https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 690: } please, no space before tabs https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 690: } please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 694: geni_write_reg(trans_len, spi_bus->phys_addr, SE_SPI_TX_TRANS_LEN); line over 80 characters https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@6… PS2, Line 698: geni_write_reg(trans_len, spi_bus->phys_addr, SE_SPI_RX_TRANS_LEN); line over 80 characters https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@7… PS2, Line 701: geni_setup_m_cmd(spi_bus->phys_addr, m_cmd, m_param); please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@7… PS2, Line 704: geni_write_reg(spi_bus->tx_wm, spi_bus->phys_addr, SE_GENI_TX_WATERMARK_REG); line over 80 characters https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@7… PS2, Line 706: if(spi_irq_poll(spi_bus)){ space required before the open brace '{' https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@7… PS2, Line 706: if(spi_irq_poll(spi_bus)){ space required before the open parenthesis '(' https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@7… PS2, Line 711: else else should follow close brace '}' https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@7… PS2, Line 723: spi_bus->phys_addr = (u8 *)0x880000; please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@7… PS2, Line 724: u8* spi_bus_base = spi_bus->phys_addr; please, no spaces at the start of a line https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@7… PS2, Line 724: u8* spi_bus_base = spi_bus->phys_addr; "foo* bar" should be "foo *bar" https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@7… PS2, Line 731: geni_se_init(spi_bus_base, 0,(spi_bus->rx_fifo_depth-2)); space required after that ',' (ctx:VxV) https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@7… PS2, Line 733: /*TODO :slave_cfg Should be set by client before xfer, initializing default values*/ line over 80 characters https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@7… PS2, Line 734: spi_bus->slave_cfg = (struct spi_cfg) {SPI_CLOCK_PHASE_FIRST, SPI_POLARITY_LOW, SPI_POLARITY_LOW, SPI_4_WIRE_MODE, 0x8}; line over 80 characters https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@7… PS2, Line 737: REG_OUT(0,0x3500000,0x85); space required after that ',' (ctx:VxV) https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@7… PS2, Line 737: REG_OUT(0,0x3500000,0x85); space required after that ',' (ctx:VxV) https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@7… PS2, Line 738: REG_OUT(0,0x3501000,0x285); space required after that ',' (ctx:VxV) https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@7… PS2, Line 738: REG_OUT(0,0x3501000,0x285); space required after that ',' (ctx:VxV) https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@7… PS2, Line 739: REG_OUT(0,0x3502000,0x284); space required after that ',' (ctx:VxV) https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@7… PS2, Line 739: REG_OUT(0,0x3502000,0x284); space required after that ',' (ctx:VxV) https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@7… PS2, Line 740: REG_OUT(0,0x3503000,0x285); space required after that ',' (ctx:VxV) https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@7… PS2, Line 740: REG_OUT(0,0x3503000,0x285); space required after that ',' (ctx:VxV) https://review.coreboot.org/#/c/27483/2/src/soc/qualcomm/sdm845/spi_qup.c@7… PS2, Line 758: } void function return statements are not generally useful -- To view, visit https://review.coreboot.org/27483 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35061727d5ccc550eaeb06caef4524bc4cf25b54 Gerrit-Change-Number: 27483 Gerrit-PatchSet: 2 Gerrit-Owner: T.Michael Turney <tturne(a)codeaurora.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: T Michael Turney <mturney(a)codeaurora.org> Gerrit-Reviewer: Vin Kamath <vink(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Fri, 20 Jul 2018 22:05:50 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/octopus: Add support for smbios_mainboard_sku
by Furquan Shaikh (Code Review) 20 Jul '18

20 Jul '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/27560 Change subject: mb/google/octopus: Add support for smbios_mainboard_sku ...................................................................... mb/google/octopus: Add support for smbios_mainboard_sku This change provides implementation of smbios_mainboard_sku that queries the EC for SKU ID using CBI. Currently, get_board_sku() is implemented as a common function for all variants since this is the only way used by all the octopus variants to query SKU ID. If this changes in the future, this function can be changed to a variant_* callback. BUG=b:111671163 TEST=Verified following on phaser: 1. "mosys platform sku" returns the SKU ID programmed in CBI 2. "dmidecode -t 1" shows SKU information as "skuXYZ" where XYZ is the SKU ID programmed in CBI. Change-Id: Ic0d344b3c13632f2ca582adc36aa337b99959712 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/mainboard/google/octopus/mainboard.c 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/27560/1 diff --git a/src/mainboard/google/octopus/mainboard.c b/src/mainboard/google/octopus/mainboard.c index fc533af..c31c03a 100644 --- a/src/mainboard/google/octopus/mainboard.c +++ b/src/mainboard/google/octopus/mainboard.c @@ -18,10 +18,13 @@ #include <boardid.h> #include <console/console.h> #include <device/device.h> +#include <ec/google/chromeec/ec.h> #include <ec/ec.h> #include <nhlt.h> #include <soc/gpio.h> #include <soc/nhlt.h> +#include <smbios.h> +#include <string.h> #include <vendorcode/google/chromeos/chromeos.h> #include <variant/ec.h> #include <variant/gpio.h> @@ -75,3 +78,35 @@ .init = mainboard_init, .enable_dev = mainboard_enable, }; + +#define SKU_UNKNOWN 0xFFFFFFFF +#define SKU_MAX 255 + +static uint32_t get_board_sku(void) +{ + static uint32_t sku_id = SKU_UNKNOWN; + + if (sku_id != SKU_UNKNOWN) + return sku_id; + + if (google_chromeec_cbi_get_sku_id(&sku_id)) + sku_id = SKU_UNKNOWN; + + return sku_id; +} + +const char *smbios_mainboard_sku(void) +{ + static char sku_str[7]; /* sku{0..255} */ + uint32_t sku_id = get_board_sku(); + + if ((sku_id == SKU_UNKNOWN) || (sku_id > SKU_MAX)) { + printk(BIOS_ERR, "%s: Unexpected SKU ID %u\n", + __func__, sku_id); + return ""; + } + + snprintf(sku_str, sizeof(sku_str), "sku%u", sku_id); + + return sku_str; +} -- To view, visit https://review.coreboot.org/27560 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic0d344b3c13632f2ca582adc36aa337b99959712 Gerrit-Change-Number: 27560 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: mb/*/*: Harmonise FD and devicetree on boards featuring ICH7
by Martin Roth (Code Review) 20 Jul '18

20 Jul '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/27122 ) Change subject: mb/*/*: Harmonise FD and devicetree on boards featuring ICH7 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/27122 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1692ca5f490ea84e2fc520d3f66044ad7514f76e Gerrit-Change-Number: 27122 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Jul 2018 15:15:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nocturne: set nvme to use clk src 3
by Patrick Georgi (Code Review) 20 Jul '18

20 Jul '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/27536 ) Change subject: mb/google/poppy/variants/nocturne: set nvme to use clk src 3 ...................................................................... mb/google/poppy/variants/nocturne: set nvme to use clk src 3 Latest nocturne architecture uses clk src 3 for nvme. BUG=b:111514174 BRANCH=none TEST="emerge-nocturne coreboot chromeos-bootimage" and verify nvme nocturne devices are able to recognize the nvme controller. Change-Id: I5b2bf012ba88568cb4b0bb3918a3a2c6770ff4c1 Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> Reviewed-on: https://review.coreboot.org/27536 Reviewed-by: Lijian Zhao <lijian.zhao(a)intel.com> Reviewed-by: Furquan Shaikh <furquan(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/poppy/variants/nocturne/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Lijian Zhao: Looks good to me, approved diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb index 5e1b7aa..1d00bc2 100644 --- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb @@ -164,13 +164,13 @@ # PcieRpEnable: Enable root port # PcieRpClkReqSupport: Enable CLKREQ# # PcieRpClkReqNumber: Uses SRCCLKREQ2# - # PcieRpClkSrcNumber: Uses 2 + # PcieRpClkSrcNumber: Uses 3 # PcieRpAdvancedErrorReporting: Enable Advanced Error Reporting # PcieRpLtrEnable: Enable Latency Tolerance Reporting Mechanism register "PcieRpEnable[8]" = "1" register "PcieRpClkReqSupport[8]" = "1" register "PcieRpClkReqNumber[8]" = "2" - register "PcieRpClkSrcNumber[8]" = "2" + register "PcieRpClkSrcNumber[8]" = "3" register "PcieRpAdvancedErrorReporting[8]" = "1" register "PcieRpLtrEnable[8]" = "1" -- To view, visit https://review.coreboot.org/27536 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5b2bf012ba88568cb4b0bb3918a3a2c6770ff4c1 Gerrit-Change-Number: 27536 Gerrit-PatchSet: 2 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: cpu/intel/speedstep/acpi.c: Add Netburst CPUs
by build bot (Jenkins) (Code Review) 20 Jul '18

20 Jul '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22604 ) Change subject: cpu/intel/speedstep/acpi.c: Add Netburst CPUs ...................................................................... Patch Set 15: (13 comments) https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/acpi.c File src/cpu/intel/speedstep/acpi.c: https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/acpi.c@68 PS15, Line 68: if ( c.x86_model ==2) spaces required around that '==' (ctx:WxV) https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/acpi.c@68 PS15, Line 68: if ( c.x86_model ==2) space prohibited after that open parenthesis '(' https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/acpi.c@92 PS15, Line 92: else else is not generally useful after a break or return https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.c File src/cpu/intel/speedstep/speedstep.c: https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.… PS15, Line 45: if (((rdmsr(MSR_EXTENDED_CONFIG).lo >> 27) & 3) == 3) {/*supported and line over 80 characters https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.… PS15, Line 46: enabled bits */ line over 80 characters https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.… PS15, Line 48: params->slfm = SPEEDSTEP_STATE_FROM_MSR(msr.lo, state_mask); line over 80 characters https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.… PS15, Line 52: } code indent should use tabs where possible https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.… PS15, Line 52: } please, no spaces at the start of a line https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.… PS15, Line 73: if (!(((cpuid_eax(1) >> 8) & 0xf) == 0xf)) { suspect code indent for conditional statements (8, 8) https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.… PS15, Line 77: !(rdmsr(IA32_MISC_ENABLES).hi & (1 << (38 - 32)))) { line over 80 characters https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.… PS15, Line 79: params->turbo = SPEEDSTEP_STATE_FROM_MSR(msr.hi, state_mask); line over 80 characters https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.… PS15, Line 82: } code indent should use tabs where possible https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.… PS15, Line 82: } please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/22604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a Gerrit-Change-Number: 22604 Gerrit-PatchSet: 15 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Jul 2018 11:30:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [WIP]mb/facebook/satima: Add new port
by build bot (Jenkins) (Code Review) 20 Jul '18

20 Jul '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27425 ) Change subject: [WIP]mb/facebook/satima: Add new port ...................................................................... Patch Set 8: (174 comments) https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… File src/mainboard/opencellular/satima/cn81xx-linux.dtsi: https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 46: compatible = "cavium,thunder-81xx"; DT compatible string "cavium,thunder-81xx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 46: compatible = "cavium,thunder-81xx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 52: compatible = "arm,psci-0.2"; DT compatible string "arm,psci-0.2" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 52: compatible = "arm,psci-0.2"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 113: compatible = "cache"; DT compatible string "cache" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 118: compatible = "arm,armv8-timer"; DT compatible string "arm,armv8-timer" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 118: compatible = "arm,armv8-timer"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string "cavium,thunder-pmu" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string "arm,armv8-pmuv3" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 131: compatible = "regulator-fixed"; DT compatible string "regulator-fixed" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 141: compatible = "arm,gic-v3"; DT compatible string "arm,gic-v3" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 141: compatible = "arm,gic-v3"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 153: compatible = "arm,gic-v3-its"; DT compatible string "arm,gic-v3-its" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 153: compatible = "arm,gic-v3-its"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 161: compatible = "simple-bus"; DT compatible string "simple-bus" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 168: compatible = "fixed-clock"; DT compatible string "fixed-clock" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 175: compatible = "fixed-clock"; DT compatible string "fixed-clock" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 218: compatible = "arm,sbsa-gwdt"; DT compatible string "arm,sbsa-gwdt" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 218: compatible = "arm,sbsa-gwdt"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 219: reg = <0x8440 0xa0000 0x0 0x1000>, <0x8440 0xb0000 0x0 0x1000>; line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 224: compatible = "cfi-flash"; DT compatible string "cfi-flash" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 232: compatible = "cavium,smmu-v2"; DT compatible string "cavium,smmu-v2" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 232: compatible = "cavium,smmu-v2"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 235: interrupts = <0 68 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 236: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 237: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 238: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 239: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 240: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 241: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 242: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 243: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 244: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 245: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>; line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 255: compatible = "pci-host-ecam-generic"; DT compatible string "pci-host-ecam-generic" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 265: reg = <0x8480 0x00000000 0 0x02000000>; /* Configuration space */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 266: ranges = <0x03000000 0x8010 0x00000000 0x8010 0x00000000 0x080 0x00000000>, /* mem ranges */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 267: <0x03000000 0x8100 0x00000000 0x8100 0x00000000 0x80 0x00000000>, /* SATA */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 268: <0x03000000 0x8680 0x00000000 0x8680 0x00000000 0x160 0x28000000>, /* UARTs */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 269: <0x03000000 0x87e0 0x2c000000 0x87e0 0x2c000000 0x000 0x94000000>, /* PEMs */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 270: <0x03000000 0x8400 0x00000000 0x8400 0x00000000 0x010 0x00000000>, /* RNM */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 271: <0x03000000 0x8430 0x00000000 0x8430 0x00000000 0x02 0x00000000>, /* NIC0*/ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 272: <0x03000000 0x87e0 0xc6000000 0x87e0 0xc6000000 0x01f 0x3a000000>; line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string "pci-bridge" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string "cavium,thunder-8890-mrml-bridge" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 278: ranges = <0x03000000 0x87e0 0x00000000 0x03000000 0x87e0 0x00000000 0x10 0x00000000>; line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 284: compatible = "cavium,thunder-8890-mdio-nexus"; DT compatible string "cavium,thunder-8890-mdio-nexus" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 284: compatible = "cavium,thunder-8890-mdio-nexus"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 284: compatible = "cavium,thunder-8890-mdio-nexus"; line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 287: reg = <0x0b00 0 0 0 0>; /* DEVFN = 0x0b (1:3) */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 288: assigned-addresses = <0x03000000 0x87e0 0x05000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 289: ranges = <0x87e0 0x05000000 0x03000000 0x87e0 0x05000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 291: compatible = "cavium,thunder-8890-mdio"; DT compatible string "cavium,thunder-8890-mdio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 291: compatible = "cavium,thunder-8890-mdio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 291: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 294: reg = <0x87e0 0x05003800 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 297: compatible = "cavium,thunder-8890-mdio"; DT compatible string "cavium,thunder-8890-mdio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 297: compatible = "cavium,thunder-8890-mdio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 297: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 300: reg = <0x87e0 0x05003880 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 305: compatible = "cavium,thunder-8890-mmc"; DT compatible string "cavium,thunder-8890-mmc" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 305: compatible = "cavium,thunder-8890-mmc"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 306: reg = <0x0c00 0 0 0 0>; /* DEVFN = 0x0c (1:4) */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 315: compatible = "cavium,thunder-8890-twsi"; DT compatible string "cavium,thunder-8890-twsi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 315: compatible = "cavium,thunder-8890-twsi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 316: reg = <0x4800 0 0 0 0>; /* DEVFN = 0x48 (9:0) */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 325: compatible = "cavium,thunder-8890-twsi"; DT compatible string "cavium,thunder-8890-twsi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 325: compatible = "cavium,thunder-8890-twsi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 326: reg = <0x4900 0 0 0 0>; /* DEVFN = 0x49 (9:1) */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 335: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 335: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 336: reg = <0x9000 0 0 0 0>; /* DEVFN = 0x90 (16:1) */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 341: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 341: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 342: reg = <0x8000 0 0 0 0>; /* DEVFN = 0x80 (16:0) */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 347: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 347: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 348: reg = <0x8100 0 0 0 0>; /* DEVFN = 0x81 (16:1) */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 353: compatible = "cavium,thunder-8190-spi"; DT compatible string "cavium,thunder-8190-spi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 353: compatible = "cavium,thunder-8190-spi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 354: reg = <0x3800 0x0 0x0 0x0 0x0>; /* DEVFN = 0x38 (7:0) */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 362: compatible = "cavium,thunder-8890-gpio"; DT compatible string "cavium,thunder-8890-gpio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 362: compatible = "cavium,thunder-8890-gpio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 364: reg = <0x3000 0 0 0 0>; /* DEVFN = 0x30 (6:0) */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 371: compatible = "cavium,cn8130-nand"; DT compatible string "cavium,cn8130-nand" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 371: compatible = "cavium,cn8130-nand"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 392: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 392: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 401: reg = <0x8800 0x1f000000 0x0 0x39000000>, /* Configuration space */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 402: <0x87e0 0xc0000000 0x0 0x01000000>; /* PEM space */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 403: ranges = <0x01000000 0x00 0x00000000 0x8830 0x00000000 0x00 0x00010000>, /* I/O */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 404: <0x03000000 0x00 0x10000000 0x8810 0x10000000 0x0f 0xf0000000>, /* mem64 */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 405: <0x43000000 0x10 0x00000000 0x8820 0x00000000 0x10 0x00000000>, /* mem64-pref */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 406: <0x03000000 0x87e0 0xc0000000 0x87e0 0xc0000000 0x00 0x01000000>; /* mem64 PEM */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 417: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 417: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 426: reg = <0x8840 0x57000000 0x0 0x39000000>, /* Configuration space */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 427: <0x87e0 0xc1000000 0x0 0x01000000>; /* PEM space */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 428: ranges = <0x01000000 0x00 0x00010000 0x8870 0x00010000 0x00 0x00010000>, /* I/O */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 429: <0x03000000 0x00 0x10000000 0x8850 0x10000000 0x0f 0xf0000000>, /* mem64 */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 430: <0x43000000 0x10 0x00000000 0x8860 0x00000000 0x10 0x00000000>, /* mem64-pref */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 431: <0x03000000 0x87e0 0xc1000000 0x87e0 0xc1000000 0x00 0x01000000>; /* mem64 PEM */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 442: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 442: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 451: reg = <0x8880 0x8f000000 0x0 0x39000000>, /* Configuration space */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 452: <0x87e0 0xc2000000 0x0 0x01000000>; /* PEM space */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 453: ranges = <0x01000000 0x00 0x00020000 0x88b0 0x00020000 0x00 0x00010000>, /* I/O */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 454: <0x03000000 0x00 0x10000000 0x8890 0x10000000 0x0f 0xf0000000>, /* mem64 */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 455: <0x43000000 0x10 0x00000000 0x88a0 0x00000000 0x10 0x00000000>, /* mem64-pref */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 456: <0x03000000 0x87e0 0xc2000000 0x87e0 0xc2000000 0x00 0x01000000>; /* mem64 PEM */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 469: compatible = "cavium,thunder-8190-tdm"; DT compatible string "cavium,thunder-8190-tdm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/c… PS8, Line 469: compatible = "cavium,thunder-8190-tdm"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/d… File src/mainboard/opencellular/satima/death.c: https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/d… PS8, Line 31: } while(1); space required before the open parenthesis '(' https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/m… File src/mainboard/opencellular/satima/mainboard.h: https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/m… PS8, Line 18: #define SATIMA_GPIO_SPI_MUX 24 please, no space before tabs https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… File src/mainboard/opencellular/satima/sff8104-linux.dts: https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; DT compatible string "marvell,88e1510" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; DT compatible string vendor "marvell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; DT compatible string "ethernet-phy-ieee802.3-c22" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; DT compatible string "vitesse,vsc8574" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; DT compatible string vendor "vitesse" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; DT compatible string "ethernet-phy-ieee802.3-c22" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; DT compatible string "aquantia,aqr105" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; DT compatible string vendor "aquantia" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; DT compatible string "ethernet-phy-ieee802.3-c45" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 98: compatible = "mmc-slot"; DT compatible string "mmc-slot" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 108: /* There is no card detection available; polling must be used. */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 117: compatible = "mmc-slot"; DT compatible string "mmc-slot" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 128: /* There is no card detection available; polling must be used. */ line over 80 characters https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string "micron,n25q128a13" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string vendor "micron" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string "spi-flash" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string "jedec,spi-nor" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string vendor "jedec" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 149: compatible = "spinand,mt29f", "mt29f"; DT compatible string "spinand,mt29f" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 149: compatible = "spinand,mt29f", "mt29f"; DT compatible string vendor "spinand" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/8/src/mainboard/opencellular/satima/s… PS8, Line 149: compatible = "spinand,mt29f", "mt29f"; DT compatible string "mt29f" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ -- To view, visit https://review.coreboot.org/27425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f972d59ac2243823a77f614c4f92c1666185705 Gerrit-Change-Number: 27425 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Jul 2018 10:12:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [WIP]mb/facebook/satima: Add new port
by build bot (Jenkins) (Code Review) 20 Jul '18

20 Jul '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27425 ) Change subject: [WIP]mb/facebook/satima: Add new port ...................................................................... Patch Set 7: (174 comments) https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… File src/mainboard/opencellular/satima/cn81xx-linux.dtsi: https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 46: compatible = "cavium,thunder-81xx"; DT compatible string "cavium,thunder-81xx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 46: compatible = "cavium,thunder-81xx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 52: compatible = "arm,psci-0.2"; DT compatible string "arm,psci-0.2" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 52: compatible = "arm,psci-0.2"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 113: compatible = "cache"; DT compatible string "cache" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 118: compatible = "arm,armv8-timer"; DT compatible string "arm,armv8-timer" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 118: compatible = "arm,armv8-timer"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string "cavium,thunder-pmu" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string "arm,armv8-pmuv3" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 131: compatible = "regulator-fixed"; DT compatible string "regulator-fixed" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 141: compatible = "arm,gic-v3"; DT compatible string "arm,gic-v3" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 141: compatible = "arm,gic-v3"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 153: compatible = "arm,gic-v3-its"; DT compatible string "arm,gic-v3-its" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 153: compatible = "arm,gic-v3-its"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 161: compatible = "simple-bus"; DT compatible string "simple-bus" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 168: compatible = "fixed-clock"; DT compatible string "fixed-clock" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 175: compatible = "fixed-clock"; DT compatible string "fixed-clock" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 218: compatible = "arm,sbsa-gwdt"; DT compatible string "arm,sbsa-gwdt" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 218: compatible = "arm,sbsa-gwdt"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 219: reg = <0x8440 0xa0000 0x0 0x1000>, <0x8440 0xb0000 0x0 0x1000>; line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 224: compatible = "cfi-flash"; DT compatible string "cfi-flash" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 232: compatible = "cavium,smmu-v2"; DT compatible string "cavium,smmu-v2" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 232: compatible = "cavium,smmu-v2"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 235: interrupts = <0 68 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 236: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 237: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 238: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 239: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 240: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 241: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 242: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 243: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 244: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 245: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>; line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 255: compatible = "pci-host-ecam-generic"; DT compatible string "pci-host-ecam-generic" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 265: reg = <0x8480 0x00000000 0 0x02000000>; /* Configuration space */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 266: ranges = <0x03000000 0x8010 0x00000000 0x8010 0x00000000 0x080 0x00000000>, /* mem ranges */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 267: <0x03000000 0x8100 0x00000000 0x8100 0x00000000 0x80 0x00000000>, /* SATA */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 268: <0x03000000 0x8680 0x00000000 0x8680 0x00000000 0x160 0x28000000>, /* UARTs */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 269: <0x03000000 0x87e0 0x2c000000 0x87e0 0x2c000000 0x000 0x94000000>, /* PEMs */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 270: <0x03000000 0x8400 0x00000000 0x8400 0x00000000 0x010 0x00000000>, /* RNM */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 271: <0x03000000 0x8430 0x00000000 0x8430 0x00000000 0x02 0x00000000>, /* NIC0*/ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 272: <0x03000000 0x87e0 0xc6000000 0x87e0 0xc6000000 0x01f 0x3a000000>; line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string "pci-bridge" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string "cavium,thunder-8890-mrml-bridge" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 278: ranges = <0x03000000 0x87e0 0x00000000 0x03000000 0x87e0 0x00000000 0x10 0x00000000>; line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 284: compatible = "cavium,thunder-8890-mdio-nexus"; DT compatible string "cavium,thunder-8890-mdio-nexus" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 284: compatible = "cavium,thunder-8890-mdio-nexus"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 284: compatible = "cavium,thunder-8890-mdio-nexus"; line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 287: reg = <0x0b00 0 0 0 0>; /* DEVFN = 0x0b (1:3) */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 288: assigned-addresses = <0x03000000 0x87e0 0x05000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 289: ranges = <0x87e0 0x05000000 0x03000000 0x87e0 0x05000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 291: compatible = "cavium,thunder-8890-mdio"; DT compatible string "cavium,thunder-8890-mdio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 291: compatible = "cavium,thunder-8890-mdio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 291: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 294: reg = <0x87e0 0x05003800 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 297: compatible = "cavium,thunder-8890-mdio"; DT compatible string "cavium,thunder-8890-mdio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 297: compatible = "cavium,thunder-8890-mdio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 297: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 300: reg = <0x87e0 0x05003880 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 305: compatible = "cavium,thunder-8890-mmc"; DT compatible string "cavium,thunder-8890-mmc" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 305: compatible = "cavium,thunder-8890-mmc"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 306: reg = <0x0c00 0 0 0 0>; /* DEVFN = 0x0c (1:4) */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 315: compatible = "cavium,thunder-8890-twsi"; DT compatible string "cavium,thunder-8890-twsi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 315: compatible = "cavium,thunder-8890-twsi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 316: reg = <0x4800 0 0 0 0>; /* DEVFN = 0x48 (9:0) */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 325: compatible = "cavium,thunder-8890-twsi"; DT compatible string "cavium,thunder-8890-twsi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 325: compatible = "cavium,thunder-8890-twsi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 326: reg = <0x4900 0 0 0 0>; /* DEVFN = 0x49 (9:1) */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 335: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 335: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 336: reg = <0x9000 0 0 0 0>; /* DEVFN = 0x90 (16:1) */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 341: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 341: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 342: reg = <0x8000 0 0 0 0>; /* DEVFN = 0x80 (16:0) */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 347: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 347: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 348: reg = <0x8100 0 0 0 0>; /* DEVFN = 0x81 (16:1) */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 353: compatible = "cavium,thunder-8190-spi"; DT compatible string "cavium,thunder-8190-spi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 353: compatible = "cavium,thunder-8190-spi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 354: reg = <0x3800 0x0 0x0 0x0 0x0>; /* DEVFN = 0x38 (7:0) */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 362: compatible = "cavium,thunder-8890-gpio"; DT compatible string "cavium,thunder-8890-gpio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 362: compatible = "cavium,thunder-8890-gpio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 364: reg = <0x3000 0 0 0 0>; /* DEVFN = 0x30 (6:0) */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 371: compatible = "cavium,cn8130-nand"; DT compatible string "cavium,cn8130-nand" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 371: compatible = "cavium,cn8130-nand"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 392: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 392: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 401: reg = <0x8800 0x1f000000 0x0 0x39000000>, /* Configuration space */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 402: <0x87e0 0xc0000000 0x0 0x01000000>; /* PEM space */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 403: ranges = <0x01000000 0x00 0x00000000 0x8830 0x00000000 0x00 0x00010000>, /* I/O */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 404: <0x03000000 0x00 0x10000000 0x8810 0x10000000 0x0f 0xf0000000>, /* mem64 */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 405: <0x43000000 0x10 0x00000000 0x8820 0x00000000 0x10 0x00000000>, /* mem64-pref */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 406: <0x03000000 0x87e0 0xc0000000 0x87e0 0xc0000000 0x00 0x01000000>; /* mem64 PEM */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 417: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 417: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 426: reg = <0x8840 0x57000000 0x0 0x39000000>, /* Configuration space */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 427: <0x87e0 0xc1000000 0x0 0x01000000>; /* PEM space */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 428: ranges = <0x01000000 0x00 0x00010000 0x8870 0x00010000 0x00 0x00010000>, /* I/O */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 429: <0x03000000 0x00 0x10000000 0x8850 0x10000000 0x0f 0xf0000000>, /* mem64 */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 430: <0x43000000 0x10 0x00000000 0x8860 0x00000000 0x10 0x00000000>, /* mem64-pref */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 431: <0x03000000 0x87e0 0xc1000000 0x87e0 0xc1000000 0x00 0x01000000>; /* mem64 PEM */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 442: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 442: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 451: reg = <0x8880 0x8f000000 0x0 0x39000000>, /* Configuration space */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 452: <0x87e0 0xc2000000 0x0 0x01000000>; /* PEM space */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 453: ranges = <0x01000000 0x00 0x00020000 0x88b0 0x00020000 0x00 0x00010000>, /* I/O */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 454: <0x03000000 0x00 0x10000000 0x8890 0x10000000 0x0f 0xf0000000>, /* mem64 */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 455: <0x43000000 0x10 0x00000000 0x88a0 0x00000000 0x10 0x00000000>, /* mem64-pref */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 456: <0x03000000 0x87e0 0xc2000000 0x87e0 0xc2000000 0x00 0x01000000>; /* mem64 PEM */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 469: compatible = "cavium,thunder-8190-tdm"; DT compatible string "cavium,thunder-8190-tdm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/c… PS7, Line 469: compatible = "cavium,thunder-8190-tdm"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/d… File src/mainboard/opencellular/satima/death.c: https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/d… PS7, Line 31: } while(1); space required before the open parenthesis '(' https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/m… File src/mainboard/opencellular/satima/mainboard.h: https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/m… PS7, Line 18: #define SATIMA_GPIO_SPI_MUX 24 please, no space before tabs https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… File src/mainboard/opencellular/satima/sff8104-linux.dts: https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; DT compatible string "marvell,88e1510" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; DT compatible string vendor "marvell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; DT compatible string "ethernet-phy-ieee802.3-c22" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; DT compatible string "vitesse,vsc8574" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; DT compatible string vendor "vitesse" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; DT compatible string "ethernet-phy-ieee802.3-c22" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; DT compatible string "aquantia,aqr105" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; DT compatible string vendor "aquantia" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; DT compatible string "ethernet-phy-ieee802.3-c45" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 98: compatible = "mmc-slot"; DT compatible string "mmc-slot" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 108: /* There is no card detection available; polling must be used. */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 117: compatible = "mmc-slot"; DT compatible string "mmc-slot" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 128: /* There is no card detection available; polling must be used. */ line over 80 characters https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string "micron,n25q128a13" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string vendor "micron" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string "spi-flash" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string "jedec,spi-nor" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string vendor "jedec" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 149: compatible = "spinand,mt29f", "mt29f"; DT compatible string "spinand,mt29f" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 149: compatible = "spinand,mt29f", "mt29f"; DT compatible string vendor "spinand" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/7/src/mainboard/opencellular/satima/s… PS7, Line 149: compatible = "spinand,mt29f", "mt29f"; DT compatible string "mt29f" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ -- To view, visit https://review.coreboot.org/27425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f972d59ac2243823a77f614c4f92c1666185705 Gerrit-Change-Number: 27425 Gerrit-PatchSet: 7 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Jul 2018 09:34:51 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: cpu/intel/model_f6x: Add model F6x for i945 parallel MP init
by Elyes HAOUAS (Code Review) 20 Jul '18

20 Jul '18

Elyes HAOUAS has uploaded a new patch set (#2). ( https://review.coreboot.org/27558 ) Change subject: cpu/intel/model_f6x: Add model F6x for i945 parallel MP init ...................................................................... cpu/intel/model_f6x: Add model F6x for i945 parallel MP init 945G-M4 board boots fine: https://pastebin.com/xacbWNE5 Change-Id: I62eedf2e6f1fd79fa3bf4e173e5317a7c775cdef Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/intel/model_f6x/Makefile.inc M src/cpu/intel/model_f6x/model_f6x_init.c 2 files changed, 4 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/27558/2 -- To view, visit https://review.coreboot.org/27558 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I62eedf2e6f1fd79fa3bf4e173e5317a7c775cdef Gerrit-Change-Number: 27558 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: [WIP]mb/facebook/satima: Add new port
by build bot (Jenkins) (Code Review) 20 Jul '18

20 Jul '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27425 ) Change subject: [WIP]mb/facebook/satima: Add new port ...................................................................... Patch Set 6: (174 comments) https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… File src/mainboard/opencellular/satima/cn81xx-linux.dtsi: https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 46: compatible = "cavium,thunder-81xx"; DT compatible string "cavium,thunder-81xx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 46: compatible = "cavium,thunder-81xx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 52: compatible = "arm,psci-0.2"; DT compatible string "arm,psci-0.2" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 52: compatible = "arm,psci-0.2"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 113: compatible = "cache"; DT compatible string "cache" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 118: compatible = "arm,armv8-timer"; DT compatible string "arm,armv8-timer" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 118: compatible = "arm,armv8-timer"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string "cavium,thunder-pmu" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string "arm,armv8-pmuv3" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 131: compatible = "regulator-fixed"; DT compatible string "regulator-fixed" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 141: compatible = "arm,gic-v3"; DT compatible string "arm,gic-v3" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 141: compatible = "arm,gic-v3"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 153: compatible = "arm,gic-v3-its"; DT compatible string "arm,gic-v3-its" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 153: compatible = "arm,gic-v3-its"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 161: compatible = "simple-bus"; DT compatible string "simple-bus" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 168: compatible = "fixed-clock"; DT compatible string "fixed-clock" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 175: compatible = "fixed-clock"; DT compatible string "fixed-clock" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 218: compatible = "arm,sbsa-gwdt"; DT compatible string "arm,sbsa-gwdt" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 218: compatible = "arm,sbsa-gwdt"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 219: reg = <0x8440 0xa0000 0x0 0x1000>, <0x8440 0xb0000 0x0 0x1000>; line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 224: compatible = "cfi-flash"; DT compatible string "cfi-flash" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 232: compatible = "cavium,smmu-v2"; DT compatible string "cavium,smmu-v2" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 232: compatible = "cavium,smmu-v2"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 235: interrupts = <0 68 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 236: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 237: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 238: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 239: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 240: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 241: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 242: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 243: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 244: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 245: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>; line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 255: compatible = "pci-host-ecam-generic"; DT compatible string "pci-host-ecam-generic" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 265: reg = <0x8480 0x00000000 0 0x02000000>; /* Configuration space */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 266: ranges = <0x03000000 0x8010 0x00000000 0x8010 0x00000000 0x080 0x00000000>, /* mem ranges */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 267: <0x03000000 0x8100 0x00000000 0x8100 0x00000000 0x80 0x00000000>, /* SATA */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 268: <0x03000000 0x8680 0x00000000 0x8680 0x00000000 0x160 0x28000000>, /* UARTs */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 269: <0x03000000 0x87e0 0x2c000000 0x87e0 0x2c000000 0x000 0x94000000>, /* PEMs */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 270: <0x03000000 0x8400 0x00000000 0x8400 0x00000000 0x010 0x00000000>, /* RNM */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 271: <0x03000000 0x8430 0x00000000 0x8430 0x00000000 0x02 0x00000000>, /* NIC0*/ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 272: <0x03000000 0x87e0 0xc6000000 0x87e0 0xc6000000 0x01f 0x3a000000>; line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string "pci-bridge" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string "cavium,thunder-8890-mrml-bridge" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 278: ranges = <0x03000000 0x87e0 0x00000000 0x03000000 0x87e0 0x00000000 0x10 0x00000000>; line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 284: compatible = "cavium,thunder-8890-mdio-nexus"; DT compatible string "cavium,thunder-8890-mdio-nexus" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 284: compatible = "cavium,thunder-8890-mdio-nexus"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 284: compatible = "cavium,thunder-8890-mdio-nexus"; line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 287: reg = <0x0b00 0 0 0 0>; /* DEVFN = 0x0b (1:3) */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 288: assigned-addresses = <0x03000000 0x87e0 0x05000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 289: ranges = <0x87e0 0x05000000 0x03000000 0x87e0 0x05000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 291: compatible = "cavium,thunder-8890-mdio"; DT compatible string "cavium,thunder-8890-mdio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 291: compatible = "cavium,thunder-8890-mdio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 291: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 294: reg = <0x87e0 0x05003800 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 297: compatible = "cavium,thunder-8890-mdio"; DT compatible string "cavium,thunder-8890-mdio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 297: compatible = "cavium,thunder-8890-mdio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 297: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 300: reg = <0x87e0 0x05003880 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 305: compatible = "cavium,thunder-8890-mmc"; DT compatible string "cavium,thunder-8890-mmc" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 305: compatible = "cavium,thunder-8890-mmc"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 306: reg = <0x0c00 0 0 0 0>; /* DEVFN = 0x0c (1:4) */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 315: compatible = "cavium,thunder-8890-twsi"; DT compatible string "cavium,thunder-8890-twsi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 315: compatible = "cavium,thunder-8890-twsi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 316: reg = <0x4800 0 0 0 0>; /* DEVFN = 0x48 (9:0) */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 325: compatible = "cavium,thunder-8890-twsi"; DT compatible string "cavium,thunder-8890-twsi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 325: compatible = "cavium,thunder-8890-twsi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 326: reg = <0x4900 0 0 0 0>; /* DEVFN = 0x49 (9:1) */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 335: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 335: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 336: reg = <0x9000 0 0 0 0>; /* DEVFN = 0x90 (16:1) */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 341: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 341: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 342: reg = <0x8000 0 0 0 0>; /* DEVFN = 0x80 (16:0) */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 347: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 347: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 348: reg = <0x8100 0 0 0 0>; /* DEVFN = 0x81 (16:1) */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 353: compatible = "cavium,thunder-8190-spi"; DT compatible string "cavium,thunder-8190-spi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 353: compatible = "cavium,thunder-8190-spi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 354: reg = <0x3800 0x0 0x0 0x0 0x0>; /* DEVFN = 0x38 (7:0) */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 362: compatible = "cavium,thunder-8890-gpio"; DT compatible string "cavium,thunder-8890-gpio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 362: compatible = "cavium,thunder-8890-gpio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 364: reg = <0x3000 0 0 0 0>; /* DEVFN = 0x30 (6:0) */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 371: compatible = "cavium,cn8130-nand"; DT compatible string "cavium,cn8130-nand" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 371: compatible = "cavium,cn8130-nand"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 392: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 392: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 401: reg = <0x8800 0x1f000000 0x0 0x39000000>, /* Configuration space */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 402: <0x87e0 0xc0000000 0x0 0x01000000>; /* PEM space */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 403: ranges = <0x01000000 0x00 0x00000000 0x8830 0x00000000 0x00 0x00010000>, /* I/O */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 404: <0x03000000 0x00 0x10000000 0x8810 0x10000000 0x0f 0xf0000000>, /* mem64 */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 405: <0x43000000 0x10 0x00000000 0x8820 0x00000000 0x10 0x00000000>, /* mem64-pref */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 406: <0x03000000 0x87e0 0xc0000000 0x87e0 0xc0000000 0x00 0x01000000>; /* mem64 PEM */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 417: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 417: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 426: reg = <0x8840 0x57000000 0x0 0x39000000>, /* Configuration space */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 427: <0x87e0 0xc1000000 0x0 0x01000000>; /* PEM space */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 428: ranges = <0x01000000 0x00 0x00010000 0x8870 0x00010000 0x00 0x00010000>, /* I/O */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 429: <0x03000000 0x00 0x10000000 0x8850 0x10000000 0x0f 0xf0000000>, /* mem64 */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 430: <0x43000000 0x10 0x00000000 0x8860 0x00000000 0x10 0x00000000>, /* mem64-pref */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 431: <0x03000000 0x87e0 0xc1000000 0x87e0 0xc1000000 0x00 0x01000000>; /* mem64 PEM */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 442: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 442: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 451: reg = <0x8880 0x8f000000 0x0 0x39000000>, /* Configuration space */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 452: <0x87e0 0xc2000000 0x0 0x01000000>; /* PEM space */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 453: ranges = <0x01000000 0x00 0x00020000 0x88b0 0x00020000 0x00 0x00010000>, /* I/O */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 454: <0x03000000 0x00 0x10000000 0x8890 0x10000000 0x0f 0xf0000000>, /* mem64 */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 455: <0x43000000 0x10 0x00000000 0x88a0 0x00000000 0x10 0x00000000>, /* mem64-pref */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 456: <0x03000000 0x87e0 0xc2000000 0x87e0 0xc2000000 0x00 0x01000000>; /* mem64 PEM */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 469: compatible = "cavium,thunder-8190-tdm"; DT compatible string "cavium,thunder-8190-tdm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/c… PS6, Line 469: compatible = "cavium,thunder-8190-tdm"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/d… File src/mainboard/opencellular/satima/death.c: https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/d… PS6, Line 31: } while(1); space required before the open parenthesis '(' https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/m… File src/mainboard/opencellular/satima/mainboard.h: https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/m… PS6, Line 18: #define SATIMA_GPIO_SPI_MUX 24 please, no space before tabs https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… File src/mainboard/opencellular/satima/sff8104-linux.dts: https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; DT compatible string "marvell,88e1510" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; DT compatible string vendor "marvell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; DT compatible string "ethernet-phy-ieee802.3-c22" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; DT compatible string "vitesse,vsc8574" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; DT compatible string vendor "vitesse" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; DT compatible string "ethernet-phy-ieee802.3-c22" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; DT compatible string "aquantia,aqr105" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; DT compatible string vendor "aquantia" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; DT compatible string "ethernet-phy-ieee802.3-c45" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 98: compatible = "mmc-slot"; DT compatible string "mmc-slot" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 108: /* There is no card detection available; polling must be used. */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 117: compatible = "mmc-slot"; DT compatible string "mmc-slot" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 128: /* There is no card detection available; polling must be used. */ line over 80 characters https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string "micron,n25q128a13" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string vendor "micron" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string "spi-flash" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string "jedec,spi-nor" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string vendor "jedec" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 149: compatible = "spinand,mt29f", "mt29f"; DT compatible string "spinand,mt29f" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 149: compatible = "spinand,mt29f", "mt29f"; DT compatible string vendor "spinand" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/6/src/mainboard/opencellular/satima/s… PS6, Line 149: compatible = "spinand,mt29f", "mt29f"; DT compatible string "mt29f" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ -- To view, visit https://review.coreboot.org/27425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f972d59ac2243823a77f614c4f92c1666185705 Gerrit-Change-Number: 27425 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Jul 2018 09:07:01 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

← Newer
1
...
35
36
37
38
39
40
41
...
88
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2018