coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: soc/intel/fsp_broadwell_de: Drop unused files
by Nico Huber (Code Review) 01 Jun '18

01 Jun '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/26756 Change subject: soc/intel/fsp_broadwell_de: Drop unused files ...................................................................... soc/intel/fsp_broadwell_de: Drop unused files It seems they are not included anywhere, Jenkins? Change-Id: I629cdeb337fce381c69bd1ba0520e524ccdd90dd Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- D src/soc/intel/fsp_broadwell_de/acpi/irq_helper.h D src/soc/intel/fsp_broadwell_de/acpi/irqroute.asl 2 files changed, 0 insertions(+), 84 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/26756/1 diff --git a/src/soc/intel/fsp_broadwell_de/acpi/irq_helper.h b/src/soc/intel/fsp_broadwell_de/acpi/irq_helper.h deleted file mode 100644 index 8799a9b..0000000 --- a/src/soc/intel/fsp_broadwell_de/acpi/irq_helper.h +++ /dev/null @@ -1,45 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Google Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#undef PCI_DEV_PIRQ_ROUTES -#undef ACPI_DEV_IRQ -#undef PCI_DEV_PIRQ_ROUTE -#undef PIRQ_PIC_ROUTES -#undef PIRQ_PIC -#undef IRQROUTE_H - -#if defined(PIC_MODE) - -#define ACPI_DEV_IRQ(dev_, pin_, pin_name_) \ - { Package() { ## dev_ ## ffff, pin_, \_SB.PCI0.LPCB.LNK ## pin_name_, 0 } } - -#else /* defined(PIC_MODE) */ - -#define ACPI_DEV_IRQ(dev_, pin_, pin_name_) \ - { Package() { ## dev_ ## ffff, pin_, 0, PIRQ ## pin_name_ ## _APIC_IRQ } } - -#endif - -#define PCI_DEV_PIRQ_ROUTE(dev_, a_, b_, c_, d_) \ - { ACPI_DEV_IRQ(dev_, 0, a_), \ - ACPI_DEV_IRQ(dev_, 1, b_), \ - ACPI_DEV_IRQ(dev_, 2, c_), \ - ACPI_DEV_IRQ(dev_, 3, d_) } - -/* Empty PIRQ_PIC definition. */ -#define PIRQ_PIC(pirq_, pic_irq_) - -/* Include the mainboard irq route definition */ -#include "irqroute.h" diff --git a/src/soc/intel/fsp_broadwell_de/acpi/irqroute.asl b/src/soc/intel/fsp_broadwell_de/acpi/irqroute.asl deleted file mode 100644 index 8a54d33..0000000 --- a/src/soc/intel/fsp_broadwell_de/acpi/irqroute.asl +++ /dev/null @@ -1,39 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2007-2009 coresystems GmbH - * Copyright (C) 2013 Google Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* PCI Interrupt Routing */ -Method(_PRT) -{ - /* - * PICM comes from _PIC, which returns the following: - * 0 - PIC mode - * 1 - APIC mode - * 2 - SAPIC mode - */ - If (PICM) { - Return (Package() { - #undef PIC_MODE - #include "irq_helper.h" - PCI_DEV_PIRQ_ROUTES - }) - } Else { - Return (Package() { - #define PIC_MODE - #include "irq_helper.h" - PCI_DEV_PIRQ_ROUTES - }) - } -} -- To view, visit https://review.coreboot.org/26756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I629cdeb337fce381c69bd1ba0520e524ccdd90dd Gerrit-Change-Number: 26756 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: soc/cavium: Add PCI support
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25750 ) Change subject: soc/cavium: Add PCI support ...................................................................... Patch Set 20: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73944/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28057/ : SUCCESS -- To view, visit https://review.coreboot.org/25750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I881f38a26a165e6bd965fcd73547473b5e32d4b0 Gerrit-Change-Number: 25750 Gerrit-PatchSet: 20 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 01 Jun 2018 14:25:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/cavium: Enable MMU
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25371 ) Change subject: soc/cavium: Enable MMU ...................................................................... Patch Set 29: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73940/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28053/ : SUCCESS -- To view, visit https://review.coreboot.org/25371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I969446da62b4cc7adf9393fab69ff84ebf49220d Gerrit-Change-Number: 25371 Gerrit-PatchSet: 29 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 14:23:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/cavium/cn81xx: Set cntfrq_el0
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25450 ) Change subject: soc/cavium/cn81xx: Set cntfrq_el0 ...................................................................... Patch Set 27: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73943/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28056/ : SUCCESS -- To view, visit https://review.coreboot.org/25450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b6d0b0cf646a066fc5a51552a1891eccbd91e5e Gerrit-Change-Number: 25450 Gerrit-PatchSet: 27 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 14:20:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/cavium/cn8100_sff_evb: Be verbose
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25449 ) Change subject: mb/cavium/cn8100_sff_evb: Be verbose ...................................................................... Patch Set 27: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73942/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28055/ : SUCCESS -- To view, visit https://review.coreboot.org/25449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0acac7a29290bc2eb9f4283317165fa0cf1b24e1 Gerrit-Change-Number: 25449 Gerrit-PatchSet: 27 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 14:16:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/cavium: Clean uart code
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25448 ) Change subject: soc/cavium: Clean uart code ...................................................................... Patch Set 27: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73941/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28054/ : SUCCESS -- To view, visit https://review.coreboot.org/25448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1043b30318ec6210e2dd6b7ac313a41171d37f55 Gerrit-Change-Number: 25448 Gerrit-PatchSet: 27 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 14:12:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: vendorcode/amd/pi/00670F00: Remove IdsLib.h ref
by Garrett Kirkendall (Code Review) 01 Jun '18

01 Jun '18

Garrett Kirkendall has uploaded this change for review. ( https://review.coreboot.org/26755 Change subject: vendorcode/amd/pi/00670F00: Remove IdsLib.h ref ...................................................................... vendorcode/amd/pi/00670F00: Remove IdsLib.h ref Remove Proc/IDS/IdsLib.h from being included in src/vendorcode/amd/pi/00670F00/agesa_headers.h. It is no longer needed. BUG=b:69220826 BRANCH=master TEST=build Gardenia, Kahlee, and Grunt systems. Change-Id: I03134b37ac4ed30c425b6af727da74bc8d480670 Signed-off-by: Garrett Kirkendall <garrett.kirkendall(a)amd.corp-partner.google.com> --- M src/vendorcode/amd/pi/00670F00/agesa_headers.h 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/26755/1 diff --git a/src/vendorcode/amd/pi/00670F00/agesa_headers.h b/src/vendorcode/amd/pi/00670F00/agesa_headers.h index fb17927..a8deae5 100644 --- a/src/vendorcode/amd/pi/00670F00/agesa_headers.h +++ b/src/vendorcode/amd/pi/00670F00/agesa_headers.h @@ -25,7 +25,6 @@ #include "Include/Ids.h" #include "Include/PlatformMemoryConfiguration.h" #include "Proc/Fch/FchPlatform.h" -#include "Proc/IDS/IdsLib.h" #include "Proc/Psp/PspBaseLib/PspBaseLib.h" #pragma pack(pop) #undef AGESA_HEADERS_ARE_WRAPPED -- To view, visit https://review.coreboot.org/26755 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I03134b37ac4ed30c425b6af727da74bc8d480670 Gerrit-Change-Number: 26755 Gerrit-PatchSet: 1 Gerrit-Owner: Garrett Kirkendall <garrett.kirkendall(a)amd.corp-partner.google.com>

1 0

Change in coreboot[master]: device: Only expose VGA_ROM_RUN on supported architectures
by Patrick Rudolph (Code Review) 01 Jun '18

01 Jun '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/26754 Change subject: device: Only expose VGA_ROM_RUN on supported architectures ...................................................................... device: Only expose VGA_ROM_RUN on supported architectures The yabel emulator depends on IO ports, that aren't available on ARM and MIPS. Add additional dependencies to fix compilation errors with the default configuration. Change-Id: If0e28b356c01cb3ae0739a54aa3531a2acedbfbb Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/device/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/26754/1 diff --git a/src/device/Kconfig b/src/device/Kconfig index a36b2e1..3d1d3fe 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -85,7 +85,7 @@ # TODO: Explain differences (if any) for onboard cards. config VGA_ROM_RUN bool "Run VGA Option ROMs" - depends on PCI && !MAINBOARD_FORCE_NATIVE_VGA_INIT + depends on PCI && (ARCH_X86 || ARCH_POWER8) && !MAINBOARD_FORCE_NATIVE_VGA_INIT select HAVE_VGA_TEXT_FRAMEBUFFER help Execute VGA Option ROMs in coreboot if found. This can be used -- To view, visit https://review.coreboot.org/26754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If0e28b356c01cb3ae0739a54aa3531a2acedbfbb Gerrit-Change-Number: 26754 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>

1 0

Change in coreboot[master]: security/tpm: Unify the coreboot TPM software stack
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24903 ) Change subject: security/tpm: Unify the coreboot TPM software stack ...................................................................... Patch Set 36: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73938/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28051/ : SUCCESS -- To view, visit https://review.coreboot.org/24903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ec277e82a3c20c62a0548a1a2b013e6ce8f5b3f Gerrit-Change-Number: 24903 Gerrit-PatchSet: 36 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Fri, 01 Jun 2018 14:01:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/console/vtxprintf.c: Remove unneeded 'console.h' include
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26753 ) Change subject: src/console/vtxprintf.c: Remove unneeded 'console.h' include ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73937/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28050/ : SUCCESS -- To view, visit https://review.coreboot.org/26753 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d7caaf58b3119a9fff339df1159a6e3277fc2dc Gerrit-Change-Number: 26753 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 13:56:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018